)]}'
{"test/unit/common/middleware/helpers.py":[{"author":{"_account_id":36606,"name":"Yan Xiao","display_name":"Yan","email":"yanxiao@nvidia.com","username":"yanxiao"},"change_message_id":"d4707773cc9dce3ed45a7b373470cb2f92824733","unresolved":true,"context_lines":[{"line_number":169,"context_line":"    account_existence_skip_cache \u003d 0.0"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"    def __init__(self, capture_unexpected_calls\u003dTrue):"},{"line_number":172,"context_line":"        self.capture_unexpected_calls \u003d capture_unexpected_calls"},{"line_number":173,"context_line":"        self._calls \u003d []"},{"line_number":174,"context_line":"        self.req_bodies \u003d []"},{"line_number":175,"context_line":"        self._unclosed_req_keys \u003d defaultdict(int)"}],"source_content_type":"text/x-python","patch_set":1,"id":"131d35cb_9fd13d7d","line":172,"updated":"2024-10-11 16:18:32.000000000","message":"should the default be True or False if we need backward compatibility for unit tests API?","commit_id":"4cbcfd68e455ee3cc20900dfb16f1063e4003765"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"d18ae7b8b5e86437efcad64079cd0d63d7213214","unresolved":true,"context_lines":[{"line_number":169,"context_line":"    account_existence_skip_cache \u003d 0.0"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"    def __init__(self, capture_unexpected_calls\u003dTrue):"},{"line_number":172,"context_line":"        self.capture_unexpected_calls \u003d capture_unexpected_calls"},{"line_number":173,"context_line":"        self._calls \u003d []"},{"line_number":174,"context_line":"        self.req_bodies \u003d []"},{"line_number":175,"context_line":"        self._unclosed_req_keys \u003d defaultdict(int)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ed4e7279_da148b76","line":172,"in_reply_to":"131d35cb_9fd13d7d","updated":"2024-10-11 18:27:52.000000000","message":"I\u0027m inclined to see the existing behavior as a bug.\n\nNothing in the tests is a \"public\" interface in the sense that third parties would use it.\n\nThat said, I don\u0027t really like this approach. I might try to fix the reconciler tests, or perhaps capture the expected and unexpected tests separately so that tests can make assertions on either/both.\n\nI\u0027m going to mark this WIP and get another patchset up.\n\nThanks for reviewing Yan!","commit_id":"4cbcfd68e455ee3cc20900dfb16f1063e4003765"}]}