)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"84d839cefc3aed40fb9f76457120a1cacccac102","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"2695db84_179c931b","updated":"2024-12-05 16:25:51.000000000","message":"I made a fresh start on this now that the parent patches have merged. I was afraid the merge conflict would be horrendous on this patch.\n\nSee https://review.opendev.org/c/openstack/swift/+/937189","commit_id":"6dcf63acfb8ab9c4711f4d59eba3105f40ce0c65"}],"test/unit/common/utils/test_logs.py":[{"author":{"_account_id":36606,"name":"Yan Xiao","display_name":"Yan","email":"yanxiao@nvidia.com","username":"yanxiao"},"change_message_id":"7313d9def17b81dd230374b7aea3c3a0329a6691","unresolved":true,"context_lines":[{"line_number":52,"context_line":"    get_swift_logger, get_prefixed_swift_logger"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"def reset_loggers():"},{"line_number":56,"context_line":"    if hasattr(get_swift_logger, \u0027handler4logger\u0027):"},{"line_number":57,"context_line":"        for logger, handler in get_swift_logger.handler4logger.items():"},{"line_number":58,"context_line":"            logger.removeHandler(handler)"}],"source_content_type":"text/x-python","patch_set":4,"id":"81d6ccd5_d2932694","line":55,"updated":"2024-11-12 22:29:28.000000000","message":"should probably be imported from test_utils.py","commit_id":"30d2e85cd0954e5e13f62599c967a0ff23c8ac30"},{"author":{"_account_id":35790,"name":"Shreeya Deshpande","email":"shreeyad@nvidia.com","username":"shreeyad"},"change_message_id":"208f58afc00c877e8ef46f7de07b797971298603","unresolved":false,"context_lines":[{"line_number":52,"context_line":"    get_swift_logger, get_prefixed_swift_logger"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"def reset_loggers():"},{"line_number":56,"context_line":"    if hasattr(get_swift_logger, \u0027handler4logger\u0027):"},{"line_number":57,"context_line":"        for logger, handler in get_swift_logger.handler4logger.items():"},{"line_number":58,"context_line":"            logger.removeHandler(handler)"}],"source_content_type":"text/x-python","patch_set":4,"id":"2ed6f944_e7b949a0","line":55,"in_reply_to":"81d6ccd5_d2932694","updated":"2024-11-22 01:00:55.000000000","message":"Actually, reset_logger for get_logger and reset_logger for get_swift_logger would both be needed. Places where swift_logger is used probably wouldn\u0027t be reset with get_logger_reset()","commit_id":"30d2e85cd0954e5e13f62599c967a0ff23c8ac30"},{"author":{"_account_id":36606,"name":"Yan Xiao","display_name":"Yan","email":"yanxiao@nvidia.com","username":"yanxiao"},"change_message_id":"7313d9def17b81dd230374b7aea3c3a0329a6691","unresolved":true,"context_lines":[{"line_number":80,"context_line":"    return wrapper"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"def purge_logger_statsd_client(name):"},{"line_number":84,"context_line":"    \u0027\u0027\u0027"},{"line_number":85,"context_line":"    Avoid test coupling by removing any StatsdClient instance"},{"line_number":86,"context_line":"    that may have been patched on to a Logger."}],"source_content_type":"text/x-python","patch_set":4,"id":"ce0812bc_a6d0ef13","line":83,"updated":"2024-11-12 22:29:28.000000000","message":"should probably be imported from test_utils.py","commit_id":"30d2e85cd0954e5e13f62599c967a0ff23c8ac30"},{"author":{"_account_id":35790,"name":"Shreeya Deshpande","email":"shreeyad@nvidia.com","username":"shreeyad"},"change_message_id":"208f58afc00c877e8ef46f7de07b797971298603","unresolved":false,"context_lines":[{"line_number":80,"context_line":"    return wrapper"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"def purge_logger_statsd_client(name):"},{"line_number":84,"context_line":"    \u0027\u0027\u0027"},{"line_number":85,"context_line":"    Avoid test coupling by removing any StatsdClient instance"},{"line_number":86,"context_line":"    that may have been patched on to a Logger."}],"source_content_type":"text/x-python","patch_set":4,"id":"8dbf0cf2_c0dbf471","line":83,"in_reply_to":"ce0812bc_a6d0ef13","updated":"2024-11-22 01:00:55.000000000","message":"Yes, we actually shouldn\u0027t need this in tset_logs. Moving this out","commit_id":"30d2e85cd0954e5e13f62599c967a0ff23c8ac30"},{"author":{"_account_id":36606,"name":"Yan Xiao","display_name":"Yan","email":"yanxiao@nvidia.com","username":"yanxiao"},"change_message_id":"7313d9def17b81dd230374b7aea3c3a0329a6691","unresolved":true,"context_lines":[{"line_number":886,"context_line":"        self.assertEqual(cloned_adapted_logger.thread_locals, (\u0027x\u0027, \u0027y\u0027))"},{"line_number":887,"context_line":"        self.assertIs(adapted_logger.logger, cloned_adapted_logger.logger)"},{"line_number":888,"context_line":""},{"line_number":889,"context_line":"    def test_get_prefixed_swift_logger_no_statsd_client(self):"},{"line_number":890,"context_line":"        # verify get_prefixed_logger can be used to mutate the prefix of a"},{"line_number":891,"context_line":"        # SwiftLogAdapter that does *not* have a StatsdClient interface"},{"line_number":892,"context_line":"        purge_logger_statsd_client(\u0027server\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"71857d15_e933d942","line":889,"updated":"2024-11-12 22:29:28.000000000","message":"should be prefixed_logger to be consistent as other test functions","commit_id":"30d2e85cd0954e5e13f62599c967a0ff23c8ac30"},{"author":{"_account_id":35790,"name":"Shreeya Deshpande","email":"shreeyad@nvidia.com","username":"shreeyad"},"change_message_id":"208f58afc00c877e8ef46f7de07b797971298603","unresolved":true,"context_lines":[{"line_number":886,"context_line":"        self.assertEqual(cloned_adapted_logger.thread_locals, (\u0027x\u0027, \u0027y\u0027))"},{"line_number":887,"context_line":"        self.assertIs(adapted_logger.logger, cloned_adapted_logger.logger)"},{"line_number":888,"context_line":""},{"line_number":889,"context_line":"    def test_get_prefixed_swift_logger_no_statsd_client(self):"},{"line_number":890,"context_line":"        # verify get_prefixed_logger can be used to mutate the prefix of a"},{"line_number":891,"context_line":"        # SwiftLogAdapter that does *not* have a StatsdClient interface"},{"line_number":892,"context_line":"        purge_logger_statsd_client(\u0027server\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"02e41e1f_2adc377b","line":889,"in_reply_to":"71857d15_e933d942","updated":"2024-11-22 01:00:55.000000000","message":"I changed this test case since we are testing get_prefixed_swift_logger() and not get_prefixed_logger(). To make it consistent I think changing test names to use swift_ would be well reflected in what it\u0027s testing.","commit_id":"30d2e85cd0954e5e13f62599c967a0ff23c8ac30"}]}