)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"aa5f66029417bbbcc48682beac186f08215a248c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"9de999b5_20e97b9e","updated":"2024-11-15 10:56:36.000000000","message":"I\u0027m voting -1 to indicate that despite authoring this test I am in fact ambivalent about it being merged. This is an opportunity if others feel they want this test.","commit_id":"af1d6691d87feb0cbb866166e510efab35412ef3"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"ae93ad80bfc7c452d01f9dbcb4d66664cd1429e0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"db330181_315ea560","updated":"2024-11-15 11:15:03.000000000","message":"If I see a +2 on this patch I\u0027ll squash it to the parent","commit_id":"af1d6691d87feb0cbb866166e510efab35412ef3"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"8ad798efe2c5d9dd7f7467a3485c95104557a1d5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"117e58bb_d31265d9","updated":"2024-11-15 16:56:07.000000000","message":"not helpful as a follow-up, even sq I think it makes less sense a new test than a diff to an existing test showing the change in the behavior of the existing class.  Happy to leave the legacy of SwiftLogAdatper as a statds_delegate-er behind to the git log.","commit_id":"af1d6691d87feb0cbb866166e510efab35412ef3"}],"test/unit/common/test_utils.py":[{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"aa5f66029417bbbcc48682beac186f08215a248c","unresolved":true,"context_lines":[{"line_number":7381,"context_line":"        if hasattr(self.core_logger, \u0027statsd_client\u0027):"},{"line_number":7382,"context_line":"            del self.core_logger.statsd_client"},{"line_number":7383,"context_line":""},{"line_number":7384,"context_line":"    def test_adapter_is_not_a_statsd_client(self):"},{"line_number":7385,"context_line":"        # Historically a SwiftLogAdapter *implicitly* provided an interface to"},{"line_number":7386,"context_line":"        # a StatsdClient that was added to the adapted logging.Logger instance"},{"line_number":7387,"context_line":"        # by utils.get_logger(). This is no longer the case; the"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba1b9c7c_51f3b8c1","line":7384,"updated":"2024-11-15 10:56:36.000000000","message":"added this to test_utils because:\n\n(a) it\u0027s related to the statsd delegation \"theme\"\n\n(b) putting it in test_logs would require importing FakeStatsdClient into test_logs (and I wanted the core_logger to have a statsd_client of some sort).","commit_id":"742b23cb117c064e7bbf62f26af022bfdac22015"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"c5a3a23a6d4f94e9465b1cf40eb3f1b59256cdcd","unresolved":true,"context_lines":[{"line_number":7387,"context_line":"        # by utils.get_logger(). This is no longer the case; the"},{"line_number":7388,"context_line":"        # _patch_statsd_methods function SwiftLogAdapter must now be used to"},{"line_number":7389,"context_line":"        # *explicitly* add a StatsdClient interface to a SwiftLogAdapter if"},{"line_number":7390,"context_line":"        # required."},{"line_number":7391,"context_line":"        self.core_logger.statsd_client \u003d FakeStatsdClient(\u0027host.com\u0027, 1234)"},{"line_number":7392,"context_line":"        adapter \u003d utils.logs.SwiftLogAdapter(self.core_logger, \u0027foo\u0027)"},{"line_number":7393,"context_line":"        self.assertFalse(hasattr(adapter, \u0027increment\u0027))"}],"source_content_type":"text/x-python","patch_set":2,"id":"37f416cc_86cb2b1a","line":7390,"updated":"2024-11-15 11:16:16.000000000","message":"come to think of it, would this sort of comment be useful in SwiftLogAdapter?","commit_id":"af1d6691d87feb0cbb866166e510efab35412ef3"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"8ad798efe2c5d9dd7f7467a3485c95104557a1d5","unresolved":true,"context_lines":[{"line_number":7387,"context_line":"        # by utils.get_logger(). This is no longer the case; the"},{"line_number":7388,"context_line":"        # _patch_statsd_methods function SwiftLogAdapter must now be used to"},{"line_number":7389,"context_line":"        # *explicitly* add a StatsdClient interface to a SwiftLogAdapter if"},{"line_number":7390,"context_line":"        # required."},{"line_number":7391,"context_line":"        self.core_logger.statsd_client \u003d FakeStatsdClient(\u0027host.com\u0027, 1234)"},{"line_number":7392,"context_line":"        adapter \u003d utils.logs.SwiftLogAdapter(self.core_logger, \u0027foo\u0027)"},{"line_number":7393,"context_line":"        self.assertFalse(hasattr(adapter, \u0027increment\u0027))"}],"source_content_type":"text/x-python","patch_set":2,"id":"7983ad6d_a4f40329","line":7390,"in_reply_to":"37f416cc_86cb2b1a","updated":"2024-11-15 16:56:07.000000000","message":"I think the commit message in 931473: Use a patcher to make SwiftLogAdapter looks like a StatsdClient | https://review.opendev.org/c/openstack/swift/+/931473 sort of hints as this, and that\u0027s probably the best place for it.","commit_id":"af1d6691d87feb0cbb866166e510efab35412ef3"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"8ad798efe2c5d9dd7f7467a3485c95104557a1d5","unresolved":true,"context_lines":[{"line_number":7390,"context_line":"        # required."},{"line_number":7391,"context_line":"        self.core_logger.statsd_client \u003d FakeStatsdClient(\u0027host.com\u0027, 1234)"},{"line_number":7392,"context_line":"        adapter \u003d utils.logs.SwiftLogAdapter(self.core_logger, \u0027foo\u0027)"},{"line_number":7393,"context_line":"        self.assertFalse(hasattr(adapter, \u0027increment\u0027))"},{"line_number":7394,"context_line":""},{"line_number":7395,"context_line":"    def test_patch_statsd_methods(self):"},{"line_number":7396,"context_line":"        client \u003d FakeStatsdClient(\u0027host.com\u0027, 1234)"}],"source_content_type":"text/x-python","patch_set":2,"id":"c6830095_9b826de4","line":7393,"updated":"2024-11-15 16:56:07.000000000","message":"I think this sort of assertion might have looked reasonable as an update to an existing test in the diff that \"made a SwiftLogAdapter an orange\" and seems less necessary after the fact.","commit_id":"af1d6691d87feb0cbb866166e510efab35412ef3"}]}