)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"bb74127c38136d9fe9052e8ce39d5ce6ecb03905","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"9f99e30c_4eeb8f50","updated":"2024-11-22 12:28:39.000000000","message":"IMHO this uses more familiar constructs and is therefore easier to grok than the original. However, I\u0027m not sure if we should bloat the parent patch with this (the parent needs to merge ASAP, and has a very targeted bug fix) or consider this as a separate refactor (in which case the commit message needs to change).","commit_id":"9008e860f35f3bf2ce273002b1b0cf142101660d"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"ae0a0792f0111a7ddfc89565bdde7d49a58db138","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"9a3e84c0_dfe9007c","updated":"2024-11-22 18:49:31.000000000","message":"as best I can tell this also returns the correct casing on the wire:\n\n```\nvagrant@saio:~$ curl -H \u0027x-auth-token: AUTH_tkxxx\u0027 http://saio:8080/v1/AUTH_test -I\nHTTP/1.1 204 No Content\nContent-Type: text/plain; charset\u003dutf-8\nX-Account-Container-Count: 0\nX-Account-Object-Count: 0\nX-Account-Bytes-Used: 0\nX-Timestamp: 1732113456.37823\nX-Account-Storage-Policy-Default-Container-Count: 0\nX-Account-Storage-Policy-Default-Object-Count: 0\nX-Account-Storage-Policy-Default-Bytes-Used: 0\nX-Account-Storage-Policy-Ec-Container-Count: 0\nX-Account-Storage-Policy-Ec-Object-Count: 0\nX-Account-Storage-Policy-Ec-Bytes-Used: 0\nAccept-Ranges: bytes\nX-Account-Access-Control: {\"admin\":[]}\nVary: Accept\nContent-Length: 0\nX-Trans-Id: txab7e2c24c6d146bfa71c2-006740d1a8\nX-Openstack-Request-Id: txab7e2c24c6d146bfa71c2-006740d1a8\nDate: Fri, 22 Nov 2024 18:47:04 GMT\n```","commit_id":"9008e860f35f3bf2ce273002b1b0cf142101660d"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"84b2d2db196651383b5c26b83ab8dfc8a92125c9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"4a483a8e_b7009d66","updated":"2024-11-22 12:17:03.000000000","message":"just a rebase","commit_id":"9008e860f35f3bf2ce273002b1b0cf142101660d"}],"swift/common/middleware/listing_formats.py":[{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"bb74127c38136d9fe9052e8ce39d5ce6ecb03905","unresolved":true,"context_lines":[{"line_number":205,"context_line":"            # proxy logging (and maybe other mw?) seem to be good about"},{"line_number":206,"context_line":"            # sticking this on HEAD/204 but we do it here to be responsible"},{"line_number":207,"context_line":"            # and explicit"},{"line_number":208,"context_line":"            headers_dict[\u0027content-length\u0027] \u003d 0"},{"line_number":209,"context_line":"            start_response(status, list(headers_dict.items()))"},{"line_number":210,"context_line":"            return resp_iter"},{"line_number":211,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3f72d8b3_e5b9c8e5","line":208,"range":{"start_line":208,"start_character":45,"end_line":208,"end_character":46},"updated":"2024-11-22 12:28:39.000000000","message":"ok, HeadersKeyDict changes the int to a string","commit_id":"9008e860f35f3bf2ce273002b1b0cf142101660d"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"bb74127c38136d9fe9052e8ce39d5ce6ecb03905","unresolved":true,"context_lines":[{"line_number":245,"context_line":"                body \u003d json.dumps(listing).encode(\u0027ascii\u0027)"},{"line_number":246,"context_line":"        except KeyError:"},{"line_number":247,"context_line":"            # listing was in a bad format -- funky static web listing??"},{"line_number":248,"context_line":"            start_response(status, list(headers_dict.items()))"},{"line_number":249,"context_line":"            return [body]"},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"        if not body:"}],"source_content_type":"text/x-python","patch_set":2,"id":"f3c6d4c7_91635183","line":248,"updated":"2024-11-22 12:28:39.000000000","message":"I wonder if we ought to be returning the unmodified resp headers in this case (same on master)","commit_id":"9008e860f35f3bf2ce273002b1b0cf142101660d"}]}