)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"66b32bae14f9264d3f65aae726dca4990e48ee4b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"24064935_2e872957","updated":"2024-12-02 21:06:00.000000000","message":"Definitely reduced the number of times I saw `eventlet-0.38.0` in jobs, and everybody still passed. Next ones to worry about:\n\n- `build-openstack-api-ref` -- seems to run unconstrained\n- `swift-build-image` -- though maybe we\u0027re ok with this being unconstrained?\n- `swift-multinode-rolling-upgrade` -- unconstrained because of https://github.com/openstack/swift/blob/2.34.0/tools/playbooks/multinode_setup/make_rings.yaml#L43\n- anybody relying on https://github.com/openstack/swift/blob/2.34.0/tools/playbooks/common/install_dependencies.yaml#L38, including\n  - `swift-func-cors`\n  - `swift-tox-func-s3api-ceph-s3tests-tempauth`\n  - `swift-tox-func-s3api-tests-tempauth`\n  - `swift-probetests-centos-9-stream`","commit_id":"54ec8a124a37d170166f10cb13fae48b5c29a0a0"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"d27feb1d2bcd56d1f8320d54a50e067c4cf47ef3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"e9104efa_07e6d2a3","updated":"2024-12-04 10:38:01.000000000","message":"Just want to clarify my understanding before merging.\n\nAlso, is it worth having a (non-voting) job that *does* upgrade packages to get a heads-up when something is going to break us (like eventlet 0.38.0 did)? Although in the recent case, unit tests didn\u0027t catch it anyway.","commit_id":"54ec8a124a37d170166f10cb13fae48b5c29a0a0"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"18f9e4062e76d392280d29baf785ee4920a8cb30","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"aaea85f1_7fcb29d3","updated":"2024-12-06 17:54:56.000000000","message":"recheck\n\nLooks like some repo-mirroring hiccup.","commit_id":"54ec8a124a37d170166f10cb13fae48b5c29a0a0"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"9217a51fd3a92d0e6524496504c2c3a9b286699d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"9b6f4595_ac3e5932","in_reply_to":"e9104efa_07e6d2a3","updated":"2024-12-04 17:40:28.000000000","message":"\u003e Also, is it worth having a (non-voting) job that does upgrade packages to get a heads-up when something is going to break us (like eventlet 0.38.0 did)?\n\nYeah, I was thinking that\u0027d be good once we have everything properly pinned down. Would we want unit, func, probe, s3 cross-compat...?\n\nProbably start with just unit and in-process (encryption-enabled) func tests.","commit_id":"54ec8a124a37d170166f10cb13fae48b5c29a0a0"}],"tox.ini":[{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"d27feb1d2bcd56d1f8320d54a50e067c4cf47ef3","unresolved":true,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"[testenv]"},{"line_number":12,"context_line":"usedevelop \u003d True"},{"line_number":13,"context_line":"install_command \u003d pip install {opts} {packages}"},{"line_number":14,"context_line":"setenv \u003d VIRTUAL_ENV\u003d{envdir}"},{"line_number":15,"context_line":"deps \u003d"},{"line_number":16,"context_line":"  -c{env:TOX_CONSTRAINTS_FILE:https://releases.openstack.org/constraints/upper/master}"}],"source_content_type":"text/x-properties","patch_set":1,"id":"cc356a6a_f27ba44e","line":13,"updated":"2024-12-04 10:38:01.000000000","message":"I\u0027m confused...did the -U option override the constraints file (which currently pins eventlet to 0.36.1)?","commit_id":"54ec8a124a37d170166f10cb13fae48b5c29a0a0"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"9217a51fd3a92d0e6524496504c2c3a9b286699d","unresolved":true,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"[testenv]"},{"line_number":12,"context_line":"usedevelop \u003d True"},{"line_number":13,"context_line":"install_command \u003d pip install {opts} {packages}"},{"line_number":14,"context_line":"setenv \u003d VIRTUAL_ENV\u003d{envdir}"},{"line_number":15,"context_line":"deps \u003d"},{"line_number":16,"context_line":"  -c{env:TOX_CONSTRAINTS_FILE:https://releases.openstack.org/constraints/upper/master}"}],"source_content_type":"text/x-properties","patch_set":1,"id":"d9a84900_171fd08d","line":13,"in_reply_to":"cc356a6a_f27ba44e","updated":"2024-12-04 17:40:28.000000000","message":"The trick is that tox runs `install_command` more than once: first as part of `install_deps` with everything in `deps`, then as part of `install_package_deps` with whatever the swift wheel lists as dependencies, then again as part of `install_package` for the wheel itself. And that\u0027s just for the `[tox : Run tox without tests]` task; `install_package` happens *again* in the `[tox : Run tox]` task. Only the first of those has the constraints file. For a recent example, see\n\n- https://zuul.opendev.org/t/openstack/build/9541bde525e54826993099aa8019c2a0/log/job-output.txt#994\n- https://zuul.opendev.org/t/openstack/build/9541bde525e54826993099aa8019c2a0/log/job-output.txt#1739\n- https://zuul.opendev.org/t/openstack/build/9541bde525e54826993099aa8019c2a0/log/job-output.txt#1767\n- https://zuul.opendev.org/t/openstack/build/9541bde525e54826993099aa8019c2a0/log/job-output.txt#2431\n\nFollowing the second link, there\u0027s\n```\nRequirement already satisfied: pycparser in ./.tox/py312/lib/python3.12/site-packages (from cffi\u003e\u003d1.12-\u003ecryptography\u003e\u003d2.0.2) (2.22)\nInstalling collected packages: eventlet\n  Attempting uninstall: eventlet\n    Found existing installation: eventlet 0.36.1\n    Uninstalling eventlet-0.36.1:\n      Successfully uninstalled eventlet-0.36.1\nSuccessfully installed eventlet-0.38.0\n```\n(ignoring some log prefixing)","commit_id":"54ec8a124a37d170166f10cb13fae48b5c29a0a0"}]}