)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"c63b4813ae0e67539c00949d12ca9f4dbe9c85b4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"8a3ae00f_56a6c16a","updated":"2025-01-14 11:09:57.000000000","message":"There\u0027s obviously some issue w.r.t. openstack requirements and pytest-subtests\n\nSadly my pycharm IDE built-in test runner doesn\u0027t seem to like subtest failures and screws up the test output formatting. Which is disappointing because I\u0027d really like to adopt subtest.\n\nUpdate: FYI for anyone else with pycharm, I found a workaround ref https://youtrack.jetbrains.com/issue/PY-34218/TeamCity-messages-in-output-console-running-tests (the issue is not exactly the same but disabling the teamcity console output capture seems to help w.r.t. subtest failures)\nAdd JB_DISABLE_BUFFERING\u003d to the pytest and autodetect test config templates.","commit_id":"a31f2c5488ba24af18a84c89648568b5ff8a6726"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"577a0b2fe7e1f9e1f4c624b97b87419d329afc27","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"195cc846_80a45554","in_reply_to":"8a3ae00f_56a6c16a","updated":"2025-02-14 18:42:29.000000000","message":"\u003e  it appears to be causing PyCharm\u0027s pytest UI to think that tests have succeeded when they have actually failed (see screenshot.)\n\nOof. That should be a show-stopper... I\u0027m dumbfounded that it\u0027s still open nearly 6 years later...","commit_id":"a31f2c5488ba24af18a84c89648568b5ff8a6726"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"577a0b2fe7e1f9e1f4c624b97b87419d329afc27","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"98a3b68c_ea6e8276","updated":"2025-02-14 18:42:29.000000000","message":"Submitted https://review.opendev.org/c/openstack/requirements/+/941708 to add `pytest-subtests` to global requirements.","commit_id":"ff455194477e502f1ddc1652209dfba8bacac698"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"46a1f8eded61299fef4fca2ccbd53323f3629859","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"881674e6_e83a0ffe","updated":"2025-04-09 23:36:57.000000000","message":"We can +A it -- it won\u0027t attempt to merge until the Depends-On merges.","commit_id":"ff455194477e502f1ddc1652209dfba8bacac698"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"7e63603a0670e093ad9cfb683083d81a00d2e36f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"9e62b828_55efdeb9","updated":"2025-02-19 09:56:50.000000000","message":"not sure if I should workflow +1 until the constraints patch merges??","commit_id":"ff455194477e502f1ddc1652209dfba8bacac698"}],"test/probe/test_sharder.py":[{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"c63b4813ae0e67539c00949d12ca9f4dbe9c85b4","unresolved":true,"context_lines":[{"line_number":3305,"context_line":"        # root container own shard range should still be SHARDED"},{"line_number":3306,"context_line":"        for i, node in enumerate(self.brain.nodes):"},{"line_number":3307,"context_line":"            with annotate_failure(\u0027node[%d]\u0027 % i):"},{"line_number":3308,"context_line":"                broker \u003d self.get_broker(self.brain.part, self.brain.nodes[0])"},{"line_number":3309,"context_line":"                self.assertEqual(ShardRange.SHARDED,"},{"line_number":3310,"context_line":"                                 broker.get_own_shard_range().state)"},{"line_number":3311,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"128ffcbe_12d9c039","side":"PARENT","line":3308,"updated":"2025-01-14 11:09:57.000000000","message":"oops","commit_id":"31ccf24770b36663e7fec302ade97231c35f5d1e"}]}