)]}'
{"swift/common/middleware/proxy_logging.py":[{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"4bf5755117b81be5b8d73f56bdb0b72d3f21dd45","unresolved":true,"context_lines":[{"line_number":129,"context_line":"        self.anonymization_salt \u003d conf.get(\u0027log_anonymization_salt\u0027, \u0027\u0027)"},{"line_number":130,"context_line":"        self.storage_domains \u003d list_from_csv(conf.get(\u0027storage_domain\u0027, \u0027\u0027))"},{"line_number":131,"context_line":"        self.dns_compliant_bucket_names \u003d config_true_value("},{"line_number":132,"context_line":"            conf.get(\u0027dns_compliant_bucket_names\u0027, True))"},{"line_number":133,"context_line":"        self.log_hdrs \u003d config_true_value(conf.get("},{"line_number":134,"context_line":"            \u0027access_log_headers\u0027,"},{"line_number":135,"context_line":"            conf.get(\u0027log_headers\u0027, \u0027no\u0027)))"}],"source_content_type":"text/x-python","patch_set":1,"id":"f8bdd8d8_752019d3","line":132,"updated":"2025-02-07 15:01:24.000000000","message":"this needs unit test coverage","commit_id":"35d85638db312ddca7cc04a26ae1f70833ae3cb2"}],"test/unit/common/middleware/s3api/test_utils.py":[{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"4bf5755117b81be5b8d73f56bdb0b72d3f21dd45","unresolved":true,"context_lines":[{"line_number":127,"context_line":"                         utils.extract_bucket_and_key(req, [], False))"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"        self.assertEqual((None, None),"},{"line_number":130,"context_line":"                         utils.extract_bucket_and_key(req, [], True))"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"    def test_get_s3_access_key_id_not_s3_req(self):"},{"line_number":133,"context_line":"        headers \u003d {\u0027Authorization\u0027: \u0027not AWS my_access_key_id:signature\u0027}"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f6743cc_06f77901","line":130,"updated":"2025-02-07 15:01:24.000000000","message":"for the purpose of labeling metrics, this seems less useful outcome than getting the invalid bucket name","commit_id":"35d85638db312ddca7cc04a26ae1f70833ae3cb2"}],"test/unit/common/middleware/test_proxy_logging.py":[{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"4bf5755117b81be5b8d73f56bdb0b72d3f21dd45","unresolved":true,"context_lines":[{"line_number":1489,"context_line":""},{"line_number":1490,"context_line":"        def fake_app(env, start_response):"},{"line_number":1491,"context_line":"            req_environs.append(env)"},{"line_number":1492,"context_line":"            return HTTPOk()(env, start_response)"},{"line_number":1493,"context_line":""},{"line_number":1494,"context_line":"        mw \u003d proxy_logging.ProxyLoggingMiddleware("},{"line_number":1495,"context_line":"            fake_app, mw_conf, logger\u003dself.logger)"}],"source_content_type":"text/x-python","patch_set":1,"id":"539492a6_34f1eb7a","line":1492,"updated":"2025-02-07 15:01:24.000000000","message":"oh FakeSwift why do you NOT capture the request environ 😭","commit_id":"35d85638db312ddca7cc04a26ae1f70833ae3cb2"}]}