)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"e47be3ab8a6e912abe490b06569728b31da33e10","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"45e215ba_5c4a5178","updated":"2025-05-13 19:44:18.000000000","message":"I think the test changes got squashed into https://review.opendev.org/c/openstack/swift/+/836755 a while back?","commit_id":"2810ceeb4ed0ac60972d1e5141276ae0236de33e"}],"swift/common/middleware/s3api/s3token.py":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"aa5c807586f76ab21c61b08e4c80eb44bf8834e4","unresolved":true,"context_lines":[{"line_number":365,"context_line":"                        cred_ref \u003d self.keystoneclient.ec2.get("},{"line_number":366,"context_line":"                            user_id\u003duser_id,"},{"line_number":367,"context_line":"                            access\u003daccess)"},{"line_number":368,"context_line":"                        if s3_auth_details[\u0027check_signature\u0027](cred_ref.secret):"},{"line_number":369,"context_line":"                            # This should always be true (keystone *just* told"},{"line_number":370,"context_line":"                            # us it was valid), but we want to make sure the"},{"line_number":371,"context_line":"                            # secret gets plumbed back into s3api via the"}],"source_content_type":"text/x-python","patch_set":1,"id":"b2ff2fe2_3227305e","side":"PARENT","line":368,"updated":"2025-02-14 19:26:32.000000000","message":"OK, so back this guy out; leave it as a known-issue until we can get a proper (\u0026 tested!) fix.","commit_id":"030d6272a2b20c7db308e71cf0c30ef31e699944"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"e47be3ab8a6e912abe490b06569728b31da33e10","unresolved":true,"context_lines":[{"line_number":365,"context_line":"                        cred_ref \u003d self.keystoneclient.ec2.get("},{"line_number":366,"context_line":"                            user_id\u003duser_id,"},{"line_number":367,"context_line":"                            access\u003daccess)"},{"line_number":368,"context_line":"                        if s3_auth_details[\u0027check_signature\u0027](cred_ref.secret):"},{"line_number":369,"context_line":"                            # This should always be true (keystone *just* told"},{"line_number":370,"context_line":"                            # us it was valid), but we want to make sure the"},{"line_number":371,"context_line":"                            # secret gets plumbed back into s3api via the"}],"source_content_type":"text/x-python","patch_set":1,"id":"0d3036b0_e2d8f028","side":"PARENT","line":368,"in_reply_to":"80f625c5_5733b3be","updated":"2025-05-13 19:44:18.000000000","message":"Brought it back in https://review.opendev.org/c/openstack/swift/+/949671","commit_id":"030d6272a2b20c7db308e71cf0c30ef31e699944"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"9185ef72f3de6a830ca8b50432a4d152b2a9e7ef","unresolved":true,"context_lines":[{"line_number":365,"context_line":"                        cred_ref \u003d self.keystoneclient.ec2.get("},{"line_number":366,"context_line":"                            user_id\u003duser_id,"},{"line_number":367,"context_line":"                            access\u003daccess)"},{"line_number":368,"context_line":"                        if s3_auth_details[\u0027check_signature\u0027](cred_ref.secret):"},{"line_number":369,"context_line":"                            # This should always be true (keystone *just* told"},{"line_number":370,"context_line":"                            # us it was valid), but we want to make sure the"},{"line_number":371,"context_line":"                            # secret gets plumbed back into s3api via the"}],"source_content_type":"text/x-python","patch_set":1,"id":"80f625c5_5733b3be","side":"PARENT","line":368,"in_reply_to":"b2ff2fe2_3227305e","updated":"2025-02-17 18:06:52.000000000","message":"ok, so I don\u0027t think I intended to push this change - I was reverting to establish that no tests would fail. But yeah, I think we need to leave this until we have tests. We do now have the catch-all NotImplementedError in s3Request.","commit_id":"030d6272a2b20c7db308e71cf0c30ef31e699944"}],"test/unit/common/middleware/s3api/test_s3request.py":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"aa5c807586f76ab21c61b08e4c80eb44bf8834e4","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c0d951fc_1c893857","updated":"2025-02-14 19:26:32.000000000","message":"This is going to take me a bit to digest.","commit_id":"2810ceeb4ed0ac60972d1e5141276ae0236de33e"}]}