)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"04980f320c6b11d9227dc48a45e85938f790f445","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"dbc76477_f764bdb1","updated":"2025-02-20 21:42:46.000000000","message":"the only harm I can see here would come from if we think of a better way to do this later using e.g. `boto3.Session(profile_name\u003d\u0027some name\u0027)` and supporting this extended-pseudo-credential-file format we made up for `SWIFT_TEST_AWS_CONFIG_FILE` is annoying to maintain for backwards compat.\n\nBut hopefully at that point we can just make a `SWIFT_TEST_AWS_BOTO_PROFILE_NAME` to take precedent and when unset still allow users to configure exactly what they want via the default section of our explicit s3-sepcific config file.  But by then maybe I can toggle between testing s3api and various aws/region/option by *just* flipping my boto-profile-name?","commit_id":"f9354c9eb6752e583bdcdf7e8af658e262fb77b0"}],"test/s3api/__init__.py":[{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"04980f320c6b11d9227dc48a45e85938f790f445","unresolved":true,"context_lines":[{"line_number":45,"context_line":"    Read user credentials from an AWS CLI style credentials file and translate"},{"line_number":46,"context_line":"    to a swift test config. Currently only supports a single user."},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    :param conf_file: path to AWS credentials file"},{"line_number":49,"context_line":"    \"\"\""},{"line_number":50,"context_line":"    conf \u003d readconf(conf_file, \u0027default\u0027)"},{"line_number":51,"context_line":"    global _CONFIG"}],"source_content_type":"text/x-python","patch_set":1,"id":"d1b2c612_3c062e10","line":48,"updated":"2025-02-20 21:42:46.000000000","message":"I think this method was originally imagined as a taking an unmodified `~/.aws/credentials` file; which don\u0027t typically have `endpoint` or `region` keys.\n\nA `~/.aws/config` file would; but the semantics are different and they\u0027re probably more difficult to parse:\n\n```\n\u003e\u003e\u003e readconf(os.path.expanduser(\u0027~/.aws/config\u0027))[\u0027profile default\u0027][\u0027s3\u0027].splitlines()\n[\u0027\u0027, \u0027signature_version \u003d s3v4\u0027, \u0027endpoint_url \u003d http://saio:8080\u0027]\n```\n\nmaybe it\u0027s better to just extend the aws credentials file to meet our needs.","commit_id":"f9354c9eb6752e583bdcdf7e8af658e262fb77b0"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"04980f320c6b11d9227dc48a45e85938f790f445","unresolved":true,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    :param conf_file: path to AWS credentials file"},{"line_number":49,"context_line":"    \"\"\""},{"line_number":50,"context_line":"    conf \u003d readconf(conf_file, \u0027default\u0027)"},{"line_number":51,"context_line":"    global _CONFIG"},{"line_number":52,"context_line":"    _CONFIG \u003d {"},{"line_number":53,"context_line":"        \u0027endpoint\u0027: conf.get(\u0027endpoint\u0027, \u0027https://s3.amazonaws.com\u0027),"}],"source_content_type":"text/x-python","patch_set":1,"id":"8526f720_bfb624fc","line":50,"updated":"2025-02-20 21:42:46.000000000","message":"this method is already fairly opinionated on how your ~/.aws/credentials is configured; so it\u0027s probably not always reasonable to expect this test suite to be able to take your \"existing s3 config\" *as-is*","commit_id":"f9354c9eb6752e583bdcdf7e8af658e262fb77b0"}]}