)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"cd768368ae884f2bc9052776e6fd17d57032ee87","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"b741d306_061948ff","updated":"2025-02-26 23:33:39.000000000","message":"I 100% support this idea in spirit and also haven\u0027t tested it on my local vsaio but would very much like to use it in theory!","commit_id":"22e41fc2ea779f56dce79f4fbd88c3c385c9f5f6"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"4845ad1125a31694425557f56a7c90952754c2cb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"872bebcf_e42b83fe","updated":"2025-05-14 09:56:08.000000000","message":"I\u0027d very much like something like this - but I tried to salvage some of the test assertions that pass with or without s3_acl in an alternative https://review.opendev.org/c/openstack/swift/+/949716","commit_id":"22e41fc2ea779f56dce79f4fbd88c3c385c9f5f6"}],"test/s3api/test_service.py":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"cedbfca1907bb337ab7bab3d60cf2000cc23a05c","unresolved":true,"context_lines":[{"line_number":23,"context_line":"    @classmethod"},{"line_number":24,"context_line":"    def setUpClass(cls):"},{"line_number":25,"context_line":"        if not config_true_value(get_opt(\u0027include_s3_acl_tests\u0027, \u0027true\u0027)):"},{"line_number":26,"context_line":"            raise unittest.SkipTest(\u0027include_s3_acl_tests is disabled\u0027)"},{"line_number":27,"context_line":"        return super().setUpClass()"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    def test_empty_service(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"ec92c592_7ef1d561","line":26,"updated":"2025-03-04 21:58:31.000000000","message":"Hmmm... actually, these don\u0027t pass against AWS, either -- unless you have no buckets at the outset, I guess? Maybe the option should be more specific, like `include_service_level_tests`?\n\nI was thinking that later we may have other tests that require `s3_acl` to be enabled (something involving per-object ACLs, say?) so let\u0027s have it be somewhat generic to that -- but it just seems weird to need to configure `include_s3_acl_tests \u003d no` to get a successful whole-suite run against a non-Swift endpoint...","commit_id":"22e41fc2ea779f56dce79f4fbd88c3c385c9f5f6"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"4845ad1125a31694425557f56a7c90952754c2cb","unresolved":true,"context_lines":[{"line_number":23,"context_line":"    @classmethod"},{"line_number":24,"context_line":"    def setUpClass(cls):"},{"line_number":25,"context_line":"        if not config_true_value(get_opt(\u0027include_s3_acl_tests\u0027, \u0027true\u0027)):"},{"line_number":26,"context_line":"            raise unittest.SkipTest(\u0027include_s3_acl_tests is disabled\u0027)"},{"line_number":27,"context_line":"        return super().setUpClass()"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    def test_empty_service(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"cb8fefc8_853ca968","line":26,"in_reply_to":"ec92c592_7ef1d561","updated":"2025-05-14 09:56:08.000000000","message":"Also , pieces of the tests *do* pass even with s3_acl \u003d False, so I think there\u0027s two possible reasons to skip:\n\n* skip because s3_acl \u003d False\n* skip because buckets exist\n\nAnd with some refactoring some of the assertions can pass with or without s3_acl","commit_id":"22e41fc2ea779f56dce79f4fbd88c3c385c9f5f6"}]}