)]}'
{"swift/common/utils/checksum.py":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"032e1351b08a330cde99b9046529200334e5b8bc","unresolved":true,"context_lines":[{"line_number":119,"context_line":""},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"crc32c_func \u003d _select_crc32c_impl()"},{"line_number":122,"context_line":"if crc32c_func \u003d\u003d crc32c_ref:"},{"line_number":123,"context_line":"    warnings.warn(\u0027Using (slow) reference implementation for CRC32-C; \u0027"},{"line_number":124,"context_line":"                  \u0027install ISA-L for faster checksums.\u0027, RuntimeWarning)"},{"line_number":125,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"44fa6766_c2b61c15","line":122,"range":{"start_line":122,"start_character":15,"end_line":122,"end_character":17},"updated":"2025-03-13 04:32:35.000000000","message":"`is`","commit_id":"75c62240ead0e070046b6fefdee2add2d74233b7"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"c3b0460208460d76c0ebb838dc85fae8540e8f83","unresolved":false,"context_lines":[{"line_number":119,"context_line":""},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"crc32c_func \u003d _select_crc32c_impl()"},{"line_number":122,"context_line":"if crc32c_func \u003d\u003d crc32c_ref:"},{"line_number":123,"context_line":"    warnings.warn(\u0027Using (slow) reference implementation for CRC32-C; \u0027"},{"line_number":124,"context_line":"                  \u0027install ISA-L for faster checksums.\u0027, RuntimeWarning)"},{"line_number":125,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"8f6ef963_0f0691ea","line":122,"range":{"start_line":122,"start_character":15,"end_line":122,"end_character":17},"in_reply_to":"44fa6766_c2b61c15","updated":"2025-03-17 19:41:01.000000000","message":"Done","commit_id":"75c62240ead0e070046b6fefdee2add2d74233b7"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"032e1351b08a330cde99b9046529200334e5b8bc","unresolved":true,"context_lines":[{"line_number":159,"context_line":""},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"crc64nvme_func \u003d _select_crc64nvme_impl()"},{"line_number":162,"context_line":"if crc64nvme_func \u003d\u003d crc64nvme_ref:"},{"line_number":163,"context_line":"    warnings.warn(\u0027Using (slow) reference implementation for CRC64-NVME; \u0027"},{"line_number":164,"context_line":"                  \u0027install ISA-L for faster checksums.\u0027, RuntimeWarning)"},{"line_number":165,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"2db21f3a_679374e4","line":162,"range":{"start_line":162,"start_character":18,"end_line":162,"end_character":20},"updated":"2025-03-13 04:32:35.000000000","message":"`is`","commit_id":"75c62240ead0e070046b6fefdee2add2d74233b7"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"c3b0460208460d76c0ebb838dc85fae8540e8f83","unresolved":false,"context_lines":[{"line_number":159,"context_line":""},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"crc64nvme_func \u003d _select_crc64nvme_impl()"},{"line_number":162,"context_line":"if crc64nvme_func \u003d\u003d crc64nvme_ref:"},{"line_number":163,"context_line":"    warnings.warn(\u0027Using (slow) reference implementation for CRC64-NVME; \u0027"},{"line_number":164,"context_line":"                  \u0027install ISA-L for faster checksums.\u0027, RuntimeWarning)"},{"line_number":165,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"8fe53a0f_fc08f575","line":162,"range":{"start_line":162,"start_character":18,"end_line":162,"end_character":20},"in_reply_to":"2db21f3a_679374e4","updated":"2025-03-17 19:41:01.000000000","message":"Done","commit_id":"75c62240ead0e070046b6fefdee2add2d74233b7"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"032e1351b08a330cde99b9046529200334e5b8bc","unresolved":true,"context_lines":[{"line_number":228,"context_line":""},{"line_number":229,"context_line":"def crc32(data\u003dNone, initial_value\u003d0):"},{"line_number":230,"context_line":"    return CRCHasher(\u0027crc32\u0027,"},{"line_number":231,"context_line":"                     zlib.crc32,"},{"line_number":232,"context_line":"                     data\u003ddata,"},{"line_number":233,"context_line":"                     initial_value\u003dinitial_value)"},{"line_number":234,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"b016e775_f3754f76","line":231,"range":{"start_line":231,"start_character":21,"end_line":231,"end_character":31},"updated":"2025-03-13 04:32:35.000000000","message":"Side note: I wonder at what point we\u0027ll want a `_select_crc32_impl`...\n\nI feel like I looked into it a little and decided stdlib was \"fast enough\" -- but especially if boto3 is defaulting to CRC32, we may want to revisit.","commit_id":"75c62240ead0e070046b6fefdee2add2d74233b7"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"c3b0460208460d76c0ebb838dc85fae8540e8f83","unresolved":true,"context_lines":[{"line_number":228,"context_line":""},{"line_number":229,"context_line":"def crc32(data\u003dNone, initial_value\u003d0):"},{"line_number":230,"context_line":"    return CRCHasher(\u0027crc32\u0027,"},{"line_number":231,"context_line":"                     zlib.crc32,"},{"line_number":232,"context_line":"                     data\u003ddata,"},{"line_number":233,"context_line":"                     initial_value\u003dinitial_value)"},{"line_number":234,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"0ad1e2f4_a15af930","line":231,"range":{"start_line":231,"start_character":21,"end_line":231,"end_character":31},"in_reply_to":"b016e775_f3754f76","updated":"2025-03-17 19:41:01.000000000","message":"🤔 Maybe we\u0027ll also want something like eventlet\u0027s `EVENTLET_HUB` -- `SWIFT_CRC_BACKEND`, say? With options `isa-l`, `kernel`, `anycrc`?\n\nThough there\u0027s also the sha1 and sh256 checksum options...","commit_id":"75c62240ead0e070046b6fefdee2add2d74233b7"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"032e1351b08a330cde99b9046529200334e5b8bc","unresolved":true,"context_lines":[{"line_number":235,"context_line":""},{"line_number":236,"context_line":"def crc32c(data\u003dNone, initial_value\u003d0):"},{"line_number":237,"context_line":"    return CRCHasher(\u0027crc32c\u0027,"},{"line_number":238,"context_line":"                     _select_crc32c_impl(),"},{"line_number":239,"context_line":"                     data\u003ddata,"},{"line_number":240,"context_line":"                     initial_value\u003dinitial_value)"},{"line_number":241,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"4570d43a_069862fb","line":238,"range":{"start_line":238,"start_character":21,"end_line":238,"end_character":40},"updated":"2025-03-13 04:32:35.000000000","message":"If we\u0027re calling this here, do we even need to write down `crc32c_func`?","commit_id":"75c62240ead0e070046b6fefdee2add2d74233b7"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"c3b0460208460d76c0ebb838dc85fae8540e8f83","unresolved":false,"context_lines":[{"line_number":235,"context_line":""},{"line_number":236,"context_line":"def crc32c(data\u003dNone, initial_value\u003d0):"},{"line_number":237,"context_line":"    return CRCHasher(\u0027crc32c\u0027,"},{"line_number":238,"context_line":"                     _select_crc32c_impl(),"},{"line_number":239,"context_line":"                     data\u003ddata,"},{"line_number":240,"context_line":"                     initial_value\u003dinitial_value)"},{"line_number":241,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"142bb1ec_dd8ade78","line":238,"range":{"start_line":238,"start_character":21,"end_line":238,"end_character":40},"in_reply_to":"4570d43a_069862fb","updated":"2025-03-17 19:41:01.000000000","message":"Done","commit_id":"75c62240ead0e070046b6fefdee2add2d74233b7"}]}