)]}'
{"swift/common/middleware/s3api/exception.py":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"4fa5cfdc1e7b4d06812abc67d5735fec35c9f727","unresolved":true,"context_lines":[{"line_number":92,"context_line":"    Client provided a X-Amz-Checksum-* header, but it doesn\u0027t match the data."},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    This should result in a InvalidRequest going back to the client."},{"line_number":95,"context_line":"    Note that we cheat a little and re-use this in our SLO per-segment hook"},{"line_number":96,"context_line":"    (even though wsgi.input is no longer involved)"},{"line_number":97,"context_line":"    \"\"\""},{"line_number":98,"context_line":""},{"line_number":99,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"19957609_cd389fa5","line":96,"range":{"start_line":95,"start_character":4,"end_line":96,"end_character":50},"updated":"2025-03-14 21:31:54.000000000","message":"Oh yeah, this comment is out of date now...","commit_id":"87e1ad0fe0805684981dc11fa8b9b8e2b2f64922"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"4fa5cfdc1e7b4d06812abc67d5735fec35c9f727","unresolved":true,"context_lines":[{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    This should result in a InvalidRequest going back to the client."},{"line_number":105,"context_line":"    \"\"\""},{"line_number":106,"context_line":"    def __init__(self, trailer):"},{"line_number":107,"context_line":"        self.trailer \u003d trailer"}],"source_content_type":"text/x-python","patch_set":1,"id":"e6ccdf6b_3a306928","line":106,"range":{"start_line":106,"start_character":23,"end_line":106,"end_character":30},"updated":"2025-03-14 21:31:54.000000000","message":"Is this the header name, or the value? We should make that clear in the arg name, at least.","commit_id":"87e1ad0fe0805684981dc11fa8b9b8e2b2f64922"}],"test/unit/common/middleware/s3api/test_s3request.py":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"4fa5cfdc1e7b4d06812abc67d5735fec35c9f727","unresolved":true,"context_lines":[{"line_number":1465,"context_line":"        sigv4_req \u003d SigV4Request(req.environ)"},{"line_number":1466,"context_line":"        # Verify header signature"},{"line_number":1467,"context_line":"        self.assertTrue(sigv4_req.sig_checker.check_signature(\u0027secret\u0027))"},{"line_number":1468,"context_line":"        return sigv4_req"},{"line_number":1469,"context_line":""},{"line_number":1470,"context_line":"    def test_check_sig_v4_streaming_unsigned_payload_trailer_ok(self):"},{"line_number":1471,"context_line":"        body \u003d \u0027a\\r\\nabcdefghij\\r\\n\u0027 \\"}],"source_content_type":"text/x-python","patch_set":1,"id":"56bc6744_0dd41c1f","line":1468,"updated":"2025-03-14 21:31:54.000000000","message":"Do we want a similar change in `_test_sig_v4_streaming_aws_hmac_sha256_payload_trailer`? Feels weird to have them asymmetric like that.","commit_id":"87e1ad0fe0805684981dc11fa8b9b8e2b2f64922"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"4fa5cfdc1e7b4d06812abc67d5735fec35c9f727","unresolved":true,"context_lines":[{"line_number":1589,"context_line":"               \u00277\\r\\nuvwxyz\\n\\r\\n\u0027 \\"},{"line_number":1590,"context_line":"               \u00270\\r\\n\u0027 \\"},{"line_number":1591,"context_line":"               \u0027x-amz-checksum-sha256: not\u003dbase-64\\r\\n\u0027"},{"line_number":1592,"context_line":"        s3req \u003d self._test_sig_v4_streaming_unsigned_payload_trailer(body)"},{"line_number":1593,"context_line":"        self.assertEqual(b\u0027abcdefghijklmnopqrst\u0027,"},{"line_number":1594,"context_line":"                         s3req.environ[\u0027wsgi.input\u0027].read(20))"},{"line_number":1595,"context_line":"        with self.assertRaises(s3request.S3InputChecksumTrailerInvalid):"}],"source_content_type":"text/x-python","patch_set":1,"id":"73121af4_36608ea3","line":1592,"range":{"start_line":1592,"start_character":8,"end_line":1592,"end_character":13},"updated":"2025-03-14 21:31:54.000000000","message":"Everywhere else we just use `req` -- I wonder if we want to rename the other returns to be `s3req` too...\n\nThough we bump into line-length limits if we tryo to apply the same logic to `_test_sig_v4_streaming_aws_hmac_sha256_payload_trailer` :-/","commit_id":"87e1ad0fe0805684981dc11fa8b9b8e2b2f64922"}]}