)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"d1a43b1d1fccaac960f3f4c83b520bc94f7b7889","unresolved":true,"context_lines":[{"line_number":11,"context_line":"function. Several logger options were not included in this subset,"},{"line_number":12,"context_line":"presumably due to an oversight when the options were added, i.e.:"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"  log_max_line_length"},{"line_number":15,"context_line":"  log_address"},{"line_number":16,"context_line":"  log_custom_handlers"},{"line_number":17,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"a69670f3_376b777d","line":14,"updated":"2025-03-26 12:04:47.000000000","message":"is it possible that this omission was deliberate, since proxy-logging has a log_msg_template and you\u0027d expect everything in the template to be emitted???","commit_id":"8fd2166e7dbaddc25115cdfce7643b04864b5f7d"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"d1a43b1d1fccaac960f3f4c83b520bc94f7b7889","unresolved":true,"context_lines":[{"line_number":12,"context_line":"presumably due to an oversight when the options were added, i.e.:"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"  log_max_line_length"},{"line_number":15,"context_line":"  log_address"},{"line_number":16,"context_line":"  log_custom_handlers"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"This patch modifies proxy logging so that *all* config options are"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"6a145ad5_3740c1cd","line":15,"updated":"2025-03-26 12:04:47.000000000","message":"access_log_address was even documented in the proxy-logging conf section!","commit_id":"8fd2166e7dbaddc25115cdfce7643b04864b5f7d"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"d1a43b1d1fccaac960f3f4c83b520bc94f7b7889","unresolved":true,"context_lines":[{"line_number":26,"context_line":"option, if specified, would overwrite the \u0027log_name\u0027 option passed to"},{"line_number":27,"context_line":"get_logger."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"This patch does NOT extend the \u0027access_\u0027 prefix pattern to the options"},{"line_number":30,"context_line":"that were not previously passed to get_logger. For example,"},{"line_number":31,"context_line":"access_log_address will NOT overwrite log_address. Operators that wish"},{"line_number":32,"context_line":"to vary the access logger\u0027s options from the generic values are"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"8717bb63_14ec803b","line":29,"updated":"2025-03-26 12:04:47.000000000","message":"I\u0027m not sure which way to fall on this. I\u0027m trying to resist proliferation of the access_ prefix pattern, but having written the patch (and particularly fixing the proxy-server.conf-sample), I\u0027ve realised that it\u0027s much simpler to document that *all* log_ options can be prefixed with \u0027access_\u0027","commit_id":"8fd2166e7dbaddc25115cdfce7643b04864b5f7d"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"aee02c8b37d477ad528dac65c9bb7c3476e55ebc","unresolved":true,"context_lines":[{"line_number":26,"context_line":"option, if specified, would overwrite the \u0027log_name\u0027 option passed to"},{"line_number":27,"context_line":"get_logger."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"This patch does NOT extend the \u0027access_\u0027 prefix pattern to the options"},{"line_number":30,"context_line":"that were not previously passed to get_logger. For example,"},{"line_number":31,"context_line":"access_log_address will NOT overwrite log_address. Operators that wish"},{"line_number":32,"context_line":"to vary the access logger\u0027s options from the generic values are"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3a49680f_32e6a22b","line":29,"in_reply_to":"8717bb63_14ec803b","updated":"2025-03-26 17:01:23.000000000","message":"not if we deprecate the access_log_* pattern - then ALL log_ options can be overridden with the expected set option \u003d value format (which is always how you override default options)","commit_id":"8fd2166e7dbaddc25115cdfce7643b04864b5f7d"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"aee02c8b37d477ad528dac65c9bb7c3476e55ebc","unresolved":true,"context_lines":[{"line_number":31,"context_line":"access_log_address will NOT overwrite log_address. Operators that wish"},{"line_number":32,"context_line":"to vary the access logger\u0027s options from the generic values are"},{"line_number":33,"context_line":"encouraged to use the \u0027set log_\u003csuffix\u003e \u003d value\u0027 syntax in the"},{"line_number":34,"context_line":"proxy-logging filter config section."},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"Closes-Bug: #2104248"},{"line_number":37,"context_line":"Change-Id: If494956cfb44d1f73c360365acf10e596d77321a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"0e6ac0d3_3ef79380","line":34,"updated":"2025-03-26 17:01:23.000000000","message":"right, enabling this is the *fix* - we should document that expected style and remove the access_ prefix pattern from the docs possibly only supporting it with a deprecation warning.","commit_id":"8fd2166e7dbaddc25115cdfce7643b04864b5f7d"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"aee02c8b37d477ad528dac65c9bb7c3476e55ebc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"4793a01f_536ab1b8","updated":"2025-03-26 17:01:23.000000000","message":"seems like a good idea to me - we should deprecate the unsustainable access_log_ pattern as part of fixing the bug.","commit_id":"8fd2166e7dbaddc25115cdfce7643b04864b5f7d"}],"etc/proxy-server.conf-sample":[{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"d1a43b1d1fccaac960f3f4c83b520bc94f7b7889","unresolved":true,"context_lines":[{"line_number":994,"context_line":""},{"line_number":995,"context_line":"# \"log_*\" options documented in the [DEFAULT] section are inherited for"},{"line_number":996,"context_line":"# proxy-logging. They can be overridden in this section using the \u0027set option \u003d"},{"line_number":997,"context_line":"# value\u0027 syntax. For historical reasons, some, but not all, \"log_*\" options"},{"line_number":998,"context_line":"# can also be overridden here by prefixing them with \"access_\"."},{"line_number":999,"context_line":"# access_log_name \u003d swift"},{"line_number":1000,"context_line":"# access_log_facility \u003d LOG_LOCAL0"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"be8c8146_98a8c210","line":997,"range":{"start_line":997,"start_character":41,"end_line":997,"end_character":59},"updated":"2025-03-26 12:04:47.000000000","message":"right, this doesn\u0027t feel helpful to ops that are already trying to navigate a somewhat complicated conf document\n\n\"why not all?\" seems like a reasonable complaint","commit_id":"8fd2166e7dbaddc25115cdfce7643b04864b5f7d"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"aee02c8b37d477ad528dac65c9bb7c3476e55ebc","unresolved":true,"context_lines":[{"line_number":994,"context_line":""},{"line_number":995,"context_line":"# \"log_*\" options documented in the [DEFAULT] section are inherited for"},{"line_number":996,"context_line":"# proxy-logging. They can be overridden in this section using the \u0027set option \u003d"},{"line_number":997,"context_line":"# value\u0027 syntax. For historical reasons, some, but not all, \"log_*\" options"},{"line_number":998,"context_line":"# can also be overridden here by prefixing them with \"access_\"."},{"line_number":999,"context_line":"# access_log_name \u003d swift"},{"line_number":1000,"context_line":"# access_log_facility \u003d LOG_LOCAL0"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"83debdc5_2445b1d5","line":997,"range":{"start_line":997,"start_character":41,"end_line":997,"end_character":59},"in_reply_to":"be8c8146_98a8c210","updated":"2025-03-26 17:01:23.000000000","message":"yeah I think it\u0027d be ok for this closes-bug change to document the `set option \u003d value` syntax add a warning around `access_` values to encourage migration and officially \"deprecate\" any further support for access_log options.","commit_id":"8fd2166e7dbaddc25115cdfce7643b04864b5f7d"}],"swift/common/middleware/proxy_logging.py":[{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"aee02c8b37d477ad528dac65c9bb7c3476e55ebc","unresolved":true,"context_lines":[{"line_number":149,"context_line":"                    \u0027log_statsd_default_sample_rate\u0027,"},{"line_number":150,"context_line":"                    \u0027log_statsd_sample_rate_factor\u0027,"},{"line_number":151,"context_line":"                    \u0027log_statsd_metric_prefix\u0027):"},{"line_number":152,"context_line":"            value \u003d conf.get(\u0027access_\u0027 + key, conf.get(key, None))"},{"line_number":153,"context_line":"            if value:"},{"line_number":154,"context_line":"                access_log_conf[key] \u003d value"},{"line_number":155,"context_line":"        self.access_logger \u003d logger or get_logger("}],"source_content_type":"text/x-python","patch_set":3,"id":"ac400f16_97b1e708","line":152,"updated":"2025-03-26 17:01:23.000000000","message":"it\u0027s possible having the `conf.get` here is redundant; maybe better as just:\n\n```\nif access_ + key in conf:\n    warn(\u0027deprecated access_log use set key \u003d value instead\u0027)\n    conf[key] \u003d conf[access + key]\n```","commit_id":"8fd2166e7dbaddc25115cdfce7643b04864b5f7d"}],"test/unit/common/middleware/test_proxy_logging.py":[{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"aee02c8b37d477ad528dac65c9bb7c3476e55ebc","unresolved":true,"context_lines":[{"line_number":268,"context_line":""},{"line_number":269,"context_line":"    def test_init_some_log_options_not_overridden_by_access_log_options(self):"},{"line_number":270,"context_line":"        # access_log_\u003coption\u003e does NOT override log_\u003coption\u003e for the following"},{"line_number":271,"context_line":"        # exceptions: log_address, log_max_line_length, log_custom_handlers"},{"line_number":272,"context_line":"        conf \u003d {"},{"line_number":273,"context_line":"            \u0027access_log_name\u0027: \u0027alice\u0027,"},{"line_number":274,"context_line":"            \u0027access_log_address\u0027: \u0027/dev/access_log_file\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"2e4cda68_8582b197","line":271,"updated":"2025-03-26 17:01:23.000000000","message":"... and as such is deprecated in favor of `set log_option \u003d value` syntax","commit_id":"8fd2166e7dbaddc25115cdfce7643b04864b5f7d"}]}