)]}'
{"id":"openstack%2Fswift~947574","triplet_id":"openstack%2Fswift~master~I642ac8dba86b66e6ecf212cb644af4b7193f56a3","project":"openstack/swift","branch":"master","topic":"label","attention_set":{},"removed_from_attention_set":{"7847":{"account":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"last_update":"2025-04-22 09:50:17.000000000","reason":"\u003cGERRIT_ACCOUNT_7847\u003e replied on the change","reason_account":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"}},"15343":{"account":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"last_update":"2025-04-22 10:05:36.000000000","reason":"Change was abandoned"}},"hashtags":[],"change_id":"I642ac8dba86b66e6ecf212cb644af4b7193f56a3","subject":"sq: cleanup StreamingInput and ChunkReader","status":"ABANDONED","created":"2025-04-17 13:33:56.000000000","updated":"2025-04-22 10:05:36.000000000","total_comment_count":4,"unresolved_comment_count":3,"has_review_started":true,"meta_rev_id":"1dc7b5fdde583fbb42f262f147d94b5f23ac865c","_number":947574,"virtual_id_number":947574,"owner":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:check","value":1,"date":"2025-04-17 14:42:06.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2025-04-21 21:40:04.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-04-17 14:28:28.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2025-04-17 14:42:06.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2025-04-21 21:40:04.000000000","updated_by":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"reviewer":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"state":"REVIEWER"}],"messages":[{"id":"6d77c4ec26a2478f7d005de4702f57ff737bc105","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"date":"2025-04-17 13:33:56.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"0e58294d297918831f4a9e624fe8dd5158ac08fa","tag":"autogenerated:zuul:check-arm64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-04-17 14:28:28.000000000","message":"Patch Set 1:\n\nBuild succeeded (ARM64 pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/588035f9f45f46d280a063df12deb02f\n\n- swift-tox-py312-arm64 https://zuul.opendev.org/t/openstack/build/de1e1882727c447eb822a9c4bc588949 : SUCCESS in 52m 11s","accounts_in_message":[],"_revision_number":1},{"id":"a852dd4698b1c717e919d500eebe9dfb96aa8585","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-04-17 14:42:06.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/36e63140de4144c5803a7d5ac10a24b1\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/2f63813d8c374faaa5ba2db0a2217bc0 : SUCCESS in 4m 48s\n- grenade https://zuul.opendev.org/t/openstack/build/06a6eaa2a03a4a49a22c1a55f0e55c35 : SUCCESS in 51m 09s\n- grenade-skip-level-always https://zuul.opendev.org/t/openstack/build/afd27b03f596420b9299de23251e0d18 : SUCCESS in 49m 07s\n- tempest-integrated-object-storage https://zuul.opendev.org/t/openstack/build/59fbe7b731334226873675e0d9d0c257 : SUCCESS in 44m 45s\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/e92936a94bf449289636c366c47d42ef : SUCCESS in 32m 20s\n- swift-tox-func-py39-centos-9-stream-fips https://zuul.opendev.org/t/openstack/build/dfc29a81bdad480c96575383a1226fbb : SUCCESS in 10m 20s (non-voting)\n- swift-tox-func-encryption-py39-centos-9-stream-fips https://zuul.opendev.org/t/openstack/build/76a12c8b310d44e8a94734f86ead7d1e : SUCCESS in 21m 10s (non-voting)\n- swift-tox-func-ec-py39-centos-9-stream-fips https://zuul.opendev.org/t/openstack/build/af02c11ebe9945fca17eb1842a21f811 : SUCCESS in 22m 59s (non-voting)\n- swift-build-image https://zuul.opendev.org/t/openstack/build/b53f71e3ba1646ccac23c8fad355cab2 : SUCCESS in 7m 52s (non-voting)\n- swift-tox-py36 https://zuul.opendev.org/t/openstack/build/b4f98126971143daafbbaa3b71d13146 : SUCCESS in 17m 57s\n- swift-tox-py39 https://zuul.opendev.org/t/openstack/build/3c39a0de956f4d77bd4e8f02f628a2d1 : SUCCESS in 19m 28s\n- swift-tox-py312 https://zuul.opendev.org/t/openstack/build/cee0458368d249fb859f56c12ba50dff : SUCCESS in 23m 36s\n- swift-tox-func-py312 https://zuul.opendev.org/t/openstack/build/4b46c011428e42958f3d892dc54db314 : SUCCESS in 8m 44s\n- swift-tox-func-encryption-py312 https://zuul.opendev.org/t/openstack/build/09b34b676fe7444b887f6c42cfe1209b : SUCCESS in 23m 47s\n- swift-tox-func-ec-py312 https://zuul.opendev.org/t/openstack/build/73c5ade0fd4a4a3c882643711ef986fb : SUCCESS in 16m 37s\n- swift-func-cors https://zuul.opendev.org/t/openstack/build/4e53160d8c5d45adbf554bd5f474406d : SUCCESS in 7m 48s\n- swift-tox-func-ceph-s3tests-tempauth https://zuul.opendev.org/t/openstack/build/f85984c48b524b5bbf018dcb2187fc28 : SUCCESS in 18m 34s (non-voting)\n- swift-tox-func-s3api-compat-tests-tempauth https://zuul.opendev.org/t/openstack/build/a6cdaa1ae0e244c8905693a4a7538bc2 : SUCCESS in 8m 47s\n- swift-probetests-centos-9-stream https://zuul.opendev.org/t/openstack/build/b849290c3fb64d34a8b6ca34713e1c54 : SUCCESS in 1h 00m 52s\n- swift-dsvm-functional https://zuul.opendev.org/t/openstack/build/b3462fee02c348828e2e3d8feebd19c3 : SUCCESS in 33m 10s\n- swift-dsvm-functional-ipv6 https://zuul.opendev.org/t/openstack/build/60aa96b1b17a47a1a83443fcf8e91f8c : SUCCESS in 48m 49s\n- swift-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/d8d7753bdaee43058b0d62ca2ffd6598 : SUCCESS in 16m 04s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/f86975975eb54ff88ccc7039452e137c : SUCCESS in 5m 45s\n- swift-multinode-rolling-upgrade https://zuul.opendev.org/t/openstack/build/24d6c3cc91ea41e7bf4f76f708ce36f6 : SUCCESS in 23m 16s\n- tempest-integrated-object-storage-ubuntu-jammy https://zuul.opendev.org/t/openstack/build/000976f8c75d48e095a0ee0a7dda08c4 : SUCCESS in 29m 00s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/7fa84976f6f145a9bbf4ec849486ead6 : SUCCESS in 55m 47s","accounts_in_message":[],"_revision_number":1},{"id":"0ea6ac566fc7a72f280db1222e58cc71cf9e4529","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2025-04-21 21:40:04.000000000","message":"Patch Set 1: Code-Review+2\n\n(3 comments)","accounts_in_message":[],"_revision_number":1},{"id":"19d1a4f28813722747d6d36666026e248428d4e3","author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"date":"2025-04-22 09:50:17.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"1dc7b5fdde583fbb42f262f147d94b5f23ac865c","tag":"autogenerated:gerrit:abandon","author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"date":"2025-04-22 10:05:36.000000000","message":"Abandoned\n\nsquashed into https://review.opendev.org/c/openstack/swift/+/836755/74","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"71f12ee6c890f1f8c810ff9d4ad6205d1f387c27","revisions":{"71f12ee6c890f1f8c810ff9d4ad6205d1f387c27":{"kind":"REWORK","_number":1,"created":"2025-04-17 13:33:56.000000000","uploader":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"ref":"refs/changes/74/947574/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/swift","ref":"refs/changes/74/947574/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/swift refs/changes/74/947574/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/swift refs/changes/74/947574/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/swift refs/changes/74/947574/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/swift refs/changes/74/947574/1"}}},"commit":{"parents":[{"commit":"4ee081373017f0b0b72f046467675d6f46d91c89","subject":"sq: fixups for s3pi chunked transfer","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/4ee081373017f0b0b72f046467675d6f46d91c89"}]}],"author":{"name":"Alistair Coles","email":"alistairncoles@gmail.com","date":"2025-04-17 10:39:06.000000000","tz":60},"committer":{"name":"Alistair Coles","email":"alistairncoles@gmail.com","date":"2025-04-17 13:32:04.000000000","tz":60},"subject":"sq: cleanup StreamingInput and ChunkReader","message":"sq: cleanup StreamingInput and ChunkReader\n\n- some variable renaming for consistency/clarity\n- break up long read method into read_payload, read_trailers\n- close the input, in one place, whenever an error is raised\n- unify post-end-of-chunk handling (end of payload or chunk separator)\n  in StreamingInput (previously split between ChunkReader and\n  StreamingInput.\n- make ChunkReader subclass InputProxy (minor benefit or re-using close)\n- add unit tests\n\nChange-Id: I642ac8dba86b66e6ecf212cb644af4b7193f56a3\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/71f12ee6c890f1f8c810ff9d4ad6205d1f387c27"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/71f12ee6c890f1f8c810ff9d4ad6205d1f387c27"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Verified\u003dMAX","label:Verified\u003dMIN"],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX"],"failing_atoms":["label:Code-Review\u003dMIN"],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Workflow\u003dMAX","label:Workflow\u003dMIN"],"atom_explanations":{}}}]}