)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"273171244dd8eed3744deaac2822cb72dc30de09","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This reverts commit 33b89492eb2b15db453c91c9dd0d6d837cb81915."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Reason for revert: Some packaging workflows still need this."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I5cfb8e6412adea30a1a21ce20f6a72c30dfbfac3"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9852c9c7_a527472a","line":11,"range":{"start_line":11,"start_character":19,"end_line":11,"end_character":43},"updated":"2025-05-22 02:18:39.000000000","message":"This still needs some investigation -- I know a downstream packager bumped into issues building RPMs -- specifically, some of the non-python XML schema files required by s3api no longer appeared in the RPM, leading to clients no longer being able to (for example) complete MPUs.\n\nIf there\u0027s a reasonably-straightforward downstream fix that doesn\u0027t require this revert, I don\u0027t know we *need* to put MANIFEST.in back.","commit_id":"b9d1002c79416c1d641715634fcbeb6d9e899a3a"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":37598,"name":"Ivan Anfimov","display_name":"Ivan Anfimov","email":"lazekteam@gmail.com","username":"anfimovir"},"change_message_id":"fd51bed964f8707fd1f92f8fd138a79ea243ef1f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"f7e5b162_e93fbb66","updated":"2025-06-01 19:56:35.000000000","message":"@tburke@nvidia.com hello, I think revert not need.","commit_id":"b9d1002c79416c1d641715634fcbeb6d9e899a3a"},{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"403ec21f8574de8c0e1dad855802e5416c9754a1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"562a59ea_b490437c","updated":"2025-08-14 04:26:04.000000000","message":"Because there is an issue if you try and build a swift without the git metadata and MANIFEST.in is the way to specify extra files that need to be added, I think we should probably still have this file.\n\nThe fact that it does work without it in most cases is great, but I\u0027d hate someone to hit the same edgecase as me, and the simple way to make it OK for everyone is to have it, so I think we should keep having the MANIFEST.in... at least for now.","commit_id":"b9d1002c79416c1d641715634fcbeb6d9e899a3a"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"9e8c7a635e8ead1ac5ca8e6143cfe7019443a398","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"d14e63f1_e0a058b8","updated":"2025-05-28 22:17:35.000000000","message":"I tried a fresh `python3 -m build .` on py37 after applying\n```\ndiff --git a/pyproject.toml b/pyproject.toml\nindex e63322f96..c617e919e 100644\n--- a/pyproject.toml\n+++ b/pyproject.toml\n@@ -1,3 +1,3 @@\n [build-system]\n-requires \u003d [\"pbr\u003e\u003d6.0.0\", \"setuptools\u003e\u003d64\"]\n+requires \u003d [\"pbr\u003d\u003d6.0.0\", \"setuptools\u003d\u003d64\"]\n build-backend \u003d \"pbr.build\"\n```\nLooks like the schema files get included:\n```\n~/swift$ unzip -l dist/swift-2.36.0.dev73-py3-none-any.whl | grep s3api/schema\n      443  2025-05-28 22:04   swift/common/middleware/s3api/schema/access_control_policy.rng\n      780  2025-05-28 22:04   swift/common/middleware/s3api/schema/bucket_logging_status.rng\n     2009  2025-05-28 22:04   swift/common/middleware/s3api/schema/common.rng\n      568  2025-05-28 22:04   swift/common/middleware/s3api/schema/complete_multipart_upload.rng\n      557  2025-05-28 22:04   swift/common/middleware/s3api/schema/complete_multipart_upload_result.rng\n      399  2025-05-28 22:04   swift/common/middleware/s3api/schema/copy_object_result.rng\n      397  2025-05-28 22:04   swift/common/middleware/s3api/schema/copy_part_result.rng\n      321  2025-05-28 22:04   swift/common/middleware/s3api/schema/create_bucket_configuration.rng\n      801  2025-05-28 22:04   swift/common/middleware/s3api/schema/delete.rng\n     1412  2025-05-28 22:04   swift/common/middleware/s3api/schema/delete_result.rng\n      732  2025-05-28 22:04   swift/common/middleware/s3api/schema/error.rng\n      482  2025-05-28 22:04   swift/common/middleware/s3api/schema/initiate_multipart_upload_result.rng\n     1555  2025-05-28 22:04   swift/common/middleware/s3api/schema/lifecycle_configuration.rng\n      700  2025-05-28 22:04   swift/common/middleware/s3api/schema/list_all_my_buckets_result.rng\n     2562  2025-05-28 22:04   swift/common/middleware/s3api/schema/list_bucket_result.rng\n     2059  2025-05-28 22:04   swift/common/middleware/s3api/schema/list_multipart_uploads_result.rng\n     1657  2025-05-28 22:04   swift/common/middleware/s3api/schema/list_parts_result.rng\n     3005  2025-05-28 22:04   swift/common/middleware/s3api/schema/list_versions_result.rng\n      269  2025-05-28 22:04   swift/common/middleware/s3api/schema/location_constraint.rng\n      652  2025-05-28 22:04   swift/common/middleware/s3api/schema/versioning_configuration.rng\n~/swift$ tar tzf dist/swift-2.36.0.dev73.tar.gz | grep s3api/schema\nswift-2.36.0.dev73/swift/common/middleware/s3api/schema/\nswift-2.36.0.dev73/swift/common/middleware/s3api/schema/access_control_policy.rng\nswift-2.36.0.dev73/swift/common/middleware/s3api/schema/bucket_logging_status.rng\nswift-2.36.0.dev73/swift/common/middleware/s3api/schema/common.rng\nswift-2.36.0.dev73/swift/common/middleware/s3api/schema/complete_multipart_upload.rng\nswift-2.36.0.dev73/swift/common/middleware/s3api/schema/complete_multipart_upload_result.rng\nswift-2.36.0.dev73/swift/common/middleware/s3api/schema/copy_object_result.rng\nswift-2.36.0.dev73/swift/common/middleware/s3api/schema/copy_part_result.rng\nswift-2.36.0.dev73/swift/common/middleware/s3api/schema/create_bucket_configuration.rng\nswift-2.36.0.dev73/swift/common/middleware/s3api/schema/delete.rng\nswift-2.36.0.dev73/swift/common/middleware/s3api/schema/delete_result.rng\nswift-2.36.0.dev73/swift/common/middleware/s3api/schema/error.rng\nswift-2.36.0.dev73/swift/common/middleware/s3api/schema/initiate_multipart_upload_result.rng\nswift-2.36.0.dev73/swift/common/middleware/s3api/schema/lifecycle_configuration.rng\nswift-2.36.0.dev73/swift/common/middleware/s3api/schema/list_all_my_buckets_result.rng\nswift-2.36.0.dev73/swift/common/middleware/s3api/schema/list_bucket_result.rng\nswift-2.36.0.dev73/swift/common/middleware/s3api/schema/list_multipart_uploads_result.rng\nswift-2.36.0.dev73/swift/common/middleware/s3api/schema/list_parts_result.rng\nswift-2.36.0.dev73/swift/common/middleware/s3api/schema/list_versions_result.rng\nswift-2.36.0.dev73/swift/common/middleware/s3api/schema/location_constraint.rng\nswift-2.36.0.dev73/swift/common/middleware/s3api/schema/versioning_configuration.rng\n```\nI\u0027m inclined to say the trouble was in downstream not keeping up to date with two-year-old packaging tools.","commit_id":"b9d1002c79416c1d641715634fcbeb6d9e899a3a"},{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"3c6b82edf9c18ab173d5f8e30da796f8bf77eb22","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"60ba676b_a80cd3fe","updated":"2025-08-14 01:44:39.000000000","message":"OK finally solved the issue in the downstream build system. Turns out it all works great on our dev laptops because it includes the git repo and setuptools with the git scm plugin can use git to see the scema rng files are part of the repo so it includes it.\n\nOn the downstream build system we just pull the source from github as a tag/branch tarball which doesn\u0027t include the git repo metadata, so it doesn\u0027t know those rng files are apart and ignores them.\n\nThe included MANIFEST.in would give normal setuptools the heads up on these files.\n\nIt does mean though if anyone is building this like we are downstream, s3api is broken unless they\u0027re using the git metadata too (ie use a shallow clone) and have git available on their build system.\n\nI\u0027m happy to just fix this in my build system, but still might cause issues for others out there.. so I\u0027m in 2 minds about this. Maybe it\u0027s better to have a MAINIFEST.in until it is in fact properly deprecated, or we have another way of telling setuptools these files need to be included that doesn\u0027t rely on the git metadata.","commit_id":"b9d1002c79416c1d641715634fcbeb6d9e899a3a"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"273171244dd8eed3744deaac2822cb72dc30de09","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"f2ad00d6_1da4051a","updated":"2025-05-22 02:18:39.000000000","message":"recheck\n\nSome connection timeout during pip install","commit_id":"b9d1002c79416c1d641715634fcbeb6d9e899a3a"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"57d1294e726b9fb49176813ea7da872bd448ba92","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"00988516_8dd676d2","updated":"2025-08-14 16:27:15.000000000","message":"we\u0027re carrying this patch b/c our packaging is broken - we\u0027re probably not the only one:\n\nPackaging: s3api unit tests fail due to missing package_data for schema files - https://bugs.launchpad.net/swift/+bug/2120590","commit_id":"b9d1002c79416c1d641715634fcbeb6d9e899a3a"},{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"f970122e2cdb5de7482ef72b35640f9265b48004","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"2289e480_9d7d7487","in_reply_to":"d14e63f1_e0a058b8","updated":"2025-08-13 07:37:16.000000000","message":"I\u0027ve tried building the latest version of setuptools and it still doesn\u0027t add them downstream.","commit_id":"b9d1002c79416c1d641715634fcbeb6d9e899a3a"},{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"f970122e2cdb5de7482ef72b35640f9265b48004","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"201afc44_33353c9d","in_reply_to":"d14e63f1_e0a058b8","updated":"2025-08-13 07:37:16.000000000","message":"When I run build or install on my laptop it\u0027s also fine. But downstream no matter what I do it doesn\u0027t include them. I\u0027ve tried building the latest setuptools (to no avail). Upgraded PBR. We\u0027re running py3.10.\n\nI\u0027ve tried manually adding the schame dir as a package_data.. I\u0027m obviously missing somethingin the downstream env.. just haven\u0027t figured it out yet.","commit_id":"b9d1002c79416c1d641715634fcbeb6d9e899a3a"},{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"47d0d34345b39267c10f983c244fe96365763b22","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"e02d6c39_981a7b35","updated":"2025-08-15 02:11:34.000000000","message":"Just added the bug that this will fix to the commit message.\n\n@tim needed to add a sign off based on the new rules. So just signed it myself.. it is just a revert after all.","commit_id":"de81a844f3410f5bf676186f1ac284a14b0e4b49"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"92ac97a71dc958c731dc39272e834e6e8cbb4dcd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"006c5fda_c4140b51","updated":"2025-08-18 23:33:41.000000000","message":"Thanks for digging in to this some more @matt@oliver.net.au -- and for linking the bug. Looks like we *do* still want `MANIFEST.in`","commit_id":"de81a844f3410f5bf676186f1ac284a14b0e4b49"},{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"6ab492c18db131ea656b0e02bcbbe5d85b8eec23","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"feb32b40_67ce46f0","updated":"2025-08-19 01:08:49.000000000","message":"recheck","commit_id":"de81a844f3410f5bf676186f1ac284a14b0e4b49"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"cd97f52803f16bc3e32baa76aa488e27ff807fef","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"8c328722_8d800e52","updated":"2025-08-20 17:32:00.000000000","message":"recheck\n\npy37 issue should be resolved now.","commit_id":"de81a844f3410f5bf676186f1ac284a14b0e4b49"}]}