)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"cd4f293d44fa8f8df8446406498cb5c42be1688e","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Yan Xiao \u003cyanxiao@nvidia.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2025-05-27 17:15:34 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Object-server: change labeled timing metrics sample rate for debugging requests"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Ia6e856ffaf8fd1b4a905e6976ebdc62ed5ddf32f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ad49b74d_64ec300a","line":7,"updated":"2025-05-28 08:48:02.000000000","message":"could you add a sentence explaining why the sample rates aren\u0027t appropriate? IIUC it was to do with the low rate at which some of the label variants are emitted?\n\nAlso, why are we not changing the legacy metric sample rate? is it because they *are* still appropriate, or just because this patch is limited in scope to labeled metrics?","commit_id":"1905922765fb712eeaffdda8d3cdb5ddcab66d99"},{"author":{"_account_id":36606,"name":"Yan Xiao","display_name":"Yan","email":"yanxiao@nvidia.com","username":"yanxiao"},"change_message_id":"d0e9542e3b0118cb7165a5ac18341ed11633d942","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Yan Xiao \u003cyanxiao@nvidia.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2025-05-27 17:15:34 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Object-server: change labeled timing metrics sample rate for debugging requests"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Ia6e856ffaf8fd1b4a905e6976ebdc62ed5ddf32f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"e9fc0717_b14edda0","line":7,"in_reply_to":"ad49b74d_64ec300a","updated":"2025-05-28 21:22:04.000000000","message":"Acknowledged","commit_id":"1905922765fb712eeaffdda8d3cdb5ddcab66d99"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"cd4f293d44fa8f8df8446406498cb5c42be1688e","unresolved":true,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2025-05-27 17:15:34 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Object-server: change labeled timing metrics sample rate for debugging requests"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Ia6e856ffaf8fd1b4a905e6976ebdc62ed5ddf32f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"c03cd071_6b936158","line":8,"updated":"2025-05-28 08:48:02.000000000","message":"please add \n\n```\nRelated-Change: I05336b700120ab5fcf922590d6a12f73112edb50\n```\n\ni.e. the gerrit id of the patch that added the labeled metrics","commit_id":"1905922765fb712eeaffdda8d3cdb5ddcab66d99"},{"author":{"_account_id":36606,"name":"Yan Xiao","display_name":"Yan","email":"yanxiao@nvidia.com","username":"yanxiao"},"change_message_id":"d0e9542e3b0118cb7165a5ac18341ed11633d942","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2025-05-27 17:15:34 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Object-server: change labeled timing metrics sample rate for debugging requests"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Ia6e856ffaf8fd1b4a905e6976ebdc62ed5ddf32f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"abe24a0c_8816c328","line":8,"in_reply_to":"c03cd071_6b936158","updated":"2025-05-28 21:22:04.000000000","message":"Acknowledged","commit_id":"1905922765fb712eeaffdda8d3cdb5ddcab66d99"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"a872a6dd1be41544d512d6f5e14211523e157805","unresolved":true,"context_lines":[{"line_number":11,"context_line":"not been helpful when using labeled metrics to investigate customer"},{"line_number":12,"context_line":"issues, for example those related to object server REPLICATE requests."},{"line_number":13,"context_line":"This patch changes labeled timing metrics to not have sample_rate. The"},{"line_number":14,"context_line":"non-labeled metrics are unrelated to this effort thus not changed."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Related-Change: I05336b700120ab5fcf922590d6a12f73112edb50"},{"line_number":17,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"a605467f_332fe279","line":14,"updated":"2025-05-29 10:14:07.000000000","message":"That\u0027s great! thanks","commit_id":"313959ae9253681760a5639c1256aa036692a603"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"cd4f293d44fa8f8df8446406498cb5c42be1688e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"5b338649_ded09981","updated":"2025-05-28 08:48:02.000000000","message":"LGTM\n\nI reverted the change and saw expected tests fail:\n\n```\nFAILED test/unit/obj/test_server.py::TestObjectController::test_legacy_and_labeled_timing_stats_head_error - AssertionError: {\u0027timing_since\u0027: [((\u0027swift_object_server_[127 chars]}})]} !\u003d defaultdict(\u003cclass \u0027list\u0027\u003e, {\u0027timing_sinc[176 chars]})]})\nFAILED test/unit/obj/test_server.py::TestObjectController::test_legacy_and_labeled_timing_stats_head_success - AssertionError: {\u0027timing_since\u0027: [((\u0027swift_object_server_[127 chars]}})]} !\u003d defaultdict(\u003cclass \u0027list\u0027\u003e, {\u0027timing_sinc[176 chars]})]})\nFAILED test/unit/obj/test_server.py::TestObjectController::test_legacy_and_labeled_timing_stats_replicate_507 - AssertionError: {\u0027timing_since\u0027: [((\u0027swift_object_server_[120 chars]}})]} !\u003d defaultdict(\u003cclass \u0027list\u0027\u003e, {\u0027timing_sinc[169 chars]})]})\nFAILED test/unit/obj/test_server.py::TestObjectController::test_legacy_and_labeled_timing_stats_replicate_bad_policy - AssertionError: {\u0027timing_since\u0027: [((\u0027swift_object_server_[85 chars]}})]} !\u003d defaultdict(\u003cclass \u0027list\u0027\u003e, {\u0027timing_sinc[134 chars]})]})\nFAILED test/unit/obj/test_server.py::TestObjectController::test_legacy_and_labeled_timing_stats_replicate_policy - AssertionError: {\u0027timing_since\u0027: [((\u0027swift_object_server_[121 chars]}})]} !\u003d defaultdict(\u003cclass \u0027list\u0027\u003e, {\u0027timing_sinc[170 chars]})]})\nFAILED test/unit/obj/test_server.py::TestObjectController::test_legacy_and_labeled_timing_stats_replicate_skip_rehash - AssertionError: {\u0027timing_since\u0027: [((\u0027swift_object_server_[119 chars]}})]} !\u003d defaultdict(\u003cclass \u0027list\u0027\u003e, {\u0027timing_sinc[168 chars]})]})\nFAILED test/unit/obj/test_server.py::TestObjectController::test_legacy_and_labeled_timing_stats_replicate_success - AssertionError: {\u0027timing_since\u0027: [((\u0027swift_object_server_[120 chars]}})]} !\u003d defaultdict(\u003cclass \u0027list\u0027\u003e, {\u0027timing_sinc[169 chars]})]})\nFAILED test/unit/obj/test_server.py::TestObjectController::test_legacy_and_labeled_timing_stats_ssync_bad_policy - AssertionError: {\u0027timing_since\u0027: [((\u0027swift_object_server_[81 chars]}})]} !\u003d defaultdict(\u003cclass \u0027list\u0027\u003e, {\u0027timing_sinc[130 chars]})]})\nFAILED test/unit/obj/test_server.py::TestObjectController::test_legacy_and_labeled_timing_stats_ssync_error - AssertionError: {\u0027timing_since\u0027: [((\u0027swift_object_server_[82 chars]}})]} !\u003d defaultdict(\u003cclass \u0027list\u0027\u003e, {\u0027timing_sinc[131 chars]})]})\nFAILED test/unit/obj/test_server.py::TestObjectController::test_legacy_and_labeled_timing_stats_ssync_success - AssertionError: {\u0027timing_since\u0027: [((\u0027swift_object_server_[94 chars]}})]} !\u003d defaultdict(\u003cclass \u0027list\u0027\u003e, {\u0027timing_sinc[143 chars]})]})\n```","commit_id":"1905922765fb712eeaffdda8d3cdb5ddcab66d99"}]}