)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"3f1353127ecafaeb459b2becdce2108d0ab40713","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Tim Burke \u003ctim.burke@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2025-06-02 13:20:04 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"s3token: Enable secret caching by default"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Ief0a29c4300edf2e0d52c041960d756ecc8a2677"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"70a0a1a8_072f5a96","line":7,"updated":"2025-08-20 04:46:35.000000000","message":"I should flesh out the \"why\" more here -- basically, enabling s3token without secret caching gives you a broken deployment. With hundreds of Swift proxies backed by thousands of object nodes, you can pretty easily get aggregate, sustained load on the order of 100k req/s; without the caching, all of those need to make a subrequest to Keystone, and no one provisions for that. Even if they did, I\u0027m not sure it\u0027d scale well.","commit_id":"97dc0ae89c211de8bd991276310bcd5a05664163"}],"swift/common/middleware/s3api/s3token.py":[{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"c8bb1d7dea78485545ec4f2a105fd40e5c43c624","unresolved":true,"context_lines":[{"line_number":178,"context_line":"            self._verify \u003d None"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"        self._secret_cache_duration \u003d int("},{"line_number":181,"context_line":"            conf.get(\u0027secret_cache_duration\u0027, 60))"},{"line_number":182,"context_line":"        if self._secret_cache_duration \u003c 0:"},{"line_number":183,"context_line":"            raise ValueError(\u0027secret_cache_duration must be non-negative\u0027)"},{"line_number":184,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"2bf82957_21360e21","line":181,"updated":"2025-11-06 10:15:10.000000000","message":"this is apparently untested?","commit_id":"5f89d14ebb6e6fed3b2ef507f8084fe7f05fc951"}]}