)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"a4d5be3839eb6dd918c20fda450b93c3a990a25e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"1ad44472_ca55a0a4","updated":"2025-06-05 21:45:31.000000000","message":"I think it\u0027s okay, although if you revise it, I\u0027d love\nan intent in the log message. My guess is that you want\nto see what was used for authentication (access_key is\nbasically a username). But ultimately... why?","commit_id":"3a2bfd98112ae8a0594114e9017c457e4942939c"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"2a05be3daf19fc55785e176e18ef8d8f46995cc4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"7fda0aa2_3ac35f50","updated":"2025-06-06 13:15:24.000000000","message":"probably better as it\u0027s own/optional new template field.","commit_id":"3a2bfd98112ae8a0594114e9017c457e4942939c"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"2a05be3daf19fc55785e176e18ef8d8f46995cc4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"4850d5fa_6afe4b42","in_reply_to":"1ad44472_ca55a0a4","updated":"2025-06-06 13:15:24.000000000","message":"\u003e I\u0027d love an intent in the log message\n\n100% commit could be better; and it needs tests.\n\n\u003e My guess is that you want to see what was used for authentication\n\nyeah that\u0027s a really good guess!  we have two different auth systems and we can tell which one was used based on the shape of the username...\n\n\u003e But ultimately... why?\n\nI think the *real* reason is *ultimately* I think it\u0027s an attempt to fulfill the role of the \"Requester\" field from https://docs.aws.amazon.com/AmazonS3/latest/userguide/LogFormat.html\n\n... although I\u0027m realizing there\u0027s a lot MORE fields we\u0027ll eventually have to enable/template for s3 stuff if we want proxy logging to be able to generate source material for s3-compatible-access-log-delivery\n\n... so it\u0027s not really that helpful to \"hi-jack\" auth_token.  Tim thinks a REMOTE_USER field could be better/more-generic - but i\u0027m not that enthused about updating ALL the auth mw.  And aws_access_key_id is already right there in the environment it turns out!  Specifically when auth_token is not!  So I was just being opportunistic.","commit_id":"3a2bfd98112ae8a0594114e9017c457e4942939c"}]}
