)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"10f37c2d6c322914c7c32306ed15eab427546eda","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If we already know enough about the error to feel confident in"},{"line_number":10,"context_line":"quarantining, we don\u0027t really need a whole traceback about it;"},{"line_number":11,"context_line":"that just clutters logs."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Iab0e62c85b33d699f96d744faaa16420b7148b47"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"c72df7ca_eab27ac4","line":11,"updated":"2025-07-30 23:04:07.000000000","message":"100%","commit_id":"a555a8593e192361f43f8e32172ee4887b9339bc"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"907cce45b7e2194b1cf152036b5aca05e5be42cf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"04319a63_9bfe21cd","updated":"2025-07-07 18:26:23.000000000","message":"Looks good to me, but let\u0027s have someone with an operator insight to land it.","commit_id":"a555a8593e192361f43f8e32172ee4887b9339bc"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"10f37c2d6c322914c7c32306ed15eab427546eda","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"d4a7836a_3717f364","updated":"2025-07-30 23:04:07.000000000","message":"this is the way","commit_id":"a555a8593e192361f43f8e32172ee4887b9339bc"}],"swift/obj/diskfile.py":[{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"10f37c2d6c322914c7c32306ed15eab427546eda","unresolved":true,"context_lines":[{"line_number":1223,"context_line":"                        orig_path \u003d hsh_path"},{"line_number":1224,"context_line":"                    except (OSError, IOError):"},{"line_number":1225,"context_line":"                        # We\u0027ve *also* seen the bad sectors lead to us needing"},{"line_number":1226,"context_line":"                        # to quarantine the whole suffix"},{"line_number":1227,"context_line":"                        quar_path \u003d quarantine_renamer(device_path, hsh_path)"},{"line_number":1228,"context_line":"                        orig_path \u003d path"},{"line_number":1229,"context_line":"                    logging.error("}],"source_content_type":"text/x-python","patch_set":2,"id":"4fe06724_69d37c12","line":1226,"updated":"2025-07-30 23:04:07.000000000","message":"heh, this part is funny and telling:\n\nshit broke, $%^\u0026ing filesystems amirite - hard drives fail; it\u0027s life; no one cares; %^\u0026ing deal with it and move on.","commit_id":"a555a8593e192361f43f8e32172ee4887b9339bc"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"10f37c2d6c322914c7c32306ed15eab427546eda","unresolved":true,"context_lines":[{"line_number":1229,"context_line":"                    logging.error("},{"line_number":1230,"context_line":"                        \u0027Quarantined %(orig_path)s to %(quar_path)s because \u0027"},{"line_number":1231,"context_line":"                        \u0027it could not be listed\u0027, {\u0027orig_path\u0027: orig_path,"},{"line_number":1232,"context_line":"                                                   \u0027quar_path\u0027: quar_path})"},{"line_number":1233,"context_line":"                    continue"},{"line_number":1234,"context_line":"                raise"},{"line_number":1235,"context_line":"            if not ondisk_info[\u0027files\u0027]:"}],"source_content_type":"text/x-python","patch_set":2,"id":"5948393b_180eabcd","line":1232,"updated":"2025-07-30 23:04:07.000000000","message":"I guess the original thinking was maybe something like \"we don\u0027t know *exactly* which os.syscall down in cleanup_ondiskf_files raised this OSError and there may still be some surprises in the stack somewhere?\" - but it turns out the reality is no one cares - just get it out of the way and move on.  If there\u0027s enough errors like this on a disk it\u0027s coming out of the cluster anyway, there\u0027s nothing for SRE or dev to DO or fix here.","commit_id":"a555a8593e192361f43f8e32172ee4887b9339bc"}]}