)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"e9d5526a9c050687cab2c328a74513bf173c6669","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"cb500352_3c93ae04","updated":"2025-08-21 08:10:14.000000000","message":"This looks better. I didn\u0027t think much further than making the error more \u0027helpful\u0027.\n\nI guess the test I added needs updating:\ntest.unit.common.utils.test_checksum.TestModuleFunctions testMethod\u003dtest_find_isal_pyeclib_dist_missing_files","commit_id":"c509ef13881fb3c24b5c1f2f9a8097b86612906a"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"58a4b381eda58f15c9a2fe1a3a4bb75d37a91b72","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"419db2c5_cfd16a76","updated":"2025-08-21 09:58:05.000000000","message":"test fix and more tests here https://review.opendev.org/c/openstack/swift/+/958162 - you may be able to improve! take what you like","commit_id":"c509ef13881fb3c24b5c1f2f9a8097b86612906a"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"89ad9ee7b70af64898c67da9f60d0ac548cbc59c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"62037d8f_f2af40cf","in_reply_to":"419db2c5_cfd16a76","updated":"2025-08-21 15:43:32.000000000","message":"LGTM, thanks! Yeah, clearly I neglected to actually run tests locally...","commit_id":"c509ef13881fb3c24b5c1f2f9a8097b86612906a"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"5e48ac2f4e70550fb6fe3b54087f40f1f09a1365","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"706217ee_eb285247","updated":"2025-08-21 18:25:10.000000000","message":"I\u0027m really glad this is a follow-up change.  I\u0027d really like to hear back from Myles if the RuntimeError helped him debug what was going on.  Was it something he needed to *fix*?  Or is this just a normal state we are confident we need to \"support\".\n\nI\u0027m worried this diff is more of just a convenient way to sweep the \"not our problem\" under the rug?  Which is ok too - as long as it doesn\u0027t make Myles job of fixing his pyeclib install harder.  Assuming... he *needed* to fix his pyeclib?\n\n    I\u0027m confused \u003d\u003e BLOW UP \n\n^ seems like a perfectly reasonable strategy.\n\n    I tried to be helpful, but I don\u0027t know what I\u0027m doing \u003d\u003e shrug and move on\n\n^ also seems reasonable - but maybe harder to maintain?  *I* don\u0027t know what\u0027s going on - and I\u0027m not sure that Tim, Al or Myles do either.  So... \n\nHappy to wait to merge this until we actually know what\u0027s wrong - or if this helps someone we can merge it now too I guess.","commit_id":"81df05a9c4702204a8347ab2ba43e7ff75c328aa"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"2c52dcae0ad6455265b0bb333d2e798732857b36","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"f7d69366_7eeb6bf7","updated":"2025-08-21 20:24:49.000000000","message":"Update!  It seems like this is just the normal way for ubuntu\u0027s pyeclib package to behave:\n\n```\nubuntu@ip-172-31-30-112:~$ python3\nPython 3.12.3 (main, Feb  4 2025, 14:48:35) [GCC 13.3.0] on linux\nType \"help\", \"copyright\", \"credits\" or \"license\" for more information.\n\u003e\u003e\u003e from importlib.metadata import files as pkg_files\n\u003e\u003e\u003e pkg_files(\u0027pyeclib\u0027)\n\u003e\u003e\u003e import pyeclib\n\u003e\u003e\u003e \n```\n\nafter `sudo apt-get install python3-pyeclib` on a fresh `DISTRIB_RELEASE\u003d24.04` - I can *import* pyeclib - but pkg_files returns None.\n\nFWIW I\u0027m not sure if this is a bug in debian packaging, or some limitation of importlib.metadata in the face of changes from PEP 668\n\n```\n\u003e\u003e\u003e pkg_files(\u0027bcrypt\u0027)\n\u003e\u003e\u003e pkg_files(\u0027boto3\u0027)\n\u003e\u003e\u003e pkg_files(\u0027jinja2\u0027)\n\u003e\u003e\u003e \nubuntu@ip-172-31-30-112:~$ dpkg -L python3-pyeclib\n/.\n/usr\n/usr/lib\n/usr/lib/python3\n/usr/lib/python3/dist-packages\n/usr/lib/python3/dist-packages/pyeclib\n/usr/lib/python3/dist-packages/pyeclib/__init__.py\n/usr/lib/python3/dist-packages/pyeclib/core.py\n/usr/lib/python3/dist-packages/pyeclib/ec_iface.py\n/usr/lib/python3/dist-packages/pyeclib/enum.py\n/usr/lib/python3/dist-packages/pyeclib/utils.py\n/usr/lib/python3/dist-packages/pyeclib-1.6.0.egg-info\n/usr/lib/python3/dist-packages/pyeclib-1.6.0.egg-info/PKG-INFO\n/usr/lib/python3/dist-packages/pyeclib-1.6.0.egg-info/dependency_links.txt\n/usr/lib/python3/dist-packages/pyeclib-1.6.0.egg-info/top_level.txt\n/usr/lib/python3/dist-packages/pyeclib_c.cpython-312-x86_64-linux-gnu.so\n/usr/share\n/usr/share/doc\n/usr/share/doc/python3-pyeclib\n/usr/share/doc/python3-pyeclib/changelog.Debian.gz\n/usr/share/doc/python3-pyeclib/copyright\n```\n\n... but \"ubuntu system installed pyeclib\" is definitely something we want to support so the RuntimeError is a bug!  Thanks for helping me understand why we\u0027re doing this Tim!","commit_id":"81df05a9c4702204a8347ab2ba43e7ff75c328aa"}]}
