)]}'
{"swift/obj/updater.py":[{"author":{"_account_id":1216,"name":"gholt","email":"z-launchpad@brim.net","username":"gholt"},"change_message_id":"9a3d06e7afed8e7802ca262184d9f41c0eb1dbb5","unresolved":false,"context_lines":[{"line_number":189,"context_line":"            return"},{"line_number":190,"context_line":"        successes \u003d update.get(\u0027successes\u0027, [])"},{"line_number":191,"context_line":"        container_ring \u003d self.get_container_ring()"},{"line_number":192,"context_line":"        part, nodes \u003d container_ring.get_nodes("},{"line_number":193,"context_line":"            update[\u0027account\u0027], update[\u0027container\u0027])"},{"line_number":194,"context_line":"        obj \u003d \u0027/%s/%s/%s\u0027 % \\"},{"line_number":195,"context_line":"              (update[\u0027account\u0027], update[\u0027container\u0027], update[\u0027obj\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"3ae8d1ca_133137a2","line":192,"updated":"2014-05-29 15:03:40.000000000","message":"Not that it really matters, but why this change? Or just a leftover from some previous work?","commit_id":"d05fda48d2c98f5eb50de87c73ef142966b4e335"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"af4d29ab8a43ea6134065c4ac9bdcebf92af68ff","unresolved":false,"context_lines":[{"line_number":189,"context_line":"            return"},{"line_number":190,"context_line":"        successes \u003d update.get(\u0027successes\u0027, [])"},{"line_number":191,"context_line":"        container_ring \u003d self.get_container_ring()"},{"line_number":192,"context_line":"        part, nodes \u003d container_ring.get_nodes("},{"line_number":193,"context_line":"            update[\u0027account\u0027], update[\u0027container\u0027])"},{"line_number":194,"context_line":"        obj \u003d \u0027/%s/%s/%s\u0027 % \\"},{"line_number":195,"context_line":"              (update[\u0027account\u0027], update[\u0027container\u0027], update[\u0027obj\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"3ae8d1ca_def26f6e","line":192,"in_reply_to":"3ae8d1ca_133137a2","updated":"2014-05-29 18:40:17.000000000","message":"must be left over, maybe I was doing something later in the method where I wanted the ref to the container_ring in hand?  might have even just been from debugging... I don\u0027t really know if there\u0027s any reason to have it in a function really?  Since you commented on it - I guess I\u0027ll pull it out of the diff.\n\nDone.","commit_id":"d05fda48d2c98f5eb50de87c73ef142966b4e335"}],"test/unit/__init__.py":[{"author":{"_account_id":1216,"name":"gholt","email":"z-launchpad@brim.net","username":"gholt"},"change_message_id":"9a3d06e7afed8e7802ca262184d9f41c0eb1dbb5","unresolved":false,"context_lines":[{"line_number":114,"context_line":"        storage_policy._POLICIES \u003d self._orig_POLICIES"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"class FakeRing(Ring):"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"    def __init__(self, replicas\u003d3, max_more_nodes\u003d0, part_power\u003d0):"},{"line_number":120,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"3ae8d1ca_d3726f48","line":117,"updated":"2014-05-29 15:03:40.000000000","message":"No criticism here; just wanted to give a big thumbs up to this better testing. :D","commit_id":"d05fda48d2c98f5eb50de87c73ef142966b4e335"},{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"95f126f9bf3d1d973cb28ce510cbb8a1f4e6e5cd","unresolved":false,"context_lines":[{"line_number":133,"context_line":"        # this is set higher, or R^2 for R replicas"},{"line_number":134,"context_line":"        self.set_replicas(replicas)"},{"line_number":135,"context_line":"        self.max_more_nodes \u003d max_more_nodes"},{"line_number":136,"context_line":"        self.part_power \u003d part_power"},{"line_number":137,"context_line":"        self._part_shift \u003d 32 - part_power"},{"line_number":138,"context_line":"        self._reload()"},{"line_number":139,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"1ae5cdf2_c0fffba8","line":136,"updated":"2014-06-02 20:47:01.000000000","message":"self.part_power is unused anywhere, right? Not used by parent class Ring seemingly.","commit_id":"13c41a44638e4b35bbfa198699792f010a01efa3"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"9813c3e01780d00fb2a8e1c89e27208b2fe007fb","unresolved":false,"context_lines":[{"line_number":133,"context_line":"        # this is set higher, or R^2 for R replicas"},{"line_number":134,"context_line":"        self.set_replicas(replicas)"},{"line_number":135,"context_line":"        self.max_more_nodes \u003d max_more_nodes"},{"line_number":136,"context_line":"        self.part_power \u003d part_power"},{"line_number":137,"context_line":"        self._part_shift \u003d 32 - part_power"},{"line_number":138,"context_line":"        self._reload()"},{"line_number":139,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"1ae5cdf2_99dc8a14","line":136,"in_reply_to":"1ae5cdf2_c0fffba8","updated":"2014-06-02 22:51:24.000000000","message":"Done","commit_id":"13c41a44638e4b35bbfa198699792f010a01efa3"},{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"95f126f9bf3d1d973cb28ce510cbb8a1f4e6e5cd","unresolved":false,"context_lines":[{"line_number":157,"context_line":"    def set_replicas(self, replicas):"},{"line_number":158,"context_line":"        self.replicas \u003d replicas"},{"line_number":159,"context_line":"        self._devs \u003d []"},{"line_number":160,"context_line":"        for x in xrange(self.replicas):"},{"line_number":161,"context_line":"            ip \u003d \u002710.0.0.%s\u0027 % x"},{"line_number":162,"context_line":"            port \u003d 1000 + x"},{"line_number":163,"context_line":"            self._devs.append({"}],"source_content_type":"text/x-python","patch_set":5,"id":"1ae5cdf2_cc0497c2","line":160,"updated":"2014-06-02 20:47:01.000000000","message":"Next Alex comes and changes xrange to range because py3","commit_id":"13c41a44638e4b35bbfa198699792f010a01efa3"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"9813c3e01780d00fb2a8e1c89e27208b2fe007fb","unresolved":false,"context_lines":[{"line_number":157,"context_line":"    def set_replicas(self, replicas):"},{"line_number":158,"context_line":"        self.replicas \u003d replicas"},{"line_number":159,"context_line":"        self._devs \u003d []"},{"line_number":160,"context_line":"        for x in xrange(self.replicas):"},{"line_number":161,"context_line":"            ip \u003d \u002710.0.0.%s\u0027 % x"},{"line_number":162,"context_line":"            port \u003d 1000 + x"},{"line_number":163,"context_line":"            self._devs.append({"}],"source_content_type":"text/x-python","patch_set":5,"id":"1ae5cdf2_d905327b","line":160,"in_reply_to":"1ae5cdf2_cc0497c2","updated":"2014-06-02 22:51:24.000000000","message":"Done","commit_id":"13c41a44638e4b35bbfa198699792f010a01efa3"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"b02cf165facc738a43b0b4b072783e1cd17b649d","unresolved":false,"context_lines":[{"line_number":126,"context_line":"        :param part_power: make part calculation based on the path"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"        If you set a part_power when you setup your FakeRing the parts you get"},{"line_number":129,"context_line":"        out of ring methods will acctually be based on the path - otherwise we"},{"line_number":130,"context_line":"        exercise the real ring code, but ignore the result and return 1."},{"line_number":131,"context_line":"        \"\"\""},{"line_number":132,"context_line":"        # 9 total nodes (6 more past the initial 3) is the cap, no matter if"}],"source_content_type":"text/x-python","patch_set":8,"id":"1ae5cdf2_dd8c7082","line":129,"updated":"2014-06-09 19:27:58.000000000","message":"nit s/acctually/actually/","commit_id":"44e766f0c93c1ad3982ba249ae5d119c83f65c7f"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"57b49fb036cf0a498e9209a729f141223814afc5","unresolved":false,"context_lines":[{"line_number":126,"context_line":"        :param part_power: make part calculation based on the path"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"        If you set a part_power when you setup your FakeRing the parts you get"},{"line_number":129,"context_line":"        out of ring methods will acctually be based on the path - otherwise we"},{"line_number":130,"context_line":"        exercise the real ring code, but ignore the result and return 1."},{"line_number":131,"context_line":"        \"\"\""},{"line_number":132,"context_line":"        # 9 total nodes (6 more past the initial 3) is the cap, no matter if"}],"source_content_type":"text/x-python","patch_set":8,"id":"1ae5cdf2_731b8880","line":129,"in_reply_to":"1ae5cdf2_dd8c7082","updated":"2014-06-09 19:34:41.000000000","message":"Done","commit_id":"44e766f0c93c1ad3982ba249ae5d119c83f65c7f"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"b02cf165facc738a43b0b4b072783e1cd17b649d","unresolved":false,"context_lines":[{"line_number":137,"context_line":"        self._reload()"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"    def get_part(self, *args, **kwargs):"},{"line_number":140,"context_line":"        real_part \u003d super(FakeRing, self).get_part(*args, **kwargs)"},{"line_number":141,"context_line":"        if self._part_shift \u003d\u003d 32:"},{"line_number":142,"context_line":"            return 1"},{"line_number":143,"context_line":"        return real_part"}],"source_content_type":"text/x-python","patch_set":8,"id":"1ae5cdf2_10f31f74","line":140,"updated":"2014-06-09 19:27:58.000000000","message":"just curiosity  - why call this if part_shift isn\u0027t set - is it just to provoke any exceptions?","commit_id":"44e766f0c93c1ad3982ba249ae5d119c83f65c7f"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"57b49fb036cf0a498e9209a729f141223814afc5","unresolved":false,"context_lines":[{"line_number":137,"context_line":"        self._reload()"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"    def get_part(self, *args, **kwargs):"},{"line_number":140,"context_line":"        real_part \u003d super(FakeRing, self).get_part(*args, **kwargs)"},{"line_number":141,"context_line":"        if self._part_shift \u003d\u003d 32:"},{"line_number":142,"context_line":"            return 1"},{"line_number":143,"context_line":"        return real_part"}],"source_content_type":"text/x-python","patch_set":8,"id":"1ae5cdf2_9312d460","line":140,"in_reply_to":"1ae5cdf2_10f31f74","updated":"2014-06-09 19:34:41.000000000","message":"100% correct - good intuition","commit_id":"44e766f0c93c1ad3982ba249ae5d119c83f65c7f"},{"author":{"_account_id":6198,"name":"Peter Portante","email":"peter.a.portante@gmail.com","username":"peter-a-portante"},"change_message_id":"bf3f24752f5aca41279daad278fd53ab20db9a42","unresolved":false,"context_lines":[{"line_number":741,"context_line":""},{"line_number":742,"context_line":""},{"line_number":743,"context_line":"@contextmanager"},{"line_number":744,"context_line":"def mocked_http_conn(*args, **kwargs):"},{"line_number":745,"context_line":"    fake_conn \u003d fake_http_connect(*args, **kwargs)"},{"line_number":746,"context_line":"    with mocklib.patch(\u0027swift.common.bufferedhttp.http_connect_raw\u0027,"},{"line_number":747,"context_line":"                       new\u003dfake_conn):"}],"source_content_type":"text/x-python","patch_set":11,"id":"1ae5cdf2_a1d15131","line":744,"updated":"2014-06-16 20:29:21.000000000","message":"While this is used in subsequent patch sets, it does not appear to be referenced here.","commit_id":"09fb8458f954bf310ecb3760a7d5489d48c1062d"}]}
