)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"55e51c7b99db43c73455ac946b503ec5bdeccc10","unresolved":false,"context_lines":[{"line_number":25,"context_line":"moving large amounts of object data around.  Thus, if it is desired to"},{"line_number":26,"context_line":"change the policy for data in a container, the supported method would"},{"line_number":27,"context_line":"be to create a new container with the desired policy and move the data"},{"line_number":28,"context_line":"over."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"This commit does not address replicators, auditors, or updaters except"},{"line_number":31,"context_line":"where method signatures changed. They\u0027ll still work if your cluster"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"1ae5cdf2_235b4988","line":28,"updated":"2014-06-10 17:32:50.000000000","message":"^^  not sure this para belongs here, looks similar to message for patch below in chain","commit_id":"cb1737866d8fb16fa08166dc671f17e4eb6360d1"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"a9252ed482f27214aea59f03d186ed151b1d8278","unresolved":false,"context_lines":[{"line_number":25,"context_line":"moving large amounts of object data around.  Thus, if it is desired to"},{"line_number":26,"context_line":"change the policy for data in a container, the supported method would"},{"line_number":27,"context_line":"be to create a new container with the desired policy and move the data"},{"line_number":28,"context_line":"over."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"This commit does not address replicators, auditors, or updaters except"},{"line_number":31,"context_line":"where method signatures changed. They\u0027ll still work if your cluster"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"1ae5cdf2_e51dca63","line":28,"in_reply_to":"1ae5cdf2_235b4988","updated":"2014-06-11 08:11:21.000000000","message":"Done","commit_id":"cb1737866d8fb16fa08166dc671f17e4eb6360d1"}],"swift/common/request_helpers.py":[{"author":{"_account_id":917,"name":"Chuck Thier","email":"cthier@gmail.com","username":"cthier"},"change_message_id":"7e8b2c44168e6c63df2053bd1121b97d49e4878d","unresolved":false,"context_lines":[{"line_number":79,"context_line":"    return out_content_type"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"def get_name_and_placement(request, *args):"},{"line_number":83,"context_line":"    policy_idx \u003d request.headers.get(POLICY_INDEX, \u00270\u0027)"},{"line_number":84,"context_line":"    try:"},{"line_number":85,"context_line":"        policy_idx \u003d int(policy_idx)"}],"source_content_type":"text/x-python","patch_set":5,"id":"1ae5cdf2_99f20f99","line":82,"updated":"2014-05-30 18:48:08.000000000","message":"Like in other reviews, I\u0027m not a fan of the *args style in passing args like this.  It looks like all the calls to this are the same, so why not be explicit and put the actual args there?","commit_id":"c3038b30255c927e7df23579567c9190bef0fd7d"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"c7723c3ba494940156cddafe143ebed3341175b8","unresolved":false,"context_lines":[{"line_number":79,"context_line":"    return out_content_type"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"def get_name_and_placement(request, *args):"},{"line_number":83,"context_line":"    policy_idx \u003d request.headers.get(POLICY_INDEX, \u00270\u0027)"},{"line_number":84,"context_line":"    try:"},{"line_number":85,"context_line":"        policy_idx \u003d int(policy_idx)"}],"source_content_type":"text/x-python","patch_set":5,"id":"1ae5cdf2_5279392e","line":82,"in_reply_to":"1ae5cdf2_99f20f99","updated":"2014-05-30 22:18:01.000000000","message":"Because those args aren\u0027t for this method, they\u0027re for split_and_validate_path.","commit_id":"c3038b30255c927e7df23579567c9190bef0fd7d"},{"author":{"_account_id":6968,"name":"Christian Schwede","email":"cschwede@nvidia.com","username":"cschwede"},"change_message_id":"02f9123a4cbcd77432a774a395f7a46bda8ed776","unresolved":false,"context_lines":[{"line_number":86,"context_line":"    except ValueError:"},{"line_number":87,"context_line":"        results \u003d HTTPBadRequest("},{"line_number":88,"context_line":"            \"Policy index must be numeric (was %s)\""},{"line_number":89,"context_line":"            % policy_idx)"},{"line_number":90,"context_line":"    results \u003d split_and_validate_path(request, *args)"},{"line_number":91,"context_line":"    results.append(policy_idx)"},{"line_number":92,"context_line":"    return results"}],"source_content_type":"text/x-python","patch_set":6,"id":"1ae5cdf2_1fc07e7b","line":89,"updated":"2014-06-02 02:12:47.000000000","message":"Is this try..except really required? POLICY_INDEX is not user-accessible, thus int(policy_idx) should never raise a ValueError exception?\n\nOn the other side, if we don\u0027t trust POLICY_INDEX we might need an additional check if this is an positive integer?","commit_id":"5a1723030736563b9c6726a9dd020dd2a7c452bc"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"80d9b4474784b8da8e6bc9fe2f7b89461e1a7b16","unresolved":false,"context_lines":[{"line_number":86,"context_line":"    except ValueError:"},{"line_number":87,"context_line":"        results \u003d HTTPBadRequest("},{"line_number":88,"context_line":"            \"Policy index must be numeric (was %s)\""},{"line_number":89,"context_line":"            % policy_idx)"},{"line_number":90,"context_line":"    results \u003d split_and_validate_path(request, *args)"},{"line_number":91,"context_line":"    results.append(policy_idx)"},{"line_number":92,"context_line":"    return results"}],"source_content_type":"text/x-python","patch_set":6,"id":"1ae5cdf2_b8b06e8c","line":89,"in_reply_to":"1ae5cdf2_1fc07e7b","updated":"2014-06-02 19:18:22.000000000","message":"Done","commit_id":"5a1723030736563b9c6726a9dd020dd2a7c452bc"},{"author":{"_account_id":1216,"name":"gholt","email":"z-launchpad@brim.net","username":"gholt"},"change_message_id":"cf4df26fc34bce2507e5ea3bc6a190f7b6c54e0d","unresolved":false,"context_lines":[{"line_number":88,"context_line":"    args are passed through to :meth:`split_and_validate_path`."},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    :returns: storage_policy_index and result of"},{"line_number":91,"context_line":"              :meth:`split_and_validate_path`"},{"line_number":92,"context_line":"    :raises: HTTPBadRequest if something\u0027s not okay"},{"line_number":93,"context_line":"    \"\"\""},{"line_number":94,"context_line":"    policy_idx \u003d request.headers.get(POLICY_INDEX, \u00270\u0027)"}],"source_content_type":"text/x-python","patch_set":10,"id":"1ae5cdf2_37288832","line":91,"updated":"2014-06-12 19:29:48.000000000","message":"This is a misleading docstring since it returns [*result_of_split_and_validate_path, storage_policy_index] and not the opposite. If you fix this, might just remove the \"if something\u0027s not okay\" on the next line since it\u0027s not horribly helpful. ;)","commit_id":"b2019aba548858cc4f1a064136f689df8a0a7be3"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"357e823a73294450ca0c647032ae09db1cb4b97b","unresolved":false,"context_lines":[{"line_number":88,"context_line":"    args are passed through to :meth:`split_and_validate_path`."},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    :returns: storage_policy_index and result of"},{"line_number":91,"context_line":"              :meth:`split_and_validate_path`"},{"line_number":92,"context_line":"    :raises: HTTPBadRequest if something\u0027s not okay"},{"line_number":93,"context_line":"    \"\"\""},{"line_number":94,"context_line":"    policy_idx \u003d request.headers.get(POLICY_INDEX, \u00270\u0027)"}],"source_content_type":"text/x-python","patch_set":10,"id":"1ae5cdf2_85920155","line":91,"in_reply_to":"1ae5cdf2_37288832","updated":"2014-06-12 22:51:00.000000000","message":"lol, copied from split_and_validate_path\u0027s doc string :)\n\nDone.","commit_id":"b2019aba548858cc4f1a064136f689df8a0a7be3"}],"swift/obj/diskfile.py":[{"author":{"_account_id":9625,"name":"Thiago da Silva","email":"thiagodasilva@gmail.com","username":"thiago"},"change_message_id":"721ef251de7a4386a51a17a6d0fbd01ff7be86ce","unresolved":false,"context_lines":[{"line_number":71,"context_line":"DATADIR_BASE \u003d \u0027objects\u0027"},{"line_number":72,"context_line":"ASYNCDIR_BASE \u003d \u0027async_pending\u0027"},{"line_number":73,"context_line":"get_data_dir \u003d partial(get_policy_string, DATADIR_BASE)"},{"line_number":74,"context_line":"get_async_dir \u003d partial(get_policy_string, ASYNCDIR_BASE)"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"def read_metadata(fd):"}],"source_content_type":"text/x-python","patch_set":6,"id":"1ae5cdf2_760fcd2e","line":74,"updated":"2014-06-02 22:03:54.000000000","message":"where is get_async_dir used?","commit_id":"5a1723030736563b9c6726a9dd020dd2a7c452bc"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"b27f147798f41e97baa7ff636b1edcacd94f3984","unresolved":false,"context_lines":[{"line_number":71,"context_line":"DATADIR_BASE \u003d \u0027objects\u0027"},{"line_number":72,"context_line":"ASYNCDIR_BASE \u003d \u0027async_pending\u0027"},{"line_number":73,"context_line":"get_data_dir \u003d partial(get_policy_string, DATADIR_BASE)"},{"line_number":74,"context_line":"get_async_dir \u003d partial(get_policy_string, ASYNCDIR_BASE)"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"def read_metadata(fd):"}],"source_content_type":"text/x-python","patch_set":6,"id":"1ae5cdf2_793b3e38","line":74,"in_reply_to":"1ae5cdf2_760fcd2e","updated":"2014-06-02 22:56:31.000000000","message":"pickle_async_update - shows up in Object Updates","commit_id":"5a1723030736563b9c6726a9dd020dd2a7c452bc"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"55e51c7b99db43c73455ac946b503ec5bdeccc10","unresolved":false,"context_lines":[{"line_number":137,"context_line":"    if \u0027-\u0027 in obj_dirname:"},{"line_number":138,"context_line":"        base, policy_idx \u003d obj_dirname.split(\u0027-\u0027, 1)"},{"line_number":139,"context_line":"        if POLICIES.get_by_index(policy_idx) is None:"},{"line_number":140,"context_line":"            policy_idx \u003d 0"},{"line_number":141,"context_line":"    return int(policy_idx)"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"1ae5cdf2_2f5968fe","line":140,"updated":"2014-06-10 17:32:50.000000000","message":"why revert to 0 here?","commit_id":"cb1737866d8fb16fa08166dc671f17e4eb6360d1"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"4a4f1e39bb763398c091b684f5e492d25cfbe5b5","unresolved":false,"context_lines":[{"line_number":137,"context_line":"    if \u0027-\u0027 in obj_dirname:"},{"line_number":138,"context_line":"        base, policy_idx \u003d obj_dirname.split(\u0027-\u0027, 1)"},{"line_number":139,"context_line":"        if POLICIES.get_by_index(policy_idx) is None:"},{"line_number":140,"context_line":"            policy_idx \u003d 0"},{"line_number":141,"context_line":"    return int(policy_idx)"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"1ae5cdf2_5987a7b6","line":140,"in_reply_to":"1ae5cdf2_2597b291","updated":"2014-06-16 18:14:14.000000000","message":"I guess I was querying the case when the path is NOT mangled, but refers to a now-deleted policy section. So swift_object_info just won\u0027t work on that object \u0027cos the policy index will be forced to 0.\n\nNot a blocker though.","commit_id":"cb1737866d8fb16fa08166dc671f17e4eb6360d1"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"a9252ed482f27214aea59f03d186ed151b1d8278","unresolved":false,"context_lines":[{"line_number":137,"context_line":"    if \u0027-\u0027 in obj_dirname:"},{"line_number":138,"context_line":"        base, policy_idx \u003d obj_dirname.split(\u0027-\u0027, 1)"},{"line_number":139,"context_line":"        if POLICIES.get_by_index(policy_idx) is None:"},{"line_number":140,"context_line":"            policy_idx \u003d 0"},{"line_number":141,"context_line":"    return int(policy_idx)"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"1ae5cdf2_2597b291","line":140,"in_reply_to":"1ae5cdf2_2f5968fe","updated":"2014-06-11 08:11:21.000000000","message":"it\u0027s probably just the only one we know we\u0027ve got, it\u0027s also legacy, and the resulting path doesn\u0027t include a policy_index - which sorta matches the mess we\u0027re in.  I think you could make a case that if the path is mangled enough you should try to write into an separate object quarantine path altogether - but that\u0027s not what was written.  This part is fairly new, added during the review cycle, I\u0027m not sure anyone has had too much time to think about it - or that there\u0027s a large concern it will happen enough to be a confusing problem.","commit_id":"cb1737866d8fb16fa08166dc671f17e4eb6360d1"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"55e51c7b99db43c73455ac946b503ec5bdeccc10","unresolved":false,"context_lines":[{"line_number":975,"context_line":"    :param container: container name for the object"},{"line_number":976,"context_line":"    :param obj: object name for the object"},{"line_number":977,"context_line":"    :param _datadir: override the full datadir otherwise constructed here"},{"line_number":978,"context_line":"    :param policy_idx: used to get the data dir when contructing it here"},{"line_number":979,"context_line":"    \"\"\""},{"line_number":980,"context_line":""},{"line_number":981,"context_line":"    def __init__(self, mgr, device_path, threadpool, partition,"}],"source_content_type":"text/x-python","patch_set":9,"id":"1ae5cdf2_af9f385e","line":978,"updated":"2014-06-10 17:32:50.000000000","message":"nit: s/contructing/constructing/","commit_id":"cb1737866d8fb16fa08166dc671f17e4eb6360d1"}],"swift/proxy/controllers/base.py":[{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"55e51c7b99db43c73455ac946b503ec5bdeccc10","unresolved":false,"context_lines":[{"line_number":156,"context_line":"    headers, meta, sysmeta \u003d _prep_headers_to_info(headers, \u0027container\u0027)"},{"line_number":157,"context_line":"    # assure we have a policy 0 set when the policy header doesn\u0027t exist"},{"line_number":158,"context_line":"    if headers.get(POLICY_INDEX.lower()) is None:"},{"line_number":159,"context_line":"        headers[POLICY_INDEX.lower()] \u003d \u00270\u0027"},{"line_number":160,"context_line":"    return {"},{"line_number":161,"context_line":"        \u0027status\u0027: status_int,"},{"line_number":162,"context_line":"        \u0027read_acl\u0027: headers.get(\u0027x-container-read\u0027),"}],"source_content_type":"text/x-python","patch_set":9,"id":"1ae5cdf2_d60501c3","line":159,"updated":"2014-06-10 17:32:50.000000000","message":"nit: could just add default arg at line 168\n\n  \u0027storage_policy\u0027: headers.get(POLICY_INDEX.lower(), 0)","commit_id":"cb1737866d8fb16fa08166dc671f17e4eb6360d1"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"a9252ed482f27214aea59f03d186ed151b1d8278","unresolved":false,"context_lines":[{"line_number":156,"context_line":"    headers, meta, sysmeta \u003d _prep_headers_to_info(headers, \u0027container\u0027)"},{"line_number":157,"context_line":"    # assure we have a policy 0 set when the policy header doesn\u0027t exist"},{"line_number":158,"context_line":"    if headers.get(POLICY_INDEX.lower()) is None:"},{"line_number":159,"context_line":"        headers[POLICY_INDEX.lower()] \u003d \u00270\u0027"},{"line_number":160,"context_line":"    return {"},{"line_number":161,"context_line":"        \u0027status\u0027: status_int,"},{"line_number":162,"context_line":"        \u0027read_acl\u0027: headers.get(\u0027x-container-read\u0027),"}],"source_content_type":"text/x-python","patch_set":9,"id":"1ae5cdf2_05cd56b7","line":159,"in_reply_to":"1ae5cdf2_d60501c3","updated":"2014-06-11 08:11:21.000000000","message":"Done","commit_id":"cb1737866d8fb16fa08166dc671f17e4eb6360d1"}],"swift/proxy/controllers/obj.py":[{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"55e51c7b99db43c73455ac946b503ec5bdeccc10","unresolved":false,"context_lines":[{"line_number":196,"context_line":"            self.account_name, self.container_name, req)"},{"line_number":197,"context_line":"        req.acl \u003d container_info[\u0027read_acl\u0027]"},{"line_number":198,"context_line":"        policy_idx \u003d container_info[\u0027storage_policy\u0027]"},{"line_number":199,"context_line":"        obj_ring \u003d self.app.get_object_ring(policy_idx)"},{"line_number":200,"context_line":"        # pass the policy index to storage nodes via req header"},{"line_number":201,"context_line":"        req.headers[POLICY_INDEX] \u003d policy_idx"},{"line_number":202,"context_line":"        if \u0027swift.authorize\u0027 in req.environ:"}],"source_content_type":"text/x-python","patch_set":9,"id":"1ae5cdf2_f42675b9","line":199,"updated":"2014-06-10 17:32:50.000000000","message":"This generates a 500 if I delete the policy section, which I know I shouldn\u0027t do... But it seems that if we have the policy index then (in theory) we shouldn\u0027t need the policy conf section to handle object requests - the ring file name is deterministic so as long as the ring hasn\u0027t been deleted we ought to be able to load the ring and carry on?\n\nHaving said that, I think it could wait for a follow on patch.","commit_id":"cb1737866d8fb16fa08166dc671f17e4eb6360d1"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"a9252ed482f27214aea59f03d186ed151b1d8278","unresolved":false,"context_lines":[{"line_number":196,"context_line":"            self.account_name, self.container_name, req)"},{"line_number":197,"context_line":"        req.acl \u003d container_info[\u0027read_acl\u0027]"},{"line_number":198,"context_line":"        policy_idx \u003d container_info[\u0027storage_policy\u0027]"},{"line_number":199,"context_line":"        obj_ring \u003d self.app.get_object_ring(policy_idx)"},{"line_number":200,"context_line":"        # pass the policy index to storage nodes via req header"},{"line_number":201,"context_line":"        req.headers[POLICY_INDEX] \u003d policy_idx"},{"line_number":202,"context_line":"        if \u0027swift.authorize\u0027 in req.environ:"}],"source_content_type":"text/x-python","patch_set":9,"id":"1ae5cdf2_e555cac2","line":199,"in_reply_to":"1ae5cdf2_f42675b9","updated":"2014-06-11 08:11:21.000000000","message":"interesting, i\u0027ll think about that one.","commit_id":"cb1737866d8fb16fa08166dc671f17e4eb6360d1"}],"swift/proxy/server.py":[{"author":{"_account_id":5600,"name":"Brian Cline","email":"bcline@softlayer.com","username":"briancline"},"change_message_id":"3971628730d5723a9ef210e81cadda821b133ea8","unresolved":false,"context_lines":[{"line_number":103,"context_line":"                                                     ring_name\u003d\u0027container\u0027)"},{"line_number":104,"context_line":"        self.account_ring \u003d account_ring or Ring(swift_dir,"},{"line_number":105,"context_line":"                                                 ring_name\u003d\u0027account\u0027)"},{"line_number":106,"context_line":"        # ensure rings are loaded for all configrued storage policies"},{"line_number":107,"context_line":"        for policy in POLICIES:"},{"line_number":108,"context_line":"            policy.load_ring(swift_dir)"},{"line_number":109,"context_line":"        self.memcache \u003d memcache"}],"source_content_type":"text/x-python","patch_set":7,"id":"1ae5cdf2_a2ac538d","line":106,"updated":"2014-06-05 06:57:56.000000000","message":"s/configrued/configured/ :)","commit_id":"27d1fbe484a871dca775ea4fb98335d29b19492c"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"ae9c21d9199fa91ea880ed02a16fc3d15b6dbcc6","unresolved":false,"context_lines":[{"line_number":103,"context_line":"                                                     ring_name\u003d\u0027container\u0027)"},{"line_number":104,"context_line":"        self.account_ring \u003d account_ring or Ring(swift_dir,"},{"line_number":105,"context_line":"                                                 ring_name\u003d\u0027account\u0027)"},{"line_number":106,"context_line":"        # ensure rings are loaded for all configrued storage policies"},{"line_number":107,"context_line":"        for policy in POLICIES:"},{"line_number":108,"context_line":"            policy.load_ring(swift_dir)"},{"line_number":109,"context_line":"        self.memcache \u003d memcache"}],"source_content_type":"text/x-python","patch_set":7,"id":"1ae5cdf2_0067bf26","line":106,"in_reply_to":"1ae5cdf2_a2ac538d","updated":"2014-06-05 08:21:37.000000000","message":"Done","commit_id":"27d1fbe484a871dca775ea4fb98335d29b19492c"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"55e51c7b99db43c73455ac946b503ec5bdeccc10","unresolved":false,"context_lines":[{"line_number":226,"context_line":"        \"\"\""},{"line_number":227,"context_line":"        Get the ring object to use to handle a request based on its policy."},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"        :policy_idx: policy index as defined in swift.conf"},{"line_number":230,"context_line":"        :returns: appropriate ring object"},{"line_number":231,"context_line":"        \"\"\""},{"line_number":232,"context_line":"        return POLICIES.get_object_ring(policy_idx, self.swift_dir)"}],"source_content_type":"text/x-python","patch_set":9,"id":"1ae5cdf2_e5519cd9","line":229,"updated":"2014-06-10 17:32:50.000000000","message":"nit: :param policy_idx:","commit_id":"cb1737866d8fb16fa08166dc671f17e4eb6360d1"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"a9252ed482f27214aea59f03d186ed151b1d8278","unresolved":false,"context_lines":[{"line_number":226,"context_line":"        \"\"\""},{"line_number":227,"context_line":"        Get the ring object to use to handle a request based on its policy."},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"        :policy_idx: policy index as defined in swift.conf"},{"line_number":230,"context_line":"        :returns: appropriate ring object"},{"line_number":231,"context_line":"        \"\"\""},{"line_number":232,"context_line":"        return POLICIES.get_object_ring(policy_idx, self.swift_dir)"}],"source_content_type":"text/x-python","patch_set":9,"id":"1ae5cdf2_e50ceaee","line":229,"in_reply_to":"1ae5cdf2_e5519cd9","updated":"2014-06-11 08:11:21.000000000","message":"Done","commit_id":"cb1737866d8fb16fa08166dc671f17e4eb6360d1"}],"test/unit/proxy/test_server.py":[{"author":{"_account_id":5600,"name":"Brian Cline","email":"bcline@softlayer.com","username":"briancline"},"change_message_id":"3971628730d5723a9ef210e81cadda821b133ea8","unresolved":false,"context_lines":[{"line_number":560,"context_line":"            StoragePolicy(1, \u0027b\u0027, True, object_ring\u003d456),"},{"line_number":561,"context_line":"            StoragePolicy(2, \u0027d\u0027, False, object_ring\u003d789)"},{"line_number":562,"context_line":"        ]):"},{"line_number":563,"context_line":"            #None means legacy so always use policy 0"},{"line_number":564,"context_line":"            ring \u003d baseapp.get_object_ring(None)"},{"line_number":565,"context_line":"            self.assertEqual(ring, 123)"},{"line_number":566,"context_line":"            ring \u003d baseapp.get_object_ring(\u0027\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"1ae5cdf2_2235a345","line":563,"updated":"2014-06-05 06:57:56.000000000","message":"flake8 ought to be griping about a space after the #","commit_id":"27d1fbe484a871dca775ea4fb98335d29b19492c"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"ae9c21d9199fa91ea880ed02a16fc3d15b6dbcc6","unresolved":false,"context_lines":[{"line_number":560,"context_line":"            StoragePolicy(1, \u0027b\u0027, True, object_ring\u003d456),"},{"line_number":561,"context_line":"            StoragePolicy(2, \u0027d\u0027, False, object_ring\u003d789)"},{"line_number":562,"context_line":"        ]):"},{"line_number":563,"context_line":"            #None means legacy so always use policy 0"},{"line_number":564,"context_line":"            ring \u003d baseapp.get_object_ring(None)"},{"line_number":565,"context_line":"            self.assertEqual(ring, 123)"},{"line_number":566,"context_line":"            ring \u003d baseapp.get_object_ring(\u0027\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"1ae5cdf2_20511b36","line":563,"in_reply_to":"1ae5cdf2_2235a345","updated":"2014-06-05 08:21:37.000000000","message":"Done","commit_id":"27d1fbe484a871dca775ea4fb98335d29b19492c"},{"author":{"_account_id":5600,"name":"Brian Cline","email":"bcline@softlayer.com","username":"briancline"},"change_message_id":"3971628730d5723a9ef210e81cadda821b133ea8","unresolved":false,"context_lines":[{"line_number":571,"context_line":"            self.assertEqual(ring, 456)"},{"line_number":572,"context_line":"            ring \u003d baseapp.get_object_ring(\u00272\u0027)"},{"line_number":573,"context_line":"            self.assertEqual(ring, 789)"},{"line_number":574,"context_line":"            #illegal values"},{"line_number":575,"context_line":"            self.assertRaises(ValueError, baseapp.get_object_ring, \u002799\u0027)"},{"line_number":576,"context_line":"            self.assertRaises(ValueError, baseapp.get_object_ring, \u0027asdf\u0027)"},{"line_number":577,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"1ae5cdf2_e2157b9c","line":574,"updated":"2014-06-05 06:57:56.000000000","message":"reee-peat! *record scratch*","commit_id":"27d1fbe484a871dca775ea4fb98335d29b19492c"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"ae9c21d9199fa91ea880ed02a16fc3d15b6dbcc6","unresolved":false,"context_lines":[{"line_number":571,"context_line":"            self.assertEqual(ring, 456)"},{"line_number":572,"context_line":"            ring \u003d baseapp.get_object_ring(\u00272\u0027)"},{"line_number":573,"context_line":"            self.assertEqual(ring, 789)"},{"line_number":574,"context_line":"            #illegal values"},{"line_number":575,"context_line":"            self.assertRaises(ValueError, baseapp.get_object_ring, \u002799\u0027)"},{"line_number":576,"context_line":"            self.assertRaises(ValueError, baseapp.get_object_ring, \u0027asdf\u0027)"},{"line_number":577,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"1ae5cdf2_40446773","line":574,"in_reply_to":"1ae5cdf2_e2157b9c","updated":"2014-06-05 08:21:37.000000000","message":"Done","commit_id":"27d1fbe484a871dca775ea4fb98335d29b19492c"}]}
