)]}'
{"bin/swift-container-reconciler":[{"author":{"_account_id":1216,"name":"gholt","email":"z-launchpad@brim.net","username":"gholt"},"change_message_id":"353cb01feb92ff02eb53008a29280faaef0b5ff1","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/usr/bin/env python"},{"line_number":2,"context_line":"# Copyright (c) 2010-2012 OpenStack Foundation"},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":5,"context_line":"# you may not use this file except in compliance with the License."}],"source_content_type":"application/octet-stream","patch_set":5,"id":"1ae5cdf2_4f81a68e","line":2,"updated":"2014-05-30 14:38:22.000000000","message":"Wrong year range.","commit_id":"907fa21af80815aff32e762b4dcaa9f76c7b9024"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"dd550371bfd30ff012c1001c1c88c9d0665f63dd","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/usr/bin/env python"},{"line_number":2,"context_line":"# Copyright (c) 2010-2012 OpenStack Foundation"},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":5,"context_line":"# you may not use this file except in compliance with the License."}],"source_content_type":"application/octet-stream","patch_set":5,"id":"1ae5cdf2_b2951de6","line":2,"in_reply_to":"1ae5cdf2_4f81a68e","updated":"2014-05-30 22:37:00.000000000","message":"Done","commit_id":"907fa21af80815aff32e762b4dcaa9f76c7b9024"}],"bin/swift-reconciler-enqueue":[{"author":{"_account_id":1216,"name":"gholt","email":"z-launchpad@brim.net","username":"gholt"},"change_message_id":"353cb01feb92ff02eb53008a29280faaef0b5ff1","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/usr/bin/env python"},{"line_number":2,"context_line":"# Copyright (c) 2010-2012 OpenStack Foundation"},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":5,"context_line":"# you may not use this file except in compliance with the License."}],"source_content_type":"application/octet-stream","patch_set":5,"id":"1ae5cdf2_8f4ace81","line":2,"updated":"2014-05-30 14:38:22.000000000","message":"Wrong year range.","commit_id":"907fa21af80815aff32e762b4dcaa9f76c7b9024"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"dd550371bfd30ff012c1001c1c88c9d0665f63dd","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/usr/bin/env python"},{"line_number":2,"context_line":"# Copyright (c) 2010-2012 OpenStack Foundation"},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":5,"context_line":"# you may not use this file except in compliance with the License."}],"source_content_type":"application/octet-stream","patch_set":5,"id":"1ae5cdf2_d29aa913","line":2,"in_reply_to":"1ae5cdf2_8f4ace81","updated":"2014-05-30 22:37:00.000000000","message":"Done","commit_id":"907fa21af80815aff32e762b4dcaa9f76c7b9024"},{"author":{"_account_id":1216,"name":"gholt","email":"z-launchpad@brim.net","username":"gholt"},"change_message_id":"353cb01feb92ff02eb53008a29280faaef0b5ff1","unresolved":false,"context_lines":[{"line_number":29,"context_line":"parser.add_option(\u0027-X\u0027, \u0027--op\u0027, default\u003d\u0027PUT\u0027, choices\u003d(\u0027PUT\u0027, \u0027DELETE\u0027),"},{"line_number":30,"context_line":"                  help\u003d\u0027the method of the misplaced operation\u0027)"},{"line_number":31,"context_line":"parser.add_option(\u0027-f\u0027, \u0027--force\u0027, action\u003d\u0027store_true\u0027,"},{"line_number":32,"context_line":"                  help\u003d\u0027force an object to be re-enqueued\u0027)"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"def main():"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"1ae5cdf2_8a747c9d","line":32,"updated":"2014-05-30 14:38:22.000000000","message":"Probably needs some explanation as to how/when to use this, if at all. Is it just for debugging? Is the policy the bad or the good policy?","commit_id":"907fa21af80815aff32e762b4dcaa9f76c7b9024"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"dd550371bfd30ff012c1001c1c88c9d0665f63dd","unresolved":false,"context_lines":[{"line_number":29,"context_line":"parser.add_option(\u0027-X\u0027, \u0027--op\u0027, default\u003d\u0027PUT\u0027, choices\u003d(\u0027PUT\u0027, \u0027DELETE\u0027),"},{"line_number":30,"context_line":"                  help\u003d\u0027the method of the misplaced operation\u0027)"},{"line_number":31,"context_line":"parser.add_option(\u0027-f\u0027, \u0027--force\u0027, action\u003d\u0027store_true\u0027,"},{"line_number":32,"context_line":"                  help\u003d\u0027force an object to be re-enqueued\u0027)"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"def main():"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"1ae5cdf2_8d31e4ee","line":32,"in_reply_to":"1ae5cdf2_8a747c9d","updated":"2014-05-30 22:37:00.000000000","message":"Done","commit_id":"907fa21af80815aff32e762b4dcaa9f76c7b9024"}],"doc/saio/swift/container-reconciler.conf":[{"author":{"_account_id":9625,"name":"Thiago da Silva","email":"thiagodasilva@gmail.com","username":"thiago"},"change_message_id":"cad924e57c1f19221d67bc07f3c8746d0ad6a04c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[DEFAULT]"},{"line_number":2,"context_line":"# swift_dir \u003d /etc/swift"},{"line_number":3,"context_line":"# user \u003d swift"},{"line_number":4,"context_line":"# You can specify default log routing here if you want:"},{"line_number":5,"context_line":"# log_name \u003d swift"},{"line_number":6,"context_line":"# log_facility \u003d LOG_LOCAL0"}],"source_content_type":"text/plain","patch_set":5,"id":"1ae5cdf2_c8520213","line":3,"updated":"2014-05-30 19:15:19.000000000","message":"i think this line needs to be changed to:\nuser \u003d \u003cyour-user-name\u003e\notherwise when following the saio guide and then runningbin/startrest fails","commit_id":"907fa21af80815aff32e762b4dcaa9f76c7b9024"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"dd550371bfd30ff012c1001c1c88c9d0665f63dd","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[DEFAULT]"},{"line_number":2,"context_line":"# swift_dir \u003d /etc/swift"},{"line_number":3,"context_line":"# user \u003d swift"},{"line_number":4,"context_line":"# You can specify default log routing here if you want:"},{"line_number":5,"context_line":"# log_name \u003d swift"},{"line_number":6,"context_line":"# log_facility \u003d LOG_LOCAL0"}],"source_content_type":"text/plain","patch_set":5,"id":"1ae5cdf2_0d5dd421","line":3,"in_reply_to":"1ae5cdf2_c8520213","updated":"2014-05-30 22:37:00.000000000","message":"Done","commit_id":"907fa21af80815aff32e762b4dcaa9f76c7b9024"},{"author":{"_account_id":7479,"name":"paul luse","email":"paul.e.luse@intel.com","username":"peluse"},"change_message_id":"eca17c7e61ccacee5a85bc02c69ff73ac3bcbe64","unresolved":false,"context_lines":[{"line_number":23,"context_line":"# log_statsd_sample_rate_factor \u003d 1.0"},{"line_number":24,"context_line":"# log_statsd_metric_prefix \u003d"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"[container-reconciler]"},{"line_number":27,"context_line":"# reclaim_age \u003d 604800"},{"line_number":28,"context_line":"# interval \u003d 300"},{"line_number":29,"context_line":"# request_tries \u003d 3"}],"source_content_type":"text/plain","patch_set":5,"id":"1ae5cdf2_6d4e58c3","line":26,"updated":"2014-05-30 22:54:21.000000000","message":"don\u0027t forget to add these to the docs :)","commit_id":"907fa21af80815aff32e762b4dcaa9f76c7b9024"},{"author":{"_account_id":917,"name":"Chuck Thier","email":"cthier@gmail.com","username":"cthier"},"change_message_id":"c836d502b30428fbe0a648af28d59b42845e8a55","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[DEFAULT]"},{"line_number":2,"context_line":"# swift_dir \u003d /etc/swift"},{"line_number":3,"context_line":"# user \u003d \u003cyour-user-name\u003e"},{"line_number":4,"context_line":"# You can specify default log routing here if you want:"},{"line_number":5,"context_line":"# log_name \u003d swift"},{"line_number":6,"context_line":"# log_facility \u003d LOG_LOCAL0"}],"source_content_type":"text/plain","patch_set":7,"id":"1ae5cdf2_a5a039a0","line":3,"updated":"2014-06-03 03:54:05.000000000","message":"This needs to be uncommented to make it clear that the user has to put their name in here for it to work with the SAIO","commit_id":"1d96aa2503ad402e04f1b8ddf5775172f9c6ab97"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"3c66b457e5774197614da12de6c5413a68a32606","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[DEFAULT]"},{"line_number":2,"context_line":"# swift_dir \u003d /etc/swift"},{"line_number":3,"context_line":"# user \u003d \u003cyour-user-name\u003e"},{"line_number":4,"context_line":"# You can specify default log routing here if you want:"},{"line_number":5,"context_line":"# log_name \u003d swift"},{"line_number":6,"context_line":"# log_facility \u003d LOG_LOCAL0"}],"source_content_type":"text/plain","patch_set":7,"id":"1ae5cdf2_34e24b2f","line":3,"in_reply_to":"1ae5cdf2_a5a039a0","updated":"2014-06-04 20:37:54.000000000","message":"Done","commit_id":"1d96aa2503ad402e04f1b8ddf5775172f9c6ab97"}],"etc/container-reconciler.conf-sample":[{"author":{"_account_id":1216,"name":"gholt","email":"z-launchpad@brim.net","username":"gholt"},"change_message_id":"19a98def7739bd89ae042e6cf37fe4f095cbb269","unresolved":false,"context_lines":[{"line_number":24,"context_line":"# log_statsd_metric_prefix \u003d"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"[container-reconciler]"},{"line_number":27,"context_line":"# reclaim_age \u003d 604800"},{"line_number":28,"context_line":"# interval \u003d 300"},{"line_number":29,"context_line":"# request_tries \u003d 3"},{"line_number":30,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":5,"id":"1ae5cdf2_a17951fe","line":27,"updated":"2014-05-30 20:54:54.000000000","message":"This setting probably needs a quick description. I\u0027m pretty sure I understand it indicates how long the reconciler will attempt to reconcile something and keep failing before just giving up and deleting the record of the work to be done.","commit_id":"907fa21af80815aff32e762b4dcaa9f76c7b9024"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"dd550371bfd30ff012c1001c1c88c9d0665f63dd","unresolved":false,"context_lines":[{"line_number":24,"context_line":"# log_statsd_metric_prefix \u003d"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"[container-reconciler]"},{"line_number":27,"context_line":"# reclaim_age \u003d 604800"},{"line_number":28,"context_line":"# interval \u003d 300"},{"line_number":29,"context_line":"# request_tries \u003d 3"},{"line_number":30,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":5,"id":"1ae5cdf2_edf34808","line":27,"in_reply_to":"1ae5cdf2_a17951fe","updated":"2014-05-30 22:37:00.000000000","message":"Done","commit_id":"907fa21af80815aff32e762b4dcaa9f76c7b9024"}],"swift/container/reconciler.py":[{"author":{"_account_id":1216,"name":"gholt","email":"z-launchpad@brim.net","username":"gholt"},"change_message_id":"353cb01feb92ff02eb53008a29280faaef0b5ff1","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2010-2012 OpenStack Foundation"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":4,"context_line":"# you may not use this file except in compliance with the License."}],"source_content_type":"text/x-python","patch_set":5,"id":"1ae5cdf2_0a722c7c","line":1,"updated":"2014-05-30 14:38:22.000000000","message":"Wrong year range.","commit_id":"907fa21af80815aff32e762b4dcaa9f76c7b9024"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"dd550371bfd30ff012c1001c1c88c9d0665f63dd","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2010-2012 OpenStack Foundation"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":4,"context_line":"# you may not use this file except in compliance with the License."}],"source_content_type":"text/x-python","patch_set":5,"id":"1ae5cdf2_0df954e9","line":1,"in_reply_to":"1ae5cdf2_0a722c7c","updated":"2014-05-30 22:37:00.000000000","message":"Done","commit_id":"907fa21af80815aff32e762b4dcaa9f76c7b9024"},{"author":{"_account_id":7479,"name":"paul luse","email":"paul.e.luse@intel.com","username":"peluse"},"change_message_id":"2ead7d4f39e68ba83eab9fd1f657262fa02c2eab","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    else"},{"line_number":46,"context_line":"        return the oldest"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    I tried cleaning it up for awhile, but setteled on just writing a bunch of"},{"line_number":49,"context_line":"    tests instead.  Once you get an intuative sense for the nuance here you"},{"line_number":50,"context_line":"    can try and see there\u0027s a better way to spell the boolean logic but it all"},{"line_number":51,"context_line":"    ends up looking sorta hairy."}],"source_content_type":"text/x-python","patch_set":5,"id":"1ae5cdf2_0d26b4b7","line":48,"updated":"2014-05-30 22:48:12.000000000","message":"super nit - don\u0027t recall seeing first person comments elsewhere, not sure if anyone cares but thought I\u0027d mention it","commit_id":"907fa21af80815aff32e762b4dcaa9f76c7b9024"},{"author":{"_account_id":7479,"name":"paul luse","email":"paul.e.luse@intel.com","username":"peluse"},"change_message_id":"2ead7d4f39e68ba83eab9fd1f657262fa02c2eab","unresolved":false,"context_lines":[{"line_number":49,"context_line":"    tests instead.  Once you get an intuative sense for the nuance here you"},{"line_number":50,"context_line":"    can try and see there\u0027s a better way to spell the boolean logic but it all"},{"line_number":51,"context_line":"    ends up looking sorta hairy."},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    :returns: -1 if info is correct, 1 if remote_info is better"},{"line_number":54,"context_line":"    \"\"\""},{"line_number":55,"context_line":"    def is_deleted(info):"}],"source_content_type":"text/x-python","patch_set":5,"id":"1ae5cdf2_522219ba","line":52,"updated":"2014-05-30 22:48:12.000000000","message":"missing param:","commit_id":"907fa21af80815aff32e762b4dcaa9f76c7b9024"},{"author":{"_account_id":7479,"name":"paul luse","email":"paul.e.luse@intel.com","username":"peluse"},"change_message_id":"2ead7d4f39e68ba83eab9fd1f657262fa02c2eab","unresolved":false,"context_lines":[{"line_number":85,"context_line":"def incorrect_policy_index(info, remote_info):"},{"line_number":86,"context_line":"    \"\"\""},{"line_number":87,"context_line":"    Compare remote_info to info and decide if the remote storage policy index"},{"line_number":88,"context_line":"    should be used instead of ours."},{"line_number":89,"context_line":"    \"\"\""},{"line_number":90,"context_line":"    if \u0027storage_policy_index\u0027 not in remote_info:"},{"line_number":91,"context_line":"        return False"}],"source_content_type":"text/x-python","patch_set":5,"id":"1ae5cdf2_6d3498de","line":88,"updated":"2014-05-30 22:48:12.000000000","message":"missing param: and meaning of return value","commit_id":"907fa21af80815aff32e762b4dcaa9f76c7b9024"},{"author":{"_account_id":7479,"name":"paul luse","email":"paul.e.luse@intel.com","username":"peluse"},"change_message_id":"2ead7d4f39e68ba83eab9fd1f657262fa02c2eab","unresolved":false,"context_lines":[{"line_number":184,"context_line":"    :param response_timeout: max time to wait for response from container"},{"line_number":185,"context_line":"                             server"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"    :returns: .misplaced_object container name, False on failure. \"Success\""},{"line_number":188,"context_line":"              means a quorum of containers got the update."},{"line_number":189,"context_line":"    \"\"\""},{"line_number":190,"context_line":"    container_name \u003d get_reconciler_container_name(obj_timestamp)"}],"source_content_type":"text/x-python","patch_set":5,"id":"1ae5cdf2_ed41880c","line":187,"updated":"2014-05-30 22:48:12.000000000","message":"I guess the first part here means \"the container name of the misplaced object\"?  The . and _ there threw me for a sec","commit_id":"907fa21af80815aff32e762b4dcaa9f76c7b9024"},{"author":{"_account_id":7479,"name":"paul luse","email":"paul.e.luse@intel.com","username":"peluse"},"change_message_id":"2ead7d4f39e68ba83eab9fd1f657262fa02c2eab","unresolved":false,"context_lines":[{"line_number":309,"context_line":"    \"\"\""},{"line_number":310,"context_line":"    Talk directly to the primary container servers to delete a particular"},{"line_number":311,"context_line":"    object listing. Does not talk to object servers; use this only when a"},{"line_number":312,"context_line":"    container entry does not actually have a corresponding object."},{"line_number":313,"context_line":"    \"\"\""},{"line_number":314,"context_line":"    pool \u003d GreenPool()"},{"line_number":315,"context_line":"    part, nodes \u003d container_ring.get_nodes(account_name, container_name)"}],"source_content_type":"text/x-python","patch_set":5,"id":"1ae5cdf2_ed26e867","line":312,"updated":"2014-05-30 22:48:12.000000000","message":"missing param:","commit_id":"907fa21af80815aff32e762b4dcaa9f76c7b9024"},{"author":{"_account_id":7479,"name":"paul luse","email":"paul.e.luse@intel.com","username":"peluse"},"change_message_id":"2ead7d4f39e68ba83eab9fd1f657262fa02c2eab","unresolved":false,"context_lines":[{"line_number":392,"context_line":"        :param account: the object name"},{"line_number":393,"context_line":"        :param timestamp: the timestamp of the object to delete"},{"line_number":394,"context_line":"        :param policy_index: the policy index to direct the request"},{"line_number":395,"context_line":"        :param path: the path to be used for logging"},{"line_number":396,"context_line":"        \"\"\""},{"line_number":397,"context_line":"        x_timestamp \u003d slightly_later_timestamp(timestamp)"},{"line_number":398,"context_line":"        self.stats_log(\u0027cleanup_attempt\u0027, \u0027%r (%f) from policy_index \u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"1ae5cdf2_add30037","line":395,"updated":"2014-05-30 22:48:12.000000000","message":"missing return meaning","commit_id":"907fa21af80815aff32e762b4dcaa9f76c7b9024"},{"author":{"_account_id":7479,"name":"paul luse","email":"paul.e.luse@intel.com","username":"peluse"},"change_message_id":"2ead7d4f39e68ba83eab9fd1f657262fa02c2eab","unresolved":false,"context_lines":[{"line_number":515,"context_line":"        :param source_ts: a float, the timestamp of the source object"},{"line_number":516,"context_line":"        :param source_obj_status: the HTTP status source object request"},{"line_number":517,"context_line":"        :param source_obj_info: the HTTP headers of the source object request"},{"line_number":518,"context_line":"        :param source_obj_iter: the body iter of the source object request"},{"line_number":519,"context_line":"        \"\"\""},{"line_number":520,"context_line":"        if source_obj_status // 100 !\u003d 2 or source_ts \u003c q_ts:"},{"line_number":521,"context_line":"            if q_ts \u003c time.time() - self.reclaim_age:"}],"source_content_type":"text/x-python","patch_set":5,"id":"1ae5cdf2_0dba34de","line":518,"updated":"2014-05-30 22:48:12.000000000","message":"missing return meaning","commit_id":"907fa21af80815aff32e762b4dcaa9f76c7b9024"},{"author":{"_account_id":5600,"name":"Brian Cline","email":"bcline@softlayer.com","username":"briancline"},"change_message_id":"0f6a68f659ff1a232f053f9b3cad1efb86e7830a","unresolved":false,"context_lines":[{"line_number":44,"context_line":"        return the oldest"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    I tried cleaning it up for awhile, but setteled on just writing a bunch of"},{"line_number":47,"context_line":"    tests instead.  Once you get an intuative sense for the nuance here you"},{"line_number":48,"context_line":"    can try and see there\u0027s a better way to spell the boolean logic but it all"},{"line_number":49,"context_line":"    ends up looking sorta hairy."},{"line_number":50,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"1ae5cdf2_f80b6dd3","line":47,"updated":"2014-06-05 04:59:02.000000000","message":"s/intuative/intuitive/  :)","commit_id":"1d96aa2503ad402e04f1b8ddf5775172f9c6ab97"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"ed6bc557681e826b78bb52e5996c40346eab54a7","unresolved":false,"context_lines":[{"line_number":44,"context_line":"        return the oldest"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    I tried cleaning it up for awhile, but setteled on just writing a bunch of"},{"line_number":47,"context_line":"    tests instead.  Once you get an intuative sense for the nuance here you"},{"line_number":48,"context_line":"    can try and see there\u0027s a better way to spell the boolean logic but it all"},{"line_number":49,"context_line":"    ends up looking sorta hairy."},{"line_number":50,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"1ae5cdf2_5b71b6a6","line":47,"in_reply_to":"1ae5cdf2_f80b6dd3","updated":"2014-06-05 08:27:28.000000000","message":"Done","commit_id":"1d96aa2503ad402e04f1b8ddf5775172f9c6ab97"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"f763acf6664234f5b2b863282802719715c3370c","unresolved":false,"context_lines":[{"line_number":190,"context_line":"                                          container, obj)"},{"line_number":191,"context_line":"    if force:"},{"line_number":192,"context_line":"        # this allows an operator to re-enqueue an object that has already"},{"line_number":193,"context_line":"        # been popped from the queue to be reprocessed, but could potentailly"},{"line_number":194,"context_line":"        # prevent out of order updates from making it into the queue"},{"line_number":195,"context_line":"        x_timestamp \u003d normalize_timestamp(time.time())"},{"line_number":196,"context_line":"    else:"}],"source_content_type":"text/x-python","patch_set":10,"id":"1ae5cdf2_63489a2d","line":193,"updated":"2014-06-12 17:47:37.000000000","message":"nit s/potentailly/potentially/","commit_id":"83e6ed4b1c2fdadeb3dd721fab26b568f9929081"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"86a255be090f27ffbfe8194e4d02f431e5658d32","unresolved":false,"context_lines":[{"line_number":190,"context_line":"                                          container, obj)"},{"line_number":191,"context_line":"    if force:"},{"line_number":192,"context_line":"        # this allows an operator to re-enqueue an object that has already"},{"line_number":193,"context_line":"        # been popped from the queue to be reprocessed, but could potentailly"},{"line_number":194,"context_line":"        # prevent out of order updates from making it into the queue"},{"line_number":195,"context_line":"        x_timestamp \u003d normalize_timestamp(time.time())"},{"line_number":196,"context_line":"    else:"}],"source_content_type":"text/x-python","patch_set":10,"id":"1ae5cdf2_a94fcf90","line":193,"in_reply_to":"1ae5cdf2_63489a2d","updated":"2014-06-13 07:17:22.000000000","message":"Done","commit_id":"83e6ed4b1c2fdadeb3dd721fab26b568f9929081"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"f763acf6664234f5b2b863282802719715c3370c","unresolved":false,"context_lines":[{"line_number":236,"context_line":"def parse_raw_obj(obj_info):"},{"line_number":237,"context_line":"    \"\"\""},{"line_number":238,"context_line":"    Translate a reconciler container listing entry to a dictionary"},{"line_number":239,"context_line":"    containg the parts of the misplaced object queue entry."},{"line_number":240,"context_line":""},{"line_number":241,"context_line":"    :param obj_info: an entry in an a container listing with the"},{"line_number":242,"context_line":"                     required keys: name, content_type, and hash"}],"source_content_type":"text/x-python","patch_set":10,"id":"1ae5cdf2_f4ce2359","line":239,"updated":"2014-06-12 17:47:37.000000000","message":"nit: s/containg/containing/","commit_id":"83e6ed4b1c2fdadeb3dd721fab26b568f9929081"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"86a255be090f27ffbfe8194e4d02f431e5658d32","unresolved":false,"context_lines":[{"line_number":236,"context_line":"def parse_raw_obj(obj_info):"},{"line_number":237,"context_line":"    \"\"\""},{"line_number":238,"context_line":"    Translate a reconciler container listing entry to a dictionary"},{"line_number":239,"context_line":"    containg the parts of the misplaced object queue entry."},{"line_number":240,"context_line":""},{"line_number":241,"context_line":"    :param obj_info: an entry in an a container listing with the"},{"line_number":242,"context_line":"                     required keys: name, content_type, and hash"}],"source_content_type":"text/x-python","patch_set":10,"id":"1ae5cdf2_e945576f","line":239,"in_reply_to":"1ae5cdf2_f4ce2359","updated":"2014-06-13 07:17:22.000000000","message":"Done","commit_id":"83e6ed4b1c2fdadeb3dd721fab26b568f9929081"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"f763acf6664234f5b2b863282802719715c3370c","unresolved":false,"context_lines":[{"line_number":365,"context_line":"        object queue entry."},{"line_number":366,"context_line":""},{"line_number":367,"context_line":"        :param container: the misplaced objects container"},{"line_number":368,"context_line":"        :param q_ts: a float, the timestamp of the mispalced object"},{"line_number":369,"context_line":"        :param q_record: a float, the timestamp of the queue entry"},{"line_number":370,"context_line":""},{"line_number":371,"context_line":"        N.B. q_ts will normally be the same time as q_record except when"}],"source_content_type":"text/x-python","patch_set":10,"id":"1ae5cdf2_2f8d96d3","line":368,"updated":"2014-06-12 17:47:37.000000000","message":"nit: s/mispalced/misplaced/","commit_id":"83e6ed4b1c2fdadeb3dd721fab26b568f9929081"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"86a255be090f27ffbfe8194e4d02f431e5658d32","unresolved":false,"context_lines":[{"line_number":365,"context_line":"        object queue entry."},{"line_number":366,"context_line":""},{"line_number":367,"context_line":"        :param container: the misplaced objects container"},{"line_number":368,"context_line":"        :param q_ts: a float, the timestamp of the mispalced object"},{"line_number":369,"context_line":"        :param q_record: a float, the timestamp of the queue entry"},{"line_number":370,"context_line":""},{"line_number":371,"context_line":"        N.B. q_ts will normally be the same time as q_record except when"}],"source_content_type":"text/x-python","patch_set":10,"id":"1ae5cdf2_295bbf54","line":368,"in_reply_to":"1ae5cdf2_2f8d96d3","updated":"2014-06-13 07:17:22.000000000","message":"Done","commit_id":"83e6ed4b1c2fdadeb3dd721fab26b568f9929081"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"f763acf6664234f5b2b863282802719715c3370c","unresolved":false,"context_lines":[{"line_number":489,"context_line":"            source_obj_iter \u003d None"},{"line_number":490,"context_line":""},{"line_number":491,"context_line":"        source_ts \u003d float(source_obj_info.get(\"X-Timestamp\", 0))"},{"line_number":492,"context_line":"        if source_obj_status \u003d\u003d 404 and q_op \u003d\u003d \u0027DELETE\u0027:"},{"line_number":493,"context_line":"            return self.ensure_tombstone_in_right_location("},{"line_number":494,"context_line":"                q_policy_index, account, container, obj, q_ts, path,"},{"line_number":495,"context_line":"                container_policy_index, source_ts)"}],"source_content_type":"text/x-python","patch_set":10,"id":"1ae5cdf2_c697bcea","line":492,"updated":"2014-06-12 17:47:37.000000000","message":"what would lead q_op being DELETE but source_obj_status not 404? - is it replicator detected a deleted obj but by time reconciler runs the object got PUT again?","commit_id":"83e6ed4b1c2fdadeb3dd721fab26b568f9929081"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"86a255be090f27ffbfe8194e4d02f431e5658d32","unresolved":false,"context_lines":[{"line_number":489,"context_line":"            source_obj_iter \u003d None"},{"line_number":490,"context_line":""},{"line_number":491,"context_line":"        source_ts \u003d float(source_obj_info.get(\"X-Timestamp\", 0))"},{"line_number":492,"context_line":"        if source_obj_status \u003d\u003d 404 and q_op \u003d\u003d \u0027DELETE\u0027:"},{"line_number":493,"context_line":"            return self.ensure_tombstone_in_right_location("},{"line_number":494,"context_line":"                q_policy_index, account, container, obj, q_ts, path,"},{"line_number":495,"context_line":"                container_policy_index, source_ts)"}],"source_content_type":"text/x-python","patch_set":10,"id":"1ae5cdf2_c9397bf3","line":492,"in_reply_to":"1ae5cdf2_c697bcea","updated":"2014-06-13 07:17:22.000000000","message":"yup, that would do it, there\u0027s a comment about moving objects with timestamps newer than the queue in ensure_object_in_right_location.","commit_id":"83e6ed4b1c2fdadeb3dd721fab26b568f9929081"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"f763acf6664234f5b2b863282802719715c3370c","unresolved":false,"context_lines":[{"line_number":505,"context_line":"                                        source_obj_status, source_obj_info,"},{"line_number":506,"context_line":"                                        source_obj_iter, **kwargs):"},{"line_number":507,"context_line":"        \"\"\""},{"line_number":508,"context_line":"        Validate source object will satisfiy the misplaced object queue entry"},{"line_number":509,"context_line":"        and move to destination."},{"line_number":510,"context_line":""},{"line_number":511,"context_line":"        :param q_policy_index: the policy_index for the source object"}],"source_content_type":"text/x-python","patch_set":10,"id":"1ae5cdf2_cfd192fc","line":508,"updated":"2014-06-12 17:47:37.000000000","message":"nit: s/satisfiy/satisfy/","commit_id":"83e6ed4b1c2fdadeb3dd721fab26b568f9929081"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"86a255be090f27ffbfe8194e4d02f431e5658d32","unresolved":false,"context_lines":[{"line_number":505,"context_line":"                                        source_obj_status, source_obj_info,"},{"line_number":506,"context_line":"                                        source_obj_iter, **kwargs):"},{"line_number":507,"context_line":"        \"\"\""},{"line_number":508,"context_line":"        Validate source object will satisfiy the misplaced object queue entry"},{"line_number":509,"context_line":"        and move to destination."},{"line_number":510,"context_line":""},{"line_number":511,"context_line":"        :param q_policy_index: the policy_index for the source object"}],"source_content_type":"text/x-python","patch_set":10,"id":"1ae5cdf2_891a137b","line":508,"in_reply_to":"1ae5cdf2_cfd192fc","updated":"2014-06-13 07:17:22.000000000","message":"Done","commit_id":"83e6ed4b1c2fdadeb3dd721fab26b568f9929081"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"f763acf6664234f5b2b863282802719715c3370c","unresolved":false,"context_lines":[{"line_number":523,"context_line":"        if source_obj_status // 100 !\u003d 2 or source_ts \u003c q_ts:"},{"line_number":524,"context_line":"            if q_ts \u003c time.time() - self.reclaim_age:"},{"line_number":525,"context_line":"                # it\u0027s old and there are no tombstones or anything; give up"},{"line_number":526,"context_line":"                self.stats_log(\u0027lost_source\u0027, \u0027%r (%f) was not avaialble in \u0027"},{"line_number":527,"context_line":"                               \u0027policy_index %s and has expired\u0027, path, q_ts,"},{"line_number":528,"context_line":"                               q_policy_index, level\u003dlogging.CRITICAL)"},{"line_number":529,"context_line":"                return True"}],"source_content_type":"text/x-python","patch_set":10,"id":"1ae5cdf2_cf3fd223","line":526,"updated":"2014-06-12 17:47:37.000000000","message":"s/avaialble/available/","commit_id":"83e6ed4b1c2fdadeb3dd721fab26b568f9929081"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"86a255be090f27ffbfe8194e4d02f431e5658d32","unresolved":false,"context_lines":[{"line_number":523,"context_line":"        if source_obj_status // 100 !\u003d 2 or source_ts \u003c q_ts:"},{"line_number":524,"context_line":"            if q_ts \u003c time.time() - self.reclaim_age:"},{"line_number":525,"context_line":"                # it\u0027s old and there are no tombstones or anything; give up"},{"line_number":526,"context_line":"                self.stats_log(\u0027lost_source\u0027, \u0027%r (%f) was not avaialble in \u0027"},{"line_number":527,"context_line":"                               \u0027policy_index %s and has expired\u0027, path, q_ts,"},{"line_number":528,"context_line":"                               q_policy_index, level\u003dlogging.CRITICAL)"},{"line_number":529,"context_line":"                return True"}],"source_content_type":"text/x-python","patch_set":10,"id":"1ae5cdf2_c9109b5b","line":526,"in_reply_to":"1ae5cdf2_cf3fd223","updated":"2014-06-13 07:17:22.000000000","message":"Done","commit_id":"83e6ed4b1c2fdadeb3dd721fab26b568f9929081"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"f763acf6664234f5b2b863282802719715c3370c","unresolved":false,"context_lines":[{"line_number":537,"context_line":"            return False"},{"line_number":538,"context_line":""},{"line_number":539,"context_line":"        # optimistically move any source with a timestamp \u003e\u003d q_ts"},{"line_number":540,"context_line":"        ts \u003d max(float(source_ts), q_ts)"},{"line_number":541,"context_line":"        # move the object"},{"line_number":542,"context_line":"        put_timestamp \u003d slightly_later_timestamp(ts, offset\u003d2)"},{"line_number":543,"context_line":"        self.stats_log(\u0027copy_attempt\u0027, \u0027%r (%f) in policy_index %s will be \u0027"}],"source_content_type":"text/x-python","patch_set":10,"id":"1ae5cdf2_66ad0831","line":540,"updated":"2014-06-12 17:47:37.000000000","message":"similar question to line 492 - is this in case the misplaced object got newer since the replicator found it? could source_ts ever be \u003c q_ts?","commit_id":"83e6ed4b1c2fdadeb3dd721fab26b568f9929081"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"86a255be090f27ffbfe8194e4d02f431e5658d32","unresolved":false,"context_lines":[{"line_number":537,"context_line":"            return False"},{"line_number":538,"context_line":""},{"line_number":539,"context_line":"        # optimistically move any source with a timestamp \u003e\u003d q_ts"},{"line_number":540,"context_line":"        ts \u003d max(float(source_ts), q_ts)"},{"line_number":541,"context_line":"        # move the object"},{"line_number":542,"context_line":"        put_timestamp \u003d slightly_later_timestamp(ts, offset\u003d2)"},{"line_number":543,"context_line":"        self.stats_log(\u0027copy_attempt\u0027, \u0027%r (%f) in policy_index %s will be \u0027"}],"source_content_type":"text/x-python","patch_set":10,"id":"1ae5cdf2_04150a3f","line":540,"in_reply_to":"1ae5cdf2_66ad0831","updated":"2014-06-13 07:17:22.000000000","message":"Yes, handled above as \"unavailable\" in that the source object to satisfy the queue entry wasn\u0027t available yet - in which case the reconciler will retry next go \u0027round","commit_id":"83e6ed4b1c2fdadeb3dd721fab26b568f9929081"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"f763acf6664234f5b2b863282802719715c3370c","unresolved":false,"context_lines":[{"line_number":667,"context_line":"                                  \u0027account %s (%s)\u0027,"},{"line_number":668,"context_line":"                                  MISPLACED_OBJECTS_ACCOUNT, err)"},{"line_number":669,"context_line":""},{"line_number":670,"context_line":"            if not one_page:"},{"line_number":671,"context_line":"                # don\u0027t generally expect more than one page"},{"line_number":672,"context_line":"                break"},{"line_number":673,"context_line":"            # reversed order since we expect older containers to be empty"}],"source_content_type":"text/x-python","patch_set":10,"id":"1ae5cdf2_74c05350","line":670,"updated":"2014-06-12 17:47:37.000000000","message":"my eyes are telling me that one_page could be referenced before assigned but strangely my IDE isn\u0027t complaining. There\u0027s no coverage for lines 665-666, and if I force internal client to raise an UnexpectedResponse then I see an UnboundLocalError.","commit_id":"83e6ed4b1c2fdadeb3dd721fab26b568f9929081"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"86a255be090f27ffbfe8194e4d02f431e5658d32","unresolved":false,"context_lines":[{"line_number":667,"context_line":"                                  \u0027account %s (%s)\u0027,"},{"line_number":668,"context_line":"                                  MISPLACED_OBJECTS_ACCOUNT, err)"},{"line_number":669,"context_line":""},{"line_number":670,"context_line":"            if not one_page:"},{"line_number":671,"context_line":"                # don\u0027t generally expect more than one page"},{"line_number":672,"context_line":"                break"},{"line_number":673,"context_line":"            # reversed order since we expect older containers to be empty"}],"source_content_type":"text/x-python","patch_set":10,"id":"1ae5cdf2_241da60f","line":670,"in_reply_to":"1ae5cdf2_74c05350","updated":"2014-06-13 07:17:22.000000000","message":"you eyes do not deceive you, I added some extra error handling and didn\u0027t write better tests.\n\nDone.","commit_id":"83e6ed4b1c2fdadeb3dd721fab26b568f9929081"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"f763acf6664234f5b2b863282802719715c3370c","unresolved":false,"context_lines":[{"line_number":685,"context_line":"        :param container: the name of the container to process"},{"line_number":686,"context_line":""},{"line_number":687,"context_line":"        If the given container is empty and older than reclaim_age this"},{"line_number":688,"context_line":"        processor will attemp to reap it."},{"line_number":689,"context_line":"        \"\"\""},{"line_number":690,"context_line":"        self.logger.debug(\u0027looking for objects in %s\u0027, container)"},{"line_number":691,"context_line":"        found_obj \u003d False"}],"source_content_type":"text/x-python","patch_set":10,"id":"1ae5cdf2_54899724","line":688,"updated":"2014-06-12 17:47:37.000000000","message":"nit: s/attemp/attempt/","commit_id":"83e6ed4b1c2fdadeb3dd721fab26b568f9929081"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"86a255be090f27ffbfe8194e4d02f431e5658d32","unresolved":false,"context_lines":[{"line_number":685,"context_line":"        :param container: the name of the container to process"},{"line_number":686,"context_line":""},{"line_number":687,"context_line":"        If the given container is empty and older than reclaim_age this"},{"line_number":688,"context_line":"        processor will attemp to reap it."},{"line_number":689,"context_line":"        \"\"\""},{"line_number":690,"context_line":"        self.logger.debug(\u0027looking for objects in %s\u0027, container)"},{"line_number":691,"context_line":"        found_obj \u003d False"}],"source_content_type":"text/x-python","patch_set":10,"id":"1ae5cdf2_a4d8d653","line":688,"in_reply_to":"1ae5cdf2_54899724","updated":"2014-06-13 07:17:22.000000000","message":"Done","commit_id":"83e6ed4b1c2fdadeb3dd721fab26b568f9929081"}],"test/unit/__init__.py":[{"author":{"_account_id":5600,"name":"Brian Cline","email":"bcline@softlayer.com","username":"briancline"},"change_message_id":"0f6a68f659ff1a232f053f9b3cad1efb86e7830a","unresolved":false,"context_lines":[{"line_number":626,"context_line":"                    self._next_sleep \u003d None"},{"line_number":627,"context_line":""},{"line_number":628,"context_line":"        def getresponse(self):"},{"line_number":629,"context_line":"            exc \u003d kwargs.get(\u0027raise_exc\u0027)"},{"line_number":630,"context_line":"            if exc:"},{"line_number":631,"context_line":"                if isinstance(exc, Exception):"},{"line_number":632,"context_line":"                    raise exc"}],"source_content_type":"text/x-python","patch_set":7,"id":"1ae5cdf2_0c337eab","line":629,"updated":"2014-06-05 04:59:02.000000000","message":"I might have missed something -- but wouldn\u0027t you want a kwargs.get(\u0027raise_exc\u0027, None) here in case it\u0027s not in the dict? (as well as on line 634)","commit_id":"1d96aa2503ad402e04f1b8ddf5775172f9c6ab97"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"ed6bc557681e826b78bb52e5996c40346eab54a7","unresolved":false,"context_lines":[{"line_number":626,"context_line":"                    self._next_sleep \u003d None"},{"line_number":627,"context_line":""},{"line_number":628,"context_line":"        def getresponse(self):"},{"line_number":629,"context_line":"            exc \u003d kwargs.get(\u0027raise_exc\u0027)"},{"line_number":630,"context_line":"            if exc:"},{"line_number":631,"context_line":"                if isinstance(exc, Exception):"},{"line_number":632,"context_line":"                    raise exc"}],"source_content_type":"text/x-python","patch_set":7,"id":"1ae5cdf2_3ba5ca03","line":629,"in_reply_to":"1ae5cdf2_0c337eab","updated":"2014-06-05 08:27:28.000000000","message":"the default... default for the get method is None already.","commit_id":"1d96aa2503ad402e04f1b8ddf5775172f9c6ab97"}],"test/unit/container/test_reconciler.py":[{"author":{"_account_id":1216,"name":"gholt","email":"z-launchpad@brim.net","username":"gholt"},"change_message_id":"353cb01feb92ff02eb53008a29280faaef0b5ff1","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2010-2012 OpenStack Foundation"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":4,"context_line":"# you may not use this file except in compliance with the License."}],"source_content_type":"text/x-python","patch_set":5,"id":"1ae5cdf2_6a0010ab","line":1,"updated":"2014-05-30 14:38:22.000000000","message":"Wrong year range.","commit_id":"907fa21af80815aff32e762b4dcaa9f76c7b9024"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"dd550371bfd30ff012c1001c1c88c9d0665f63dd","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2010-2012 OpenStack Foundation"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":4,"context_line":"# you may not use this file except in compliance with the License."}],"source_content_type":"text/x-python","patch_set":5,"id":"1ae5cdf2_0dd0744f","line":1,"in_reply_to":"1ae5cdf2_6a0010ab","updated":"2014-05-30 22:37:00.000000000","message":"Done","commit_id":"907fa21af80815aff32e762b4dcaa9f76c7b9024"}]}
