)]}'
{"swift/common/db_replicator.py":[{"author":{"_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"},"change_message_id":"ec5f7a8fd35ab4b45a14226e925494c61a514890","unresolved":false,"context_lines":[{"line_number":623,"context_line":"         delete_timestamp, metadata) \u003d args[:7]"},{"line_number":624,"context_line":"        try:"},{"line_number":625,"context_line":"            remote_metadata \u003d json.loads(metadata)"},{"line_number":626,"context_line":"        except json.JSONDecodeError:"},{"line_number":627,"context_line":"            remote_metadata \u003d {}"},{"line_number":628,"context_line":"        remote_info \u003d {"},{"line_number":629,"context_line":"            \u0027point\u0027: remote_sync,"}],"source_content_type":"text/x-python","patch_set":10,"id":"1ae5cdf2_001b3f81","line":626,"updated":"2014-06-12 23:55:22.000000000","message":"This seems to be a simplejson thing; stdlib json doesn\u0027t have a JSONDecodeError, at least in Python 2.7.\n\nIn fact, it doesn\u0027t exist in simplejson 2.0.9 (the minimum version in requirements.txt) either. Both stdlib json and simplejson 2.0.9 raise ValueError when given an invalid string.\n\nGood news, though: simplejson.JSONDecodeError inherits from ValueError, so catching ValueError here should cover all the bases.","commit_id":"7f6714775d079d5c17988688236ac53ee80a789e"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"02f2e86e1ce2067bd3b5f92b5ffb986eea40ed0e","unresolved":false,"context_lines":[{"line_number":623,"context_line":"         delete_timestamp, metadata) \u003d args[:7]"},{"line_number":624,"context_line":"        try:"},{"line_number":625,"context_line":"            remote_metadata \u003d json.loads(metadata)"},{"line_number":626,"context_line":"        except json.JSONDecodeError:"},{"line_number":627,"context_line":"            remote_metadata \u003d {}"},{"line_number":628,"context_line":"        remote_info \u003d {"},{"line_number":629,"context_line":"            \u0027point\u0027: remote_sync,"}],"source_content_type":"text/x-python","patch_set":10,"id":"1ae5cdf2_e4b57eed","line":626,"in_reply_to":"1ae5cdf2_001b3f81","updated":"2014-06-13 07:25:57.000000000","message":"The old code was doing an \u0027if metadata\u0027 check before trying to deserialize - so I guess this is a new bug.  So maybe I should have just stuck with that anyway, if it\u0027s malformed I suppose that\u0027s a different error.\n\nDone.","commit_id":"7f6714775d079d5c17988688236ac53ee80a789e"}],"swift/container/replicator.py":[{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"fbaab35ec4c66bf83924b41c01e1ba189533fffe","unresolved":false,"context_lines":[{"line_number":79,"context_line":"                remote_info[\u0027storage_policy_index\u0027],"},{"line_number":80,"context_line":"                timestamp\u003dstatus_changed_at)"},{"line_number":81,"context_line":"        parent \u003d super(ContainerReplicatorRpc, self)"},{"line_number":82,"context_line":"        rv \u003d parent._handle_sync_request(broker, remote_info)"},{"line_number":83,"context_line":"        return rv"}],"source_content_type":"text/x-python","patch_set":13,"id":"1ae5cdf2_f76adbb3","line":82,"updated":"2014-06-18 15:33:48.000000000","message":"Looks like the (original) parent._handle_sync_request handles db container_stat table not found gracefully by quarantining the db and returning 404, but set_storage_policy_index called above doesn\u0027t seem to do that (maybe i missed it) and will raise an exception. So could/should the parent handle_sync_request come first?","commit_id":"f9280311ec47abe8844aba88263e1ea07d02ad2d"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"fdb054c51842b3bbcd9d25ec9c3b2491c15d0b8b","unresolved":false,"context_lines":[{"line_number":79,"context_line":"                remote_info[\u0027storage_policy_index\u0027],"},{"line_number":80,"context_line":"                timestamp\u003dstatus_changed_at)"},{"line_number":81,"context_line":"        parent \u003d super(ContainerReplicatorRpc, self)"},{"line_number":82,"context_line":"        rv \u003d parent._handle_sync_request(broker, remote_info)"},{"line_number":83,"context_line":"        return rv"}],"source_content_type":"text/x-python","patch_set":13,"id":"1ae5cdf2_529aa614","line":82,"in_reply_to":"1ae5cdf2_d1188286","updated":"2014-06-19 01:40:50.000000000","message":"Done","commit_id":"f9280311ec47abe8844aba88263e1ea07d02ad2d"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"5741ac06c4d06107e3401f3540ef92fc1c6dbda8","unresolved":false,"context_lines":[{"line_number":79,"context_line":"                remote_info[\u0027storage_policy_index\u0027],"},{"line_number":80,"context_line":"                timestamp\u003dstatus_changed_at)"},{"line_number":81,"context_line":"        parent \u003d super(ContainerReplicatorRpc, self)"},{"line_number":82,"context_line":"        rv \u003d parent._handle_sync_request(broker, remote_info)"},{"line_number":83,"context_line":"        return rv"}],"source_content_type":"text/x-python","patch_set":13,"id":"1ae5cdf2_d1188286","line":82,"in_reply_to":"1ae5cdf2_f76adbb3","updated":"2014-06-18 19:04:00.000000000","message":"ahh... interesting, i want the correct storage policy and status changed at in the response so I can\u0027t just move it \"after\" per se.  But I think i could do something better than return a 500 :P","commit_id":"f9280311ec47abe8844aba88263e1ea07d02ad2d"}],"test/probe/test_container_merge_policy_index.py":[{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"fbaab35ec4c66bf83924b41c01e1ba189533fffe","unresolved":false,"context_lines":[{"line_number":189,"context_line":"        self.brain.put_container()"},{"line_number":190,"context_line":"        self.brain.put_object()"},{"line_number":191,"context_line":"        self.brain.start_handoff_half()"},{"line_number":192,"context_line":"        # make sure we have some mannor of split brain"},{"line_number":193,"context_line":"        container_part, container_nodes \u003d self.container_ring.get_nodes("},{"line_number":194,"context_line":"            self.account, self.container_name)"},{"line_number":195,"context_line":"        head_responses \u003d []"}],"source_content_type":"text/x-python","patch_set":13,"id":"1ae5cdf2_3fadff31","line":192,"updated":"2014-06-18 15:33:48.000000000","message":"nit s/mannor/manner/\n\nhappens again somewhere when a later patch touches this file","commit_id":"f9280311ec47abe8844aba88263e1ea07d02ad2d"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"5741ac06c4d06107e3401f3540ef92fc1c6dbda8","unresolved":false,"context_lines":[{"line_number":189,"context_line":"        self.brain.put_container()"},{"line_number":190,"context_line":"        self.brain.put_object()"},{"line_number":191,"context_line":"        self.brain.start_handoff_half()"},{"line_number":192,"context_line":"        # make sure we have some mannor of split brain"},{"line_number":193,"context_line":"        container_part, container_nodes \u003d self.container_ring.get_nodes("},{"line_number":194,"context_line":"            self.account, self.container_name)"},{"line_number":195,"context_line":"        head_responses \u003d []"}],"source_content_type":"text/x-python","patch_set":13,"id":"1ae5cdf2_8c5ee111","line":192,"in_reply_to":"1ae5cdf2_3fadff31","updated":"2014-06-18 19:04:00.000000000","message":"Done","commit_id":"f9280311ec47abe8844aba88263e1ea07d02ad2d"}]}
