)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"efd790779e229a8796f4fdb2fbecf0e930e2d3cc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"d5cb7e60_bb8e0b74","updated":"2025-09-10 19:51:58.000000000","message":"this is great, it could probably use an lp bug (I think the broke during py2-\u003epy3)\n\nbut I\u0027d prefer we not go from \"one untested branch\" to TWO untested branches; maybe a test like:\n\n960414: sq: test for error in ppi rename | https://review.opendev.org/c/openstack/swift/+/960414\n\n???","commit_id":"4a8e8cf9c9d11dbb3ee3ac3285209a1c1dc11c0c"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"27afe8c32f654d27de17b200dc3355d29ae6e3bb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"a1798345_c69b3fdd","updated":"2025-09-16 16:18:02.000000000","message":"LGTM!","commit_id":"397f94c73bbfac121960d551fdb0a6877a6b6171"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"c744f69b8be0ae844b46068f18ac611a400acff8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"bd2ffdec_d212ef54","updated":"2025-09-10 20:55:09.000000000","message":"either of these tests fail with the change reverted:\n\n```\nFAILED swift/test/unit/obj/test_diskfile.py::TestECDiskFile::test_commit_overwritten_before_ppi_rename - UnboundLocalError: local variable \u0027exc\u0027 referenced before assignment\nFAILED swift/test/unit/obj/test_diskfile.py::TestECDiskFile::test_commit_raises_DiskFileError_for_error_in_ppi_rename - UnboundLocalError: local variable \u0027exc\u0027 referenced before assignment\n```\n\nprobably the overwrite one is better?\n\navoiding +A only b/c it\u0027s brand new; I think the lp bug is a problem and we should merge this fix very soon.","commit_id":"397f94c73bbfac121960d551fdb0a6877a6b6171"}],"test/unit/obj/test_diskfile.py":[{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"c744f69b8be0ae844b46068f18ac611a400acff8","unresolved":true,"context_lines":[{"line_number":6421,"context_line":"                    writer.put(metadata)"},{"line_number":6422,"context_line":"                    writer.commit(ts2)"},{"line_number":6423,"context_line":"                os.unlink(args[0])"},{"line_number":6424,"context_line":"            return orig_rename(*args)"},{"line_number":6425,"context_line":""},{"line_number":6426,"context_line":"        timestamp \u003d Timestamp.now()"},{"line_number":6427,"context_line":"        ts2 \u003d Timestamp(timestamp, delta\u003d1)"}],"source_content_type":"text/x-python","patch_set":3,"id":"dc17be08_d7f40f0f","line":6424,"updated":"2025-09-10 20:55:09.000000000","message":"oic, so this is an explination of how we actually SEE the error (orig_rename raises ENOENT?) - no mocking involved!","commit_id":"397f94c73bbfac121960d551fdb0a6877a6b6171"}]}