)]}'
{"swift/account/backend.py":[{"author":{"_account_id":1216,"name":"gholt","email":"z-launchpad@brim.net","username":"gholt"},"change_message_id":"77eb8b09654af47f5c8d463d9beaeff32da83a22","unresolved":false,"context_lines":[{"line_number":88,"context_line":"                object_count INTEGER,"},{"line_number":89,"context_line":"                bytes_used INTEGER,"},{"line_number":90,"context_line":"                deleted INTEGER DEFAULT 0,"},{"line_number":91,"context_line":"                storage_policy_index INTEGER"},{"line_number":92,"context_line":"            );"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"            CREATE INDEX ix_container_deleted_name ON"}],"source_content_type":"text/x-python","patch_set":9,"id":"1ae5cdf2_ef2f7b3c","line":91,"updated":"2014-06-10 19:22:23.000000000","message":"I might\u0027ve missed some discussion but this should probably have a DEFAULT 0","commit_id":"68923ce015890632faec3c24e4fd1ab9948fb9f1"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"a17b0a740d459aa1758456b095e30b7d26c20234","unresolved":false,"context_lines":[{"line_number":88,"context_line":"                object_count INTEGER,"},{"line_number":89,"context_line":"                bytes_used INTEGER,"},{"line_number":90,"context_line":"                deleted INTEGER DEFAULT 0,"},{"line_number":91,"context_line":"                storage_policy_index INTEGER"},{"line_number":92,"context_line":"            );"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"            CREATE INDEX ix_container_deleted_name ON"}],"source_content_type":"text/x-python","patch_set":9,"id":"1ae5cdf2_457afe24","line":91,"in_reply_to":"1ae5cdf2_ef2f7b3c","updated":"2014-06-11 08:16:46.000000000","message":"Done","commit_id":"68923ce015890632faec3c24e4fd1ab9948fb9f1"}],"test/unit/account/test_backend.py":[{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"f00cb9eb1e7bebad5310649736503bb48d2a7045","unresolved":false,"context_lines":[{"line_number":757,"context_line":""},{"line_number":758,"context_line":"def prespi_create_container_table(self, conn):"},{"line_number":759,"context_line":"    \"\"\""},{"line_number":760,"context_line":"    Copied from AccountBroker before the sstoage_policy_index column was"},{"line_number":761,"context_line":"    added; used for testing with TestAccountBrokerBeforeSPI."},{"line_number":762,"context_line":""},{"line_number":763,"context_line":"    Create container table which is specific to the account DB."}],"source_content_type":"text/x-python","patch_set":14,"id":"1ae5cdf2_e3390fd9","line":760,"updated":"2014-06-19 16:16:49.000000000","message":"nit: s/sstoage/storage/","commit_id":"00a162c4d42a0f7813058d2ae5c3208b4f7a3157"}],"test/unit/account/test_replicator.py":[{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"2f188157c4c5a40b33dc339a9254230f9895b8a9","unresolved":false,"context_lines":[{"line_number":53,"context_line":"        daemon \u003d self._run_once(node)"},{"line_number":54,"context_line":"        # complete rsync"},{"line_number":55,"context_line":"        self.assertEqual(2, daemon.stats[\u0027rsync\u0027])"},{"line_number":56,"context_line":"        local_info \u003d self._get_broker("},{"line_number":57,"context_line":"            \u0027a\u0027, node_index\u003d0).get_info()"},{"line_number":58,"context_line":"        for i in range(1, 3):"},{"line_number":59,"context_line":"            remote_broker \u003d self._get_broker(\u0027a\u0027, node_index\u003di)"}],"source_content_type":"text/x-python","patch_set":13,"id":"1ae5cdf2_1937764e","line":56,"updated":"2014-06-18 17:04:37.000000000","message":"nit: could use broker.get_info(), unless i\u0027m missing a subtlety in _get_broker()","commit_id":"e1f2eb9ac55ec8aecd6e579407a6f299b198f3e3"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"958de7fcdbba3be698d69f9cdeef1e05495f5aae","unresolved":false,"context_lines":[{"line_number":53,"context_line":"        daemon \u003d self._run_once(node)"},{"line_number":54,"context_line":"        # complete rsync"},{"line_number":55,"context_line":"        self.assertEqual(2, daemon.stats[\u0027rsync\u0027])"},{"line_number":56,"context_line":"        local_info \u003d self._get_broker("},{"line_number":57,"context_line":"            \u0027a\u0027, node_index\u003d0).get_info()"},{"line_number":58,"context_line":"        for i in range(1, 3):"},{"line_number":59,"context_line":"            remote_broker \u003d self._get_broker(\u0027a\u0027, node_index\u003di)"}],"source_content_type":"text/x-python","patch_set":13,"id":"1ae5cdf2_63889f22","line":56,"in_reply_to":"1ae5cdf2_0ca8118b","updated":"2014-06-19 15:57:16.000000000","message":"duh, of course. sorry!","commit_id":"e1f2eb9ac55ec8aecd6e579407a6f299b198f3e3"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"71e0a88b9dd71cb98b98e7a0a3de617f9fe82a59","unresolved":false,"context_lines":[{"line_number":53,"context_line":"        daemon \u003d self._run_once(node)"},{"line_number":54,"context_line":"        # complete rsync"},{"line_number":55,"context_line":"        self.assertEqual(2, daemon.stats[\u0027rsync\u0027])"},{"line_number":56,"context_line":"        local_info \u003d self._get_broker("},{"line_number":57,"context_line":"            \u0027a\u0027, node_index\u003d0).get_info()"},{"line_number":58,"context_line":"        for i in range(1, 3):"},{"line_number":59,"context_line":"            remote_broker \u003d self._get_broker(\u0027a\u0027, node_index\u003di)"}],"source_content_type":"text/x-python","patch_set":13,"id":"1ae5cdf2_0ca8118b","line":56,"in_reply_to":"1ae5cdf2_1937764e","updated":"2014-06-18 19:11:17.000000000","message":"yeah when the rsync kicks in the reference is stale.","commit_id":"e1f2eb9ac55ec8aecd6e579407a6f299b198f3e3"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"2f188157c4c5a40b33dc339a9254230f9895b8a9","unresolved":false,"context_lines":[{"line_number":92,"context_line":"        self.assertTrue(success)"},{"line_number":93,"context_line":"        # row merge"},{"line_number":94,"context_line":"        self.assertEqual(1, daemon.stats[\u0027remote_merge\u0027])"},{"line_number":95,"context_line":"        local_info \u003d self._get_broker("},{"line_number":96,"context_line":"            \u0027a\u0027, node_index\u003d0).get_info()"},{"line_number":97,"context_line":"        remote_info \u003d self._get_broker("},{"line_number":98,"context_line":"            \u0027a\u0027, node_index\u003d1).get_info()"}],"source_content_type":"text/x-python","patch_set":13,"id":"1ae5cdf2_1984d609","line":95,"updated":"2014-06-18 17:04:37.000000000","message":"nit: could re-use \u0027broker\u0027 variable: broker.get_info()","commit_id":"e1f2eb9ac55ec8aecd6e579407a6f299b198f3e3"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"71e0a88b9dd71cb98b98e7a0a3de617f9fe82a59","unresolved":false,"context_lines":[{"line_number":92,"context_line":"        self.assertTrue(success)"},{"line_number":93,"context_line":"        # row merge"},{"line_number":94,"context_line":"        self.assertEqual(1, daemon.stats[\u0027remote_merge\u0027])"},{"line_number":95,"context_line":"        local_info \u003d self._get_broker("},{"line_number":96,"context_line":"            \u0027a\u0027, node_index\u003d0).get_info()"},{"line_number":97,"context_line":"        remote_info \u003d self._get_broker("},{"line_number":98,"context_line":"            \u0027a\u0027, node_index\u003d1).get_info()"}],"source_content_type":"text/x-python","patch_set":13,"id":"1ae5cdf2_ac89dd70","line":95,"in_reply_to":"1ae5cdf2_1984d609","updated":"2014-06-18 19:11:17.000000000","message":"you can\u0027t if there was an rsync involved - which I think may have been the case here.  Either way it\u0027s always safe to call _get_broker again.","commit_id":"e1f2eb9ac55ec8aecd6e579407a6f299b198f3e3"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"2f188157c4c5a40b33dc339a9254230f9895b8a9","unresolved":false,"context_lines":[{"line_number":94,"context_line":"        self.assertEqual(1, daemon.stats[\u0027remote_merge\u0027])"},{"line_number":95,"context_line":"        local_info \u003d self._get_broker("},{"line_number":96,"context_line":"            \u0027a\u0027, node_index\u003d0).get_info()"},{"line_number":97,"context_line":"        remote_info \u003d self._get_broker("},{"line_number":98,"context_line":"            \u0027a\u0027, node_index\u003d1).get_info()"},{"line_number":99,"context_line":"        for k, v in local_info.items():"},{"line_number":100,"context_line":"            if k \u003d\u003d \u0027id\u0027:"}],"source_content_type":"text/x-python","patch_set":13,"id":"1ae5cdf2_79a95a7b","line":97,"updated":"2014-06-18 17:04:37.000000000","message":"nit, ditto , remote_broker.get_info()","commit_id":"e1f2eb9ac55ec8aecd6e579407a6f299b198f3e3"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"71e0a88b9dd71cb98b98e7a0a3de617f9fe82a59","unresolved":false,"context_lines":[{"line_number":94,"context_line":"        self.assertEqual(1, daemon.stats[\u0027remote_merge\u0027])"},{"line_number":95,"context_line":"        local_info \u003d self._get_broker("},{"line_number":96,"context_line":"            \u0027a\u0027, node_index\u003d0).get_info()"},{"line_number":97,"context_line":"        remote_info \u003d self._get_broker("},{"line_number":98,"context_line":"            \u0027a\u0027, node_index\u003d1).get_info()"},{"line_number":99,"context_line":"        for k, v in local_info.items():"},{"line_number":100,"context_line":"            if k \u003d\u003d \u0027id\u0027:"}],"source_content_type":"text/x-python","patch_set":13,"id":"1ae5cdf2_2cf5cdec","line":97,"in_reply_to":"1ae5cdf2_79a95a7b","updated":"2014-06-18 19:11:17.000000000","message":"ditto.","commit_id":"e1f2eb9ac55ec8aecd6e579407a6f299b198f3e3"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"2f188157c4c5a40b33dc339a9254230f9895b8a9","unresolved":false,"context_lines":[{"line_number":129,"context_line":"        self.assertTrue(success)"},{"line_number":130,"context_line":"        # row merge"},{"line_number":131,"context_line":"        self.assertEqual(1, daemon.stats[\u0027diff\u0027])"},{"line_number":132,"context_line":"        local_info \u003d self._get_broker("},{"line_number":133,"context_line":"            \u0027a\u0027, node_index\u003d0).get_info()"},{"line_number":134,"context_line":"        remote_info \u003d self._get_broker("},{"line_number":135,"context_line":"            \u0027a\u0027, node_index\u003d1).get_info()"}],"source_content_type":"text/x-python","patch_set":13,"id":"1ae5cdf2_79731a16","line":132,"updated":"2014-06-18 17:04:37.000000000","message":"ditto","commit_id":"e1f2eb9ac55ec8aecd6e579407a6f299b198f3e3"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"71e0a88b9dd71cb98b98e7a0a3de617f9fe82a59","unresolved":false,"context_lines":[{"line_number":129,"context_line":"        self.assertTrue(success)"},{"line_number":130,"context_line":"        # row merge"},{"line_number":131,"context_line":"        self.assertEqual(1, daemon.stats[\u0027diff\u0027])"},{"line_number":132,"context_line":"        local_info \u003d self._get_broker("},{"line_number":133,"context_line":"            \u0027a\u0027, node_index\u003d0).get_info()"},{"line_number":134,"context_line":"        remote_info \u003d self._get_broker("},{"line_number":135,"context_line":"            \u0027a\u0027, node_index\u003d1).get_info()"}],"source_content_type":"text/x-python","patch_set":13,"id":"1ae5cdf2_ace0fd26","line":132,"in_reply_to":"1ae5cdf2_79731a16","updated":"2014-06-18 19:11:17.000000000","message":"so here it probably is safe to reuse the existing broker - but for consistency and maintainability it turned out for me when working on these tests to better to just always use the helper method.  When you have a broker and you don\u0027t get the info in hand because the file-handle got wonkied about by the rsync business it\u0027s sorta inscrutable.  Better the next guy to copy one of these tests just use the helper and stave off all that noise.","commit_id":"e1f2eb9ac55ec8aecd6e579407a6f299b198f3e3"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"958de7fcdbba3be698d69f9cdeef1e05495f5aae","unresolved":false,"context_lines":[{"line_number":129,"context_line":"        self.assertTrue(success)"},{"line_number":130,"context_line":"        # row merge"},{"line_number":131,"context_line":"        self.assertEqual(1, daemon.stats[\u0027diff\u0027])"},{"line_number":132,"context_line":"        local_info \u003d self._get_broker("},{"line_number":133,"context_line":"            \u0027a\u0027, node_index\u003d0).get_info()"},{"line_number":134,"context_line":"        remote_info \u003d self._get_broker("},{"line_number":135,"context_line":"            \u0027a\u0027, node_index\u003d1).get_info()"}],"source_content_type":"text/x-python","patch_set":13,"id":"1ae5cdf2_239bf773","line":132,"in_reply_to":"1ae5cdf2_ace0fd26","updated":"2014-06-19 15:57:16.000000000","message":"yes, agreed.","commit_id":"e1f2eb9ac55ec8aecd6e579407a6f299b198f3e3"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"2f188157c4c5a40b33dc339a9254230f9895b8a9","unresolved":false,"context_lines":[{"line_number":131,"context_line":"        self.assertEqual(1, daemon.stats[\u0027diff\u0027])"},{"line_number":132,"context_line":"        local_info \u003d self._get_broker("},{"line_number":133,"context_line":"            \u0027a\u0027, node_index\u003d0).get_info()"},{"line_number":134,"context_line":"        remote_info \u003d self._get_broker("},{"line_number":135,"context_line":"            \u0027a\u0027, node_index\u003d1).get_info()"},{"line_number":136,"context_line":"        for k, v in local_info.items():"},{"line_number":137,"context_line":"            if k \u003d\u003d \u0027id\u0027:"}],"source_content_type":"text/x-python","patch_set":13,"id":"1ae5cdf2_d9650e46","line":134,"updated":"2014-06-18 17:04:37.000000000","message":"ditto","commit_id":"e1f2eb9ac55ec8aecd6e579407a6f299b198f3e3"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"71e0a88b9dd71cb98b98e7a0a3de617f9fe82a59","unresolved":false,"context_lines":[{"line_number":131,"context_line":"        self.assertEqual(1, daemon.stats[\u0027diff\u0027])"},{"line_number":132,"context_line":"        local_info \u003d self._get_broker("},{"line_number":133,"context_line":"            \u0027a\u0027, node_index\u003d0).get_info()"},{"line_number":134,"context_line":"        remote_info \u003d self._get_broker("},{"line_number":135,"context_line":"            \u0027a\u0027, node_index\u003d1).get_info()"},{"line_number":136,"context_line":"        for k, v in local_info.items():"},{"line_number":137,"context_line":"            if k \u003d\u003d \u0027id\u0027:"}],"source_content_type":"text/x-python","patch_set":13,"id":"1ae5cdf2_ecd5a543","line":134,"in_reply_to":"1ae5cdf2_d9650e46","updated":"2014-06-18 19:11:17.000000000","message":"ditto.","commit_id":"e1f2eb9ac55ec8aecd6e579407a6f299b198f3e3"}],"test/unit/account/test_server.py":[{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"2f188157c4c5a40b33dc339a9254230f9895b8a9","unresolved":false,"context_lines":[{"line_number":1824,"context_line":"        # check container counts in roll up headers"},{"line_number":1825,"context_line":"        total_object_count \u003d 0"},{"line_number":1826,"context_line":"        total_bytes_used \u003d 0"},{"line_number":1827,"context_line":"        print repr(resp.headers)"},{"line_number":1828,"context_line":"        for key in resp.headers:"},{"line_number":1829,"context_line":"            if \u0027storage-policy\u0027 not in key.lower():"},{"line_number":1830,"context_line":"                continue"}],"source_content_type":"text/x-python","patch_set":13,"id":"1ae5cdf2_de36d402","line":1827,"updated":"2014-06-18 17:04:37.000000000","message":"leftover print","commit_id":"e1f2eb9ac55ec8aecd6e579407a6f299b198f3e3"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"71e0a88b9dd71cb98b98e7a0a3de617f9fe82a59","unresolved":false,"context_lines":[{"line_number":1824,"context_line":"        # check container counts in roll up headers"},{"line_number":1825,"context_line":"        total_object_count \u003d 0"},{"line_number":1826,"context_line":"        total_bytes_used \u003d 0"},{"line_number":1827,"context_line":"        print repr(resp.headers)"},{"line_number":1828,"context_line":"        for key in resp.headers:"},{"line_number":1829,"context_line":"            if \u0027storage-policy\u0027 not in key.lower():"},{"line_number":1830,"context_line":"                continue"}],"source_content_type":"text/x-python","patch_set":13,"id":"1ae5cdf2_0cdad14a","line":1827,"in_reply_to":"1ae5cdf2_de36d402","updated":"2014-06-18 19:11:17.000000000","message":"Done","commit_id":"e1f2eb9ac55ec8aecd6e579407a6f299b198f3e3"}]}
