)]}'
{"swift/cli/recon.py":[{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"c4bf5e6306d2c9b5f26003cdc6522d646204a8a0","unresolved":false,"context_lines":[{"line_number":198,"context_line":""},{"line_number":199,"context_line":"        :param hosts: set of hosts to check. in the format of:"},{"line_number":200,"context_line":"            set([(\u0027127.0.0.1\u0027, 6020), (\u0027127.0.0.2\u0027, 6030)])"},{"line_number":201,"context_line":"        :param ringfile: The local ring file to compare the md5sum with."},{"line_number":202,"context_line":"        \"\"\""},{"line_number":203,"context_line":"        matches \u003d 0"},{"line_number":204,"context_line":"        errors \u003d 0"}],"source_content_type":"text/x-python","patch_set":6,"id":"1ae5cdf2_9c03bc0c","line":201,"updated":"2014-06-01 23:08:38.000000000","message":"You\u0027ve changed the parameter from ringfile to swift_dir, but haven\u0027t updated the doc string.","commit_id":"ffeb8d864f6e49e392804c42af2ac68a892c8156"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"1ed1fb42e1389837a3a4c15505339b188fe76c43","unresolved":false,"context_lines":[{"line_number":198,"context_line":""},{"line_number":199,"context_line":"        :param hosts: set of hosts to check. in the format of:"},{"line_number":200,"context_line":"            set([(\u0027127.0.0.1\u0027, 6020), (\u0027127.0.0.2\u0027, 6030)])"},{"line_number":201,"context_line":"        :param ringfile: The local ring file to compare the md5sum with."},{"line_number":202,"context_line":"        \"\"\""},{"line_number":203,"context_line":"        matches \u003d 0"},{"line_number":204,"context_line":"        errors \u003d 0"}],"source_content_type":"text/x-python","patch_set":6,"id":"1ae5cdf2_dde36731","line":201,"in_reply_to":"1ae5cdf2_9c03bc0c","updated":"2014-06-02 18:17:44.000000000","message":"Done","commit_id":"ffeb8d864f6e49e392804c42af2ac68a892c8156"},{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"c4bf5e6306d2c9b5f26003cdc6522d646204a8a0","unresolved":false,"context_lines":[{"line_number":226,"context_line":"        print(\"[%s] Checking ring md5sums\" % self._ptime())"},{"line_number":227,"context_line":"        if self.verbose:"},{"line_number":228,"context_line":"            for ring_file, ring_sum in rings.items():"},{"line_number":229,"context_line":"                print(\"-\u003e On disk %s md5sum: %s\" % (ring_file, ring_sum))"},{"line_number":230,"context_line":"        for url, response, status in self.pool.imap(recon.scout, hosts):"},{"line_number":231,"context_line":"            if status !\u003d 200:"},{"line_number":232,"context_line":"                errors \u003d errors + 1"}],"source_content_type":"text/x-python","patch_set":6,"id":"1ae5cdf2_bc0a381f","line":229,"updated":"2014-06-01 23:08:38.000000000","message":"Should these we printed or logged to a file?","commit_id":"ffeb8d864f6e49e392804c42af2ac68a892c8156"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"1ed1fb42e1389837a3a4c15505339b188fe76c43","unresolved":false,"context_lines":[{"line_number":226,"context_line":"        print(\"[%s] Checking ring md5sums\" % self._ptime())"},{"line_number":227,"context_line":"        if self.verbose:"},{"line_number":228,"context_line":"            for ring_file, ring_sum in rings.items():"},{"line_number":229,"context_line":"                print(\"-\u003e On disk %s md5sum: %s\" % (ring_file, ring_sum))"},{"line_number":230,"context_line":"        for url, response, status in self.pool.imap(recon.scout, hosts):"},{"line_number":231,"context_line":"            if status !\u003d 200:"},{"line_number":232,"context_line":"                errors \u003d errors + 1"}],"source_content_type":"text/x-python","patch_set":6,"id":"1ae5cdf2_bde85b11","line":229,"in_reply_to":"1ae5cdf2_bc0a381f","updated":"2014-06-02 18:17:44.000000000","message":"it\u0027s an interactive tool, so - no?","commit_id":"ffeb8d864f6e49e392804c42af2ac68a892c8156"},{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"c1c56b166c346abf4712fdefee2cc3b9c9b65786","unresolved":false,"context_lines":[{"line_number":226,"context_line":"        print(\"[%s] Checking ring md5sums\" % self._ptime())"},{"line_number":227,"context_line":"        if self.verbose:"},{"line_number":228,"context_line":"            for ring_file, ring_sum in rings.items():"},{"line_number":229,"context_line":"                print(\"-\u003e On disk %s md5sum: %s\" % (ring_file, ring_sum))"},{"line_number":230,"context_line":"        for url, response, status in self.pool.imap(recon.scout, hosts):"},{"line_number":231,"context_line":"            if status !\u003d 200:"},{"line_number":232,"context_line":"                errors \u003d errors + 1"}],"source_content_type":"text/x-python","patch_set":6,"id":"1ae5cdf2_caff12a9","line":229,"in_reply_to":"1ae5cdf2_bde85b11","updated":"2014-06-03 01:08:41.000000000","message":"Oh, yeah good point, sorry about that!","commit_id":"ffeb8d864f6e49e392804c42af2ac68a892c8156"},{"author":{"_account_id":1216,"name":"gholt","email":"z-launchpad@brim.net","username":"gholt"},"change_message_id":"fc144ffc8165d0eb986c1ac27685e7d42d64dee8","unresolved":false,"context_lines":[{"line_number":192,"context_line":"            ips \u003d set((n[\u0027ip\u0027], n[\u0027port\u0027]) for n in ring_data.devs if n)"},{"line_number":193,"context_line":"        return ips"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"    def get_ringmd5(self, hosts, swift_dir):"},{"line_number":196,"context_line":"        \"\"\""},{"line_number":197,"context_line":"        Compare ring md5sum\u0027s with those on remote host"},{"line_number":198,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"1ae5cdf2_748e932f","line":195,"updated":"2014-06-12 16:12:45.000000000","message":"This seems to have changed behavior? Now it always checks all rings?","commit_id":"2d9e41b74139766f98ff271f48123940ad430dca"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"ea2b1416c7504c9a9a8f30d7b6022f3ba46440ad","unresolved":false,"context_lines":[{"line_number":192,"context_line":"            ips \u003d set((n[\u0027ip\u0027], n[\u0027port\u0027]) for n in ring_data.devs if n)"},{"line_number":193,"context_line":"        return ips"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"    def get_ringmd5(self, hosts, swift_dir):"},{"line_number":196,"context_line":"        \"\"\""},{"line_number":197,"context_line":"        Compare ring md5sum\u0027s with those on remote host"},{"line_number":198,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"1ae5cdf2_de94ca38","line":195,"in_reply_to":"1ae5cdf2_748e932f","updated":"2014-06-13 17:50:39.000000000","message":"Yeah, the api always responded with all the rings, so now the cli tool just uses all the data it gets back.  \n\nThe cli tooling has all that infrastructure around server_type, for some reason it seemed to make more sense at the time to just make all the server_types check all of the rings form the servers they get responses from than to special case the object server type.\n\nI made a note of the change in the commit message - do you think it\u0027s a problem?  Should I check with pandemicsyn?","commit_id":"2d9e41b74139766f98ff271f48123940ad430dca"},{"author":{"_account_id":1216,"name":"gholt","email":"z-launchpad@brim.net","username":"gholt"},"change_message_id":"95bff85ce4571fac9cd044eaed40f118ccc8b0f0","unresolved":false,"context_lines":[{"line_number":192,"context_line":"            ips \u003d set((n[\u0027ip\u0027], n[\u0027port\u0027]) for n in ring_data.devs if n)"},{"line_number":193,"context_line":"        return ips"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"    def get_ringmd5(self, hosts, swift_dir):"},{"line_number":196,"context_line":"        \"\"\""},{"line_number":197,"context_line":"        Compare ring md5sum\u0027s with those on remote host"},{"line_number":198,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"1ae5cdf2_1cf54d82","line":195,"in_reply_to":"1ae5cdf2_de94ca38","updated":"2014-06-13 17:57:21.000000000","message":"I don\u0027t think it\u0027s a big deal; it does report which ring is busted if any are. I\u0027ll try and ask Florian when I see him next to be sure.","commit_id":"2d9e41b74139766f98ff271f48123940ad430dca"}],"test/unit/common/middleware/test_list_endpoints.py":[{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"c4bf5e6306d2c9b5f26003cdc6522d646204a8a0","unresolved":false,"context_lines":[{"line_number":232,"context_line":"            self.assertEquals(resp.content_type, \u0027application/json\u0027)"},{"line_number":233,"context_line":"            self.assertEquals(json.loads(resp.body), expected[pol.idx])"},{"line_number":234,"context_line":""},{"line_number":235,"context_line":"            # test custom path without trailing slash"},{"line_number":236,"context_line":"            custom_path_le \u003d list_endpoints.filter_factory({"},{"line_number":237,"context_line":"                \u0027swift_dir\u0027: self.testdir,"},{"line_number":238,"context_line":"                \u0027list_endpoints_path\u0027: \u0027/some/another/path\u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"1ae5cdf2_3c3548da","line":235,"updated":"2014-06-01 23:08:38.000000000","message":"This isn\u0027t really related to this change, so in theory should be a part of a different change, but hey, it\u0027s one character, so nice spot :)","commit_id":"ffeb8d864f6e49e392804c42af2ac68a892c8156"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"1ed1fb42e1389837a3a4c15505339b188fe76c43","unresolved":false,"context_lines":[{"line_number":232,"context_line":"            self.assertEquals(resp.content_type, \u0027application/json\u0027)"},{"line_number":233,"context_line":"            self.assertEquals(json.loads(resp.body), expected[pol.idx])"},{"line_number":234,"context_line":""},{"line_number":235,"context_line":"            # test custom path without trailing slash"},{"line_number":236,"context_line":"            custom_path_le \u003d list_endpoints.filter_factory({"},{"line_number":237,"context_line":"                \u0027swift_dir\u0027: self.testdir,"},{"line_number":238,"context_line":"                \u0027list_endpoints_path\u0027: \u0027/some/another/path\u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"1ae5cdf2_60038c73","line":235,"in_reply_to":"1ae5cdf2_3c3548da","updated":"2014-06-02 18:17:44.000000000","message":"Done","commit_id":"ffeb8d864f6e49e392804c42af2ac68a892c8156"}]}
