)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"161622b6d4c1101883b9526e02d56079bef970e2","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Christian Ohanaja \u003ccohanaja@nvidia.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2025-09-29 08:49:10 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"replaces --force-commits flag (should be default true) with a --skip-commits flag to determine when to commit object updates in smsr"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I6de041f5c12dca2618d22d1271efe242b2f35258"},{"line_number":10,"context_line":"Signed-off-by: Christian Ohanaja \u003ccohanaja@nvidia.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"a0f90f73_463bd280","line":7,"updated":"2025-09-29 19:10:28.000000000","message":"Please wrap commit message body line messages at 72 chars per the Opendev commit message guidelines\n\nhttps://wiki.openstack.org/wiki/GitCommitMessages#Summary_of_Git_commit_message_structure","commit_id":"487aa80254273d2ca33bdabfc748a402e89eb1e6"},{"author":{"_account_id":38368,"name":"Christian Ohanaja","display_name":"Christian Ohanaja","email":"cohanaja@nvidia.com","username":"cohanaja"},"change_message_id":"b981531502a4c7a8e5a0d4532e61d91cfa8ccb38","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Christian Ohanaja \u003ccohanaja@nvidia.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2025-09-29 08:49:10 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"replaces --force-commits flag (should be default true) with a --skip-commits flag to determine when to commit object updates in smsr"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I6de041f5c12dca2618d22d1271efe242b2f35258"},{"line_number":10,"context_line":"Signed-off-by: Christian Ohanaja \u003ccohanaja@nvidia.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"2d33744c_11c1c459","line":7,"in_reply_to":"a0f90f73_463bd280","updated":"2025-09-30 00:03:58.000000000","message":"Done","commit_id":"487aa80254273d2ca33bdabfc748a402e89eb1e6"},{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"baf6fcd7081d29beb5ba0175f4749b34ddcd22a2","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Christian Ohanaja \u003ccohanaja@nvidia.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2025-09-29 23:55:00 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"replaces --force-commits with a --skip-commits flag to determine when to"},{"line_number":8,"context_line":"commit object updates in smsr"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"Change-Id: I6de041f5c12dca2618d22d1271efe242b2f35258"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"a8ffa4d8_fc3e2be4","line":7,"updated":"2025-09-30 04:20:43.000000000","message":"An openstack commit message should take the form of: https://wiki.openstack.org/wiki/GitCommitMessages#Summary_of_Git_commit_message_structure\n\nSo the first line should only be about 50 chars and a summary.  So maybe something like:\n\n```\nReplace --force-commits in s-m-s-r                                                                            \n                                                                                                              \nThis patch replaces --force-commits with a --skip-commits flag in                                             \nswift-manage-shard-ranges to determine when to commit object updates.\n```","commit_id":"7708bb388c19d6999391d03020d5ea71ae4f9151"},{"author":{"_account_id":38368,"name":"Christian Ohanaja","display_name":"Christian Ohanaja","email":"cohanaja@nvidia.com","username":"cohanaja"},"change_message_id":"2a55b8d84ffac82baf8e8aace28126c9f5c589b5","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Christian Ohanaja \u003ccohanaja@nvidia.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2025-09-29 23:55:00 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"replaces --force-commits with a --skip-commits flag to determine when to"},{"line_number":8,"context_line":"commit object updates in smsr"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"Change-Id: I6de041f5c12dca2618d22d1271efe242b2f35258"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"604bde63_3b0e92da","line":7,"in_reply_to":"a8ffa4d8_fc3e2be4","updated":"2025-09-30 05:45:44.000000000","message":"Done","commit_id":"7708bb388c19d6999391d03020d5ea71ae4f9151"},{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"99b3d29a8f6fc46fb278745bb5a423c178b93530","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Christian Ohanaja \u003ccohanaja@nvidia.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2025-09-30 05:44:55 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Adds --skip-commits to s-m-s-r                                                                            "},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch replaces --force-commits with a --skip-commits flag in                                             "},{"line_number":10,"context_line":"swift-manage-shard-ranges to determine when to commit object updates."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"ef0eee45_24a2b1dc","line":7,"updated":"2025-09-30 07:04:34.000000000","message":"We seem to have some line ending issues here. But othewise, much better :)","commit_id":"2ac47fba2fb43db389f6cf7b4da90e7aa6d89b3a"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"d33c1f3f93612040f5c190586a8258118ff8bf4e","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Christian Ohanaja \u003ccohanaja@nvidia.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2025-09-30 05:44:55 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Adds --skip-commits to s-m-s-r                                                                            "},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch replaces --force-commits with a --skip-commits flag in                                             "},{"line_number":10,"context_line":"swift-manage-shard-ranges to determine when to commit object updates."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"9fed87d6_1dac0444","line":7,"in_reply_to":"ef0eee45_24a2b1dc","updated":"2025-09-30 16:25:42.000000000","message":"\u003e If you can avoid ever having to ask someone to change a commit message you will find yourself an amazingly happier and more productive reviewer.\n\nhttps://docs.openstack.org/swift/latest/contributor/review_guidelines.html#commit-messages","commit_id":"2ac47fba2fb43db389f6cf7b4da90e7aa6d89b3a"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":38368,"name":"Christian Ohanaja","display_name":"Christian Ohanaja","email":"cohanaja@nvidia.com","username":"cohanaja"},"change_message_id":"7bcb9e5c6fb002a16ae9299b302dcf8e5a97dc27","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"1891e888_8af48bcb","updated":"2025-09-29 16:29:29.000000000","message":"recheck","commit_id":"487aa80254273d2ca33bdabfc748a402e89eb1e6"},{"author":{"_account_id":38368,"name":"Christian Ohanaja","display_name":"Christian Ohanaja","email":"cohanaja@nvidia.com","username":"cohanaja"},"change_message_id":"30a9d143ffdef6fce614a1bab28dcf056fc94347","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"e2535166_35326d37","updated":"2025-09-29 16:30:50.000000000","message":"recheck","commit_id":"487aa80254273d2ca33bdabfc748a402e89eb1e6"},{"author":{"_account_id":38368,"name":"Christian Ohanaja","display_name":"Christian Ohanaja","email":"cohanaja@nvidia.com","username":"cohanaja"},"change_message_id":"b981531502a4c7a8e5a0d4532e61d91cfa8ccb38","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"58451d5f_d391ca7d","in_reply_to":"e2535166_35326d37","updated":"2025-09-30 00:03:58.000000000","message":"Done","commit_id":"487aa80254273d2ca33bdabfc748a402e89eb1e6"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"161622b6d4c1101883b9526e02d56079bef970e2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"51f322ca_d96097fa","updated":"2025-09-29 19:10:28.000000000","message":"This is probably sufficient.  I think if it merged as-is swift would be better.\n\nHowever, I would suggest some unittests could help make this change more obvious AND more maintainable.  Please consider this advice form the swift review guidelines \n\n\u003e Even if a change has to “fix” a lot of existing tests, if a change does not include any new tests it probably should not merge.\n\nhttps://docs.openstack.org/swift/latest/contributor/review_guidelines.html#new-tests\n\nPlease consider if you find these tests helpful and if so maybe squash in something like them or expand on them:\n\n962542: sq: better argparse? | https://review.opendev.org/c/openstack/swift/+/962542\n\nPlease note that as you work on changes to swift and ask them to be reviewed you\u0027ll notice this project takes testing very seriously.  It\u0027s a great opportunity for you to improve your familiarity with python testing patterns as well as provide yourself with a forum for considering if you\u0027ve really implemented all of the behaviors you would like to see maintained!","commit_id":"70329f628322fcd359f41f058d502f1d183a4284"},{"author":{"_account_id":38368,"name":"Christian Ohanaja","display_name":"Christian Ohanaja","email":"cohanaja@nvidia.com","username":"cohanaja"},"change_message_id":"367b0a1b99f0fe345e2bf53d91548c4bfeddede6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"def3a1e6_6b0189f4","updated":"2025-09-29 18:11:01.000000000","message":"Zuul is happy\nDoes everything look good in regards to \"removing\" the force-commits flag? It\u0027s still functional and in place for backwards compat as asked but I also made it hidden from the help section since it\u0027s always True by default anyway","commit_id":"70329f628322fcd359f41f058d502f1d183a4284"},{"author":{"_account_id":38368,"name":"Christian Ohanaja","display_name":"Christian Ohanaja","email":"cohanaja@nvidia.com","username":"cohanaja"},"change_message_id":"8c8e2edec09717c7be23aa51550edccfa10348bf","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"a140bf43_c2d3e6d8","updated":"2025-09-29 16:45:11.000000000","message":"recheck","commit_id":"70329f628322fcd359f41f058d502f1d183a4284"},{"author":{"_account_id":38368,"name":"Christian Ohanaja","display_name":"Christian Ohanaja","email":"cohanaja@nvidia.com","username":"cohanaja"},"change_message_id":"b981531502a4c7a8e5a0d4532e61d91cfa8ccb38","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"b4bd5b9d_4600f401","in_reply_to":"a140bf43_c2d3e6d8","updated":"2025-09-30 00:03:58.000000000","message":"Done","commit_id":"70329f628322fcd359f41f058d502f1d183a4284"},{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"baf6fcd7081d29beb5ba0175f4749b34ddcd22a2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"8fbbd8b3_ccbcbb5e","updated":"2025-09-30 04:20:43.000000000","message":"It\u0027s looking great Christian! We are a little strict on the commit messages upstream and some other comments inline.","commit_id":"7708bb388c19d6999391d03020d5ea71ae4f9151"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"d33c1f3f93612040f5c190586a8258118ff8bf4e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"90978c93_364ef622","updated":"2025-09-30 16:25:42.000000000","message":"agree, tests look great!  watch that trailing whitespace 👍","commit_id":"ba1ab9d11c27faa8607e42908949cfcd08eba5c7"}],"swift/cli/manage_shard_ranges.py":[{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"161622b6d4c1101883b9526e02d56079bef970e2","unresolved":true,"context_lines":[{"line_number":980,"context_line":"        help\u003dargparse.SUPPRESS)"},{"line_number":981,"context_line":"    # this is useful for probe tests that shard containers with unrealistically"},{"line_number":982,"context_line":"    # low numbers of objects, of which a significant proportion may still be in"},{"line_number":983,"context_line":"    # the pending file"},{"line_number":984,"context_line":"    parser.add_argument("},{"line_number":985,"context_line":"        \u0027--skip-commits\u0027, action\u003d\u0027store_true\u0027, dest\u003d\u0027skip_commits\u0027,"},{"line_number":986,"context_line":"        default\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":3,"id":"21213754_0328733a","line":983,"updated":"2025-09-29 19:10:28.000000000","message":"the `--skip-commits` option is NOT useful for probe tests?  The `--force-commits` option WAS - but now that\u0027s the default beavhior.  I think this comment is misplaced and misleading.\n\nPerhaps:\n\n```\nWe merge in the pending file by default, this is always correct and\nuseful for probe tests where shard containers have unrealistically low\nnumbers of objects, of which a significant proportion may still be in the\npending file.  If you have 10GB databases with 100M objects you can use\n--skip-commits and the selected shard ranges probably won\u0027t be that\ndifferent.  The --force-commits option is redundant and may be deprecated.\n```","commit_id":"70329f628322fcd359f41f058d502f1d183a4284"},{"author":{"_account_id":38368,"name":"Christian Ohanaja","display_name":"Christian Ohanaja","email":"cohanaja@nvidia.com","username":"cohanaja"},"change_message_id":"b981531502a4c7a8e5a0d4532e61d91cfa8ccb38","unresolved":false,"context_lines":[{"line_number":980,"context_line":"        help\u003dargparse.SUPPRESS)"},{"line_number":981,"context_line":"    # this is useful for probe tests that shard containers with unrealistically"},{"line_number":982,"context_line":"    # low numbers of objects, of which a significant proportion may still be in"},{"line_number":983,"context_line":"    # the pending file"},{"line_number":984,"context_line":"    parser.add_argument("},{"line_number":985,"context_line":"        \u0027--skip-commits\u0027, action\u003d\u0027store_true\u0027, dest\u003d\u0027skip_commits\u0027,"},{"line_number":986,"context_line":"        default\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":3,"id":"10f32208_4ca08a68","line":983,"in_reply_to":"21213754_0328733a","updated":"2025-09-30 00:03:58.000000000","message":"Done","commit_id":"70329f628322fcd359f41f058d502f1d183a4284"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"161622b6d4c1101883b9526e02d56079bef970e2","unresolved":true,"context_lines":[{"line_number":1191,"context_line":"    if args.skip_commits:"},{"line_number":1192,"context_line":"        should_skip_commits \u003d True"},{"line_number":1193,"context_line":"    if args.force_commits:"},{"line_number":1194,"context_line":"        should_skip_commits \u003d False"},{"line_number":1195,"context_line":""},{"line_number":1196,"context_line":"    logger \u003d get_logger({}, name\u003d\u0027ContainerBroker\u0027, log_to_console\u003dTrue)"},{"line_number":1197,"context_line":"    broker \u003d ContainerBroker(os.path.realpath(args.path_to_file),"}],"source_content_type":"text/x-python","patch_set":3,"id":"99389187_d65186be","line":1194,"updated":"2025-09-29 19:10:28.000000000","message":"I\u0027m not sure I understand the justification for this order of precedence - should we even allow a user to say --force-commits AND --skip-commits?\n\nif you type `import this` from any python repl you get back some good advice on this topic:\n\n\u003e In the face of ambiguity, refuse the temptation to guess.","commit_id":"70329f628322fcd359f41f058d502f1d183a4284"},{"author":{"_account_id":38368,"name":"Christian Ohanaja","display_name":"Christian Ohanaja","email":"cohanaja@nvidia.com","username":"cohanaja"},"change_message_id":"b981531502a4c7a8e5a0d4532e61d91cfa8ccb38","unresolved":false,"context_lines":[{"line_number":1191,"context_line":"    if args.skip_commits:"},{"line_number":1192,"context_line":"        should_skip_commits \u003d True"},{"line_number":1193,"context_line":"    if args.force_commits:"},{"line_number":1194,"context_line":"        should_skip_commits \u003d False"},{"line_number":1195,"context_line":""},{"line_number":1196,"context_line":"    logger \u003d get_logger({}, name\u003d\u0027ContainerBroker\u0027, log_to_console\u003dTrue)"},{"line_number":1197,"context_line":"    broker \u003d ContainerBroker(os.path.realpath(args.path_to_file),"}],"source_content_type":"text/x-python","patch_set":3,"id":"8a9f550c_20e66f67","line":1194,"in_reply_to":"99389187_d65186be","updated":"2025-09-30 00:03:58.000000000","message":"Acknowledged","commit_id":"70329f628322fcd359f41f058d502f1d183a4284"},{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"baf6fcd7081d29beb5ba0175f4749b34ddcd22a2","unresolved":true,"context_lines":[{"line_number":965,"context_line":"             \u0027 will commit pending object updates.\u0027)"},{"line_number":966,"context_line":"    group.add_argument("},{"line_number":967,"context_line":"        \u0027--force-commits\u0027, action\u003d\u0027store_true\u0027, dest\u003d\u0027force_commits\u0027,"},{"line_number":968,"context_line":"        default\u003dTrue,"},{"line_number":969,"context_line":"        help\u003dargparse.SUPPRESS)"},{"line_number":970,"context_line":""},{"line_number":971,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"f419e3a6_68724df8","line":968,"range":{"start_line":968,"start_character":8,"end_line":968,"end_character":20},"updated":"2025-09-30 04:20:43.000000000","message":"this used to default to False and now it defaults to True.\n\nBut maybe that doesn\u0027t matter because the variable in the namespace object isn\u0027t used.\n\nI assume you\u0027ve added it like this to make the `--force-commits` option backwards compat, but it isn\u0027t used, so all it\u0027ll do it not \"break\" old callers of the CLI when they call the option.. but now it doesn\u0027t do anything.\n\nBecause it\u0027s a mutually exclusive group, should be just point them to the same backend destination, so someone can use either the set and be truly backwards compat?\n\n```\ngroup.add_argument(\n        \u0027--force-commits\u0027, action\u003d\u0027store_false\u0027, dest\u003d\u0027skip_commits\u0027,\n        default\u003dargparse.SUPPRESS,  help\u003dargparse.SUPPRESS)\n```\n\nThen we should be able to just have skip_commits ever in the namespace which should simplify the tests (just change force_commits to skip_commits) BUT if someone using an old script that might call the old flag in s-m-s-r, it\u0027ll still work for them as expected.","commit_id":"7708bb388c19d6999391d03020d5ea71ae4f9151"},{"author":{"_account_id":38368,"name":"Christian Ohanaja","display_name":"Christian Ohanaja","email":"cohanaja@nvidia.com","username":"cohanaja"},"change_message_id":"2a55b8d84ffac82baf8e8aace28126c9f5c589b5","unresolved":false,"context_lines":[{"line_number":965,"context_line":"             \u0027 will commit pending object updates.\u0027)"},{"line_number":966,"context_line":"    group.add_argument("},{"line_number":967,"context_line":"        \u0027--force-commits\u0027, action\u003d\u0027store_true\u0027, dest\u003d\u0027force_commits\u0027,"},{"line_number":968,"context_line":"        default\u003dTrue,"},{"line_number":969,"context_line":"        help\u003dargparse.SUPPRESS)"},{"line_number":970,"context_line":""},{"line_number":971,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"f29d21ec_65c00bf7","line":968,"range":{"start_line":968,"start_character":8,"end_line":968,"end_character":20},"in_reply_to":"f419e3a6_68724df8","updated":"2025-09-30 05:45:44.000000000","message":"This worked beautifully actually, amazing suggestion. Didn\u0027t know you could suppress the values as well as the help","commit_id":"7708bb388c19d6999391d03020d5ea71ae4f9151"}],"test/unit/cli/test_manage_shard_ranges.py":[{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"161622b6d4c1101883b9526e02d56079bef970e2","unresolved":true,"context_lines":[{"line_number":161,"context_line":"                             rows_per_shard\u003d500000,"},{"line_number":162,"context_line":"                             subcommand\u003d\u0027find\u0027,"},{"line_number":163,"context_line":"                             force_commits\u003dTrue,"},{"line_number":164,"context_line":"                             skip_commits\u003dFalse,"},{"line_number":165,"context_line":"                             verbose\u003d0,"},{"line_number":166,"context_line":"                             minimum_shard_size\u003d100000)"},{"line_number":167,"context_line":"        mocked.assert_called_once_with(mock.ANY, expected)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9014c262_05b3c89d","line":164,"updated":"2025-09-29 19:10:28.000000000","message":"so the fact that we have two pieces of state to represent the same idea is a smell.","commit_id":"70329f628322fcd359f41f058d502f1d183a4284"},{"author":{"_account_id":38368,"name":"Christian Ohanaja","display_name":"Christian Ohanaja","email":"cohanaja@nvidia.com","username":"cohanaja"},"change_message_id":"b981531502a4c7a8e5a0d4532e61d91cfa8ccb38","unresolved":true,"context_lines":[{"line_number":161,"context_line":"                             rows_per_shard\u003d500000,"},{"line_number":162,"context_line":"                             subcommand\u003d\u0027find\u0027,"},{"line_number":163,"context_line":"                             force_commits\u003dTrue,"},{"line_number":164,"context_line":"                             skip_commits\u003dFalse,"},{"line_number":165,"context_line":"                             verbose\u003d0,"},{"line_number":166,"context_line":"                             minimum_shard_size\u003d100000)"},{"line_number":167,"context_line":"        mocked.assert_called_once_with(mock.ANY, expected)"}],"source_content_type":"text/x-python","patch_set":3,"id":"94bfa7eb_71467d78","line":164,"in_reply_to":"9014c262_05b3c89d","updated":"2025-09-30 00:03:58.000000000","message":"I messed around with this just a bit; what it seems like is because we want to keep force_commits around still, the default of True gets set during main in _make_parser()\n\nIt\u0027s a bit tricky: if I remove force_commits\u003dTrue from the tests they all fail since it\u0027s not in the expected call, but if I keep it in it\u0027s kinda weird looking and yeah smelly. I really don\u0027t like it but in the interest of backwards compat I think it should stay this way.","commit_id":"70329f628322fcd359f41f058d502f1d183a4284"},{"author":{"_account_id":38368,"name":"Christian Ohanaja","display_name":"Christian Ohanaja","email":"cohanaja@nvidia.com","username":"cohanaja"},"change_message_id":"2a55b8d84ffac82baf8e8aace28126c9f5c589b5","unresolved":false,"context_lines":[{"line_number":161,"context_line":"                             rows_per_shard\u003d500000,"},{"line_number":162,"context_line":"                             subcommand\u003d\u0027find\u0027,"},{"line_number":163,"context_line":"                             force_commits\u003dTrue,"},{"line_number":164,"context_line":"                             skip_commits\u003dFalse,"},{"line_number":165,"context_line":"                             verbose\u003d0,"},{"line_number":166,"context_line":"                             minimum_shard_size\u003d100000)"},{"line_number":167,"context_line":"        mocked.assert_called_once_with(mock.ANY, expected)"}],"source_content_type":"text/x-python","patch_set":3,"id":"06ae82c2_8058b248","line":164,"in_reply_to":"94bfa7eb_71467d78","updated":"2025-09-30 05:45:44.000000000","message":"Done","commit_id":"70329f628322fcd359f41f058d502f1d183a4284"},{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"baf6fcd7081d29beb5ba0175f4749b34ddcd22a2","unresolved":true,"context_lines":[{"line_number":253,"context_line":"                             func\u003dmock.ANY,"},{"line_number":254,"context_line":"                             subcommand\u003d\u0027compact\u0027,"},{"line_number":255,"context_line":"                             force_commits\u003dTrue,"},{"line_number":256,"context_line":"                             skip_commits\u003dFalse,"},{"line_number":257,"context_line":"                             verbose\u003d0,"},{"line_number":258,"context_line":"                             max_expanding\u003d11,"},{"line_number":259,"context_line":"                             max_shrinking\u003d22,"}],"source_content_type":"text/x-python","patch_set":4,"id":"4d983468_4e3c7e3c","line":256,"range":{"start_line":256,"start_character":42,"end_line":256,"end_character":47},"updated":"2025-09-30 04:20:43.000000000","message":"We should add another test case to show that using the either of the options will change this value to True, so we know the argparsing in the cli is working.","commit_id":"7708bb388c19d6999391d03020d5ea71ae4f9151"},{"author":{"_account_id":38368,"name":"Christian Ohanaja","display_name":"Christian Ohanaja","email":"cohanaja@nvidia.com","username":"cohanaja"},"change_message_id":"2a55b8d84ffac82baf8e8aace28126c9f5c589b5","unresolved":false,"context_lines":[{"line_number":253,"context_line":"                             func\u003dmock.ANY,"},{"line_number":254,"context_line":"                             subcommand\u003d\u0027compact\u0027,"},{"line_number":255,"context_line":"                             force_commits\u003dTrue,"},{"line_number":256,"context_line":"                             skip_commits\u003dFalse,"},{"line_number":257,"context_line":"                             verbose\u003d0,"},{"line_number":258,"context_line":"                             max_expanding\u003d11,"},{"line_number":259,"context_line":"                             max_shrinking\u003d22,"}],"source_content_type":"text/x-python","patch_set":4,"id":"ffc64408_58559a4a","line":256,"range":{"start_line":256,"start_character":42,"end_line":256,"end_character":47},"in_reply_to":"4d983468_4e3c7e3c","updated":"2025-09-30 05:45:44.000000000","message":"Done","commit_id":"7708bb388c19d6999391d03020d5ea71ae4f9151"},{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"99b3d29a8f6fc46fb278745bb5a423c178b93530","unresolved":false,"context_lines":[{"line_number":2955,"context_line":"        self.assertEqual(0, ret)"},{"line_number":2956,"context_line":"        args \u003d mocked.call_args[0][1]"},{"line_number":2957,"context_line":"        self.assertFalse(args.skip_commits,"},{"line_number":2958,"context_line":"                         \u0027default should set skip_commits to False\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"3b168b71_7aa84910","line":2958,"updated":"2025-09-30 07:04:34.000000000","message":"Nice! Love it!","commit_id":"2ac47fba2fb43db389f6cf7b4da90e7aa6d89b3a"}]}