)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"bd3cc0a31eed1a94ecae9c5d6886facb1a4e8e97","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Add headers param to direct_client.direct_get_object, which is used in"},{"line_number":10,"context_line":"probetests to passthrough the X-Storage-Policy-Index header."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Raise SkipTest if default policy type is not replication"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"DocImpact"},{"line_number":15,"context_line":"Implements: blueprint storage-policies"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"1ae5cdf2_761a967d","line":12,"updated":"2014-06-17 13:18:05.000000000","message":"no longer applies?","commit_id":"9be349a262908abe71c8456f084717e86d1109fe"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"5ad3280067200716ee39f34ec74e4f98328a3ba1","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Add headers param to direct_client.direct_get_object, which is used in"},{"line_number":10,"context_line":"probetests to passthrough the X-Storage-Policy-Index header."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Raise SkipTest if default policy type is not replication"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"DocImpact"},{"line_number":15,"context_line":"Implements: blueprint storage-policies"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"1ae5cdf2_1d14f4e7","line":12,"in_reply_to":"1ae5cdf2_761a967d","updated":"2014-06-17 19:12:48.000000000","message":"Done","commit_id":"9be349a262908abe71c8456f084717e86d1109fe"}],"test/probe/common.py":[{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"bd3cc0a31eed1a94ecae9c5d6886facb1a4e8e97","unresolved":false,"context_lines":[{"line_number":254,"context_line":"        print \u0027%s OK\u0027 % server"},{"line_number":255,"context_line":"    for policy in POLICIES:"},{"line_number":256,"context_line":"        try:"},{"line_number":257,"context_line":"            get_ring(policy.ring_name, server\u003d\u0027object\u0027, force_validate\u003dTrue)"},{"line_number":258,"context_line":"        except AssertionError as err:"},{"line_number":259,"context_line":"            sys.exit(\u0027object ERROR (%s): %s\u0027 % (policy.name, err))"},{"line_number":260,"context_line":"        print \u0027object OK (%s)\u0027 % policy.name"}],"source_content_type":"text/x-python","patch_set":12,"id":"1ae5cdf2_9308142a","line":257,"updated":"2014-06-17 13:18:05.000000000","message":"validation fails for policies with replication !\u003d 3:\n\n  swift@saio-1:~/swift$ python test/probe/common.py  \n  account OK\n  container OK\n  object OK (Policy-0)\n  object ERROR (siLver): /etc/swift/object-1.ring.gz has 2 replicas instead of 3","commit_id":"9be349a262908abe71c8456f084717e86d1109fe"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"d1f7353fc2b31e1affc87ff0e12bff45605c86e3","unresolved":false,"context_lines":[{"line_number":254,"context_line":"        print \u0027%s OK\u0027 % server"},{"line_number":255,"context_line":"    for policy in POLICIES:"},{"line_number":256,"context_line":"        try:"},{"line_number":257,"context_line":"            get_ring(policy.ring_name, server\u003d\u0027object\u0027, force_validate\u003dTrue)"},{"line_number":258,"context_line":"        except AssertionError as err:"},{"line_number":259,"context_line":"            sys.exit(\u0027object ERROR (%s): %s\u0027 % (policy.name, err))"},{"line_number":260,"context_line":"        print \u0027object OK (%s)\u0027 % policy.name"}],"source_content_type":"text/x-python","patch_set":12,"id":"1ae5cdf2_4be3f533","line":257,"in_reply_to":"1ae5cdf2_3dc61017","updated":"2014-06-18 11:45:51.000000000","message":"Yes. Seems like all the probetests use the default policy so as long as default is 3 replica all pass. If default is 2 replica all pass except test_object_handoff. (I skip test_container_sync).\n\nI\u0027m guessing that this __main__ is used to give a sanity check as to whether probetests are going to work or not. But it spits out an error even if *non-default* policy is 2 replica - which we don\u0027t really care about (i think). So would this suffice:\nhttps://gist.github.com/alistairncoles/52ce5ea507c4a6d26eb9","commit_id":"9be349a262908abe71c8456f084717e86d1109fe"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"5ad3280067200716ee39f34ec74e4f98328a3ba1","unresolved":false,"context_lines":[{"line_number":254,"context_line":"        print \u0027%s OK\u0027 % server"},{"line_number":255,"context_line":"    for policy in POLICIES:"},{"line_number":256,"context_line":"        try:"},{"line_number":257,"context_line":"            get_ring(policy.ring_name, server\u003d\u0027object\u0027, force_validate\u003dTrue)"},{"line_number":258,"context_line":"        except AssertionError as err:"},{"line_number":259,"context_line":"            sys.exit(\u0027object ERROR (%s): %s\u0027 % (policy.name, err))"},{"line_number":260,"context_line":"        print \u0027object OK (%s)\u0027 % policy.name"}],"source_content_type":"text/x-python","patch_set":12,"id":"1ae5cdf2_3dc61017","line":257,"in_reply_to":"1ae5cdf2_9308142a","updated":"2014-06-17 19:12:48.000000000","message":"Have you tried running tests with the 2 replica ring?  Some people have alleged that maybe new tests will pass if the second policy is 2-replica (that was an accident) but I\u0027m pretty sure all of the existing tests assumed the default ring was 3 replica.  I\u0027ll try and confirm before the next rebase and do... something...\n\nMaybe worth noting that as so far the probetest suite has always just ran and failed if the configuration under test is bogus - I added the \"test_rsync\" flag to test.conf awhile ago so I give myself a quick validation test - but it\u0027s still off by default.\n\nThere\u0027s some notion that this could/should be improved, and post policies it may even be useful/required - especially if folks want to write tests that won\u0027t run against some configurations (e.g. SkipTest unless you have an policy that\u0027s EC).  But figuring out how to change the tests is really more of a consensus building exercise than a technical hurdle.","commit_id":"9be349a262908abe71c8456f084717e86d1109fe"}],"test/probe/test_object_handoff.py":[{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"0bc7a337cc646f0744b453a627af32dc7bbbb73c","unresolved":false,"context_lines":[{"line_number":155,"context_line":"            # Object DELETE returning 503 for (404, 204)"},{"line_number":156,"context_line":"            # remove this with fix for"},{"line_number":157,"context_line":"            # https://bugs.launchpad.net/swift/+bug/1318375"},{"line_number":158,"context_line":"            self.assertEqual(503, err.http_status)"},{"line_number":159,"context_line":"        exc \u003d None"},{"line_number":160,"context_line":"        try:"},{"line_number":161,"context_line":"            client.head_object(self.url, self.token, container, obj)"}],"source_content_type":"text/x-python","patch_set":14,"id":"1ae5cdf2_5488b721","line":158,"updated":"2014-06-19 17:07:22.000000000","message":"this is the hack to work with two replica rings.","commit_id":"ad2a9cefe5f7355e1861f9f76b9cb2c59b6a83eb"}],"test/probe/test_replication_servers_working.py":[{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"70a70dc9a507d6e6266fd69cae2aa20ee667ca52","unresolved":false,"context_lines":[{"line_number":129,"context_line":"                test_node_files_list.append(files)"},{"line_number":130,"context_line":"        test_node_dir_list \u003d []"},{"line_number":131,"context_line":"        for d in dir_list[num]:"},{"line_number":132,"context_line":"            if not d.startswith(\u0027tmp\u0027):"},{"line_number":133,"context_line":"                test_node_dir_list.append(d)"},{"line_number":134,"context_line":"        # Run all replicators"},{"line_number":135,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":13,"id":"1ae5cdf2_2b79492f","line":132,"updated":"2014-06-18 11:46:12.000000000","message":"The way I understood it, \u0027tmp\u0027 is expected to be recreated by the db_replicators. \u0027tmp-N\u0027 is not expected (with rsync at least). So this could be startswith(\u0027tmp-\u0027) but it doesn\u0027t really matter because the acid test is the accounts and containers dirs being replicated.","commit_id":"04b1a8e9e0926572b2226071ee56d0f7c9a47e89"}]}
