)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"71008147869e72d488d9e2c7dca1a1164b7e750a","unresolved":true,"context_lines":[{"line_number":11,"context_line":"expected to be floats. This is adhered to in code, but many tests pass"},{"line_number":12,"context_line":"a string representation of a Timestamp instance. The string has been"},{"line_number":13,"context_line":"tolerated because it has so far always been identical to a"},{"line_number":14,"context_line":"str(float)."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"However, if a Timestamp instance has an offset then its string"},{"line_number":17,"context_line":"representation is not equivalent to str(float), and"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"606f22e2_d8be64b4","line":14,"updated":"2025-11-26 11:48:41.000000000","message":"We could change all the tests (some I already have) but we tend to be tolerant in what we accept, and the quoting is technically correct regardless.\n\nHowever, it concerns me that so many tests call reclaim using a different type than the replicator code","commit_id":"37c7b867a0ed427738a1fad92ed12194f756e488"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"3140b75ee4e5f9de3950135354ecc33f9022c6c5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"ddf50c2b_4c16eaad","updated":"2025-11-26 16:12:27.000000000","message":"LGTM, leaving for another core to merge","commit_id":"48937cd18360b52d8205d5059a5cb079ea4897a4"}],"swift/common/db.py":[{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"71008147869e72d488d9e2c7dca1a1164b7e750a","unresolved":true,"context_lines":[{"line_number":1053,"context_line":""},{"line_number":1054,"context_line":"        Subclasses may reclaim other items by overriding :meth:`_reclaim`."},{"line_number":1055,"context_line":""},{"line_number":1056,"context_line":"        :param age_timestamp: (float) the max created_at timestamp of object"},{"line_number":1057,"context_line":"            rows to delete"},{"line_number":1058,"context_line":"        :param sync_timestamp: (float) the max update_at timestamp of sync rows"},{"line_number":1059,"context_line":"            to delete"}],"source_content_type":"text/x-python","patch_set":4,"id":"df0fcd98_6381790c","line":1056,"range":{"start_line":1056,"start_character":30,"end_line":1056,"end_character":37},"updated":"2025-11-26 11:48:41.000000000","message":"I got very confused and therefore tried to clarify in docstrings how the code actually calls these methods, but maybe the docstring should say \"float or string\" (but not Timestamp) ...  IDK, I don\u0027t want this patch to explode into an epic of its own!","commit_id":"37c7b867a0ed427738a1fad92ed12194f756e488"}]}