)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"3641a99c5ac2453ed7a9876652b982afc3fad398","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"8416c179_e57b0644","updated":"2025-12-12 17:31:24.000000000","message":"merging based on Matt and Tim\u0027s previous +2","commit_id":"5df4e758f35d5453bdbf73e3591139d339d157e5"}],"test/unit/common/middleware/test_slo.py":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"256bd67093b592555d93201628bde12c034c4385","unresolved":true,"context_lines":[{"line_number":6798,"context_line":""},{"line_number":6799,"context_line":"    def test_init_with_no_sysmeta(self):"},{"line_number":6800,"context_line":"        now \u003d Timestamp.now()"},{"line_number":6801,"context_line":"        attrs \u003d slo.RespAttrs(True, now.normal, None, None, None)"},{"line_number":6802,"context_line":"        self.assertTrue(attrs.is_slo)"},{"line_number":6803,"context_line":"        self.assertEqual(Timestamp(now.normal), attrs.timestamp)"},{"line_number":6804,"context_line":"        self.assertIsInstance(attrs.timestamp, Timestamp)"}],"source_content_type":"text/x-python","patch_set":2,"id":"cff2b90c_4a1c235e","line":6801,"range":{"start_line":6801,"start_character":36,"end_line":6801,"end_character":46},"updated":"2025-12-01 20:46:36.000000000","message":"Kind of off-topic? Maybe?\n\nIn practice, this should always be coming from `x-backend-timestamp`, right? Wouldn\u0027t that be using the internal format?\n\nOh, but we use `.internal` (with an offset) in the next test, I see.","commit_id":"ff5a4f3d8ce7701189e9d4a76a698e5e5f544ba4"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"860b828d3dd3c2e6304e05d5affef68c7933dd1d","unresolved":false,"context_lines":[{"line_number":6798,"context_line":""},{"line_number":6799,"context_line":"    def test_init_with_no_sysmeta(self):"},{"line_number":6800,"context_line":"        now \u003d Timestamp.now()"},{"line_number":6801,"context_line":"        attrs \u003d slo.RespAttrs(True, now.normal, None, None, None)"},{"line_number":6802,"context_line":"        self.assertTrue(attrs.is_slo)"},{"line_number":6803,"context_line":"        self.assertEqual(Timestamp(now.normal), attrs.timestamp)"},{"line_number":6804,"context_line":"        self.assertIsInstance(attrs.timestamp, Timestamp)"}],"source_content_type":"text/x-python","patch_set":2,"id":"fbf60f93_33b6bc03","line":6801,"range":{"start_line":6801,"start_character":36,"end_line":6801,"end_character":46},"in_reply_to":"cff2b90c_4a1c235e","updated":"2025-12-02 12:31:29.000000000","message":"IIRC these tests may come back to bite us after the change to v2 timestamps in a way that can only be fixed after v2 timestamps. I forget the details, maybe this was it ??","commit_id":"ff5a4f3d8ce7701189e9d4a76a698e5e5f544ba4"},{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"091a5571b4e480a132e2d41dea6bcd5c4af3a962","unresolved":true,"context_lines":[{"line_number":6800,"context_line":"        now \u003d Timestamp.now()"},{"line_number":6801,"context_line":"        attrs \u003d slo.RespAttrs(True, now.normal, None, None, None)"},{"line_number":6802,"context_line":"        self.assertTrue(attrs.is_slo)"},{"line_number":6803,"context_line":"        self.assertEqual(Timestamp(now.normal), attrs.timestamp)"},{"line_number":6804,"context_line":"        self.assertIsInstance(attrs.timestamp, Timestamp)"},{"line_number":6805,"context_line":"        self.assertEqual(\u0027\u0027, attrs.json_md5)"},{"line_number":6806,"context_line":"        self.assertEqual(\u0027\u0027, attrs.slo_etag)"}],"source_content_type":"text/x-python","patch_set":4,"id":"a02fc7cb_eae047a8","line":6803,"range":{"start_line":6803,"start_character":8,"end_line":6803,"end_character":64},"updated":"2025-12-05 01:17:06.000000000","message":"I guess this is fine, but it looks a little weird. I mean we already have now. So couldn\u0027t we just:\n\n```\nself.assertEqual(now.normal, attrs.timestamp.normal)\n```\n\nI guess your just recreated what attrs.timestamp is.. cool","commit_id":"3ab9fc470a858595a72451893036786394550c5d"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"9bb349d89349af58301ce54b8810dd1c3a665f58","unresolved":false,"context_lines":[{"line_number":6800,"context_line":"        now \u003d Timestamp.now()"},{"line_number":6801,"context_line":"        attrs \u003d slo.RespAttrs(True, now.normal, None, None, None)"},{"line_number":6802,"context_line":"        self.assertTrue(attrs.is_slo)"},{"line_number":6803,"context_line":"        self.assertEqual(Timestamp(now.normal), attrs.timestamp)"},{"line_number":6804,"context_line":"        self.assertIsInstance(attrs.timestamp, Timestamp)"},{"line_number":6805,"context_line":"        self.assertEqual(\u0027\u0027, attrs.json_md5)"},{"line_number":6806,"context_line":"        self.assertEqual(\u0027\u0027, attrs.slo_etag)"}],"source_content_type":"text/x-python","patch_set":4,"id":"4fde6d65_dec31561","line":6803,"range":{"start_line":6803,"start_character":8,"end_line":6803,"end_character":64},"in_reply_to":"a02fc7cb_eae047a8","updated":"2025-12-05 13:14:37.000000000","message":"it\u0027s a little subtle...Timestamp equality is based on Timestamp.internal, so ``self.assertEqual(now.normal, attrs.timestamp.normal)`` doesn\u0027t verify that the two are identical, because it would be true for \"1234567890.12345_abc\" and \"1234567890.12345_xyz\".\n\nThe other subtle thing is that\n\n`` self.assertEqual(Timestamp(now.normal), attrs.timestamp)``\n\nverifies that if you pass in a normal *string* you get a v1-style attrs.timestamp - Timestamp respects the fact that you gave it an offset-less timestamp str.\n\nBut in practice we don\u0027t do that - these tests explore use cases that don\u0027t exist!","commit_id":"3ab9fc470a858595a72451893036786394550c5d"}]}