)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"01fa21c422e81a48f31c234c62668b29bfa6e0a9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"e7eed72d_bb0c2fb5","updated":"2025-12-03 19:19:22.000000000","message":"thanks Matt - I wonder if we should just leave sync.py alone???","commit_id":"5f3ed0834467717085fedc5df82a43f308403f85"}],"test/unit/common/middleware/test_container_sync.py":[{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"01fa21c422e81a48f31c234c62668b29bfa6e0a9","unresolved":true,"context_lines":[{"line_number":207,"context_line":"    def test_invalid_sig(self):"},{"line_number":208,"context_line":"        req \u003d swob.Request.blank("},{"line_number":209,"context_line":"            \u0027/v1/a/c\u0027, headers\u003d{\u0027x-container-sync-auth\u0027: \u0027US nonce sig\u0027,"},{"line_number":210,"context_line":"                                \u0027x-timestamp\u0027: Timestamp.now().internal})"},{"line_number":211,"context_line":"        infocache \u003d req.environ.setdefault(\u0027swift.infocache\u0027, {})"},{"line_number":212,"context_line":"        infocache[get_cache_key(\u0027a\u0027, \u0027c\u0027)] \u003d {\u0027sync_key\u0027: \u0027abc\u0027}"},{"line_number":213,"context_line":"        resp \u003d req.get_response(self.sync)"}],"source_content_type":"text/x-python","patch_set":1,"id":"a029844a_d964ab78","line":210,"updated":"2025-12-03 19:19:22.000000000","message":"hmmm, do you think I should just revert the change to sync.py - looking at it again I think the ``, \u00270\u0027)`` change got caught up in a grep for Timestamp(...., 0)","commit_id":"5f3ed0834467717085fedc5df82a43f308403f85"},{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"4b9c084cfac9776a8094a94b5d3e87588eaebe23","unresolved":true,"context_lines":[{"line_number":207,"context_line":"    def test_invalid_sig(self):"},{"line_number":208,"context_line":"        req \u003d swob.Request.blank("},{"line_number":209,"context_line":"            \u0027/v1/a/c\u0027, headers\u003d{\u0027x-container-sync-auth\u0027: \u0027US nonce sig\u0027,"},{"line_number":210,"context_line":"                                \u0027x-timestamp\u0027: Timestamp.now().internal})"},{"line_number":211,"context_line":"        infocache \u003d req.environ.setdefault(\u0027swift.infocache\u0027, {})"},{"line_number":212,"context_line":"        infocache[get_cache_key(\u0027a\u0027, \u0027c\u0027)] \u003d {\u0027sync_key\u0027: \u0027abc\u0027}"},{"line_number":213,"context_line":"        resp \u003d req.get_response(self.sync)"}],"source_content_type":"text/x-python","patch_set":1,"id":"89537076_b4b03d75","line":210,"in_reply_to":"a029844a_d964ab78","updated":"2025-12-04 00:42:49.000000000","message":"oh yeah maybe. or change it to:\n```\nheaders.get(\u0027x-timestamp\u0027, Timestamp.zero().normal)\n```\n\nBut yeah, maybe just reverting to \u00270\u0027 would mean we don\u0027t need to fix these tests at all.","commit_id":"5f3ed0834467717085fedc5df82a43f308403f85"}],"test/unit/common/test_utils.py":[{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"055cc4a431e7a02e59138d610f594a0bc875ff20","unresolved":true,"context_lines":[{"line_number":2678,"context_line":"        response \u003d FakeResponse(200, headers, b\u0027\u0027)"},{"line_number":2679,"context_line":"        path, ts \u003d utils.get_redirect_data(response)"},{"line_number":2680,"context_line":"        self.assertEqual(\u0027a/c\u0027, path)"},{"line_number":2681,"context_line":"        self.assertEqual(utils.Timestamp.zero(), ts)"},{"line_number":2682,"context_line":""},{"line_number":2683,"context_line":"        def do_test(headers):"},{"line_number":2684,"context_line":"            response \u003d FakeResponse(200, headers, b\u0027\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1c6b0c65_4d76b1dc","line":2681,"updated":"2025-12-04 19:14:31.000000000","message":"eek, this scares me - what was an error condition (no x-timestamp) has now become ok :/\n\nI had a voice in my head worrying me that the default to zero idea might result in something like this. I think I need to find a different way. See the parent patch comments.","commit_id":"5f3ed0834467717085fedc5df82a43f308403f85"}]}