)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"4efcbeb65349c4e70f2f2defa950e2ceb30accd6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"10dd08f7_9a0ddc08","updated":"2025-12-19 11:53:36.000000000","message":"Thanks Jianjian! Tim was right, good to have the whole assertion tightened up.\n\nRebased onto master since this can land independently.","commit_id":"c36e789cdb8052f3b28c8367e803876a06cf9c06"}],"test/unit/proxy/test_server.py":[{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"caca643eeba5e775744bb735e18e5210292808a2","unresolved":true,"context_lines":[{"line_number":2759,"context_line":"        try:"},{"line_number":2760,"context_line":"            df.open()"},{"line_number":2761,"context_line":"        except DiskFileNotExist as e:"},{"line_number":2762,"context_line":"            self.assertGreater(e.timestamp, utils.Timestamp.zero())"},{"line_number":2763,"context_line":"        else:"},{"line_number":2764,"context_line":"            self.fail(\u0027did not raise DiskFileNotExist\u0027)"},{"line_number":2765,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"eee5516b_06f07dff","line":2762,"range":{"start_line":2762,"start_character":31,"end_line":2762,"end_character":42},"updated":"2025-12-18 11:25:32.000000000","message":"ok, I think the existing assertion was ok because e.timestamp IS a Timestamps and can be cast to a float...and we\u0027re just asserting that we don\u0027t get the default back. But this change is a little clearer because the default would be Timestamp.zero() so we\u0027re now explicitly asserting that what we get back is NOT the default.\n\noff-topic: The existing assertion is confusing! DiskFileNotExist doesn\u0027t have a timestamp attribute, but DiskFileDeleted (which is the subclass that is actually raised) does.","commit_id":"b481bf8cee1e1b2d02fb9b90da21659ba5a36355"},{"author":{"_account_id":34930,"name":"Jianjian Huo","email":"jhuo@nvidia.com","username":"jhuo"},"change_message_id":"c631c2a8977d730b76da9f9f1f5b296d5357413d","unresolved":false,"context_lines":[{"line_number":2759,"context_line":"        try:"},{"line_number":2760,"context_line":"            df.open()"},{"line_number":2761,"context_line":"        except DiskFileNotExist as e:"},{"line_number":2762,"context_line":"            self.assertGreater(e.timestamp, utils.Timestamp.zero())"},{"line_number":2763,"context_line":"        else:"},{"line_number":2764,"context_line":"            self.fail(\u0027did not raise DiskFileNotExist\u0027)"},{"line_number":2765,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3cf7aa45_f3394e2e","line":2762,"range":{"start_line":2762,"start_character":31,"end_line":2762,"end_character":42},"in_reply_to":"4e5a3e0b_7c2d3ed7","updated":"2025-12-18 20:52:30.000000000","message":"Done","commit_id":"b481bf8cee1e1b2d02fb9b90da21659ba5a36355"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"90ecae4ea3e0235381d30c289e54fb721e4adecf","unresolved":true,"context_lines":[{"line_number":2759,"context_line":"        try:"},{"line_number":2760,"context_line":"            df.open()"},{"line_number":2761,"context_line":"        except DiskFileNotExist as e:"},{"line_number":2762,"context_line":"            self.assertGreater(e.timestamp, utils.Timestamp.zero())"},{"line_number":2763,"context_line":"        else:"},{"line_number":2764,"context_line":"            self.fail(\u0027did not raise DiskFileNotExist\u0027)"},{"line_number":2765,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"4e5a3e0b_7c2d3ed7","line":2762,"range":{"start_line":2762,"start_character":31,"end_line":2762,"end_character":42},"in_reply_to":"eee5516b_06f07dff","updated":"2025-12-18 17:19:59.000000000","message":"Makes me think this should be explicitly catching `DiskFileDeleted` then -- probably with an `assertRaises` rather than the `try`/`except`/`else: fail` construction we\u0027ve got.","commit_id":"b481bf8cee1e1b2d02fb9b90da21659ba5a36355"}]}