)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"a507ad5743e7a0df71a26d394d6efba5cef12e7d","unresolved":true,"context_lines":[{"line_number":23,"context_line":"Castellan\u0027s BarbicanKeyManager will use this value when discovering"},{"line_number":24,"context_line":"the Barbican endpoint from the service catalog."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Related-Bug: #2138973"},{"line_number":27,"context_line":"Signed-off-by: Ade Lee \u003calee@redhat.com\u003e"},{"line_number":28,"context_line":"Change-Id: I02e86c736398698d1bae19c17e9d97b1974e5054"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"11177ea1_b75dd571","line":26,"updated":"2026-01-23 23:41:33.000000000","message":"Related-Change: https://review.opendev.org/c/openstack/swift/+/921927","commit_id":"e5db02f30f34308be567636620d5fbc739c7750e"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"a507ad5743e7a0df71a26d394d6efba5cef12e7d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"bcf29483_ee7068d1","updated":"2026-01-23 23:41:33.000000000","message":"Probably worth updating the sample config, too -- though I\u0027d be happy to do that. One quick question, though.","commit_id":"e5db02f30f34308be567636620d5fbc739c7750e"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"4bbc8b368d582b1861ffc1901e67946cf2e72357","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"82372f39_bb2dbba5","in_reply_to":"bcf29483_ee7068d1","updated":"2026-01-26 19:10:03.000000000","message":"Done.","commit_id":"e5db02f30f34308be567636620d5fbc739c7750e"}],"swift/common/middleware/crypto/kms_keymaster.py":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"a507ad5743e7a0df71a26d394d6efba5cef12e7d","unresolved":true,"context_lines":[{"line_number":77,"context_line":"        if conf.get(\u0027barbican_region_name\u0027):"},{"line_number":78,"context_line":"            oslo_conf.set_default(\u0027barbican_region_name\u0027,"},{"line_number":79,"context_line":"                                  conf.get(\u0027barbican_region_name\u0027),"},{"line_number":80,"context_line":"                                  group\u003d\u0027barbican\u0027)"},{"line_number":81,"context_line":"        options.enable_logging()"},{"line_number":82,"context_line":"        manager \u003d key_manager.API(oslo_conf)"},{"line_number":83,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"743154c3_e785bec1","line":80,"updated":"2026-01-23 23:41:33.000000000","message":"I don\u0027t often work with oslo config objects -- what\u0027s the difference between doing it this way (via `set_default`) vs. using `set_defaults` like was done for `barbican_endpoint` above? Is one of those \"more right\" -- and should we update the other?","commit_id":"e5db02f30f34308be567636620d5fbc739c7750e"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"4bbc8b368d582b1861ffc1901e67946cf2e72357","unresolved":false,"context_lines":[{"line_number":77,"context_line":"        if conf.get(\u0027barbican_region_name\u0027):"},{"line_number":78,"context_line":"            oslo_conf.set_default(\u0027barbican_region_name\u0027,"},{"line_number":79,"context_line":"                                  conf.get(\u0027barbican_region_name\u0027),"},{"line_number":80,"context_line":"                                  group\u003d\u0027barbican\u0027)"},{"line_number":81,"context_line":"        options.enable_logging()"},{"line_number":82,"context_line":"        manager \u003d key_manager.API(oslo_conf)"},{"line_number":83,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1b6a6478_867898f3","line":80,"in_reply_to":"3ba8c6ec_767c8d13","updated":"2026-01-26 19:10:03.000000000","message":"Acknowledged","commit_id":"e5db02f30f34308be567636620d5fbc739c7750e"},{"author":{"_account_id":9914,"name":"Ade Lee","email":"alee@redhat.com","username":"alee"},"change_message_id":"492a7bf04404c9ad81ef32b851e1e9952f85d27d","unresolved":true,"context_lines":[{"line_number":77,"context_line":"        if conf.get(\u0027barbican_region_name\u0027):"},{"line_number":78,"context_line":"            oslo_conf.set_default(\u0027barbican_region_name\u0027,"},{"line_number":79,"context_line":"                                  conf.get(\u0027barbican_region_name\u0027),"},{"line_number":80,"context_line":"                                  group\u003d\u0027barbican\u0027)"},{"line_number":81,"context_line":"        options.enable_logging()"},{"line_number":82,"context_line":"        manager \u003d key_manager.API(oslo_conf)"},{"line_number":83,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3ba8c6ec_767c8d13","line":80,"in_reply_to":"743154c3_e785bec1","updated":"2026-01-24 00:33:26.000000000","message":"We need to do it this way becaause barbican_region_name is not a parameter in set_defaults() in castellan.  This is an oversight I think.  I\u0027ll create a patch next week to castellan to fix this.","commit_id":"e5db02f30f34308be567636620d5fbc739c7750e"}]}