)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"0601536cb05c9f942fa59639aee300deb9cca649","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"14a78658_3a196baf","updated":"2026-05-14 15:27:44.000000000","message":"got a little mixed up by how `increment_offset` interacts with the `_offset` property setter - but I think this addresses the XXX well enough!","commit_id":"782c7e27bee3b9c0dc2b3ba66c87adeffbc01776"}],"swift/common/utils/timestamp.py":[{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"0601536cb05c9f942fa59639aee300deb9cca649","unresolved":true,"context_lines":[{"line_number":471,"context_line":"        if value \u003e max_offset:"},{"line_number":472,"context_line":"            raise ValueError(\u0027offset must be less than or equal to %d\u0027"},{"line_number":473,"context_line":"                             % max_offset)"},{"line_number":474,"context_line":"        return int(value)"},{"line_number":475,"context_line":""},{"line_number":476,"context_line":"    @property"},{"line_number":477,"context_line":"    def _offset(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"117113fd_bb9b90fc","side":"PARENT","line":474,"updated":"2026-05-14 15:27:44.000000000","message":"right, we don\u0027t need this if the only time it\u0027s called is from the `_offset` property setter!  The idea is that `increment_offset` now gets the validation by way of the property helper.","commit_id":"c17aee85591032784bf7301502f389cd0b67e854"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"0601536cb05c9f942fa59639aee300deb9cca649","unresolved":true,"context_lines":[{"line_number":511,"context_line":"        if not value:"},{"line_number":512,"context_line":"            return self._offset"},{"line_number":513,"context_line":"        if value \u003c 0:"},{"line_number":514,"context_line":"            raise ValueError(\u0027offset must be non-negative\u0027)"},{"line_number":515,"context_line":"        self._offset +\u003d value"},{"line_number":516,"context_line":"        return self._offset"},{"line_number":517,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3c3f3878_8a2b3b60","line":514,"updated":"2026-05-14 15:27:44.000000000","message":"i\u0027m guessing (hoping?) that `self._offset +\u003d` might go through the setter; in which case maybe we dont need to duplicate this?\n\noh except it doesn\u0027t cause the decrement happens \"outside\" of the setter!  oh that\u0027s so annoying!\n\nProbably this ValueError is mis-leading; the problem isn\u0027t when offset itself becomes non-negative; it\u0027s that you can *decrement* offset.\n\n```\ndiff --git a/swift/common/utils/timestamp.py b/swift/common/utils/timestamp.py\nindex ae9ca170db..c69c4492b5 100644\n--- a/swift/common/utils/timestamp.py\n+++ b/swift/common/utils/timestamp.py\n@@ -500,19 +500,19 @@ class Timestamp(BaseTimestamp):\n                                  \u0027hex_part encoding\u0027)\n         return self._offset\n \n-    def increment_offset(self, value):\n+    def increment_offset(self, delta):\n         \"\"\"\n         Increment the offset of the timestamp by the given value.\n \n-        :param value: (int) increment to the second internal offset vector.\n+        :param delta: (int) increment to the second internal offset vector.\n         :raises ValueError: if value is not a whole number, or if the\n             resulting offset would exceed the maximum supported offset.\n         \"\"\"\n-        if not value:\n+        if not delta:\n             return self._offset\n-        if value \u003c 0:\n-            raise ValueError(\u0027offset must be non-negative\u0027)\n-        self._offset +\u003d value\n+        if delta \u003c 0:\n+            raise ValueError(\u0027you can not decrement offset\u0027)\n+        self._offset +\u003d delta\n         return self._offset\n \n     @classmethod\n```\n\n^ idk, probably same difference in all the way\u0027s that matter.","commit_id":"782c7e27bee3b9c0dc2b3ba66c87adeffbc01776"}]}