)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"068e3a0676a97c3f6f523c50de3c1980d150713c","unresolved":true,"context_lines":[{"line_number":7,"context_line":"test_sharder.py: pass timestamp strings to put_object"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"ContainerBroker.put_object() expects timestamp strings, not Timestamp"},{"line_number":10,"context_line":"objects."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I7bc2919b709d745a7571ca5883d02398b1ff6a39"},{"line_number":13,"context_line":"Signed-off-by: Alistair Coles \u003calistairncoles@gmail.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"b54a1166_a76e127c","line":10,"updated":"2026-05-18 21:24:16.000000000","message":"OK, I *think* I\u0027ve convinced myself that `put_object`/`delete_object` are only ever called (and have previously only ever been called) from `container/server.py`, and always with `str` timestamps. Should we go enforce that in `container/backend.py`? Or **at least** update the docstrings?\n\n(I\u0027m also realizing I\u0027m not sure we validate that `x-content-type-timestamp` / `x-meta-timestamp` are actually valid timestamps...)","commit_id":"bab619019bc6bdf4e0e3122c88f377c8b1f26b46"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"fb1199023a65f2cb442bf64f8491d016123d8fa1","unresolved":true,"context_lines":[{"line_number":7,"context_line":"test_sharder.py: pass timestamp strings to put_object"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"ContainerBroker.put_object() expects timestamp strings, not Timestamp"},{"line_number":10,"context_line":"objects."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I7bc2919b709d745a7571ca5883d02398b1ff6a39"},{"line_number":13,"context_line":"Signed-off-by: Alistair Coles \u003calistairncoles@gmail.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7c1eb5cd_d9ba6c8c","line":10,"in_reply_to":"b54a1166_a76e127c","updated":"2026-05-19 13:44:15.000000000","message":"\u003eat least update the docstrings?\n\nDone (next patchset)\n\n\u003e Should we go enforce that in container/backend.py?\n\nProbably, but this patch as it is will be sufficient to make progress on the pickle hardening. I fear a slippery slope into type-checking many interfaces :/\n\n\u003e I\u0027m not sure we validate that x-content-type-timestamp / x-meta-timestamp are actually valid timestamps\n\n+1, we should probably be more careful about what gets persisted","commit_id":"bab619019bc6bdf4e0e3122c88f377c8b1f26b46"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":6968,"name":"Christian Schwede","email":"cschwede@nvidia.com","username":"cschwede"},"change_message_id":"55370339717824ebdc6c5a8bff0f046eb41fa39a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"579b662a_1956f089","updated":"2026-05-19 16:31:33.000000000","message":"Fixes the test issue with the pickle hardening patch for me.\n\nGiven that this paves the way for that patch, I\u0027m fine with this (agreeing with Alistair this being sufficient to make progress).","commit_id":"73a9411bb9950cde18102fbafcb8c22e63acf0ec"},{"author":{"_account_id":6968,"name":"Christian Schwede","email":"cschwede@nvidia.com","username":"cschwede"},"change_message_id":"f6defc689fd6036169724cc118504ed1f78a4124","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"09b3d691_c31fe98a","updated":"2026-05-21 04:13:40.000000000","message":"recheck","commit_id":"73a9411bb9950cde18102fbafcb8c22e63acf0ec"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"18dc275ebb2bde50e8a141fdfe8130ef38e396e4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"9ab2bcad_7155472a","updated":"2026-05-20 17:24:57.000000000","message":"recheck\n\ndsvm func tests have been fixed","commit_id":"73a9411bb9950cde18102fbafcb8c22e63acf0ec"}]}