)]}'
{"id":"openstack%2Fswift~989594","triplet_id":"openstack%2Fswift~master~I79eb5e0f6850cc93f59079247031f7c4f017a638","project":"openstack/swift","branch":"master","hashtags":[],"change_id":"I79eb5e0f6850cc93f59079247031f7c4f017a638","subject":"Validate container UPDATE bodies before auto-create","status":"NEW","created":"2026-05-21 18:02:02.000000000","updated":"2026-05-21 22:26:32.000000000","submit_type":"MERGE_IF_NECESSARY","mergeable":false,"submittable":false,"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"ff13b6cbb93f4dd181b95d8aa2440f962049c0c7","_number":989594,"virtual_id_number":989594,"owner":{"_account_id":330,"name":"John Dickinson","email":"me@not.mn","username":"notmyname"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:check","value":1,"date":"2026-05-21 19:27:48.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-05-21 19:27:48.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"d04a2c537b3e4b848c437932589537479031d05d","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":330,"name":"John Dickinson","email":"me@not.mn","username":"notmyname"},"date":"2026-05-21 18:02:02.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"0e972eca122d561b9a7c5ddee7b0b7dacd92533c","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-05-21 19:27:48.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/6ebb7490634e476c978d4d121a7fbdf3\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/c767b94c3ba64861b36f584b7b0b445e : SUCCESS in 11m 32s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/f215babeac17461ba170b9e0b1d6b0d2 : SUCCESS in 9m 01s\n- grenade https://zuul.opendev.org/t/openstack/build/a5cbfa8c89d741ecb17dc2c8bd291bb3 : SUCCESS in 1h 15m 01s\n- grenade-skip-level-always https://zuul.opendev.org/t/openstack/build/f09294f77538406ca884ae2c354c9412 : SUCCESS in 1h 06m 46s\n- tempest-integrated-object-storage https://zuul.opendev.org/t/openstack/build/3592ef971ce2466e834b20ea17eafde9 : SUCCESS in 50m 07s\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/ea3027dcdf4348a88f4140ce53487111 : SUCCESS in 1h 03m 12s\n- swift-tox-func-py39-centos-9-stream-fips https://zuul.opendev.org/t/openstack/build/aaadcfd2ebba49d5a15a6e87c150d4b9 : SUCCESS in 20m 27s (non-voting)\n- swift-tox-func-encryption-py39-centos-9-stream-fips https://zuul.opendev.org/t/openstack/build/7a066b4f69c04764b87129e30e532c57 : SUCCESS in 19m 49s (non-voting)\n- swift-tox-func-ec-py39-centos-9-stream-fips https://zuul.opendev.org/t/openstack/build/f903b6ed6e5a4c6c8ae6dfd88313ee78 : SUCCESS in 22m 40s (non-voting)\n- swift-build-image https://zuul.opendev.org/t/openstack/build/a83ea1e536d642cf97370af13925b342 : SUCCESS in 8m 16s (non-voting)\n- swift-tox-py37 https://zuul.opendev.org/t/openstack/build/c05538c8e2da4e10aae8d7d3ebe5a447 : SUCCESS in 23m 09s\n- swift-tox-py310 https://zuul.opendev.org/t/openstack/build/3cfca72b458a4224ac0b2ae6924d0ce8 : SUCCESS in 22m 42s\n- swift-tox-py313 https://zuul.opendev.org/t/openstack/build/717135fbd16d4797a2ef89aef7630855 : SUCCESS in 31m 06s\n- swift-tox-py314 https://zuul.opendev.org/t/openstack/build/1cc393c772dc457d8fdef658894d613b : SUCCESS in 14m 27s\n- swift-tox-func-py312 https://zuul.opendev.org/t/openstack/build/bb16b486e2ca4865b11b0d2a06003f1d : SUCCESS in 13m 43s\n- swift-tox-func-encryption-py312 https://zuul.opendev.org/t/openstack/build/814b4cecafac43058a3ce9bda4acac28 : SUCCESS in 15m 53s\n- swift-tox-func-ec-py312 https://zuul.opendev.org/t/openstack/build/3076d23010b64dbe8a447331c54732dc : SUCCESS in 16m 06s\n- swift-func-cors https://zuul.opendev.org/t/openstack/build/3dd1103899dd43d29eb72ba42a079b41 : SUCCESS in 7m 11s\n- swift-tox-func-ceph-s3tests-tempauth https://zuul.opendev.org/t/openstack/build/ace498ea138845f183070d0626bd0b32 : SUCCESS in 19m 45s (non-voting)\n- swift-tox-func-s3api-compat-tests-tempauth https://zuul.opendev.org/t/openstack/build/aad627efef0b4597b5d536673008e818 : SUCCESS in 10m 48s\n- swift-probetests-centos-9-stream https://zuul.opendev.org/t/openstack/build/809554dbaeee4344b0a2e0a1246103b4 : SUCCESS in 1h 03m 28s\n- swift-dsvm-functional https://zuul.opendev.org/t/openstack/build/fa00e263b54c424a8b9872ef1a652553 : SUCCESS in 52m 06s\n- swift-dsvm-functional-ipv6 https://zuul.opendev.org/t/openstack/build/a093132e0f104506a785e28e4b17c746 : SUCCESS in 51m 13s\n- swift-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/a6cafbe39ff1477190fd5da9b0719c6f : SUCCESS in 29m 47s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/344cefb2ecb049bfa57c66d33ad36cb5 : SUCCESS in 5m 21s\n- swift-multinode-rolling-upgrade https://zuul.opendev.org/t/openstack/build/18e3ef51331b4533bc015c0471cf7206 : SUCCESS in 24m 28s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/c004edce52c44a54b2118ea49e38b5a5 : SUCCESS in 36m 59s","accounts_in_message":[],"_revision_number":1},{"id":"ff13b6cbb93f4dd181b95d8aa2440f962049c0c7","tag":"autogenerated:zuul:check-arm64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-05-21 22:26:32.000000000","message":"Patch Set 1:\n\nBuild succeeded (ARM64 pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/ee6080e1bd1b4abe85f56d8a2faf2378\n\n- swift-tox-py312-arm64 https://zuul.opendev.org/t/openstack/build/c9e888ba0df049018b9835dabff75c91 : SUCCESS in 1h 02m 31s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"c00de1a6782124b4262bf8c77a9f4e74d86076da","revisions":{"c00de1a6782124b4262bf8c77a9f4e74d86076da":{"kind":"REWORK","_number":1,"created":"2026-05-21 18:02:02.000000000","uploader":{"_account_id":330,"name":"John Dickinson","email":"me@not.mn","username":"notmyname"},"ref":"refs/changes/94/989594/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/swift","ref":"refs/changes/94/989594/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/swift refs/changes/94/989594/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/swift refs/changes/94/989594/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/swift refs/changes/94/989594/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/swift refs/changes/94/989594/1"}}},"commit":{"parents":[{"commit":"ca8749f344168ad1c4e07fdfd24e68ca04c57eae","subject":"test_sharder.py: pass timestamp strings to put_object","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/ca8749f344168ad1c4e07fdfd24e68ca04c57eae"}]}],"author":{"name":"John Dickinson","email":"me@not.mn","date":"2026-05-21 17:49:13.000000000","tz":-420},"committer":{"name":"John Dickinson","email":"me@not.mn","date":"2026-05-21 18:02:01.000000000","tz":-420},"subject":"Validate container UPDATE bodies before auto-create","message":"Validate container UPDATE bodies before auto-create\n\nContainerController.UPDATE calls _maybe_autocreate() before parsing the\nJSON body. With auto-create enabled for a dot account, a malformed JSON\nbody returns 400 but still leaves an empty container database on disk.\n\nParse and validate the UPDATE body before auto-creating the container\ndatabase. Invalid JSON, or a valid JSON body with the wrong top-level\ntype, now returns 400 before the server creates any new DB file.\n\nCloses-Bug: #2153516\nAssisted-By: Codex (GPT 5.5)\nChange-Id: I79eb5e0f6850cc93f59079247031f7c4f017a638\nSigned-off-by: John Dickinson \u003cme@not.mn\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/c00de1a6782124b4262bf8c77a9f4e74d86076da"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/c00de1a6782124b4262bf8c77a9f4e74d86076da"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"OK","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY"},{"label":"Workflow","status":"MAY"}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Verified\u003dMAX","label:Verified\u003dMIN"],"atom_explanations":{"label:Verified\u003dMAX":"","label:Verified\u003dMIN":""}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","label:Code-Review\u003dMIN"],"atom_explanations":{"label:Code-Review\u003dMAX":"","label:Code-Review\u003dMIN":""}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Workflow\u003dMAX","label:Workflow\u003dMIN"],"atom_explanations":{"label:Workflow\u003dMAX":"","label:Workflow\u003dMIN":""}}}]}
