)]}'
{"id":"openstack%2Fswift~989598","triplet_id":"openstack%2Fswift~master~I655fefd9e0bf1b2fdcef7dec2275f2e719448fbb","project":"openstack/swift","branch":"master","hashtags":[],"change_id":"I655fefd9e0bf1b2fdcef7dec2275f2e719448fbb","subject":"Reject negative object content lengths","status":"NEW","created":"2026-05-21 18:02:48.000000000","updated":"2026-05-21 23:05:17.000000000","submit_type":"MERGE_IF_NECESSARY","mergeable":true,"submittable":false,"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"72fe9e920232aeb399cafd701f840e324ebe873e","_number":989598,"virtual_id_number":989598,"owner":{"_account_id":330,"name":"John Dickinson","email":"me@not.mn","username":"notmyname"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:check","value":1,"date":"2026-05-21 19:27:02.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-05-21 19:27:02.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"00e8b44bf43fdbc2292f00017cfe1d04cc601bdc","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":330,"name":"John Dickinson","email":"me@not.mn","username":"notmyname"},"date":"2026-05-21 18:02:48.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"caaddc1fb27fb3df78efab1eec3b41d34dccda24","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-05-21 19:27:02.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/a6a8e10517ce44b8a4bd34d65ac206ac\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/9b23c9812a9e4d32920406ae73f72d31 : SUCCESS in 5m 33s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/0baf794c46a04fa1926dee31f6c7cb58 : SUCCESS in 8m 44s\n- grenade https://zuul.opendev.org/t/openstack/build/227bcca4d2f04fcea1bba2dd77acdfad : SUCCESS in 36m 38s\n- grenade-skip-level-always https://zuul.opendev.org/t/openstack/build/70d4686fb4b94cbab23ff940ced86fc9 : SUCCESS in 36m 26s\n- tempest-integrated-object-storage https://zuul.opendev.org/t/openstack/build/33f1c71f933d45698325e5cb46780cde : SUCCESS in 30m 50s\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/c069e4542d404f09bb5a45af62dc7c56 : SUCCESS in 35m 11s\n- swift-tox-func-py39-centos-9-stream-fips https://zuul.opendev.org/t/openstack/build/62f25252091c4cd499ba52acbdd365bf : SUCCESS in 11m 09s (non-voting)\n- swift-tox-func-encryption-py39-centos-9-stream-fips https://zuul.opendev.org/t/openstack/build/2486e56be43344e69be3420c481af492 : SUCCESS in 16m 30s (non-voting)\n- swift-tox-func-ec-py39-centos-9-stream-fips https://zuul.opendev.org/t/openstack/build/b2e8539f20674d569fdcb94611f97126 : SUCCESS in 11m 10s (non-voting)\n- swift-build-image https://zuul.opendev.org/t/openstack/build/79bc29d3763f4d87ae0bdb139f59a225 : SUCCESS in 6m 55s (non-voting)\n- swift-tox-py37 https://zuul.opendev.org/t/openstack/build/eeddde0b9ef14e1ebba6428eeb81aded : SUCCESS in 18m 40s\n- swift-tox-py310 https://zuul.opendev.org/t/openstack/build/a72bf72a895d4168bc2f01578a79e105 : SUCCESS in 21m 50s\n- swift-tox-py313 https://zuul.opendev.org/t/openstack/build/d4809887aeb84660994834e8cb1093a4 : SUCCESS in 11m 34s\n- swift-tox-py314 https://zuul.opendev.org/t/openstack/build/412662bb3c1b47e9997a9d0559a0acea : SUCCESS in 9m 27s\n- swift-tox-func-py312 https://zuul.opendev.org/t/openstack/build/cbd192c1252d47db9cda1eb1a8602a61 : SUCCESS in 8m 54s\n- swift-tox-func-encryption-py312 https://zuul.opendev.org/t/openstack/build/a867edb249b946d98aa23c1035a10065 : SUCCESS in 12m 24s\n- swift-tox-func-ec-py312 https://zuul.opendev.org/t/openstack/build/6a467a7386774de59642109805cac268 : SUCCESS in 17m 20s\n- swift-func-cors https://zuul.opendev.org/t/openstack/build/b714e8562cb1424484f1c095d025f5dc : SUCCESS in 4m 02s\n- swift-tox-func-ceph-s3tests-tempauth https://zuul.opendev.org/t/openstack/build/556ae3bf3cea41c580c201990c37d1b7 : SUCCESS in 11m 29s (non-voting)\n- swift-tox-func-s3api-compat-tests-tempauth https://zuul.opendev.org/t/openstack/build/0d128e91226343d496f57c0c1b7d3005 : SUCCESS in 6m 52s\n- swift-probetests-centos-9-stream https://zuul.opendev.org/t/openstack/build/c1e87845ca214c2f95f522dc111611ac : SUCCESS in 38m 02s\n- swift-dsvm-functional https://zuul.opendev.org/t/openstack/build/6fd3c0daef6b4609be614981b178e7bd : SUCCESS in 26m 26s\n- swift-dsvm-functional-ipv6 https://zuul.opendev.org/t/openstack/build/a1ab7e0315484278a8224de490202450 : SUCCESS in 39m 14s\n- swift-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/8ded46f515c842bfa3a271a174ce7420 : SUCCESS in 23m 57s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/34901ae88bfa450f8cb68a5f19577b2e : SUCCESS in 4m 31s\n- swift-multinode-rolling-upgrade https://zuul.opendev.org/t/openstack/build/7f19df73996844f2afb1a14f5c48acbb : SUCCESS in 19m 46s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/c616dd01a6954fb0a141fc4da96ed9d2 : SUCCESS in 1h 10m 44s","accounts_in_message":[],"_revision_number":1},{"id":"72fe9e920232aeb399cafd701f840e324ebe873e","tag":"autogenerated:zuul:check-arm64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-05-21 23:05:17.000000000","message":"Patch Set 1:\n\nBuild succeeded (ARM64 pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/32336f3bf3da4f19b5db6555eb9e9bde\n\n- swift-tox-py312-arm64 https://zuul.opendev.org/t/openstack/build/2e4058cdf5984a59bb1f367ddbcbbab2 : SUCCESS in 59m 37s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"99eb55c1dfacea4be2cd3c438a65b0089bd788de","revisions":{"99eb55c1dfacea4be2cd3c438a65b0089bd788de":{"kind":"REWORK","_number":1,"created":"2026-05-21 18:02:48.000000000","uploader":{"_account_id":330,"name":"John Dickinson","email":"me@not.mn","username":"notmyname"},"ref":"refs/changes/98/989598/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/swift","ref":"refs/changes/98/989598/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/swift refs/changes/98/989598/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/swift refs/changes/98/989598/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/swift refs/changes/98/989598/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/swift refs/changes/98/989598/1"}}},"commit":{"parents":[{"commit":"ca8749f344168ad1c4e07fdfd24e68ca04c57eae","subject":"test_sharder.py: pass timestamp strings to put_object","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/ca8749f344168ad1c4e07fdfd24e68ca04c57eae"}]}],"author":{"name":"John Dickinson","email":"me@not.mn","date":"2026-05-21 17:49:15.000000000","tz":-420},"committer":{"name":"John Dickinson","email":"me@not.mn","date":"2026-05-21 18:02:46.000000000","tz":-420},"subject":"Reject negative object content lengths","message":"Reject negative object content lengths\n\nRequest.message_length() converts Content-Length to an integer but does\nnot reject negative values. The object server also accepts negative\nX-Backend-Obj-Content-Length values for chunked backend PUTs. Those values\ncan reach the diskfile writer and storage allocation code, causing a 500\ninstead of a client error.\n\nReject negative content lengths at both request parsing points. Invalid\nclient Content-Length and backend object content length values now return\n400 before the object server reaches disk allocation.\n\nCloses-Bug: #2153521\nAssisted-By: Codex (GPT 5.5)\nChange-Id: I655fefd9e0bf1b2fdcef7dec2275f2e719448fbb\nSigned-off-by: John Dickinson \u003cme@not.mn\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/99eb55c1dfacea4be2cd3c438a65b0089bd788de"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/99eb55c1dfacea4be2cd3c438a65b0089bd788de"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"OK","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY"},{"label":"Workflow","status":"MAY"}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Verified\u003dMAX","label:Verified\u003dMIN"],"atom_explanations":{"label:Verified\u003dMAX":"","label:Verified\u003dMIN":""}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","label:Code-Review\u003dMIN"],"atom_explanations":{"label:Code-Review\u003dMAX":"","label:Code-Review\u003dMIN":""}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Workflow\u003dMAX","label:Workflow\u003dMIN"],"atom_explanations":{"label:Workflow\u003dMAX":"","label:Workflow\u003dMIN":""}}}]}