)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":6968,"name":"Christian Schwede","email":"cschwede@nvidia.com","username":"cschwede"},"change_message_id":"0696ea083665326baba431613452649a53715a02","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"11afcd23_c565e016","updated":"2026-06-24 10:21:10.000000000","message":"LGTM. I think the Matts concern is addressed, thus moving forward.","commit_id":"b701338d87513267cf94c75fba670b59bc90c7ce"}],"swift/common/utils/timestamp.py":[{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"fe897ae2484bb138f1e7c1c67ab0326a2946b410","unresolved":true,"context_lines":[{"line_number":432,"context_line":"            return self.offset"},{"line_number":433,"context_line":"        if value \u003c 0:"},{"line_number":434,"context_line":"            raise ValueError(\u0027value must be non-negative\u0027)"},{"line_number":435,"context_line":"        self.offset +\u003d value"},{"line_number":436,"context_line":"        return self.offset"},{"line_number":437,"context_line":""},{"line_number":438,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":1,"id":"cca81d86_de790c3b","line":435,"updated":"2026-06-10 04:33:21.000000000","message":"Do we need to attempt to cast this to an int? because if this comes in as a float then offset will become a float, which seems wrong.","commit_id":"b701338d87513267cf94c75fba670b59bc90c7ce"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"bec712de19bf807c535bb9c682a2dd390622266d","unresolved":true,"context_lines":[{"line_number":432,"context_line":"            return self.offset"},{"line_number":433,"context_line":"        if value \u003c 0:"},{"line_number":434,"context_line":"            raise ValueError(\u0027value must be non-negative\u0027)"},{"line_number":435,"context_line":"        self.offset +\u003d value"},{"line_number":436,"context_line":"        return self.offset"},{"line_number":437,"context_line":""},{"line_number":438,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":1,"id":"9ad54d0d_63b240ca","line":435,"in_reply_to":"cca81d86_de790c3b","updated":"2026-06-10 14:46:15.000000000","message":"we do check it is an int at line 413 (the offset property setter)\n\nand test that a float is invalid here https://opendev.org/openstack/swift/src/commit/c528947467760b2ef26a4114a081bc7c38864b9c/test/unit/common/utils/test_timestamp.py#L378-L378","commit_id":"b701338d87513267cf94c75fba670b59bc90c7ce"}]}