)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1216,"name":"gholt","email":"z-launchpad@brim.net","username":"gholt"},"change_message_id":"6d5f9e5305601e8b4e1286d10b67134eebc93080","unresolved":false,"context_lines":[{"line_number":42,"context_line":"fast-POST may also take advantage of a offset vector update to change the"},{"line_number":43,"context_line":"\u0027content_type\u0027 of a row in the container.  The object-expirer could"},{"line_number":44,"context_line":"potentially benefit from the offset vector as well."},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"DocImpact"},{"line_number":47,"context_line":"Implements: blueprint storage-policies"},{"line_number":48,"context_line":"Change-Id: Id85c960b126ec919a481dc62469bf172b7fb8549"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"1ae5cdf2_ddddf915","line":45,"updated":"2014-06-18 17:14:52.000000000","message":"I don\u0027t think we could ever use a non-external stamp that changes actual content/exposed_metadata. It could cause sync problems with external clients.","commit_id":"5f9970f8a7990497dde68f3c1b176f309e1450fc"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"2c4007ed776f9cd9e936594351e76175c0998063","unresolved":false,"context_lines":[{"line_number":42,"context_line":"fast-POST may also take advantage of a offset vector update to change the"},{"line_number":43,"context_line":"\u0027content_type\u0027 of a row in the container.  The object-expirer could"},{"line_number":44,"context_line":"potentially benefit from the offset vector as well."},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"DocImpact"},{"line_number":47,"context_line":"Implements: blueprint storage-policies"},{"line_number":48,"context_line":"Change-Id: Id85c960b126ec919a481dc62469bf172b7fb8549"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"1ae5cdf2_18c11d4e","line":45,"in_reply_to":"1ae5cdf2_2006b61c","updated":"2014-06-19 03:02:49.000000000","message":"I reworded this to be less optimistic about the applicability in other use-cases and added some cautionary words about changing data in a way that\u0027s invisible to clients.","commit_id":"5f9970f8a7990497dde68f3c1b176f309e1450fc"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"425c5b4bdc394d25878b8c94a8753b05cb26bf18","unresolved":false,"context_lines":[{"line_number":42,"context_line":"fast-POST may also take advantage of a offset vector update to change the"},{"line_number":43,"context_line":"\u0027content_type\u0027 of a row in the container.  The object-expirer could"},{"line_number":44,"context_line":"potentially benefit from the offset vector as well."},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"DocImpact"},{"line_number":47,"context_line":"Implements: blueprint storage-policies"},{"line_number":48,"context_line":"Change-Id: Id85c960b126ec919a481dc62469bf172b7fb8549"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"1ae5cdf2_2006b61c","line":45,"in_reply_to":"1ae5cdf2_ddddf915","updated":"2014-06-18 17:27:53.000000000","message":"you mean to say that if we fixed fast-post to update the container listing and used an internal offset to force the update on the container row while still maintaining consistency when resolving differences in the etag and size based on the original object datafile that it would not work for \"external clients\" - like if someone was parsing the \"last modified\" part of a container listing?","commit_id":"5f9970f8a7990497dde68f3c1b176f309e1450fc"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"b910ef5b84dce2944dfb1beb8bdb890833b978dd","unresolved":false,"context_lines":[{"line_number":40,"context_line":"the wrong storage policy and be moved back.  This use-case is valid because"},{"line_number":41,"context_line":"the content represented by the user-facing timestamp is not modified in way."},{"line_number":42,"context_line":"Future consumers of the offset vector of timestamps should be mindful of HTTP"},{"line_number":43,"context_line":"semitics of If-Modified and take care to avoid deviation in the response from"},{"line_number":44,"context_line":"the object server without an accompanying change to the user facing timestamp."},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"DocImpact"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"1ae5cdf2_f088f8c7","line":43,"updated":"2014-06-19 15:28:29.000000000","message":"semitics -\u003e semantics?","commit_id":"587e591eb7e79f22318fdcceb80d76c7da09dda6"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"6a0cebc4dffa41942bf99bdc92abfb27e4a162be","unresolved":false,"context_lines":[{"line_number":40,"context_line":"the wrong storage policy and be moved back.  This use-case is valid because"},{"line_number":41,"context_line":"the content represented by the user-facing timestamp is not modified in way."},{"line_number":42,"context_line":"Future consumers of the offset vector of timestamps should be mindful of HTTP"},{"line_number":43,"context_line":"semitics of If-Modified and take care to avoid deviation in the response from"},{"line_number":44,"context_line":"the object server without an accompanying change to the user facing timestamp."},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"DocImpact"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"1ae5cdf2_b45bbb84","line":43,"in_reply_to":"1ae5cdf2_f088f8c7","updated":"2014-06-19 17:17:49.000000000","message":"oh, man :\\","commit_id":"587e591eb7e79f22318fdcceb80d76c7da09dda6"}],"swift/common/constraints.py":[{"author":{"_account_id":7479,"name":"paul luse","email":"paul.e.luse@intel.com","username":"peluse"},"change_message_id":"516ab3f426fab12e16f08cb3eb5540e29eb29a31","unresolved":false,"context_lines":[{"line_number":211,"context_line":""},{"line_number":212,"context_line":"def valid_timestamp(request):"},{"line_number":213,"context_line":"    \"\"\""},{"line_number":214,"context_line":"    Helper function for extract a timestamp from requests that require one."},{"line_number":215,"context_line":""},{"line_number":216,"context_line":"    :param request: the swob request object"},{"line_number":217,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_55e0d5f9","line":214,"updated":"2014-06-11 19:45:33.000000000","message":"/s/extract/exacting/","commit_id":"239cc5feb3f00dfdf3efa68fc6af733be82dbcb6"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"94e0fa2be1768f49dc52b58225f2779b639c5425","unresolved":false,"context_lines":[{"line_number":211,"context_line":""},{"line_number":212,"context_line":"def valid_timestamp(request):"},{"line_number":213,"context_line":"    \"\"\""},{"line_number":214,"context_line":"    Helper function for extract a timestamp from requests that require one."},{"line_number":215,"context_line":""},{"line_number":216,"context_line":"    :param request: the swob request object"},{"line_number":217,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_de65aa45","line":214,"in_reply_to":"1ae5cdf2_55e0d5f9","updated":"2014-06-13 10:03:53.000000000","message":"Done","commit_id":"239cc5feb3f00dfdf3efa68fc6af733be82dbcb6"}],"swift/common/db_replicator.py":[{"author":{"_account_id":7479,"name":"paul luse","email":"paul.e.luse@intel.com","username":"peluse"},"change_message_id":"516ab3f426fab12e16f08cb3eb5540e29eb29a31","unresolved":false,"context_lines":[{"line_number":666,"context_line":"            with self.debug_timing(\u0027update_metadata\u0027):"},{"line_number":667,"context_line":"                broker.update_metadata(remote_info[\u0027metadata\u0027])"},{"line_number":668,"context_line":"        sync_timestamps \u003d (\u0027created_at\u0027, \u0027put_timestamp\u0027, \u0027delete_timestamp\u0027)"},{"line_number":669,"context_line":"        # internalized timestamp format comparision, float equality is tricky"},{"line_number":670,"context_line":"        if any(info[ts] !\u003d remote_info[ts] for ts in sync_timestamps):"},{"line_number":671,"context_line":"            with self.debug_timing(\u0027merge_timestamps\u0027):"},{"line_number":672,"context_line":"                broker.merge_timestamps(*(remote_info[ts] for ts in"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_f09c8fc2","line":669,"updated":"2014-06-11 19:45:33.000000000","message":"hmmm, not sure what your intent for the reader is here with this comment","commit_id":"239cc5feb3f00dfdf3efa68fc6af733be82dbcb6"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"94e0fa2be1768f49dc52b58225f2779b639c5425","unresolved":false,"context_lines":[{"line_number":666,"context_line":"            with self.debug_timing(\u0027update_metadata\u0027):"},{"line_number":667,"context_line":"                broker.update_metadata(remote_info[\u0027metadata\u0027])"},{"line_number":668,"context_line":"        sync_timestamps \u003d (\u0027created_at\u0027, \u0027put_timestamp\u0027, \u0027delete_timestamp\u0027)"},{"line_number":669,"context_line":"        # internalized timestamp format comparision, float equality is tricky"},{"line_number":670,"context_line":"        if any(info[ts] !\u003d remote_info[ts] for ts in sync_timestamps):"},{"line_number":671,"context_line":"            with self.debug_timing(\u0027merge_timestamps\u0027):"},{"line_number":672,"context_line":"                broker.merge_timestamps(*(remote_info[ts] for ts in"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_7e4c96c8","line":669,"in_reply_to":"1ae5cdf2_f09c8fc2","updated":"2014-06-13 10:03:53.000000000","message":"left over from some code that got backed out of there, I just removed the comment...\n\nDone","commit_id":"239cc5feb3f00dfdf3efa68fc6af733be82dbcb6"}],"swift/common/swob.py":[{"author":{"_account_id":7479,"name":"paul luse","email":"paul.e.luse@intel.com","username":"peluse"},"change_message_id":"516ab3f426fab12e16f08cb3eb5540e29eb29a31","unresolved":false,"context_lines":[{"line_number":846,"context_line":"    str_params \u003d params"},{"line_number":847,"context_line":""},{"line_number":848,"context_line":"    @property"},{"line_number":849,"context_line":"    def timestamp(self):"},{"line_number":850,"context_line":"        \"\"\""},{"line_number":851,"context_line":"        Provides HTTP_X_TIMESTAMP as a :class:`~swift.common.utils.Timestamp`"},{"line_number":852,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_70f95f7f","line":849,"updated":"2014-06-11 19:45:33.000000000","message":"can you explain the need for this?","commit_id":"239cc5feb3f00dfdf3efa68fc6af733be82dbcb6"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"94e0fa2be1768f49dc52b58225f2779b639c5425","unresolved":false,"context_lines":[{"line_number":846,"context_line":"    str_params \u003d params"},{"line_number":847,"context_line":""},{"line_number":848,"context_line":"    @property"},{"line_number":849,"context_line":"    def timestamp(self):"},{"line_number":850,"context_line":"        \"\"\""},{"line_number":851,"context_line":"        Provides HTTP_X_TIMESTAMP as a :class:`~swift.common.utils.Timestamp`"},{"line_number":852,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_5effda33","line":849,"in_reply_to":"1ae5cdf2_70f95f7f","updated":"2014-06-13 10:03:53.000000000","message":"parsing the header into a Timestamp class multiple times isn\u0027t super expensive - but it seems wasteful.  This allows anyone that needs a timestamp to pull it directly off the request and future access is free - all you have to do is pass around the reference to the request - without having to pass around another reference to the timestamp directly.\n\nOr at least that\u0027s the idea, it may not have turned out to be that super useful in the code paths that I hit.","commit_id":"239cc5feb3f00dfdf3efa68fc6af733be82dbcb6"}],"swift/common/utils.py":[{"author":{"_account_id":7479,"name":"paul luse","email":"paul.e.luse@intel.com","username":"peluse"},"change_message_id":"516ab3f426fab12e16f08cb3eb5540e29eb29a31","unresolved":false,"context_lines":[{"line_number":566,"context_line":"# Setting this to True will cause the internal format to always display"},{"line_number":567,"context_line":"# extended digits - even when the value is equivilant to the normalized form."},{"line_number":568,"context_line":"# This isn\u0027t ideal during an upgrade when some servers might not understand"},{"line_number":569,"context_line":"# the new time format - but flipping it to True works great for testing."},{"line_number":570,"context_line":"FORCE_INTERNAL \u003d False  # or True"},{"line_number":571,"context_line":""},{"line_number":572,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_b552f9db","line":569,"updated":"2014-06-11 19:45:33.000000000","message":"so this is for debug only?","commit_id":"239cc5feb3f00dfdf3efa68fc6af733be82dbcb6"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"94e0fa2be1768f49dc52b58225f2779b639c5425","unresolved":false,"context_lines":[{"line_number":566,"context_line":"# Setting this to True will cause the internal format to always display"},{"line_number":567,"context_line":"# extended digits - even when the value is equivilant to the normalized form."},{"line_number":568,"context_line":"# This isn\u0027t ideal during an upgrade when some servers might not understand"},{"line_number":569,"context_line":"# the new time format - but flipping it to True works great for testing."},{"line_number":570,"context_line":"FORCE_INTERNAL \u003d False  # or True"},{"line_number":571,"context_line":""},{"line_number":572,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_3eb20e94","line":569,"in_reply_to":"1ae5cdf2_b552f9db","updated":"2014-06-13 10:03:53.000000000","message":"i apparently used to many words to say that - but yes.  While we could theoretically turn on FORCE_INTERNAL once we think all existing deployments will understand the new format during an upgrade - I don\u0027t think we have too.  It seems reasonable to me at least to continue to use the old format for timestamps with an insignificant timestamp till forever.  As long as folks understand you can\u0027t just float them - even though *most* of the time you can.","commit_id":"239cc5feb3f00dfdf3efa68fc6af733be82dbcb6"},{"author":{"_account_id":7479,"name":"paul luse","email":"paul.e.luse@intel.com","username":"peluse"},"change_message_id":"516ab3f426fab12e16f08cb3eb5540e29eb29a31","unresolved":false,"context_lines":[{"line_number":590,"context_line":"        if offset \u003e\u003d 0:"},{"line_number":591,"context_line":"            self.offset +\u003d offset"},{"line_number":592,"context_line":"        else:"},{"line_number":593,"context_line":"            raise ValueError(\u0027offset must be non-negative\u0027)"},{"line_number":594,"context_line":""},{"line_number":595,"context_line":"    def __repr__(self):"},{"line_number":596,"context_line":"        return INTERNAL_FORMAT % (self.timestamp, self.offset)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_156acded","line":593,"updated":"2014-06-11 19:45:33.000000000","message":"probably knew this, missing coverage in unit test","commit_id":"239cc5feb3f00dfdf3efa68fc6af733be82dbcb6"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"94e0fa2be1768f49dc52b58225f2779b639c5425","unresolved":false,"context_lines":[{"line_number":590,"context_line":"        if offset \u003e\u003d 0:"},{"line_number":591,"context_line":"            self.offset +\u003d offset"},{"line_number":592,"context_line":"        else:"},{"line_number":593,"context_line":"            raise ValueError(\u0027offset must be non-negative\u0027)"},{"line_number":594,"context_line":""},{"line_number":595,"context_line":"    def __repr__(self):"},{"line_number":596,"context_line":"        return INTERNAL_FORMAT % (self.timestamp, self.offset)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_3e276ecb","line":593,"in_reply_to":"1ae5cdf2_156acded","updated":"2014-06-13 10:03:53.000000000","message":"Done","commit_id":"239cc5feb3f00dfdf3efa68fc6af733be82dbcb6"},{"author":{"_account_id":7479,"name":"paul luse","email":"paul.e.luse@intel.com","username":"peluse"},"change_message_id":"516ab3f426fab12e16f08cb3eb5540e29eb29a31","unresolved":false,"context_lines":[{"line_number":596,"context_line":"        return INTERNAL_FORMAT % (self.timestamp, self.offset)"},{"line_number":597,"context_line":""},{"line_number":598,"context_line":"    def __str__(self):"},{"line_number":599,"context_line":"        raise TypeError(\u0027You must specificy which string format is required\u0027)"},{"line_number":600,"context_line":""},{"line_number":601,"context_line":"    def __float__(self):"},{"line_number":602,"context_line":"        return self.timestamp"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_356b49f2","line":599,"updated":"2014-06-11 19:45:33.000000000","message":"probably knew this, missing coverage in unit test","commit_id":"239cc5feb3f00dfdf3efa68fc6af733be82dbcb6"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"94e0fa2be1768f49dc52b58225f2779b639c5425","unresolved":false,"context_lines":[{"line_number":596,"context_line":"        return INTERNAL_FORMAT % (self.timestamp, self.offset)"},{"line_number":597,"context_line":""},{"line_number":598,"context_line":"    def __str__(self):"},{"line_number":599,"context_line":"        raise TypeError(\u0027You must specificy which string format is required\u0027)"},{"line_number":600,"context_line":""},{"line_number":601,"context_line":"    def __float__(self):"},{"line_number":602,"context_line":"        return self.timestamp"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_1e3d52dd","line":599,"in_reply_to":"1ae5cdf2_356b49f2","updated":"2014-06-13 10:03:53.000000000","message":"Done","commit_id":"239cc5feb3f00dfdf3efa68fc6af733be82dbcb6"},{"author":{"_account_id":7479,"name":"paul luse","email":"paul.e.luse@intel.com","username":"peluse"},"change_message_id":"516ab3f426fab12e16f08cb3eb5540e29eb29a31","unresolved":false,"context_lines":[{"line_number":643,"context_line":"        return cmp(self.internal, other.internal)"},{"line_number":644,"context_line":""},{"line_number":645,"context_line":""},{"line_number":646,"context_line":"def normalize_timestamp(timestamp):"},{"line_number":647,"context_line":"    \"\"\""},{"line_number":648,"context_line":"    Format a timestamp (string or numeric) into a standardized"},{"line_number":649,"context_line":"    xxxxxxxxxx.xxxxx (10.5) format."}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_70c5df8c","line":646,"updated":"2014-06-11 19:45:33.000000000","message":"are there still callers of this (other than test code?)?","commit_id":"239cc5feb3f00dfdf3efa68fc6af733be82dbcb6"},{"author":{"_account_id":7479,"name":"paul luse","email":"paul.e.luse@intel.com","username":"peluse"},"change_message_id":"fa9d7811e5d50be993517c04fe0da58d65d33179","unresolved":false,"context_lines":[{"line_number":643,"context_line":"        return cmp(self.internal, other.internal)"},{"line_number":644,"context_line":""},{"line_number":645,"context_line":""},{"line_number":646,"context_line":"def normalize_timestamp(timestamp):"},{"line_number":647,"context_line":"    \"\"\""},{"line_number":648,"context_line":"    Format a timestamp (string or numeric) into a standardized"},{"line_number":649,"context_line":"    xxxxxxxxxx.xxxxx (10.5) format."}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_e833885f","line":646,"in_reply_to":"1ae5cdf2_5e099a2f","updated":"2014-06-13 13:24:06.000000000","message":"OK cool.  From my grep it looked like it could be moved to test code but I guess not.  thanks","commit_id":"239cc5feb3f00dfdf3efa68fc6af733be82dbcb6"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"94e0fa2be1768f49dc52b58225f2779b639c5425","unresolved":false,"context_lines":[{"line_number":643,"context_line":"        return cmp(self.internal, other.internal)"},{"line_number":644,"context_line":""},{"line_number":645,"context_line":""},{"line_number":646,"context_line":"def normalize_timestamp(timestamp):"},{"line_number":647,"context_line":"    \"\"\""},{"line_number":648,"context_line":"    Format a timestamp (string or numeric) into a standardized"},{"line_number":649,"context_line":"    xxxxxxxxxx.xxxxx (10.5) format."}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_5e099a2f","line":646,"in_reply_to":"1ae5cdf2_70c5df8c","updated":"2014-06-13 10:03:53.000000000","message":"I think it\u0027s probably part of our external interface at this point, like get_logger or readconf.  But yeah I sorta audited for any users of the method in a hope that might point me to other places I should be worried about timestamps.","commit_id":"239cc5feb3f00dfdf3efa68fc6af733be82dbcb6"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"100afa499d1e54e2f28d78cb44c3cc201dc58e2b","unresolved":false,"context_lines":[{"line_number":565,"context_line":"NORMAL_FORMAT \u003d \"%016.05f\""},{"line_number":566,"context_line":"INTERNAL_FORMAT \u003d NORMAL_FORMAT + \u0027_%08x\u0027"},{"line_number":567,"context_line":"# Setting this to True will cause the internal format to always display"},{"line_number":568,"context_line":"# extended digits - even when the value is equivilant to the normalized form."},{"line_number":569,"context_line":"# This isn\u0027t ideal during an upgrade when some servers might not understand"},{"line_number":570,"context_line":"# the new time format - but flipping it to True works great for testing."},{"line_number":571,"context_line":"FORCE_INTERNAL \u003d False  # or True"}],"source_content_type":"text/x-python","patch_set":4,"id":"1ae5cdf2_de0d58ea","line":568,"updated":"2014-06-16 20:06:08.000000000","message":"nit: s/equivilant/equivalent/","commit_id":"58ddab8967c0c9072f441fa51d1201b02ffc4c9a"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"84f59e3c79d62cdb7c45d2736840ab87273130ae","unresolved":false,"context_lines":[{"line_number":565,"context_line":"NORMAL_FORMAT \u003d \"%016.05f\""},{"line_number":566,"context_line":"INTERNAL_FORMAT \u003d NORMAL_FORMAT + \u0027_%08x\u0027"},{"line_number":567,"context_line":"# Setting this to True will cause the internal format to always display"},{"line_number":568,"context_line":"# extended digits - even when the value is equivilant to the normalized form."},{"line_number":569,"context_line":"# This isn\u0027t ideal during an upgrade when some servers might not understand"},{"line_number":570,"context_line":"# the new time format - but flipping it to True works great for testing."},{"line_number":571,"context_line":"FORCE_INTERNAL \u003d False  # or True"}],"source_content_type":"text/x-python","patch_set":4,"id":"1ae5cdf2_1d086fd8","line":568,"in_reply_to":"1ae5cdf2_de0d58ea","updated":"2014-06-17 20:38:57.000000000","message":"Done","commit_id":"58ddab8967c0c9072f441fa51d1201b02ffc4c9a"}],"swift/obj/diskfile.py":[{"author":{"_account_id":7479,"name":"paul luse","email":"paul.e.luse@intel.com","username":"peluse"},"change_message_id":"bc616fbeea4baf6f84657086abb8afb958af3eb8","unresolved":false,"context_lines":[{"line_number":228,"context_line":"        if files[0].endswith(\u0027.ts\u0027):"},{"line_number":229,"context_line":"            # remove tombstones older than reclaim_age"},{"line_number":230,"context_line":"            ts \u003d files[0].rsplit(\u0027.\u0027, 1)[0]"},{"line_number":231,"context_line":"            if (time.time() - float(Timestamp(ts))) \u003e reclaim_age:"},{"line_number":232,"context_line":"                remove_file(join(hsh_path, files[0]))"},{"line_number":233,"context_line":"                files.remove(files[0])"},{"line_number":234,"context_line":"    elif files:"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_0acc5088","line":231,"updated":"2014-06-12 16:12:32.000000000","message":"in general it feels like there\u0027s been some potential rasies introduced a lot of places there the Timestamp class is used where before there was no chance of an error.  I\u0027m not flagging a potential issue, just asking if this observation is correct and/or relevant from your experience","commit_id":"239cc5feb3f00dfdf3efa68fc6af733be82dbcb6"},{"author":{"_account_id":7479,"name":"paul luse","email":"paul.e.luse@intel.com","username":"peluse"},"change_message_id":"fa9d7811e5d50be993517c04fe0da58d65d33179","unresolved":false,"context_lines":[{"line_number":228,"context_line":"        if files[0].endswith(\u0027.ts\u0027):"},{"line_number":229,"context_line":"            # remove tombstones older than reclaim_age"},{"line_number":230,"context_line":"            ts \u003d files[0].rsplit(\u0027.\u0027, 1)[0]"},{"line_number":231,"context_line":"            if (time.time() - float(Timestamp(ts))) \u003e reclaim_age:"},{"line_number":232,"context_line":"                remove_file(join(hsh_path, files[0]))"},{"line_number":233,"context_line":"                files.remove(files[0])"},{"line_number":234,"context_line":"    elif files:"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_88de84d8","line":231,"in_reply_to":"1ae5cdf2_01f25705","updated":"2014-06-13 13:24:06.000000000","message":"From what I can its probably OK not to add anything more for now but something to keep an eye out for","commit_id":"239cc5feb3f00dfdf3efa68fc6af733be82dbcb6"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"94e0fa2be1768f49dc52b58225f2779b639c5425","unresolved":false,"context_lines":[{"line_number":228,"context_line":"        if files[0].endswith(\u0027.ts\u0027):"},{"line_number":229,"context_line":"            # remove tombstones older than reclaim_age"},{"line_number":230,"context_line":"            ts \u003d files[0].rsplit(\u0027.\u0027, 1)[0]"},{"line_number":231,"context_line":"            if (time.time() - float(Timestamp(ts))) \u003e reclaim_age:"},{"line_number":232,"context_line":"                remove_file(join(hsh_path, files[0]))"},{"line_number":233,"context_line":"                files.remove(files[0])"},{"line_number":234,"context_line":"    elif files:"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_01f25705","line":231,"in_reply_to":"1ae5cdf2_0acc5088","updated":"2014-06-13 10:03:53.000000000","message":"hrmm... not sure.  I mean in this particular case either line in the diff would blow up if the file name was \u0027foo.ts\u0027 - but somehow that doesn\u0027t happen much, or when it does some other code higher up does something reasonable with the error?\n\nThere\u0027s some code paths that have to do with handling errors where we need to be extract careful, and anywhere we touch disk there\u0027s risk of corrupt data...\n\nI think in this case there\u0027s just no clear path to recovery.  In _finalize_put we could maybe try and quarantine?\n\nDunno - good question though.","commit_id":"239cc5feb3f00dfdf3efa68fc6af733be82dbcb6"}],"swift/obj/mem_diskfile.py":[{"author":{"_account_id":7479,"name":"paul luse","email":"paul.e.luse@intel.com","username":"peluse"},"change_message_id":"bc616fbeea4baf6f84657086abb8afb958af3eb8","unresolved":false,"context_lines":[{"line_number":395,"context_line":"        :param timestamp: timestamp to compare with each file"},{"line_number":396,"context_line":"        \"\"\""},{"line_number":397,"context_line":"        fp, md \u003d self._filesystem.get_object(self._name)"},{"line_number":398,"context_line":"        if md[\u0027X-Timestamp\u0027] \u003c Timestamp(timestamp):"},{"line_number":399,"context_line":"            self._filesystem.del_object(self._name)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_8ae300d8","line":398,"updated":"2014-06-12 16:12:32.000000000","message":"for each replacement w/Timestamp did you have to fully trace its use (like here, examine callers) to determine whether .internal was needed or not?  What is/was the rule exactly for when to use .internal versus not?  Also, in case I forget to look later, do you have any sort of func tests that makes sure an internal doesn\u0027t get exposed externally?","commit_id":"239cc5feb3f00dfdf3efa68fc6af733be82dbcb6"},{"author":{"_account_id":7479,"name":"paul luse","email":"paul.e.luse@intel.com","username":"peluse"},"change_message_id":"fa9d7811e5d50be993517c04fe0da58d65d33179","unresolved":false,"context_lines":[{"line_number":395,"context_line":"        :param timestamp: timestamp to compare with each file"},{"line_number":396,"context_line":"        \"\"\""},{"line_number":397,"context_line":"        fp, md \u003d self._filesystem.get_object(self._name)"},{"line_number":398,"context_line":"        if md[\u0027X-Timestamp\u0027] \u003c Timestamp(timestamp):"},{"line_number":399,"context_line":"            self._filesystem.del_object(self._name)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_c89a4c13","line":398,"in_reply_to":"1ae5cdf2_21283332","updated":"2014-06-13 13:24:06.000000000","message":"great, thanks!","commit_id":"239cc5feb3f00dfdf3efa68fc6af733be82dbcb6"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"94e0fa2be1768f49dc52b58225f2779b639c5425","unresolved":false,"context_lines":[{"line_number":395,"context_line":"        :param timestamp: timestamp to compare with each file"},{"line_number":396,"context_line":"        \"\"\""},{"line_number":397,"context_line":"        fp, md \u003d self._filesystem.get_object(self._name)"},{"line_number":398,"context_line":"        if md[\u0027X-Timestamp\u0027] \u003c Timestamp(timestamp):"},{"line_number":399,"context_line":"            self._filesystem.del_object(self._name)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_21283332","line":398,"in_reply_to":"1ae5cdf2_8ae300d8","updated":"2014-06-13 10:03:53.000000000","message":"the normal/internal thing only has to do with when you\u0027re going to a string - if you\u0027re just comparing internally you don\u0027t really have to worry about it as long as either they\u0027re both strings, or one of them is a timestamp it\u0027ll always do the right thing.  Which is nice, cause you used to always have to worry that one of them was a float and you were boned.\n\nWhen storing a timestamp or sending it along to another swift process - I always use internal, and if the timestamp doesn\u0027t have an offset then that\u0027s actually the same thing as normal - if that makes sense.\n\nAs far as functests, i didn\u0027t see any any existing tests that looked for X-Timestamp, and since it\u0027s generated by the server it\u0027s hard to say what the value should be, but I cold try and glean something about the structure (does it look like a float, does it have the right number of digits).\n\nBut I don\u0027t think that checking for it in a few places really proves the negative, I did audit unittests and make sure anytime we were looking for at a timestamp that would propagate up through the api we verified it was in the normal format (even when I ran tests with FORCE_INTERNAL)\n\nso I have some confidence","commit_id":"239cc5feb3f00dfdf3efa68fc6af733be82dbcb6"}],"swift/obj/server.py":[{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"6fa3eaea74e5690dfade91dd1dab58cb148960a7","unresolved":false,"context_lines":[{"line_number":557,"context_line":"        response.last_modified \u003d math.ceil(float(ts))"},{"line_number":558,"context_line":"        # Needed for container sync feature"},{"line_number":559,"context_line":"        response.headers[\u0027X-Timestamp\u0027] \u003d ts.normal"},{"line_number":560,"context_line":"        response.headers[\u0027X-Backend-Timestamp\u0027] \u003d ts.internal"},{"line_number":561,"context_line":"        response.content_length \u003d int(metadata[\u0027Content-Length\u0027])"},{"line_number":562,"context_line":"        try:"},{"line_number":563,"context_line":"            response.content_encoding \u003d metadata[\u0027Content-Encoding\u0027]"}],"source_content_type":"text/x-python","patch_set":7,"id":"1ae5cdf2_cfa2683e","line":560,"updated":"2014-06-19 23:32:49.000000000","message":"Does this mean the that the meta data returned to the user will contain the internal and external timestamp?\n\nI\u0027m fine with this, just confirming that we don\u0027t mind leaking the internal timestamps back to the user.","commit_id":"c1dc2fa624d2abaea1c872a4e98bf7880c07c236"},{"author":{"_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"},"change_message_id":"10eb8eeb7102c73de88915fe2ebeed8daab41fe0","unresolved":false,"context_lines":[{"line_number":557,"context_line":"        response.last_modified \u003d math.ceil(float(ts))"},{"line_number":558,"context_line":"        # Needed for container sync feature"},{"line_number":559,"context_line":"        response.headers[\u0027X-Timestamp\u0027] \u003d ts.normal"},{"line_number":560,"context_line":"        response.headers[\u0027X-Backend-Timestamp\u0027] \u003d ts.internal"},{"line_number":561,"context_line":"        response.content_length \u003d int(metadata[\u0027Content-Length\u0027])"},{"line_number":562,"context_line":"        try:"},{"line_number":563,"context_line":"            response.content_encoding \u003d metadata[\u0027Content-Encoding\u0027]"}],"source_content_type":"text/x-python","patch_set":7,"id":"1ae5cdf2_e2065bcd","line":560,"in_reply_to":"1ae5cdf2_cfa2683e","updated":"2014-06-19 23:39:15.000000000","message":"Nope, X-Backend-* gets filtered out by the gatekeeper middleware. Middleware in the proxy can see it, but it\u0027ll never make it out to a client.","commit_id":"c1dc2fa624d2abaea1c872a4e98bf7880c07c236"},{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"596e22133f6528c8973a6f5ff391336ed2d0ba13","unresolved":false,"context_lines":[{"line_number":557,"context_line":"        response.last_modified \u003d math.ceil(float(ts))"},{"line_number":558,"context_line":"        # Needed for container sync feature"},{"line_number":559,"context_line":"        response.headers[\u0027X-Timestamp\u0027] \u003d ts.normal"},{"line_number":560,"context_line":"        response.headers[\u0027X-Backend-Timestamp\u0027] \u003d ts.internal"},{"line_number":561,"context_line":"        response.content_length \u003d int(metadata[\u0027Content-Length\u0027])"},{"line_number":562,"context_line":"        try:"},{"line_number":563,"context_line":"            response.content_encoding \u003d metadata[\u0027Content-Encoding\u0027]"}],"source_content_type":"text/x-python","patch_set":7,"id":"1ae5cdf2_7b4032a5","line":560,"in_reply_to":"1ae5cdf2_e2065bcd","updated":"2014-06-20 02:48:55.000000000","message":"Awesome! Thanks for clearing that up, muchly appreciated.","commit_id":"c1dc2fa624d2abaea1c872a4e98bf7880c07c236"}],"test/unit/cli/test_info.py":[{"author":{"_account_id":7479,"name":"paul luse","email":"paul.e.luse@intel.com","username":"peluse"},"change_message_id":"bc616fbeea4baf6f84657086abb8afb958af3eb8","unresolved":false,"context_lines":[{"line_number":115,"context_line":"  Account: acct"},{"line_number":116,"context_line":"  Account Hash: dc5be2aa4347a22a0fee6bc7de505b47"},{"line_number":117,"context_line":"Metadata:"},{"line_number":118,"context_line":"  Created at: 1970-01-01T00:01:40.100000 (100.1)"},{"line_number":119,"context_line":"  Put Timestamp: 1970-01-01T00:01:46.300000 (106.3)"},{"line_number":120,"context_line":"  Delete Timestamp: 1970-01-01T00:01:47.900000 (107.9)"},{"line_number":121,"context_line":"  Status Timestamp: 1970-01-01T00:01:48.300000 (108.3)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_8d7f9adf","line":118,"updated":"2014-06-12 16:12:32.000000000","message":"where did miss the introduction the T between date and time?","commit_id":"239cc5feb3f00dfdf3efa68fc6af733be82dbcb6"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"94e0fa2be1768f49dc52b58225f2779b639c5425","unresolved":false,"context_lines":[{"line_number":115,"context_line":"  Account: acct"},{"line_number":116,"context_line":"  Account Hash: dc5be2aa4347a22a0fee6bc7de505b47"},{"line_number":117,"context_line":"Metadata:"},{"line_number":118,"context_line":"  Created at: 1970-01-01T00:01:40.100000 (100.1)"},{"line_number":119,"context_line":"  Put Timestamp: 1970-01-01T00:01:46.300000 (106.3)"},{"line_number":120,"context_line":"  Delete Timestamp: 1970-01-01T00:01:47.900000 (107.9)"},{"line_number":121,"context_line":"  Status Timestamp: 1970-01-01T00:01:48.300000 (108.3)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_61cb1b72","line":118,"in_reply_to":"1ae5cdf2_8d7f9adf","updated":"2014-06-13 10:03:53.000000000","message":"isoformat\u0027s always like that, for like in the container listings.  It seemed close enough that I didn\u0027t bother writing a second human readable converter on the Timestamp class.","commit_id":"239cc5feb3f00dfdf3efa68fc6af733be82dbcb6"}],"test/unit/common/test_utils.py":[{"author":{"_account_id":7479,"name":"paul luse","email":"paul.e.luse@intel.com","username":"peluse"},"change_message_id":"bc616fbeea4baf6f84657086abb8afb958af3eb8","unresolved":false,"context_lines":[{"line_number":236,"context_line":"    def test_no_force_internal_with_offset(self):"},{"line_number":237,"context_line":"        \"\"\"Test that internal always includes the offset if significant\"\"\""},{"line_number":238,"context_line":"        with mock.patch(\u0027swift.common.utils.FORCE_INTERNAL\u0027, new\u003dFalse):"},{"line_number":239,"context_line":"            self.assertEqual(utils.Timestamp(0, offset\u003d1).internal,"},{"line_number":240,"context_line":"                             \u00270000000000.00000_00000001\u0027)"},{"line_number":241,"context_line":"            self.assertEqual("},{"line_number":242,"context_line":"                utils.Timestamp(1402437380.58186, offset\u003d16).internal,"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_a0b1bd02","line":239,"updated":"2014-06-12 16:12:32.000000000","message":"was wondering what would happen if the offset increment in Timestamp would blow up if we specified an offset when instantiating the class with an already maxed out (8 char) initial value.  Don\u0027t know if I should be surprised or not but it worked fine and rolled from 0xffffffff to 0x100000000 - is that what you\u0027d expect?\n            self.assertEqual(utils.Timestamp(\u00274294967295.000000_00000001\u0027, offset\u003d4294967295).internal,\n                             \u00274294967295.00000_100000000\u0027)","commit_id":"239cc5feb3f00dfdf3efa68fc6af733be82dbcb6"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"94e0fa2be1768f49dc52b58225f2779b639c5425","unresolved":false,"context_lines":[{"line_number":236,"context_line":"    def test_no_force_internal_with_offset(self):"},{"line_number":237,"context_line":"        \"\"\"Test that internal always includes the offset if significant\"\"\""},{"line_number":238,"context_line":"        with mock.patch(\u0027swift.common.utils.FORCE_INTERNAL\u0027, new\u003dFalse):"},{"line_number":239,"context_line":"            self.assertEqual(utils.Timestamp(0, offset\u003d1).internal,"},{"line_number":240,"context_line":"                             \u00270000000000.00000_00000001\u0027)"},{"line_number":241,"context_line":"            self.assertEqual("},{"line_number":242,"context_line":"                utils.Timestamp(1402437380.58186, offset\u003d16).internal,"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_e1bbabc1","line":239,"in_reply_to":"1ae5cdf2_a0b1bd02","updated":"2014-06-13 10:03:53.000000000","message":"well sort of, that basically the same as the 2286 bug, they all screw up the string sorting.  I knew it was there, but I don\u0027t like think it\u0027s \"good\" or anything - I think it\u0027d be better to overflow into the timestamp portion, but I don\u0027t expect to move an about around in the reconciler that many times.","commit_id":"239cc5feb3f00dfdf3efa68fc6af733be82dbcb6"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"b673f094c11d9163d7aba3b70993f649eb81e414","unresolved":false,"context_lines":[{"line_number":647,"context_line":"        ]"},{"line_number":648,"context_line":"        expected \u003d [t for t in given]"},{"line_number":649,"context_line":"        random.shuffle(given)"},{"line_number":650,"context_line":"        \"\"\""},{"line_number":651,"context_line":"        self.assertEqual(len(given), len(expected))  # sanity"},{"line_number":652,"context_line":"        timestamps \u003d [utils.Timestamp(t) for t in given]"},{"line_number":653,"context_line":"        # our expected values don\u0027t include insignificant offsets"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_ad07d2c8","line":650,"updated":"2014-06-13 13:50:23.000000000","message":"delete the commented code","commit_id":"239cc5feb3f00dfdf3efa68fc6af733be82dbcb6"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"e39343a27b979eb2418dcc51086543f58f72cafb","unresolved":false,"context_lines":[{"line_number":647,"context_line":"        ]"},{"line_number":648,"context_line":"        expected \u003d [t for t in given]"},{"line_number":649,"context_line":"        random.shuffle(given)"},{"line_number":650,"context_line":"        \"\"\""},{"line_number":651,"context_line":"        self.assertEqual(len(given), len(expected))  # sanity"},{"line_number":652,"context_line":"        timestamps \u003d [utils.Timestamp(t) for t in given]"},{"line_number":653,"context_line":"        # our expected values don\u0027t include insignificant offsets"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_1cc70d46","line":650,"in_reply_to":"1ae5cdf2_ad07d2c8","updated":"2014-06-13 18:03:47.000000000","message":"no i like it, if somebody wants to maintain the static business it\u0027ll be handy to have how it was generated.","commit_id":"239cc5feb3f00dfdf3efa68fc6af733be82dbcb6"}],"test/unit/container/test_reconciler.py":[{"author":{"_account_id":7479,"name":"paul luse","email":"paul.e.luse@intel.com","username":"peluse"},"change_message_id":"bc616fbeea4baf6f84657086abb8afb958af3eb8","unresolved":false,"context_lines":[{"line_number":233,"context_line":"                           \u0027content_type\u0027: \u0027application/x-put\u0027})"},{"line_number":234,"context_line":""},{"line_number":235,"context_line":"    def test_get_container_policy_index(self):"},{"line_number":236,"context_line":"        ts \u003d itertools.count(int(time.time()))"},{"line_number":237,"context_line":"        mock_path \u003d \u0027swift.container.reconciler.direct_head_container\u0027"},{"line_number":238,"context_line":"        stub_resp_headers \u003d ["},{"line_number":239,"context_line":"            container_resp_headers("}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_f9fffc31","line":236,"updated":"2014-06-12 16:12:32.000000000","message":"you could do\nts \u003d (Timestamp(t).internal for t in itertools.count(int(time/time())))\nhere and just ts.next in the next 3 changes right (and a bunch later too)?  More my my understanding than anything :)","commit_id":"239cc5feb3f00dfdf3efa68fc6af733be82dbcb6"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"94e0fa2be1768f49dc52b58225f2779b639c5425","unresolved":false,"context_lines":[{"line_number":233,"context_line":"                           \u0027content_type\u0027: \u0027application/x-put\u0027})"},{"line_number":234,"context_line":""},{"line_number":235,"context_line":"    def test_get_container_policy_index(self):"},{"line_number":236,"context_line":"        ts \u003d itertools.count(int(time.time()))"},{"line_number":237,"context_line":"        mock_path \u003d \u0027swift.container.reconciler.direct_head_container\u0027"},{"line_number":238,"context_line":"        stub_resp_headers \u003d ["},{"line_number":239,"context_line":"            container_resp_headers("}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_21e913b7","line":236,"in_reply_to":"1ae5cdf2_f9fffc31","updated":"2014-06-13 10:03:53.000000000","message":"yeah I think i made that change in a number of tests, dunno why I didn\u0027t bother to do it here.  Seems equally readable either way.","commit_id":"239cc5feb3f00dfdf3efa68fc6af733be82dbcb6"}],"test/unit/container/test_replicator.py":[{"author":{"_account_id":7479,"name":"paul luse","email":"paul.e.luse@intel.com","username":"peluse"},"change_message_id":"bc616fbeea4baf6f84657086abb8afb958af3eb8","unresolved":false,"context_lines":[{"line_number":637,"context_line":"        remote_policy \u003d random.choice([p for p in POLICIES if p is not"},{"line_number":638,"context_line":"                                       policy])"},{"line_number":639,"context_line":"        remote_broker \u003d self._get_broker(\u0027a\u0027, \u0027c\u0027, node_index\u003d1)"},{"line_number":640,"context_line":"        remote_broker.initialize(Timestamp(ts.next()).internal,"},{"line_number":641,"context_line":"                                 remote_policy.idx)"},{"line_number":642,"context_line":"        # add misplaced row to remote_broker"},{"line_number":643,"context_line":"        remote_broker.put_object("}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_342ecb8c","line":640,"updated":"2014-06-12 16:12:32.000000000","message":"this can\u0027t be just ts.next()?","commit_id":"239cc5feb3f00dfdf3efa68fc6af733be82dbcb6"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"94e0fa2be1768f49dc52b58225f2779b639c5425","unresolved":false,"context_lines":[{"line_number":637,"context_line":"        remote_policy \u003d random.choice([p for p in POLICIES if p is not"},{"line_number":638,"context_line":"                                       policy])"},{"line_number":639,"context_line":"        remote_broker \u003d self._get_broker(\u0027a\u0027, \u0027c\u0027, node_index\u003d1)"},{"line_number":640,"context_line":"        remote_broker.initialize(Timestamp(ts.next()).internal,"},{"line_number":641,"context_line":"                                 remote_policy.idx)"},{"line_number":642,"context_line":"        # add misplaced row to remote_broker"},{"line_number":643,"context_line":"        remote_broker.put_object("}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_e1300b58","line":640,"in_reply_to":"1ae5cdf2_342ecb8c","updated":"2014-06-13 10:03:53.000000000","message":"sure looks like it\n\nDone.","commit_id":"239cc5feb3f00dfdf3efa68fc6af733be82dbcb6"}],"test/unit/obj/test_server.py":[{"author":{"_account_id":7479,"name":"paul luse","email":"paul.e.luse@intel.com","username":"peluse"},"change_message_id":"bc616fbeea4baf6f84657086abb8afb958af3eb8","unresolved":false,"context_lines":[{"line_number":553,"context_line":"            self.testdir, \u0027sda1\u0027,"},{"line_number":554,"context_line":"            storage_directory(diskfile.get_data_dir(0),"},{"line_number":555,"context_line":"                              \u0027p\u0027, hash_path(\u0027a\u0027, \u0027c\u0027, \u0027o\u0027)),"},{"line_number":556,"context_line":"            utils.Timestamp(timestamp).internal + \u0027.data\u0027)"},{"line_number":557,"context_line":"        self.assert_(os.path.isfile(objfile))"},{"line_number":558,"context_line":"        self.assertEquals(open(objfile).read(), \u0027VERIFY\u0027)"},{"line_number":559,"context_line":"        self.assertEquals(diskfile.read_metadata(objfile),"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_f492a355","line":556,"updated":"2014-06-12 16:12:32.000000000","message":"any reason why you didn\u0027t import Timestamp directly so there aren\u0027t so many utils.Timestamp?","commit_id":"239cc5feb3f00dfdf3efa68fc6af733be82dbcb6"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"94e0fa2be1768f49dc52b58225f2779b639c5425","unresolved":false,"context_lines":[{"line_number":553,"context_line":"            self.testdir, \u0027sda1\u0027,"},{"line_number":554,"context_line":"            storage_directory(diskfile.get_data_dir(0),"},{"line_number":555,"context_line":"                              \u0027p\u0027, hash_path(\u0027a\u0027, \u0027c\u0027, \u0027o\u0027)),"},{"line_number":556,"context_line":"            utils.Timestamp(timestamp).internal + \u0027.data\u0027)"},{"line_number":557,"context_line":"        self.assert_(os.path.isfile(objfile))"},{"line_number":558,"context_line":"        self.assertEquals(open(objfile).read(), \u0027VERIFY\u0027)"},{"line_number":559,"context_line":"        self.assertEquals(diskfile.read_metadata(objfile),"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_4141bfa7","line":556,"in_reply_to":"1ae5cdf2_f492a355","updated":"2014-06-13 10:03:53.000000000","message":"utils was already imported.","commit_id":"239cc5feb3f00dfdf3efa68fc6af733be82dbcb6"},{"author":{"_account_id":7479,"name":"paul luse","email":"paul.e.luse@intel.com","username":"peluse"},"change_message_id":"bc616fbeea4baf6f84657086abb8afb958af3eb8","unresolved":false,"context_lines":[{"line_number":1678,"context_line":"        try:"},{"line_number":1679,"context_line":"            # The following request should return 409 (HTTP Conflict). A"},{"line_number":1680,"context_line":"            # tombstone file should not have been created with this timestamp."},{"line_number":1681,"context_line":"            timestamp \u003d utils.Timestamp(start - 0.00001)"},{"line_number":1682,"context_line":"            req \u003d Request.blank(\u0027/sda1/p/a/c/o\u0027,"},{"line_number":1683,"context_line":"                                environ\u003d{\u0027REQUEST_METHOD\u0027: \u0027DELETE\u0027},"},{"line_number":1684,"context_line":"                                headers\u003d{\u0027X-Timestamp\u0027: timestamp.internal})"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_f4a0e391","line":1681,"updated":"2014-06-12 16:12:32.000000000","message":"why the .00001 subtraction instead of -1?  (I think I get it reading ahead but want to make sure)","commit_id":"239cc5feb3f00dfdf3efa68fc6af733be82dbcb6"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"94e0fa2be1768f49dc52b58225f2779b639c5425","unresolved":false,"context_lines":[{"line_number":1678,"context_line":"        try:"},{"line_number":1679,"context_line":"            # The following request should return 409 (HTTP Conflict). A"},{"line_number":1680,"context_line":"            # tombstone file should not have been created with this timestamp."},{"line_number":1681,"context_line":"            timestamp \u003d utils.Timestamp(start - 0.00001)"},{"line_number":1682,"context_line":"            req \u003d Request.blank(\u0027/sda1/p/a/c/o\u0027,"},{"line_number":1683,"context_line":"                                environ\u003d{\u0027REQUEST_METHOD\u0027: \u0027DELETE\u0027},"},{"line_number":1684,"context_line":"                                headers\u003d{\u0027X-Timestamp\u0027: timestamp.internal})"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_c1622f3d","line":1681,"in_reply_to":"1ae5cdf2_f4a0e391","updated":"2014-06-13 10:03:53.000000000","message":"seems like either works, this highlights the timestamp resolution a little better which I think the sleeps sort of alluded too.","commit_id":"239cc5feb3f00dfdf3efa68fc6af733be82dbcb6"}]}
