)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":38496,"name":"Andressa Cabistani","display_name":"Andressa","email":"acabistani@gmail.com","username":"andressadotpy","status":"I\u0027m a Software Engineer at Red Hat and I love Open Source and connect with people! Feel free to DM through IRC, I\u0027ll be delighted to chat"},"change_message_id":"f57324dc603d71a1c3839ac97ed46ada0041027b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"24f5082f_eb622cdf","updated":"2026-07-15 13:47:57.000000000","message":"Looks good to me!","commit_id":"1c9e421dbbd284484c0ce3b5edd778a721602679"}],"swift/common/concurrency.py":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"8ebe6d600f42d0542f2380fd586336cdc331759a","unresolved":true,"context_lines":[{"line_number":1163,"context_line":"            return base_pool.get()"},{"line_number":1164,"context_line":"    try:"},{"line_number":1165,"context_line":"        return base_pool.get(timeout\u003dpool_timeout)"},{"line_number":1166,"context_line":"    except Timeout:"},{"line_number":1167,"context_line":"        raise timeout_exc(pool_timeout)"},{"line_number":1168,"context_line":""},{"line_number":1169,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"a5118707_f807c107","line":1166,"updated":"2026-07-15 21:33:18.000000000","message":"Somewhat important to note that the `raise Timeout(timeout)` in `Pool.get` isn\u0027t the only way a `Timeout` might get raised -- the `Pool.create` might raise a `Timeout`, too, which will also get caught and transformed into a `timeout_exc`","commit_id":"1c9e421dbbd284484c0ce3b5edd778a721602679"}],"swift/common/db_replicator.py":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"26389d63eaac599b9e943af9547af55325041a39","unresolved":true,"context_lines":[{"line_number":161,"context_line":"        self.path \u003d \u0027/%s/%s/%s\u0027 % (node[\u0027device\u0027], partition, hash_)"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"    def connect(self):"},{"line_number":164,"context_line":"        BufferedHTTPConnection.connect(self)"},{"line_number":165,"context_line":"        # http_connect_raw clears the socket\u0027s connect timeout; ReplConnection"},{"line_number":166,"context_line":"        # bypasses it, so do it here. Otherwise under eventlet a slow REPLICATE"},{"line_number":167,"context_line":"        # hits node_timeout instead of replicate_timeout. No-op without"}],"source_content_type":"text/x-python","patch_set":5,"id":"8dd1ec03_5d42a77e","line":164,"range":{"start_line":164,"start_character":8,"end_line":164,"end_character":30},"updated":"2026-07-15 19:21:51.000000000","message":"nit: `super().connect()`? Shouldn\u0027t need to worry about old-style classes now.","commit_id":"1c9e421dbbd284484c0ce3b5edd778a721602679"}],"swift/common/memcached.py":[{"author":{"_account_id":38496,"name":"Andressa Cabistani","display_name":"Andressa","email":"acabistani@gmail.com","username":"andressadotpy","status":"I\u0027m a Software Engineer at Red Hat and I love Open Source and connect with people! Feel free to DM through IRC, I\u0027ll be delighted to chat"},"change_message_id":"f57324dc603d71a1c3839ac97ed46ada0041027b","unresolved":true,"context_lines":[{"line_number":161,"context_line":"                # An error happened previously, so we need a new connection"},{"line_number":162,"context_line":"                fp, sock \u003d self.create()"},{"line_number":163,"context_line":"            return fp, sock"},{"line_number":164,"context_line":"        except MemcachePoolTimeout:"},{"line_number":165,"context_line":"            # This is the only place that knows an item was successfully taken"},{"line_number":166,"context_line":"            # from the pool, so it has to be responsible for repopulating it."},{"line_number":167,"context_line":"            # Any other errors should get handled in _get_conns(); see the"}],"source_content_type":"text/x-python","patch_set":5,"id":"83d0fbd0_cf7893d4","line":164,"updated":"2026-07-15 13:47:57.000000000","message":"I believe this is now unreachable, is leaving it here intentional?","commit_id":"1c9e421dbbd284484c0ce3b5edd778a721602679"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"26389d63eaac599b9e943af9547af55325041a39","unresolved":true,"context_lines":[{"line_number":161,"context_line":"                # An error happened previously, so we need a new connection"},{"line_number":162,"context_line":"                fp, sock \u003d self.create()"},{"line_number":163,"context_line":"            return fp, sock"},{"line_number":164,"context_line":"        except MemcachePoolTimeout:"},{"line_number":165,"context_line":"            # This is the only place that knows an item was successfully taken"},{"line_number":166,"context_line":"            # from the pool, so it has to be responsible for repopulating it."},{"line_number":167,"context_line":"            # Any other errors should get handled in _get_conns(); see the"}],"source_content_type":"text/x-python","patch_set":5,"id":"5e20e189_b845aa05","line":164,"in_reply_to":"83d0fbd0_cf7893d4","updated":"2026-07-15 19:21:51.000000000","message":"Or it ought to get widened to `except Timeout:` -- maybe should have been ever since https://review.opendev.org/c/openstack/swift/+/817307\n\nGlad I left a note to myself on that other review about how this could run into trouble!","commit_id":"1c9e421dbbd284484c0ce3b5edd778a721602679"}]}