)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":38496,"name":"Andressa Cabistani","display_name":"Andressa","email":"acabistani@gmail.com","username":"andressadotpy","status":"I\u0027m a Software Engineer at Red Hat and I love Open Source and connect with people! Feel free to DM through IRC, I\u0027ll be delighted to chat"},"change_message_id":"4f41a6278e2fb97de08444b055d8656b2b58f766","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"6c32b23d_17de0047","updated":"2026-07-16 12:13:29.000000000","message":"This patch is looking really good to me!","commit_id":"c33fc0c984a33056349e5b4cabb9aed6ac4b84d2"},{"author":{"_account_id":6968,"name":"Christian Schwede","email":"cschwede@nvidia.com","username":"cschwede"},"change_message_id":"56918d381928a0884e411820f43589de50d4c626","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"3d78a4f7_0ad3e783","updated":"2026-09-14 09:48:52.000000000","message":"Self-approving on feature branch after discussing within the core reviewers team.","commit_id":"751a6e927d875c9b37b3b8b4611eacdb30526b34"}],"swift/common/middleware/x_profile/profile_model.py":[{"author":{"_account_id":38496,"name":"Andressa Cabistani","display_name":"Andressa","email":"acabistani@gmail.com","username":"andressadotpy","status":"I\u0027m a Software Engineer at Red Hat and I love Open Source and connect with people! Feel free to DM through IRC, I\u0027ll be delighted to chat"},"change_message_id":"4f41a6278e2fb97de08444b055d8656b2b58f766","unresolved":true,"context_lines":[{"line_number":273,"context_line":"            profiler.dump_stats(tmpfn)"},{"line_number":274,"context_line":"            # empty stats (nothing profiled) can\u0027t be loaded by pstats,"},{"line_number":275,"context_line":"            # so drop the temp dump instead of renaming it into place."},{"line_number":276,"context_line":"            if not profiler.stats:"},{"line_number":277,"context_line":"                os.remove(tmpfn)"},{"line_number":278,"context_line":"                return None"},{"line_number":279,"context_line":"            os.rename(tmpfn, pfn)"}],"source_content_type":"text/x-python","patch_set":5,"id":"a19cae25_69f17e4e","line":276,"updated":"2026-07-16 12:13:29.000000000","message":"The empty-stats write a temp file and immediately deletes it.\nSuggestion: the check could be moved before the write to avoid unnecessary I/O.\n\n```python\nif not profiler.stats:\n    return None\ntmpfn \u003d pfn + \".tmp\"\nprofiler.dump_stats(tmpfn)\nos.rename(tmpfn, pfn)\nreturn pfn\n```","commit_id":"c33fc0c984a33056349e5b4cabb9aed6ac4b84d2"},{"author":{"_account_id":6968,"name":"Christian Schwede","email":"cschwede@nvidia.com","username":"cschwede"},"change_message_id":"d4cf8a3d9e2cdbd4fe71e23d2c4baaa46eb46602","unresolved":false,"context_lines":[{"line_number":273,"context_line":"            profiler.dump_stats(tmpfn)"},{"line_number":274,"context_line":"            # empty stats (nothing profiled) can\u0027t be loaded by pstats,"},{"line_number":275,"context_line":"            # so drop the temp dump instead of renaming it into place."},{"line_number":276,"context_line":"            if not profiler.stats:"},{"line_number":277,"context_line":"                os.remove(tmpfn)"},{"line_number":278,"context_line":"                return None"},{"line_number":279,"context_line":"            os.rename(tmpfn, pfn)"}],"source_content_type":"text/x-python","patch_set":5,"id":"ee422805_f560af18","line":276,"in_reply_to":"a19cae25_69f17e4e","updated":"2026-08-21 07:42:56.000000000","message":"Tried that, but it breaks two xprofile tests. Left as it is, added a comment why the check has to come after the dump.","commit_id":"c33fc0c984a33056349e5b4cabb9aed6ac4b84d2"}]}