)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"8c865ee5e0653460990b85d0e6ac0e7e24caa14d","unresolved":true,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Let SLO and S3API authoritatively classify object responses by"},{"line_number":12,"context_line":"updating the existing shared base-label map. Proxy logging consumes"},{"line_number":13,"context_line":"that result with a stable object_type schema, representing unknown"},{"line_number":14,"context_line":"values as None internally and an empty value on the wire."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Propagate the classification intentionally across response-path"},{"line_number":17,"context_line":"metrics while keeping non-object labels behavior stable. Cover"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"da0c965c_ab87fb54","line":14,"range":{"start_line":13,"start_character":59,"end_line":14,"end_character":7},"updated":"2026-09-17 16:21:40.000000000","message":"how can there be an unknown value? if we know that ``resource\u003d\u003dobject``, then the default is ``object_type\u003dnormal``","commit_id":"66027e7bc29e5b37dfda7ab23b976d28b0000f59"},{"author":{"_account_id":36606,"name":"Yan Xiao","display_name":"Yan","email":"yanxiao@nvidia.com","username":"yanxiao"},"change_message_id":"8a23a3c3020dde1ae96b51a4c41ad7757ee35f1f","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Let SLO and S3API authoritatively classify object responses by"},{"line_number":12,"context_line":"updating the existing shared base-label map. Proxy logging consumes"},{"line_number":13,"context_line":"that result with a stable object_type schema, representing unknown"},{"line_number":14,"context_line":"values as None internally and an empty value on the wire."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Propagate the classification intentionally across response-path"},{"line_number":17,"context_line":"metrics while keeping non-object labels behavior stable. Cover"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"6cd61194_1bbcfda0","line":14,"range":{"start_line":13,"start_character":59,"end_line":14,"end_character":7},"in_reply_to":"da0c965c_ab87fb54","updated":"2026-10-02 19:35:12.000000000","message":"Acknowledged","commit_id":"66027e7bc29e5b37dfda7ab23b976d28b0000f59"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"6ccc2b10809c2a1ca46be38a49d7821d003d7837","unresolved":true,"context_lines":[{"line_number":23,"context_line":"Failures such as 404, 429, and proxy-generated 503 often have no"},{"line_number":24,"context_line":"object metadata to identify an MPU, so this patch does not classify"},{"line_number":25,"context_line":"those failures. Classification occurs before body streaming; a later"},{"line_number":26,"context_line":"stream failure can retain the known MPU label."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Change-Id: I484563649a176795da525920592bd1e3a74feaeb"},{"line_number":29,"context_line":"Assisted-By: Codex:GPT-5.6"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":15,"id":"b4db6bfb_ec4a30ce","line":26,"updated":"2026-10-06 11:50:56.000000000","message":"Claude said: \" The message says failures \"such as 404, 429, and proxy-generated 503\" aren\u0027t classified, implying those cases were evaluated. The agent traced it:\n  req.get_response() in s3api raises an S3ResponseError-derived exception for any non-success status before line 121 is reached, so all non-2xx are\n  structurally excluded — broader than the message implies, and nothing tests it. Worth a regression test: register a 404/503 for an object GET carrying the\n  SLO + upload-id sysmeta, assert object_type is absent.\"","commit_id":"7c5438ffe83d0d5b482ab1076efd1fbd400f1cbf"},{"author":{"_account_id":36606,"name":"Yan Xiao","display_name":"Yan","email":"yanxiao@nvidia.com","username":"yanxiao"},"change_message_id":"3f04812bad82fb1f29af3d73f88f20ef6a4fd7d0","unresolved":false,"context_lines":[{"line_number":23,"context_line":"Failures such as 404, 429, and proxy-generated 503 often have no"},{"line_number":24,"context_line":"object metadata to identify an MPU, so this patch does not classify"},{"line_number":25,"context_line":"those failures. Classification occurs before body streaming; a later"},{"line_number":26,"context_line":"stream failure can retain the known MPU label."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Change-Id: I484563649a176795da525920592bd1e3a74feaeb"},{"line_number":29,"context_line":"Assisted-By: Codex:GPT-5.6"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":15,"id":"43f0fb14_5d67032a","line":26,"in_reply_to":"b4db6bfb_ec4a30ce","updated":"2026-10-16 19:31:56.000000000","message":"Acknowledged","commit_id":"7c5438ffe83d0d5b482ab1076efd1fbd400f1cbf"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"c6b7c6d05ea0da941bbd6eebd6445b984ba63a72","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"0fe57fdb_377410e7","updated":"2026-07-08 15:48:55.000000000","message":"Ideally we would align this work with https://review.opendev.org/c/openstack/swift/+/974367 i.e. define the interface for other middlewares to add to base_labels dict, and then in this patch slo and s3api can simply add the labels. That way, we don\u0027t have to bleed s3api and slo into proxy_logging.","commit_id":"14a5e86cb4ba039b42b8f0b4eae43673f106b966"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"e62aeb15c3c8333e03aafcc62a72978ca164f552","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"f7bd814a_72c71bb3","updated":"2026-09-07 11:24:38.000000000","message":"I wonder if we might consider introducing a single label key that could eventually capture more abstract API operations, e.g.:\n\n```\nop: GetMpu | GetSlo | GetObject | CreateMultipartUpload | UploadPart | CompleteMultipartUpload | DeleteObjects | etc...\n```","commit_id":"b3572a0293b9deca51286cfefefa9d89af396c80"},{"author":{"_account_id":36606,"name":"Yan Xiao","display_name":"Yan","email":"yanxiao@nvidia.com","username":"yanxiao"},"change_message_id":"7fb1d961e9258e517d5abcbc89a837f749053acd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"d714d567_5257dd5c","updated":"2026-09-02 16:15:48.000000000","message":"previously update_swift_base_labels() were intended for req_labels, while proxy_logging could overlay any resp_labels on to base_labels. If object_type is part of response schema, wonder if it would be better to change base_labels to be a \"base\" section, a \"response\" section, to avoid copying the labels in callback which could be every 10sec or so?","commit_id":"b3572a0293b9deca51286cfefefa9d89af396c80"},{"author":{"_account_id":34930,"name":"Jianjian Huo","email":"jhuo@nvidia.com","username":"jhuo"},"change_message_id":"1de7ce2101f5553e327ccfeb6871d0266aa8abc7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"d8a538f7_1d966a5d","updated":"2026-09-23 00:30:48.000000000","message":"proxy logging supplies the initial ``normal`` value instead of ``None``.\nI think Yan is still working on it.","commit_id":"1fb1de1f25b6ecf27af31cb6c878aac6ce60e1ee"},{"author":{"_account_id":36606,"name":"Yan Xiao","display_name":"Yan","email":"yanxiao@nvidia.com","username":"yanxiao"},"change_message_id":"af4bb103cb64d3402b003014ef3393fcbc67b481","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"f9d4f6d3_bc41a67b","updated":"2026-10-01 21:16:46.000000000","message":"recheck","commit_id":"2cda5ed7607220c28a992016ef0dd5f73034f13e"},{"author":{"_account_id":36606,"name":"Yan Xiao","display_name":"Yan","email":"yanxiao@nvidia.com","username":"yanxiao"},"change_message_id":"e844a2344c18c7f1af9e8a31484765979687de32","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"95b228e2_6061b662","updated":"2026-10-02 21:15:36.000000000","message":"recheck","commit_id":"6ffb26e7695556cd3bf219d7caf2bf9ebc9e7ac0"},{"author":{"_account_id":34930,"name":"Jianjian Huo","email":"jhuo@nvidia.com","username":"jhuo"},"change_message_id":"600d564dc4a0031204fc9f1b424df3dbfb5efc7e","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":10,"id":"7883d4b6_e4ef522d","updated":"2026-10-05 02:04:51.000000000","message":"thanks for working on this patch, just pushed up a few comments and follow-up: https://review.opendev.org/c/openstack/swift/+/1008736\n\nalso, should we change name of this patch to something like \"enable ttfb metrics with mpu object_type extra label\"?","commit_id":"6ffb26e7695556cd3bf219d7caf2bf9ebc9e7ac0"},{"author":{"_account_id":36606,"name":"Yan Xiao","display_name":"Yan","email":"yanxiao@nvidia.com","username":"yanxiao"},"change_message_id":"26238596ec90c048db7c983a65eb3da751efeff1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"9b30bc4a_2e7c667d","in_reply_to":"7883d4b6_e4ef522d","updated":"2026-10-05 15:36:00.000000000","message":"Acknowledged","commit_id":"6ffb26e7695556cd3bf219d7caf2bf9ebc9e7ac0"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"6ccc2b10809c2a1ca46be38a49d7821d003d7837","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"ef0d7f91_3c2356e6","updated":"2026-10-06 11:50:56.000000000","message":"I think we might want to get some more use case experience before we commit to an \u0027interface\u0027 for extra_labels in request_helpers.\n\nFunctionally, this does the job. On my VSAIO, first a non-mpu HEAD\n```\nproxy-server.account.info.cache.hit:1|c\nproxy-server.container.info.cache.hit:1|c\nproxy-server.container.info.infocache.hit:1|c\nproxy-server.container.info.infocache.hit:1|c\nsubrequest.proxy-server.object.HEAD.200.timing:8.7035|ms\nsubrequest.proxy-server.object.HEAD.200.xfer:0|c\nsubrequest.proxy-server.object.policy.0.HEAD.200.timing:8.7035|ms\nsubrequest.proxy-server.object.policy.0.HEAD.200.xfer:0|c\nswift_proxy_server_request_timing:8.7035|ms|#account:AUTH_test,api:S3,container:s3test,method:HEAD,policy:0,resource:object,status:200,user_reqctx:subrequest\nswift_proxy_server_request_body_bytes:0|c|#account:AUTH_test,api:S3,container:s3test,method:HEAD,policy:0,resource:object,status:200,user_reqctx:subrequest\nswift_proxy_server_response_body_bytes:0|c|#account:AUTH_test,api:S3,container:s3test,method:HEAD,policy:0,resource:object,status:200,user_reqctx:subrequest\nswift_s3_checksum_algo_request:1|c|#account:AUTH_test,container:s3test,header_x_amz_content_sha256:hash_64,method:HEAD,status:200,type:object\nproxy-server.object.HEAD.200.timing:11.7149|ms\nproxy-server.object.HEAD.200.xfer:0|c\nproxy-server.object.policy.0.HEAD.200.timing:11.7149|ms\nproxy-server.object.policy.0.HEAD.200.xfer:0|c\nswift_proxy_server_request_timing:11.7149|ms|#account:AUTH_test,api:S3,container:s3test,method:HEAD,policy:0,resource:object,status:200\nswift_proxy_server_request_body_bytes:0|c|#account:AUTH_test,api:S3,container:s3test,method:HEAD,policy:0,resource:object,status:200\nswift_proxy_server_response_body_bytes:0|c|#account:AUTH_test,api:S3,container:s3test,method:HEAD,policy:0,resource:object,status:200\n```\n\nthen an mpu HEAD\n\n```\nproxy-server.memcached.set.timing:0.2182|ms|@0.1\nsubrequest.proxy-server.account.HEAD.204.timing:8.5797|ms\nsubrequest.proxy-server.account.HEAD.204.xfer:0|c\nswift_proxy_server_request_timing:8.5797|ms|#account:AUTH_test,api:S3,container:s3test,method:HEAD,resource:account,status:204,user_reqctx:subrequest\nswift_proxy_server_request_body_bytes:0|c|#account:AUTH_test,api:S3,container:s3test,method:HEAD,resource:account,status:204,user_reqctx:subrequest\nswift_proxy_server_response_body_bytes:0|c|#account:AUTH_test,api:S3,container:s3test,method:HEAD,resource:account,status:204,user_reqctx:subrequest\nproxy-server.account.info.cache.miss.204:1|c\nproxy-server.account.info.infocache.hit:1|c\nproxy-server.account.info.infocache.hit:1|c\nsubrequest.proxy-server.container.HEAD.204.timing:11.8043|ms\nsubrequest.proxy-server.container.HEAD.204.xfer:0|c\nswift_proxy_server_request_timing:11.8043|ms|#account:AUTH_test,api:S3,container:s3test,method:HEAD,resource:container,status:204,user_reqctx:subrequest\nswift_proxy_server_request_body_bytes:0|c|#account:AUTH_test,api:S3,container:s3test,method:HEAD,resource:container,status:204,user_reqctx:subrequest\nswift_proxy_server_response_body_bytes:0|c|#account:AUTH_test,api:S3,container:s3test,method:HEAD,resource:container,status:204,user_reqctx:subrequest\nproxy-server.container.info.cache.miss.204:1|c\nproxy-server.container.info.infocache.hit:1|c\nproxy-server.container.info.infocache.hit:1|c\nsubrequest.proxy-server.object.HEAD.200.timing:3.557|ms\nsubrequest.proxy-server.object.HEAD.200.xfer:0|c\nsubrequest.proxy-server.object.policy.0.HEAD.200.timing:3.557|ms\nsubrequest.proxy-server.object.policy.0.HEAD.200.xfer:0|c\nswift_proxy_server_request_timing:3.557|ms|#account:AUTH_test,api:S3,container:s3test,method:HEAD,policy:0,resource:object,status:200,user_reqctx:subrequest\nswift_proxy_server_request_body_bytes:0|c|#account:AUTH_test,api:S3,container:s3test,method:HEAD,policy:0,resource:object,status:200,user_reqctx:subrequest\nswift_proxy_server_response_body_bytes:0|c|#account:AUTH_test,api:S3,container:s3test,method:HEAD,policy:0,resource:object,status:200,user_reqctx:subrequest\nswift_s3_checksum_algo_request:1|c|#account:AUTH_test,container:s3test,header_x_amz_content_sha256:hash_64,method:HEAD,status:200,type:object\nproxy-server.object.HEAD.200.timing:29.1214|ms\nproxy-server.object.HEAD.200.xfer:0|c\nproxy-server.object.policy.0.HEAD.200.timing:29.1214|ms\nproxy-server.object.policy.0.HEAD.200.xfer:0|c\nswift_proxy_server_request_timing:29.1214|ms|#account:AUTH_test,api:S3,container:s3test,method:HEAD,object_type:mpu,policy:0,resource:object,status:200\nswift_proxy_server_request_body_bytes:0|c|#account:AUTH_test,api:S3,container:s3test,method:HEAD,object_type:mpu,policy:0,resource:object,status:200\nswift_proxy_server_response_body_bytes:0|c|#account:AUTH_test,api:S3,container:s3test,method:HEAD,object_type:mpu,policy:0,resource:object,status:200\n```","commit_id":"7c5438ffe83d0d5b482ab1076efd1fbd400f1cbf"}],"swift/common/middleware/proxy_logging.py":[{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"e62aeb15c3c8333e03aafcc62a72978ca164f552","unresolved":true,"context_lines":[{"line_number":642,"context_line":"        resource_type \u003d labels.get(\u0027resource\u0027)"},{"line_number":643,"context_line":"        updated_labels \u003d dict(labels)"},{"line_number":644,"context_line":"        if resource_type \u003d\u003d \u0027object\u0027:"},{"line_number":645,"context_line":"            updated_labels.setdefault(\u0027object_type\u0027, None)"},{"line_number":646,"context_line":"        else:"},{"line_number":647,"context_line":"            updated_labels.pop(\u0027object_type\u0027, None)"},{"line_number":648,"context_line":"        if resource_type \u003d\u003d \u0027object\u0027 and \\"}],"source_content_type":"text/x-python","patch_set":4,"id":"61571286_56cf5a24","line":645,"updated":"2026-09-07 11:24:38.000000000","message":"why not just add the ``object_type` label when the `base_labels`` dict is *created* for object requests?","commit_id":"b3572a0293b9deca51286cfefefa9d89af396c80"},{"author":{"_account_id":36606,"name":"Yan Xiao","display_name":"Yan","email":"yanxiao@nvidia.com","username":"yanxiao"},"change_message_id":"d434d32597f58fea2a051f07aa5de2cde49ab9ff","unresolved":false,"context_lines":[{"line_number":642,"context_line":"        resource_type \u003d labels.get(\u0027resource\u0027)"},{"line_number":643,"context_line":"        updated_labels \u003d dict(labels)"},{"line_number":644,"context_line":"        if resource_type \u003d\u003d \u0027object\u0027:"},{"line_number":645,"context_line":"            updated_labels.setdefault(\u0027object_type\u0027, None)"},{"line_number":646,"context_line":"        else:"},{"line_number":647,"context_line":"            updated_labels.pop(\u0027object_type\u0027, None)"},{"line_number":648,"context_line":"        if resource_type \u003d\u003d \u0027object\u0027 and \\"}],"source_content_type":"text/x-python","patch_set":4,"id":"2f4f6700_c9993bed","line":645,"in_reply_to":"61571286_56cf5a24","updated":"2026-09-16 19:35:31.000000000","message":"Acknowledged","commit_id":"b3572a0293b9deca51286cfefefa9d89af396c80"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"8c865ee5e0653460990b85d0e6ac0e7e24caa14d","unresolved":true,"context_lines":[{"line_number":108,"context_line":"    get_sensitive_params, register_sensitive_header"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"def update_base_labels(req, labels):"},{"line_number":112,"context_line":"    \"\"\""},{"line_number":113,"context_line":"    Helper function for other middlewares to update base_labels."},{"line_number":114,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":7,"id":"eb367bf9_3e0726ff","line":111,"updated":"2026-09-17 16:21:40.000000000","message":"we may want to move all base_labels helpers to a common module\n\nsee 1006018: sq? wip: re-use base_labels helpers in s3api | https://review.opendev.org/c/openstack/swift/+/1006018","commit_id":"66027e7bc29e5b37dfda7ab23b976d28b0000f59"},{"author":{"_account_id":36606,"name":"Yan Xiao","display_name":"Yan","email":"yanxiao@nvidia.com","username":"yanxiao"},"change_message_id":"26238596ec90c048db7c983a65eb3da751efeff1","unresolved":false,"context_lines":[{"line_number":108,"context_line":"    get_sensitive_params, register_sensitive_header"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"def update_base_labels(req, labels):"},{"line_number":112,"context_line":"    \"\"\""},{"line_number":113,"context_line":"    Helper function for other middlewares to update base_labels."},{"line_number":114,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":7,"id":"ef9cd0a1_43ccdf7b","line":111,"in_reply_to":"eb367bf9_3e0726ff","updated":"2026-10-05 15:36:00.000000000","message":"Acknowledged","commit_id":"66027e7bc29e5b37dfda7ab23b976d28b0000f59"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"8c865ee5e0653460990b85d0e6ac0e7e24caa14d","unresolved":true,"context_lines":[{"line_number":549,"context_line":"        if cont:"},{"line_number":550,"context_line":"            labels[\u0027container\u0027] \u003d cont"},{"line_number":551,"context_line":"        if resource \u003d\u003d \u0027object\u0027:"},{"line_number":552,"context_line":"            labels[\u0027object_type\u0027] \u003d None"},{"line_number":553,"context_line":"        return labels"},{"line_number":554,"context_line":""},{"line_number":555,"context_line":"    def get_current_labels(self, req, acc, cont, obj):"}],"source_content_type":"text/x-python","patch_set":7,"id":"fd99d77b_7fa18857","line":552,"updated":"2026-09-17 16:21:40.000000000","message":"isn\u0027t the default value ``normal``?","commit_id":"66027e7bc29e5b37dfda7ab23b976d28b0000f59"},{"author":{"_account_id":36606,"name":"Yan Xiao","display_name":"Yan","email":"yanxiao@nvidia.com","username":"yanxiao"},"change_message_id":"8a23a3c3020dde1ae96b51a4c41ad7757ee35f1f","unresolved":false,"context_lines":[{"line_number":549,"context_line":"        if cont:"},{"line_number":550,"context_line":"            labels[\u0027container\u0027] \u003d cont"},{"line_number":551,"context_line":"        if resource \u003d\u003d \u0027object\u0027:"},{"line_number":552,"context_line":"            labels[\u0027object_type\u0027] \u003d None"},{"line_number":553,"context_line":"        return labels"},{"line_number":554,"context_line":""},{"line_number":555,"context_line":"    def get_current_labels(self, req, acc, cont, obj):"}],"source_content_type":"text/x-python","patch_set":7,"id":"fd8f9cc3_ca1cde0b","line":552,"in_reply_to":"fd99d77b_7fa18857","updated":"2026-10-02 19:35:12.000000000","message":"Acknowledged","commit_id":"66027e7bc29e5b37dfda7ab23b976d28b0000f59"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"8c865ee5e0653460990b85d0e6ac0e7e24caa14d","unresolved":true,"context_lines":[{"line_number":570,"context_line":"        if acc:"},{"line_number":571,"context_line":"            labels[\u0027account\u0027] \u003d acc"},{"line_number":572,"context_line":"        if resource:"},{"line_number":573,"context_line":"            labels[\u0027resource\u0027] \u003d resource"},{"line_number":574,"context_line":"        if cont:"},{"line_number":575,"context_line":"            labels[\u0027container\u0027] \u003d cont"},{"line_number":576,"context_line":"        return labels"}],"source_content_type":"text/x-python","patch_set":7,"id":"19ca551d_f359a715","line":573,"updated":"2026-09-17 16:21:40.000000000","message":"don\u0027t we need to set ``object_type`` here as well?","commit_id":"66027e7bc29e5b37dfda7ab23b976d28b0000f59"},{"author":{"_account_id":36606,"name":"Yan Xiao","display_name":"Yan","email":"yanxiao@nvidia.com","username":"yanxiao"},"change_message_id":"8a23a3c3020dde1ae96b51a4c41ad7757ee35f1f","unresolved":false,"context_lines":[{"line_number":570,"context_line":"        if acc:"},{"line_number":571,"context_line":"            labels[\u0027account\u0027] \u003d acc"},{"line_number":572,"context_line":"        if resource:"},{"line_number":573,"context_line":"            labels[\u0027resource\u0027] \u003d resource"},{"line_number":574,"context_line":"        if cont:"},{"line_number":575,"context_line":"            labels[\u0027container\u0027] \u003d cont"},{"line_number":576,"context_line":"        return labels"}],"source_content_type":"text/x-python","patch_set":7,"id":"69cb4e24_134f41e2","line":573,"in_reply_to":"19ca551d_f359a715","updated":"2026-10-02 19:35:12.000000000","message":"Acknowledged","commit_id":"66027e7bc29e5b37dfda7ab23b976d28b0000f59"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"8c865ee5e0653460990b85d0e6ac0e7e24caa14d","unresolved":true,"context_lines":[{"line_number":630,"context_line":"            base_labels.setdefault(\u0027account\u0027, current_labels.get(\u0027account\u0027))"},{"line_number":631,"context_line":"            resource_type \u003d current_labels.get(\u0027resource\u0027)"},{"line_number":632,"context_line":"            base_labels.setdefault(\u0027resource\u0027, resource_type)"},{"line_number":633,"context_line":"            if resource_type \u003d\u003d \u0027object\u0027:"},{"line_number":634,"context_line":"                base_labels.setdefault(\u0027object_type\u0027, None)"},{"line_number":635,"context_line":"            # use the composition of base_labels overlaid with current_labels"},{"line_number":636,"context_line":"            req_labels \u003d ChainMap(current_labels, base_labels)"}],"source_content_type":"text/x-python","patch_set":7,"id":"424d79b3_c64abe62","line":633,"updated":"2026-09-17 16:21:40.000000000","message":"ok, I guess it is possible that something to the right of rightmost proxy-logging might set ``object_type``, but not with this patch.\n\nPerhaps we want the ``object_type`` key to be in *every* ``object`` stat for consistency, even if empty value","commit_id":"66027e7bc29e5b37dfda7ab23b976d28b0000f59"},{"author":{"_account_id":36606,"name":"Yan Xiao","display_name":"Yan","email":"yanxiao@nvidia.com","username":"yanxiao"},"change_message_id":"8a23a3c3020dde1ae96b51a4c41ad7757ee35f1f","unresolved":false,"context_lines":[{"line_number":630,"context_line":"            base_labels.setdefault(\u0027account\u0027, current_labels.get(\u0027account\u0027))"},{"line_number":631,"context_line":"            resource_type \u003d current_labels.get(\u0027resource\u0027)"},{"line_number":632,"context_line":"            base_labels.setdefault(\u0027resource\u0027, resource_type)"},{"line_number":633,"context_line":"            if resource_type \u003d\u003d \u0027object\u0027:"},{"line_number":634,"context_line":"                base_labels.setdefault(\u0027object_type\u0027, None)"},{"line_number":635,"context_line":"            # use the composition of base_labels overlaid with current_labels"},{"line_number":636,"context_line":"            req_labels \u003d ChainMap(current_labels, base_labels)"}],"source_content_type":"text/x-python","patch_set":7,"id":"621e65e6_dfdb6e7f","line":633,"in_reply_to":"424d79b3_c64abe62","updated":"2026-10-02 19:35:12.000000000","message":"Acknowledged","commit_id":"66027e7bc29e5b37dfda7ab23b976d28b0000f59"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"8c865ee5e0653460990b85d0e6ac0e7e24caa14d","unresolved":true,"context_lines":[{"line_number":631,"context_line":"            resource_type \u003d current_labels.get(\u0027resource\u0027)"},{"line_number":632,"context_line":"            base_labels.setdefault(\u0027resource\u0027, resource_type)"},{"line_number":633,"context_line":"            if resource_type \u003d\u003d \u0027object\u0027:"},{"line_number":634,"context_line":"                base_labels.setdefault(\u0027object_type\u0027, None)"},{"line_number":635,"context_line":"            # use the composition of base_labels overlaid with current_labels"},{"line_number":636,"context_line":"            req_labels \u003d ChainMap(current_labels, base_labels)"},{"line_number":637,"context_line":"        return req_labels"}],"source_content_type":"text/x-python","patch_set":7,"id":"9703ac1f_779809c7","line":634,"updated":"2026-09-17 16:21:40.000000000","message":"I think this is wrong; ``object_type`` should only be set if line 632 returns ``object`` i.e. only if ``base_labels`` now has ``resource: object``","commit_id":"66027e7bc29e5b37dfda7ab23b976d28b0000f59"},{"author":{"_account_id":36606,"name":"Yan Xiao","display_name":"Yan","email":"yanxiao@nvidia.com","username":"yanxiao"},"change_message_id":"8a23a3c3020dde1ae96b51a4c41ad7757ee35f1f","unresolved":false,"context_lines":[{"line_number":631,"context_line":"            resource_type \u003d current_labels.get(\u0027resource\u0027)"},{"line_number":632,"context_line":"            base_labels.setdefault(\u0027resource\u0027, resource_type)"},{"line_number":633,"context_line":"            if resource_type \u003d\u003d \u0027object\u0027:"},{"line_number":634,"context_line":"                base_labels.setdefault(\u0027object_type\u0027, None)"},{"line_number":635,"context_line":"            # use the composition of base_labels overlaid with current_labels"},{"line_number":636,"context_line":"            req_labels \u003d ChainMap(current_labels, base_labels)"},{"line_number":637,"context_line":"        return req_labels"}],"source_content_type":"text/x-python","patch_set":7,"id":"eb2daf1c_033e96eb","line":634,"in_reply_to":"9703ac1f_779809c7","updated":"2026-10-02 19:35:12.000000000","message":"Acknowledged","commit_id":"66027e7bc29e5b37dfda7ab23b976d28b0000f59"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"8c865ee5e0653460990b85d0e6ac0e7e24caa14d","unresolved":true,"context_lines":[{"line_number":650,"context_line":"        resource_type \u003d labels.get(\u0027resource\u0027)"},{"line_number":651,"context_line":"        updated_labels \u003d dict(labels)"},{"line_number":652,"context_line":"        if resource_type !\u003d \u0027object\u0027:"},{"line_number":653,"context_line":"            updated_labels.pop(\u0027object_type\u0027, None)"},{"line_number":654,"context_line":"        if resource_type \u003d\u003d \u0027object\u0027 and \\"},{"line_number":655,"context_line":"                policy_index is not None and \\"},{"line_number":656,"context_line":"                POLICIES.get_by_index(policy_index) is not None:"}],"source_content_type":"text/x-python","patch_set":7,"id":"9f4e32d9_b8e63ae7","line":653,"updated":"2026-09-17 16:21:40.000000000","message":"how do end up with ``object_type`` in the dict but not ``resource: object``?\n\nAlso I\u0027m not sure I like a method that was previously *additive* now removing a key as a side-effect","commit_id":"66027e7bc29e5b37dfda7ab23b976d28b0000f59"},{"author":{"_account_id":36606,"name":"Yan Xiao","display_name":"Yan","email":"yanxiao@nvidia.com","username":"yanxiao"},"change_message_id":"8a23a3c3020dde1ae96b51a4c41ad7757ee35f1f","unresolved":false,"context_lines":[{"line_number":650,"context_line":"        resource_type \u003d labels.get(\u0027resource\u0027)"},{"line_number":651,"context_line":"        updated_labels \u003d dict(labels)"},{"line_number":652,"context_line":"        if resource_type !\u003d \u0027object\u0027:"},{"line_number":653,"context_line":"            updated_labels.pop(\u0027object_type\u0027, None)"},{"line_number":654,"context_line":"        if resource_type \u003d\u003d \u0027object\u0027 and \\"},{"line_number":655,"context_line":"                policy_index is not None and \\"},{"line_number":656,"context_line":"                POLICIES.get_by_index(policy_index) is not None:"}],"source_content_type":"text/x-python","patch_set":7,"id":"e36aacd1_f7d8f950","line":653,"in_reply_to":"9f4e32d9_b8e63ae7","updated":"2026-10-02 19:35:12.000000000","message":"Acknowledged","commit_id":"66027e7bc29e5b37dfda7ab23b976d28b0000f59"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"8c865ee5e0653460990b85d0e6ac0e7e24caa14d","unresolved":true,"context_lines":[{"line_number":774,"context_line":"            req \u003d Request(env)"},{"line_number":775,"context_line":"            env[\u0027swift.proxy_logging_status\u0027] \u003d 500"},{"line_number":776,"context_line":"            status_int \u003d status_int_for_logging()"},{"line_number":777,"context_line":"            resp_labels \u003d self.get_response_labels(req_labels)"},{"line_number":778,"context_line":"            self.log_request("},{"line_number":779,"context_line":"                req, status_int, input_proxy.bytes_received, 0, start_time,"},{"line_number":780,"context_line":"                time.time(), resp_labels)"}],"source_content_type":"text/x-python","patch_set":7,"id":"038b57bc_da51e91a","line":777,"updated":"2026-09-17 16:21:40.000000000","message":"this does nothing other than pop ``object_type`` in some circumstance, but I\u0027m not sure how those circumstances arise.","commit_id":"66027e7bc29e5b37dfda7ab23b976d28b0000f59"},{"author":{"_account_id":36606,"name":"Yan Xiao","display_name":"Yan","email":"yanxiao@nvidia.com","username":"yanxiao"},"change_message_id":"8a23a3c3020dde1ae96b51a4c41ad7757ee35f1f","unresolved":false,"context_lines":[{"line_number":774,"context_line":"            req \u003d Request(env)"},{"line_number":775,"context_line":"            env[\u0027swift.proxy_logging_status\u0027] \u003d 500"},{"line_number":776,"context_line":"            status_int \u003d status_int_for_logging()"},{"line_number":777,"context_line":"            resp_labels \u003d self.get_response_labels(req_labels)"},{"line_number":778,"context_line":"            self.log_request("},{"line_number":779,"context_line":"                req, status_int, input_proxy.bytes_received, 0, start_time,"},{"line_number":780,"context_line":"                time.time(), resp_labels)"}],"source_content_type":"text/x-python","patch_set":7,"id":"a28d0852_27fe41d3","line":777,"in_reply_to":"038b57bc_da51e91a","updated":"2026-10-02 19:35:12.000000000","message":"Acknowledged","commit_id":"66027e7bc29e5b37dfda7ab23b976d28b0000f59"},{"author":{"_account_id":34930,"name":"Jianjian Huo","email":"jhuo@nvidia.com","username":"jhuo"},"change_message_id":"85d7fc70ec6a205df83bd2bcf420420449ef5312","unresolved":true,"context_lines":[{"line_number":119,"context_line":"    if extra_labels is not None:"},{"line_number":120,"context_line":"        base_labels \u003d req.environ.get(\u0027swift.base_labels\u0027)"},{"line_number":121,"context_line":"        for k, v in labels.items():"},{"line_number":122,"context_line":"            if k \u003d\u003d \u0027object_type\u0027 and base_labels.get(\u0027resource\u0027) !\u003d \u0027object\u0027:"},{"line_number":123,"context_line":"                continue"},{"line_number":124,"context_line":"            extra_labels[k] \u003d v"},{"line_number":125,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"fac2b345_27838049","line":122,"updated":"2026-10-02 01:59:32.000000000","message":"I reproduced a normal object PUT with X-Copy-From from an SLO would create a wrong ``object_type``: COPY writes a normal destination object, but the client PUT timing metric reports ``object_type\u003dslo``.\n\nsee test at https://review.opendev.org/c/openstack/swift/+/1008368/1/test/unit/common/middleware/test_copy.py#355","commit_id":"2cda5ed7607220c28a992016ef0dd5f73034f13e"},{"author":{"_account_id":36606,"name":"Yan Xiao","display_name":"Yan","email":"yanxiao@nvidia.com","username":"yanxiao"},"change_message_id":"8a23a3c3020dde1ae96b51a4c41ad7757ee35f1f","unresolved":false,"context_lines":[{"line_number":119,"context_line":"    if extra_labels is not None:"},{"line_number":120,"context_line":"        base_labels \u003d req.environ.get(\u0027swift.base_labels\u0027)"},{"line_number":121,"context_line":"        for k, v in labels.items():"},{"line_number":122,"context_line":"            if k \u003d\u003d \u0027object_type\u0027 and base_labels.get(\u0027resource\u0027) !\u003d \u0027object\u0027:"},{"line_number":123,"context_line":"                continue"},{"line_number":124,"context_line":"            extra_labels[k] \u003d v"},{"line_number":125,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"51286e49_13ad7158","line":122,"in_reply_to":"fac2b345_27838049","updated":"2026-10-02 19:35:12.000000000","message":"thanks a lot for the fix, Jianjian!","commit_id":"2cda5ed7607220c28a992016ef0dd5f73034f13e"},{"author":{"_account_id":34930,"name":"Jianjian Huo","email":"jhuo@nvidia.com","username":"jhuo"},"change_message_id":"7f7448f384e3b547e6f7e361da7cb931ff288bed","unresolved":true,"context_lines":[{"line_number":630,"context_line":"            if extra_labels is None:"},{"line_number":631,"context_line":"                extra_labels \u003d {}"},{"line_number":632,"context_line":"                if base_labels.get(\u0027resource\u0027) \u003d\u003d \u0027object\u0027:"},{"line_number":633,"context_line":"                    extra_labels[\u0027object_type\u0027] \u003d None"},{"line_number":634,"context_line":"                req.environ[\u0027swift.extra_labels\u0027] \u003d extra_labels"},{"line_number":635,"context_line":"            req_labels \u003d ChainMap({}, base_labels)"},{"line_number":636,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":9,"id":"c18715b8_1aef776c","line":633,"updated":"2026-10-02 15:59:00.000000000","message":"this is on the request path, proxy logging initializes object requests with ``extra_labels[\u0027object_type\u0027] \u003d None``, I wonder if it\u0027s better to remove the default assignment? then the ``None`` won\u0027t show up in those test cases: https://review.opendev.org/c/openstack/swift/+/1008368/1/test/unit/common/middleware/test_proxy_logging.py#3113","commit_id":"2cda5ed7607220c28a992016ef0dd5f73034f13e"},{"author":{"_account_id":36606,"name":"Yan Xiao","display_name":"Yan","email":"yanxiao@nvidia.com","username":"yanxiao"},"change_message_id":"8a23a3c3020dde1ae96b51a4c41ad7757ee35f1f","unresolved":false,"context_lines":[{"line_number":630,"context_line":"            if extra_labels is None:"},{"line_number":631,"context_line":"                extra_labels \u003d {}"},{"line_number":632,"context_line":"                if base_labels.get(\u0027resource\u0027) \u003d\u003d \u0027object\u0027:"},{"line_number":633,"context_line":"                    extra_labels[\u0027object_type\u0027] \u003d None"},{"line_number":634,"context_line":"                req.environ[\u0027swift.extra_labels\u0027] \u003d extra_labels"},{"line_number":635,"context_line":"            req_labels \u003d ChainMap({}, base_labels)"},{"line_number":636,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":9,"id":"365ffed0_880516e8","line":633,"in_reply_to":"c18715b8_1aef776c","updated":"2026-10-02 19:35:12.000000000","message":"Acknowledged","commit_id":"2cda5ed7607220c28a992016ef0dd5f73034f13e"},{"author":{"_account_id":34930,"name":"Jianjian Huo","email":"jhuo@nvidia.com","username":"jhuo"},"change_message_id":"600d564dc4a0031204fc9f1b424df3dbfb5efc7e","unresolved":true,"context_lines":[{"line_number":108,"context_line":"    get_sensitive_params, register_sensitive_header"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"def update_extra_labels(req, labels, install_if_not_exist\u003dFalse):"},{"line_number":112,"context_line":"    \"\"\""},{"line_number":113,"context_line":"    Helper function for other middlewares to update extra_labels."},{"line_number":114,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":10,"id":"241d524a_f5c8b839","line":111,"updated":"2026-10-05 02:04:51.000000000","message":"this could be a small, specific helper in request_helpers.py, so SLO and S3API do not need to import proxy-logging middleware. see https://review.opendev.org/c/openstack/swift/+/1008736","commit_id":"6ffb26e7695556cd3bf219d7caf2bf9ebc9e7ac0"},{"author":{"_account_id":36606,"name":"Yan Xiao","display_name":"Yan","email":"yanxiao@nvidia.com","username":"yanxiao"},"change_message_id":"26238596ec90c048db7c983a65eb3da751efeff1","unresolved":false,"context_lines":[{"line_number":108,"context_line":"    get_sensitive_params, register_sensitive_header"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"def update_extra_labels(req, labels, install_if_not_exist\u003dFalse):"},{"line_number":112,"context_line":"    \"\"\""},{"line_number":113,"context_line":"    Helper function for other middlewares to update extra_labels."},{"line_number":114,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":10,"id":"676c7c9a_0f271f47","line":111,"in_reply_to":"241d524a_f5c8b839","updated":"2026-10-05 15:36:00.000000000","message":"Acknowledged","commit_id":"6ffb26e7695556cd3bf219d7caf2bf9ebc9e7ac0"},{"author":{"_account_id":34930,"name":"Jianjian Huo","email":"jhuo@nvidia.com","username":"jhuo"},"change_message_id":"600d564dc4a0031204fc9f1b424df3dbfb5efc7e","unresolved":true,"context_lines":[{"line_number":122,"context_line":"            # Only classify the client object GET or HEAD response."},{"line_number":123,"context_line":"            if k \u003d\u003d \u0027object_type\u0027 and ("},{"line_number":124,"context_line":"                    base_labels.get(\u0027resource\u0027) !\u003d \u0027object\u0027 or"},{"line_number":125,"context_line":"                    base_labels.get(\u0027method\u0027) not in (\u0027GET\u0027, \u0027HEAD\u0027)):"},{"line_number":126,"context_line":"                continue"},{"line_number":127,"context_line":"            extra_labels[k] \u003d v"},{"line_number":128,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"61ee0801_f06e0cee","line":125,"updated":"2026-10-05 02:04:51.000000000","message":"The goal of this patch is to add an object_type extra label for TTFB, so it\u0027s okay if we limit ourselves to the `GET` and `HEAD` paths. Later on, we will figure out how to enable `put` path.\n\nnote: if we put `PUT` at here, the test at https://review.opendev.org/c/openstack/swift/+/996383/10/test/unit/common/middleware/test_copy.py#384 will fail, since the copy of SLO to normal object will have incorrect ``SLO`` object_type.","commit_id":"6ffb26e7695556cd3bf219d7caf2bf9ebc9e7ac0"},{"author":{"_account_id":36606,"name":"Yan Xiao","display_name":"Yan","email":"yanxiao@nvidia.com","username":"yanxiao"},"change_message_id":"26238596ec90c048db7c983a65eb3da751efeff1","unresolved":false,"context_lines":[{"line_number":122,"context_line":"            # Only classify the client object GET or HEAD response."},{"line_number":123,"context_line":"            if k \u003d\u003d \u0027object_type\u0027 and ("},{"line_number":124,"context_line":"                    base_labels.get(\u0027resource\u0027) !\u003d \u0027object\u0027 or"},{"line_number":125,"context_line":"                    base_labels.get(\u0027method\u0027) not in (\u0027GET\u0027, \u0027HEAD\u0027)):"},{"line_number":126,"context_line":"                continue"},{"line_number":127,"context_line":"            extra_labels[k] \u003d v"},{"line_number":128,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"7204ac6e_6e32044c","line":125,"in_reply_to":"61ee0801_f06e0cee","updated":"2026-10-05 15:36:00.000000000","message":"good point, agree about the PUT path","commit_id":"6ffb26e7695556cd3bf219d7caf2bf9ebc9e7ac0"},{"author":{"_account_id":34930,"name":"Jianjian Huo","email":"jhuo@nvidia.com","username":"jhuo"},"change_message_id":"600d564dc4a0031204fc9f1b424df3dbfb5efc7e","unresolved":true,"context_lines":[{"line_number":585,"context_line":"        return labels"},{"line_number":586,"context_line":""},{"line_number":587,"context_line":"    def update_swift_base_labels(self, req):"},{"line_number":588,"context_line":"        \"\"\""},{"line_number":589,"context_line":"        Updates the dict of base_labels in the request environ and returns"},{"line_number":590,"context_line":"        the current view of labels associated with the request."},{"line_number":591,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"d9801809_c5b2e1a8","line":588,"updated":"2026-10-05 02:04:51.000000000","message":"add a sentence for extra_labels.","commit_id":"6ffb26e7695556cd3bf219d7caf2bf9ebc9e7ac0"},{"author":{"_account_id":36606,"name":"Yan Xiao","display_name":"Yan","email":"yanxiao@nvidia.com","username":"yanxiao"},"change_message_id":"26238596ec90c048db7c983a65eb3da751efeff1","unresolved":false,"context_lines":[{"line_number":585,"context_line":"        return labels"},{"line_number":586,"context_line":""},{"line_number":587,"context_line":"    def update_swift_base_labels(self, req):"},{"line_number":588,"context_line":"        \"\"\""},{"line_number":589,"context_line":"        Updates the dict of base_labels in the request environ and returns"},{"line_number":590,"context_line":"        the current view of labels associated with the request."},{"line_number":591,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"5b359142_5517b9d1","line":588,"in_reply_to":"d9801809_c5b2e1a8","updated":"2026-10-05 15:36:00.000000000","message":"Acknowledged","commit_id":"6ffb26e7695556cd3bf219d7caf2bf9ebc9e7ac0"},{"author":{"_account_id":34930,"name":"Jianjian Huo","email":"jhuo@nvidia.com","username":"jhuo"},"change_message_id":"600d564dc4a0031204fc9f1b424df3dbfb5efc7e","unresolved":true,"context_lines":[{"line_number":629,"context_line":"            else:"},{"line_number":630,"context_line":"                base_labels[\u0027api\u0027] \u003d \u0027swift\u0027"},{"line_number":631,"context_line":"            req.environ[\u0027swift.base_labels\u0027] \u003d base_labels"},{"line_number":632,"context_line":"            extra_labels \u003d req.environ.get(\u0027swift.extra_labels\u0027)"},{"line_number":633,"context_line":"            if extra_labels is None:"},{"line_number":634,"context_line":"                extra_labels \u003d {}"},{"line_number":635,"context_line":"                req.environ[\u0027swift.extra_labels\u0027] \u003d extra_labels"}],"source_content_type":"text/x-python","patch_set":10,"id":"b0fbaeac_18d96724","line":632,"updated":"2026-10-05 02:04:51.000000000","message":"those 4 lines can be replaced with\n```\n      req.environ.setdefault(\u0027swift.extra_labels\u0027, {})\n```\nwhich will keep extra_labels if it\u0027s already there.","commit_id":"6ffb26e7695556cd3bf219d7caf2bf9ebc9e7ac0"},{"author":{"_account_id":36606,"name":"Yan Xiao","display_name":"Yan","email":"yanxiao@nvidia.com","username":"yanxiao"},"change_message_id":"26238596ec90c048db7c983a65eb3da751efeff1","unresolved":false,"context_lines":[{"line_number":629,"context_line":"            else:"},{"line_number":630,"context_line":"                base_labels[\u0027api\u0027] \u003d \u0027swift\u0027"},{"line_number":631,"context_line":"            req.environ[\u0027swift.base_labels\u0027] \u003d base_labels"},{"line_number":632,"context_line":"            extra_labels \u003d req.environ.get(\u0027swift.extra_labels\u0027)"},{"line_number":633,"context_line":"            if extra_labels is None:"},{"line_number":634,"context_line":"                extra_labels \u003d {}"},{"line_number":635,"context_line":"                req.environ[\u0027swift.extra_labels\u0027] \u003d extra_labels"}],"source_content_type":"text/x-python","patch_set":10,"id":"6f44cc43_c791800d","line":632,"in_reply_to":"b0fbaeac_18d96724","updated":"2026-10-05 15:36:00.000000000","message":"Acknowledged","commit_id":"6ffb26e7695556cd3bf219d7caf2bf9ebc9e7ac0"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"6ccc2b10809c2a1ca46be38a49d7821d003d7837","unresolved":true,"context_lines":[{"line_number":642,"context_line":"        resource_type \u003d labels.get(\u0027resource\u0027)"},{"line_number":643,"context_line":"        updated_labels \u003d dict(labels)"},{"line_number":644,"context_line":"        if extra_labels is not None:"},{"line_number":645,"context_line":"            updated_labels.update(extra_labels)"},{"line_number":646,"context_line":"        if resource_type \u003d\u003d \u0027object\u0027 and \\"},{"line_number":647,"context_line":"                policy_index is not None and \\"},{"line_number":648,"context_line":"                POLICIES.get_by_index(policy_index) is not None:"}],"source_content_type":"text/x-python","patch_set":15,"id":"27f6a660_c6f02bf4","line":645,"updated":"2026-10-06 11:50:56.000000000","message":"hmmm, so this is unconditional: all other middlewares need to be aware that whatever they set in extra_labels *will* be emitted.\n\nAn alternative would be for proxy_logging to be selective: if \u0027object_type\u0027 is set, then use it, but ignore unexpected extra_labels.\n\nI guess we don\u0027t really have enough experience and use cases to know exactly what the pattern will be: \n\n* ``extra_labels`` is just a mutable data structure that is shared with subrequest environs, a place where middlewares can set key value pairs that they think might be interesting to statsd emitters; emitters choose what labels to emit.\n\nOR\n\n* ``extra_labels`` is a curated set of key_value pairs that will always be emitted (but then how does it differ from ``base_labels``?)","commit_id":"7c5438ffe83d0d5b482ab1076efd1fbd400f1cbf"},{"author":{"_account_id":34930,"name":"Jianjian Huo","email":"jhuo@nvidia.com","username":"jhuo"},"change_message_id":"99883364907a29f5df2f5ecb5426c81c83cd3712","unresolved":true,"context_lines":[{"line_number":642,"context_line":"        resource_type \u003d labels.get(\u0027resource\u0027)"},{"line_number":643,"context_line":"        updated_labels \u003d dict(labels)"},{"line_number":644,"context_line":"        if extra_labels is not None:"},{"line_number":645,"context_line":"            updated_labels.update(extra_labels)"},{"line_number":646,"context_line":"        if resource_type \u003d\u003d \u0027object\u0027 and \\"},{"line_number":647,"context_line":"                policy_index is not None and \\"},{"line_number":648,"context_line":"                POLICIES.get_by_index(policy_index) is not None:"}],"source_content_type":"text/x-python","patch_set":15,"id":"0603d82a_fe3c6506","line":645,"in_reply_to":"27f6a660_c6f02bf4","updated":"2026-10-06 15:49:01.000000000","message":"\u003e extra_labels is a curated set of key_value pairs that will always be emitted (but then how does it differ from base_labels?)\n\nthat\u0027s right, it\u0027s ``extra_labels``, callers assign a value when they are confident.\n\n\u003e emitters choose what labels to emit.\n\nagree, that\u0027s a good rule for ``extra_labels``","commit_id":"7c5438ffe83d0d5b482ab1076efd1fbd400f1cbf"},{"author":{"_account_id":34930,"name":"Jianjian Huo","email":"jhuo@nvidia.com","username":"jhuo"},"change_message_id":"b2d6ca79fd92d8df3df812dad48befa9c6e1c846","unresolved":true,"context_lines":[{"line_number":650,"context_line":"        resource_type \u003d labels.get(\u0027resource\u0027)"},{"line_number":651,"context_line":"        updated_labels \u003d dict(labels)"},{"line_number":652,"context_line":"        if extra_labels is not None:"},{"line_number":653,"context_line":"            updated_labels.update(extra_labels)"},{"line_number":654,"context_line":"            if resource_type !\u003d \u0027object\u0027 or \\"},{"line_number":655,"context_line":"                    updated_labels.get(\u0027method\u0027) not in (\u0027GET\u0027, \u0027HEAD\u0027):"},{"line_number":656,"context_line":"                updated_labels.pop(\u0027object_type\u0027, None)"}],"source_content_type":"text/x-python","patch_set":16,"id":"3bf88428_bb214411","line":653,"updated":"2026-10-30 22:18:34.000000000","message":"this copies every extra label into response metrics.\n\nNot an issue for now, since S3API is the only writer to ``swift.extra_labels``, and it writes only object_type. what if we add more labels into ``swift.extra_labels``, do we want to include them all into response metrics? maybe yes, maybe no, depends on each situation. So probably we explicitly say what we want to include at here.","commit_id":"fdb271d27f118c89c995be7a6cde2079e158e6ea"}],"swift/common/middleware/s3api/controllers/obj.py":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"e6187fbcfc8867f6f26923f2219c58f1d8d5726c","unresolved":false,"context_lines":[{"line_number":120,"context_line":"        if base_labels is not None:"},{"line_number":121,"context_line":"            s3_etag \u003d resp.sysmeta_headers.get("},{"line_number":122,"context_line":"                sysmeta_header(\u0027object\u0027, \u0027etag\u0027))"},{"line_number":123,"context_line":"            if not resp.is_slo:"},{"line_number":124,"context_line":"                object_type \u003d \u0027normal\u0027"},{"line_number":125,"context_line":"            elif s3_etag:"},{"line_number":126,"context_line":"                object_type \u003d \u0027s3_mpu\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"4290b0bd_8ad760b4","line":123,"updated":"2026-08-31 20:25:52.000000000","message":"pep8: F821 undefined name \u0027sysmeta_header\u0027","commit_id":"c7e20fe98442bffe3db96a43d90001aa2a66b206"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"e62aeb15c3c8333e03aafcc62a72978ca164f552","unresolved":true,"context_lines":[{"line_number":117,"context_line":""},{"line_number":118,"context_line":"        resp \u003d req.get_response(self.app, query\u003dquery)"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"        base_labels \u003d req.environ.get(\u0027swift.base_labels\u0027)"},{"line_number":121,"context_line":"        if base_labels is not None:"},{"line_number":122,"context_line":"            s3_etag \u003d resp.sysmeta_headers.get("},{"line_number":123,"context_line":"                s3api_sysmeta_header(\u0027object\u0027, \u0027etag\u0027))"},{"line_number":124,"context_line":"            if not resp.is_slo:"}],"source_content_type":"text/x-python","patch_set":4,"id":"d09b9ae7_161c31f2","line":121,"range":{"start_line":120,"start_character":8,"end_line":121,"end_character":35},"updated":"2026-09-07 11:24:38.000000000","message":"I think it might be worth encapuslating this in a proxy_logging helper function:\n\n```\ndef update_base_labels(my_labels):\n    base_labels \u003d req.environ.get(\u0027swift.base_labels\u0027)\n    if base_labels is not None:\n        base_labels.update(my_labels)\n```\n\nso that (a) the environ key is encapuslated and (b) the test for existence doesn\u0027t need to be repeated by every caller.","commit_id":"b3572a0293b9deca51286cfefefa9d89af396c80"},{"author":{"_account_id":36606,"name":"Yan Xiao","display_name":"Yan","email":"yanxiao@nvidia.com","username":"yanxiao"},"change_message_id":"d434d32597f58fea2a051f07aa5de2cde49ab9ff","unresolved":false,"context_lines":[{"line_number":117,"context_line":""},{"line_number":118,"context_line":"        resp \u003d req.get_response(self.app, query\u003dquery)"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"        base_labels \u003d req.environ.get(\u0027swift.base_labels\u0027)"},{"line_number":121,"context_line":"        if base_labels is not None:"},{"line_number":122,"context_line":"            s3_etag \u003d resp.sysmeta_headers.get("},{"line_number":123,"context_line":"                s3api_sysmeta_header(\u0027object\u0027, \u0027etag\u0027))"},{"line_number":124,"context_line":"            if not resp.is_slo:"}],"source_content_type":"text/x-python","patch_set":4,"id":"a8e38213_a35d1536","line":121,"range":{"start_line":120,"start_character":8,"end_line":121,"end_character":35},"in_reply_to":"d09b9ae7_161c31f2","updated":"2026-09-16 19:35:31.000000000","message":"good point!","commit_id":"b3572a0293b9deca51286cfefefa9d89af396c80"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"e62aeb15c3c8333e03aafcc62a72978ca164f552","unresolved":true,"context_lines":[{"line_number":123,"context_line":"                s3api_sysmeta_header(\u0027object\u0027, \u0027etag\u0027))"},{"line_number":124,"context_line":"            if not resp.is_slo:"},{"line_number":125,"context_line":"                object_type \u003d \u0027normal\u0027"},{"line_number":126,"context_line":"            elif s3_etag:"},{"line_number":127,"context_line":"                object_type \u003d \u0027s3_mpu\u0027"},{"line_number":128,"context_line":"            else:"},{"line_number":129,"context_line":"                object_type \u003d \u0027slo\u0027"},{"line_number":130,"context_line":"            base_labels[\u0027object_type\u0027] \u003d object_type"}],"source_content_type":"text/x-python","patch_set":4,"id":"4abaadf3_e39f0a9f","line":127,"range":{"start_line":126,"start_character":12,"end_line":127,"end_character":38},"updated":"2026-09-07 11:24:38.000000000","message":"wouldn\u0027t it be more obvious to use ``x-object-sysmeta-s3api-upload-id`` as the condition for ``s3_mpu``?\n\nnit: s3_mpu seems verbose, ``mpu`` would be sufficient; we already have an ``api`` label so we\u0027d have ``{\u0027api\u0027: \u0027s3\u0027, \u0027object_type\u0027: \u0027mpu\u0027, ...}``","commit_id":"b3572a0293b9deca51286cfefefa9d89af396c80"},{"author":{"_account_id":36606,"name":"Yan Xiao","display_name":"Yan","email":"yanxiao@nvidia.com","username":"yanxiao"},"change_message_id":"d434d32597f58fea2a051f07aa5de2cde49ab9ff","unresolved":false,"context_lines":[{"line_number":123,"context_line":"                s3api_sysmeta_header(\u0027object\u0027, \u0027etag\u0027))"},{"line_number":124,"context_line":"            if not resp.is_slo:"},{"line_number":125,"context_line":"                object_type \u003d \u0027normal\u0027"},{"line_number":126,"context_line":"            elif s3_etag:"},{"line_number":127,"context_line":"                object_type \u003d \u0027s3_mpu\u0027"},{"line_number":128,"context_line":"            else:"},{"line_number":129,"context_line":"                object_type \u003d \u0027slo\u0027"},{"line_number":130,"context_line":"            base_labels[\u0027object_type\u0027] \u003d object_type"}],"source_content_type":"text/x-python","patch_set":4,"id":"e811b264_7a679118","line":127,"range":{"start_line":126,"start_character":12,"end_line":127,"end_character":38},"in_reply_to":"4abaadf3_e39f0a9f","updated":"2026-09-16 19:35:31.000000000","message":"Acknowledged","commit_id":"b3572a0293b9deca51286cfefefa9d89af396c80"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"e62aeb15c3c8333e03aafcc62a72978ca164f552","unresolved":true,"context_lines":[{"line_number":126,"context_line":"            elif s3_etag:"},{"line_number":127,"context_line":"                object_type \u003d \u0027s3_mpu\u0027"},{"line_number":128,"context_line":"            else:"},{"line_number":129,"context_line":"                object_type \u003d \u0027slo\u0027"},{"line_number":130,"context_line":"            base_labels[\u0027object_type\u0027] \u003d object_type"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"        if not resp.is_slo:"}],"source_content_type":"text/x-python","patch_set":4,"id":"e254ad6e_ee6ac243","line":129,"range":{"start_line":129,"start_character":16,"end_line":129,"end_character":35},"updated":"2026-09-07 11:24:38.000000000","message":"it seems wrong (and unnecessary?) for s3api middleware to be writing down \u0027slo\u0027 - doesn\u0027t SLO middleware set the ``object_type`` to ``slo``?\n\nI\u0027d expect the label to already be set by the tim s3api middleware handles the response, and s3api then overwrites the label value if it knows better (i.e. mpu).","commit_id":"b3572a0293b9deca51286cfefefa9d89af396c80"},{"author":{"_account_id":36606,"name":"Yan Xiao","display_name":"Yan","email":"yanxiao@nvidia.com","username":"yanxiao"},"change_message_id":"d434d32597f58fea2a051f07aa5de2cde49ab9ff","unresolved":false,"context_lines":[{"line_number":126,"context_line":"            elif s3_etag:"},{"line_number":127,"context_line":"                object_type \u003d \u0027s3_mpu\u0027"},{"line_number":128,"context_line":"            else:"},{"line_number":129,"context_line":"                object_type \u003d \u0027slo\u0027"},{"line_number":130,"context_line":"            base_labels[\u0027object_type\u0027] \u003d object_type"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"        if not resp.is_slo:"}],"source_content_type":"text/x-python","patch_set":4,"id":"0cb716cc_75e84ea5","line":129,"range":{"start_line":129,"start_character":16,"end_line":129,"end_character":35},"in_reply_to":"e254ad6e_ee6ac243","updated":"2026-09-16 19:35:31.000000000","message":"seems so, probably also depends on the user pipeline config","commit_id":"b3572a0293b9deca51286cfefefa9d89af396c80"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"8c865ee5e0653460990b85d0e6ac0e7e24caa14d","unresolved":true,"context_lines":[{"line_number":123,"context_line":"            object_type \u003d \u0027normal\u0027"},{"line_number":124,"context_line":"        elif s3api_sysmeta_header("},{"line_number":125,"context_line":"                \u0027object\u0027, \u0027upload-id\u0027) in resp.s3api_sysmeta_headers:"},{"line_number":126,"context_line":"            object_type \u003d \u0027mpu\u0027"},{"line_number":127,"context_line":"        if object_type:"},{"line_number":128,"context_line":"            update_base_labels(req, {\u0027object_type\u0027: object_type})"},{"line_number":129,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"6cfb2716_2c01b1fc","line":126,"range":{"start_line":126,"start_character":26,"end_line":126,"end_character":31},"updated":"2026-09-17 16:21:40.000000000","message":"please use ``s3_mpu`` like the commit message says, because in the future we may have plain ``mpu`` for native mpus.","commit_id":"66027e7bc29e5b37dfda7ab23b976d28b0000f59"},{"author":{"_account_id":36606,"name":"Yan Xiao","display_name":"Yan","email":"yanxiao@nvidia.com","username":"yanxiao"},"change_message_id":"8a23a3c3020dde1ae96b51a4c41ad7757ee35f1f","unresolved":false,"context_lines":[{"line_number":123,"context_line":"            object_type \u003d \u0027normal\u0027"},{"line_number":124,"context_line":"        elif s3api_sysmeta_header("},{"line_number":125,"context_line":"                \u0027object\u0027, \u0027upload-id\u0027) in resp.s3api_sysmeta_headers:"},{"line_number":126,"context_line":"            object_type \u003d \u0027mpu\u0027"},{"line_number":127,"context_line":"        if object_type:"},{"line_number":128,"context_line":"            update_base_labels(req, {\u0027object_type\u0027: object_type})"},{"line_number":129,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"feb0d9c2_f97651e3","line":126,"range":{"start_line":126,"start_character":26,"end_line":126,"end_character":31},"in_reply_to":"6cfb2716_2c01b1fc","updated":"2026-10-02 19:35:12.000000000","message":"Acknowledged","commit_id":"66027e7bc29e5b37dfda7ab23b976d28b0000f59"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"8c865ee5e0653460990b85d0e6ac0e7e24caa14d","unresolved":true,"context_lines":[{"line_number":124,"context_line":"        elif s3api_sysmeta_header("},{"line_number":125,"context_line":"                \u0027object\u0027, \u0027upload-id\u0027) in resp.s3api_sysmeta_headers:"},{"line_number":126,"context_line":"            object_type \u003d \u0027mpu\u0027"},{"line_number":127,"context_line":"        if object_type:"},{"line_number":128,"context_line":"            update_base_labels(req, {\u0027object_type\u0027: object_type})"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"        if not resp.is_slo:"}],"source_content_type":"text/x-python","patch_set":7,"id":"caffb5c5_4559e69c","line":127,"updated":"2026-09-17 16:21:40.000000000","message":"it seems like there ought always be a value at this point?\n\nOR, in fact, we should only update the labels here when we know we have a ``s3_mpu``. Leave SLO to set ``slo``, make the default be ``normal``.","commit_id":"66027e7bc29e5b37dfda7ab23b976d28b0000f59"},{"author":{"_account_id":36606,"name":"Yan Xiao","display_name":"Yan","email":"yanxiao@nvidia.com","username":"yanxiao"},"change_message_id":"8a23a3c3020dde1ae96b51a4c41ad7757ee35f1f","unresolved":false,"context_lines":[{"line_number":124,"context_line":"        elif s3api_sysmeta_header("},{"line_number":125,"context_line":"                \u0027object\u0027, \u0027upload-id\u0027) in resp.s3api_sysmeta_headers:"},{"line_number":126,"context_line":"            object_type \u003d \u0027mpu\u0027"},{"line_number":127,"context_line":"        if object_type:"},{"line_number":128,"context_line":"            update_base_labels(req, {\u0027object_type\u0027: object_type})"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"        if not resp.is_slo:"}],"source_content_type":"text/x-python","patch_set":7,"id":"993c06de_5c2f9d41","line":127,"in_reply_to":"caffb5c5_4559e69c","updated":"2026-10-02 19:35:12.000000000","message":"Acknowledged","commit_id":"66027e7bc29e5b37dfda7ab23b976d28b0000f59"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"8c865ee5e0653460990b85d0e6ac0e7e24caa14d","unresolved":true,"context_lines":[{"line_number":125,"context_line":"                \u0027object\u0027, \u0027upload-id\u0027) in resp.s3api_sysmeta_headers:"},{"line_number":126,"context_line":"            object_type \u003d \u0027mpu\u0027"},{"line_number":127,"context_line":"        if object_type:"},{"line_number":128,"context_line":"            update_base_labels(req, {\u0027object_type\u0027: object_type})"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"        if not resp.is_slo:"},{"line_number":131,"context_line":"            # SLO ignores part_number for non-slo objects, but s3api only"}],"source_content_type":"text/x-python","patch_set":7,"id":"fc7aea48_9d00e0e9","line":128,"range":{"start_line":128,"start_character":12,"end_line":128,"end_character":30},"updated":"2026-09-17 16:21:40.000000000","message":"should this be conditional on ``resource\u003d\u003dobject``? can that ever be False?","commit_id":"66027e7bc29e5b37dfda7ab23b976d28b0000f59"},{"author":{"_account_id":36606,"name":"Yan Xiao","display_name":"Yan","email":"yanxiao@nvidia.com","username":"yanxiao"},"change_message_id":"8a23a3c3020dde1ae96b51a4c41ad7757ee35f1f","unresolved":false,"context_lines":[{"line_number":125,"context_line":"                \u0027object\u0027, \u0027upload-id\u0027) in resp.s3api_sysmeta_headers:"},{"line_number":126,"context_line":"            object_type \u003d \u0027mpu\u0027"},{"line_number":127,"context_line":"        if object_type:"},{"line_number":128,"context_line":"            update_base_labels(req, {\u0027object_type\u0027: object_type})"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"        if not resp.is_slo:"},{"line_number":131,"context_line":"            # SLO ignores part_number for non-slo objects, but s3api only"}],"source_content_type":"text/x-python","patch_set":7,"id":"9c3e9644_d3c213f5","line":128,"range":{"start_line":128,"start_character":12,"end_line":128,"end_character":30},"in_reply_to":"fc7aea48_9d00e0e9","updated":"2026-10-02 19:35:12.000000000","message":"Acknowledged","commit_id":"66027e7bc29e5b37dfda7ab23b976d28b0000f59"},{"author":{"_account_id":34930,"name":"Jianjian Huo","email":"jhuo@nvidia.com","username":"jhuo"},"change_message_id":"1de7ce2101f5553e327ccfeb6871d0266aa8abc7","unresolved":true,"context_lines":[{"line_number":120,"context_line":""},{"line_number":121,"context_line":"        object_type \u003d None"},{"line_number":122,"context_line":"        if not resp.is_slo:"},{"line_number":123,"context_line":"            object_type \u003d \u0027normal\u0027"},{"line_number":124,"context_line":"        elif s3api_sysmeta_header("},{"line_number":125,"context_line":"                \u0027object\u0027, \u0027upload-id\u0027) in resp.s3api_sysmeta_headers:"},{"line_number":126,"context_line":"            object_type \u003d \u0027s3_mpu\u0027"}],"source_content_type":"text/x-python","patch_set":8,"id":"4508b261_12e0d5b7","line":123,"updated":"2026-09-23 00:30:48.000000000","message":"this is not ture, ``None`` can still mean “object type was never determined.”\nFor example:\nGET an existing MPU object\n  → object_type initialized to None\n  → authentication fails before object metadata is read\n  → 403 response returns to outer proxy-logging\n  → None → normal would incorrectly classify that request","commit_id":"1fb1de1f25b6ecf27af31cb6c878aac6ce60e1ee"},{"author":{"_account_id":36606,"name":"Yan Xiao","display_name":"Yan","email":"yanxiao@nvidia.com","username":"yanxiao"},"change_message_id":"8a23a3c3020dde1ae96b51a4c41ad7757ee35f1f","unresolved":false,"context_lines":[{"line_number":120,"context_line":""},{"line_number":121,"context_line":"        object_type \u003d None"},{"line_number":122,"context_line":"        if not resp.is_slo:"},{"line_number":123,"context_line":"            object_type \u003d \u0027normal\u0027"},{"line_number":124,"context_line":"        elif s3api_sysmeta_header("},{"line_number":125,"context_line":"                \u0027object\u0027, \u0027upload-id\u0027) in resp.s3api_sysmeta_headers:"},{"line_number":126,"context_line":"            object_type \u003d \u0027s3_mpu\u0027"}],"source_content_type":"text/x-python","patch_set":8,"id":"8baaa09f_c7a381f2","line":123,"in_reply_to":"2e7e3151_885eb6cc","updated":"2026-10-02 19:35:12.000000000","message":"Acknowledged","commit_id":"1fb1de1f25b6ecf27af31cb6c878aac6ce60e1ee"},{"author":{"_account_id":34930,"name":"Jianjian Huo","email":"jhuo@nvidia.com","username":"jhuo"},"change_message_id":"85d7fc70ec6a205df83bd2bcf420420449ef5312","unresolved":true,"context_lines":[{"line_number":120,"context_line":""},{"line_number":121,"context_line":"        object_type \u003d None"},{"line_number":122,"context_line":"        if not resp.is_slo:"},{"line_number":123,"context_line":"            object_type \u003d \u0027normal\u0027"},{"line_number":124,"context_line":"        elif s3api_sysmeta_header("},{"line_number":125,"context_line":"                \u0027object\u0027, \u0027upload-id\u0027) in resp.s3api_sysmeta_headers:"},{"line_number":126,"context_line":"            object_type \u003d \u0027s3_mpu\u0027"}],"source_content_type":"text/x-python","patch_set":8,"id":"2e7e3151_885eb6cc","line":123,"in_reply_to":"4508b261_12e0d5b7","updated":"2026-10-02 01:59:32.000000000","message":"I fixed this and below comments at: https://review.opendev.org/c/openstack/swift/+/1008368\n\nbasically, MPU GET/HEAD sets object_type\u003d\u0027mpu\u0027, normal and unknown objects retain None","commit_id":"1fb1de1f25b6ecf27af31cb6c878aac6ce60e1ee"},{"author":{"_account_id":34930,"name":"Jianjian Huo","email":"jhuo@nvidia.com","username":"jhuo"},"change_message_id":"600d564dc4a0031204fc9f1b424df3dbfb5efc7e","unresolved":true,"context_lines":[{"line_number":116,"context_line":"                # Versioning has never been enabled"},{"line_number":117,"context_line":"                raise NoSuchVersion(object_name, version_id)"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"        resp \u003d req.get_response(self.app, query\u003dquery)"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"        if resp.is_slo and s3api_sysmeta_header("},{"line_number":122,"context_line":"                \u0027object\u0027, \u0027upload-id\u0027) in resp.s3api_sysmeta_headers:"}],"source_content_type":"text/x-python","patch_set":10,"id":"607418c5_429a0aea","line":119,"updated":"2026-10-05 02:04:51.000000000","message":"this can raise before the new MPU classification runs. SLO has already set object_type\u003dslo, which then reaches the outer logger. e.g. GET with failed If-Match (412), invalid Range (416), invalid partNumber (416), and a missing first segment (409 BrokenMPU). HEAD precondition and part-number failures also retain slo. These requests won\u0027t emit metrics with mpu object_type.\n\nhowever, this patch has narrowed its scope to be just \"enable mpu ttfb metrics with object_type extra label\", we can just add a comment at here.","commit_id":"6ffb26e7695556cd3bf219d7caf2bf9ebc9e7ac0"},{"author":{"_account_id":34930,"name":"Jianjian Huo","email":"jhuo@nvidia.com","username":"jhuo"},"change_message_id":"1b5fd0278e82906a3a14c95a4ae48abba1777b1e","unresolved":true,"context_lines":[{"line_number":116,"context_line":"                # Versioning has never been enabled"},{"line_number":117,"context_line":"                raise NoSuchVersion(object_name, version_id)"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"        resp \u003d req.get_response(self.app, query\u003dquery)"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"        if resp.is_slo and s3api_sysmeta_header("},{"line_number":122,"context_line":"                \u0027object\u0027, \u0027upload-id\u0027) in resp.s3api_sysmeta_headers:"}],"source_content_type":"text/x-python","patch_set":10,"id":"c7805f68_d1cdb7cf","line":119,"in_reply_to":"607418c5_429a0aea","updated":"2026-10-05 02:10:36.000000000","message":"in the follow-up, I also removed \"slo\" object_type labeling in slo.py, then those failed MPU requests won\u0027t emit metrics with incorrect slo label.","commit_id":"6ffb26e7695556cd3bf219d7caf2bf9ebc9e7ac0"},{"author":{"_account_id":36606,"name":"Yan Xiao","display_name":"Yan","email":"yanxiao@nvidia.com","username":"yanxiao"},"change_message_id":"26238596ec90c048db7c983a65eb3da751efeff1","unresolved":false,"context_lines":[{"line_number":116,"context_line":"                # Versioning has never been enabled"},{"line_number":117,"context_line":"                raise NoSuchVersion(object_name, version_id)"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"        resp \u003d req.get_response(self.app, query\u003dquery)"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"        if resp.is_slo and s3api_sysmeta_header("},{"line_number":122,"context_line":"                \u0027object\u0027, \u0027upload-id\u0027) in resp.s3api_sysmeta_headers:"}],"source_content_type":"text/x-python","patch_set":10,"id":"d5f42b51_d6f78ace","line":119,"in_reply_to":"c7805f68_d1cdb7cf","updated":"2026-10-05 15:36:00.000000000","message":"Acknowledged","commit_id":"6ffb26e7695556cd3bf219d7caf2bf9ebc9e7ac0"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"6ccc2b10809c2a1ca46be38a49d7821d003d7837","unresolved":true,"context_lines":[{"line_number":122,"context_line":"                \u0027object\u0027, \u0027upload-id\u0027) in resp.s3api_sysmeta_headers:"},{"line_number":123,"context_line":"            # Failed MPU requests won\u0027t have mpu object type set due to no"},{"line_number":124,"context_line":"            # clear signal from response, e.g. 404, 429, 503 and etc."},{"line_number":125,"context_line":"            set_client_object_type(req, \u0027mpu\u0027)"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"        if not resp.is_slo:"},{"line_number":128,"context_line":"            # SLO ignores part_number for non-slo objects, but s3api only"}],"source_content_type":"text/x-python","patch_set":15,"id":"8a577f0a_da1b8bd0","line":125,"updated":"2026-10-06 11:50:56.000000000","message":"I thought we had decided that the label would always be emitted for object GET/HEAD with values ``\u0027mpu\u0027`` or ``\u0027\u0027``?","commit_id":"7c5438ffe83d0d5b482ab1076efd1fbd400f1cbf"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"6ccc2b10809c2a1ca46be38a49d7821d003d7837","unresolved":true,"context_lines":[{"line_number":122,"context_line":"                \u0027object\u0027, \u0027upload-id\u0027) in resp.s3api_sysmeta_headers:"},{"line_number":123,"context_line":"            # Failed MPU requests won\u0027t have mpu object type set due to no"},{"line_number":124,"context_line":"            # clear signal from response, e.g. 404, 429, 503 and etc."},{"line_number":125,"context_line":"            set_client_object_type(req, \u0027mpu\u0027)"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"        if not resp.is_slo:"},{"line_number":128,"context_line":"            # SLO ignores part_number for non-slo objects, but s3api only"}],"source_content_type":"text/x-python","patch_set":15,"id":"5483a5fb_258f8ba6","line":125,"range":{"start_line":125,"start_character":41,"end_line":125,"end_character":44},"updated":"2026-10-06 11:50:56.000000000","message":"one day we might want to differentiate ``native_mpu`` vs ``slo_mpu``.\n\nI guess we could add ``mpu_type\u003d[slo|native]`` 🤷","commit_id":"7c5438ffe83d0d5b482ab1076efd1fbd400f1cbf"},{"author":{"_account_id":36606,"name":"Yan Xiao","display_name":"Yan","email":"yanxiao@nvidia.com","username":"yanxiao"},"change_message_id":"3f04812bad82fb1f29af3d73f88f20ef6a4fd7d0","unresolved":false,"context_lines":[{"line_number":122,"context_line":"                \u0027object\u0027, \u0027upload-id\u0027) in resp.s3api_sysmeta_headers:"},{"line_number":123,"context_line":"            # Failed MPU requests won\u0027t have mpu object type set due to no"},{"line_number":124,"context_line":"            # clear signal from response, e.g. 404, 429, 503 and etc."},{"line_number":125,"context_line":"            set_client_object_type(req, \u0027mpu\u0027)"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"        if not resp.is_slo:"},{"line_number":128,"context_line":"            # SLO ignores part_number for non-slo objects, but s3api only"}],"source_content_type":"text/x-python","patch_set":15,"id":"39080a4f_08a81809","line":125,"range":{"start_line":125,"start_character":41,"end_line":125,"end_character":44},"in_reply_to":"5483a5fb_258f8ba6","updated":"2026-10-16 19:31:56.000000000","message":"Acknowledged","commit_id":"7c5438ffe83d0d5b482ab1076efd1fbd400f1cbf"},{"author":{"_account_id":34930,"name":"Jianjian Huo","email":"jhuo@nvidia.com","username":"jhuo"},"change_message_id":"99883364907a29f5df2f5ecb5426c81c83cd3712","unresolved":true,"context_lines":[{"line_number":122,"context_line":"                \u0027object\u0027, \u0027upload-id\u0027) in resp.s3api_sysmeta_headers:"},{"line_number":123,"context_line":"            # Failed MPU requests won\u0027t have mpu object type set due to no"},{"line_number":124,"context_line":"            # clear signal from response, e.g. 404, 429, 503 and etc."},{"line_number":125,"context_line":"            set_client_object_type(req, \u0027mpu\u0027)"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"        if not resp.is_slo:"},{"line_number":128,"context_line":"            # SLO ignores part_number for non-slo objects, but s3api only"}],"source_content_type":"text/x-python","patch_set":15,"id":"f3be890b_88aa9ede","line":125,"in_reply_to":"8a577f0a_da1b8bd0","updated":"2026-10-06 15:49:01.000000000","message":"I proposed this direction, since this is extra labels: this is the case for the base labels, but the extra labels will be added when the caller has confidence to assign a value to the field. I found it confusing to see lots of test cases issuing normal object requests but see the object type as None or empty.","commit_id":"7c5438ffe83d0d5b482ab1076efd1fbd400f1cbf"},{"author":{"_account_id":36606,"name":"Yan Xiao","display_name":"Yan","email":"yanxiao@nvidia.com","username":"yanxiao"},"change_message_id":"3f04812bad82fb1f29af3d73f88f20ef6a4fd7d0","unresolved":false,"context_lines":[{"line_number":122,"context_line":"                \u0027object\u0027, \u0027upload-id\u0027) in resp.s3api_sysmeta_headers:"},{"line_number":123,"context_line":"            # Failed MPU requests won\u0027t have mpu object type set due to no"},{"line_number":124,"context_line":"            # clear signal from response, e.g. 404, 429, 503 and etc."},{"line_number":125,"context_line":"            set_client_object_type(req, \u0027mpu\u0027)"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"        if not resp.is_slo:"},{"line_number":128,"context_line":"            # SLO ignores part_number for non-slo objects, but s3api only"}],"source_content_type":"text/x-python","patch_set":15,"id":"a57fae75_15053df5","line":125,"in_reply_to":"f3be890b_88aa9ede","updated":"2026-10-16 19:31:56.000000000","message":"Acknowledged","commit_id":"7c5438ffe83d0d5b482ab1076efd1fbd400f1cbf"}],"swift/common/middleware/slo.py":[{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"e62aeb15c3c8333e03aafcc62a72978ca164f552","unresolved":true,"context_lines":[{"line_number":1167,"context_line":"        base_labels \u003d req.environ.get(\u0027swift.base_labels\u0027)"},{"line_number":1168,"context_line":"        if base_labels is not None:"},{"line_number":1169,"context_line":"            base_labels[\u0027object_type\u0027] \u003d ("},{"line_number":1170,"context_line":"                \u0027slo\u0027 if resp_attrs.is_slo else \u0027normal\u0027)"},{"line_number":1171,"context_line":""},{"line_number":1172,"context_line":"        if not resp_attrs.is_slo:"},{"line_number":1173,"context_line":"            # even if the original resp_attrs may have been SLO we may have"}],"source_content_type":"text/x-python","patch_set":4,"id":"66270907_0dcefb44","line":1170,"updated":"2026-09-07 11:24:38.000000000","message":"this would always be set before the s3api middleware handled the response, correct?","commit_id":"b3572a0293b9deca51286cfefefa9d89af396c80"},{"author":{"_account_id":36606,"name":"Yan Xiao","display_name":"Yan","email":"yanxiao@nvidia.com","username":"yanxiao"},"change_message_id":"d434d32597f58fea2a051f07aa5de2cde49ab9ff","unresolved":false,"context_lines":[{"line_number":1167,"context_line":"        base_labels \u003d req.environ.get(\u0027swift.base_labels\u0027)"},{"line_number":1168,"context_line":"        if base_labels is not None:"},{"line_number":1169,"context_line":"            base_labels[\u0027object_type\u0027] \u003d ("},{"line_number":1170,"context_line":"                \u0027slo\u0027 if resp_attrs.is_slo else \u0027normal\u0027)"},{"line_number":1171,"context_line":""},{"line_number":1172,"context_line":"        if not resp_attrs.is_slo:"},{"line_number":1173,"context_line":"            # even if the original resp_attrs may have been SLO we may have"}],"source_content_type":"text/x-python","patch_set":4,"id":"5efd5d46_5ad28c6f","line":1170,"in_reply_to":"66270907_0dcefb44","updated":"2026-09-16 19:35:31.000000000","message":"Acknowledged","commit_id":"b3572a0293b9deca51286cfefefa9d89af396c80"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"8c865ee5e0653460990b85d0e6ac0e7e24caa14d","unresolved":true,"context_lines":[{"line_number":1166,"context_line":"                    req, resp_iter, resp_attrs)"},{"line_number":1167,"context_line":""},{"line_number":1168,"context_line":"        labels \u003d {\u0027object_type\u0027:"},{"line_number":1169,"context_line":"                  \u0027slo\u0027 if resp_attrs.is_slo else \u0027normal\u0027}"},{"line_number":1170,"context_line":"        update_base_labels(req, labels)"},{"line_number":1171,"context_line":""},{"line_number":1172,"context_line":"        if not resp_attrs.is_slo:"}],"source_content_type":"text/x-python","patch_set":7,"id":"7339fef0_2d3b7c3f","line":1169,"updated":"2026-09-17 16:21:40.000000000","message":"what if we already have \n\n```\nobject_type \u003d foo\n```\n\nI wonder if we should only update the labels if we have an authoritative value","commit_id":"66027e7bc29e5b37dfda7ab23b976d28b0000f59"},{"author":{"_account_id":36606,"name":"Yan Xiao","display_name":"Yan","email":"yanxiao@nvidia.com","username":"yanxiao"},"change_message_id":"8a23a3c3020dde1ae96b51a4c41ad7757ee35f1f","unresolved":false,"context_lines":[{"line_number":1166,"context_line":"                    req, resp_iter, resp_attrs)"},{"line_number":1167,"context_line":""},{"line_number":1168,"context_line":"        labels \u003d {\u0027object_type\u0027:"},{"line_number":1169,"context_line":"                  \u0027slo\u0027 if resp_attrs.is_slo else \u0027normal\u0027}"},{"line_number":1170,"context_line":"        update_base_labels(req, labels)"},{"line_number":1171,"context_line":""},{"line_number":1172,"context_line":"        if not resp_attrs.is_slo:"}],"source_content_type":"text/x-python","patch_set":7,"id":"940a6dc1_0da1aebb","line":1169,"in_reply_to":"7339fef0_2d3b7c3f","updated":"2026-10-02 19:35:12.000000000","message":"Acknowledged","commit_id":"66027e7bc29e5b37dfda7ab23b976d28b0000f59"}],"swift/common/request_helpers.py":[{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"6ccc2b10809c2a1ca46be38a49d7821d003d7837","unresolved":true,"context_lines":[{"line_number":1020,"context_line":"    return \u0027,\u0027.join(environ.get(\u0027swift.log_info\u0027, []))"},{"line_number":1021,"context_line":""},{"line_number":1022,"context_line":""},{"line_number":1023,"context_line":"def set_client_object_type(req, object_type):"},{"line_number":1024,"context_line":"    \"\"\"Set the object type for a client object GET or HEAD.\"\"\""},{"line_number":1025,"context_line":"    base_labels \u003d req.environ.get(\u0027swift.base_labels\u0027) or {}"},{"line_number":1026,"context_line":"    extra_labels \u003d req.environ.get(\u0027swift.extra_labels\u0027)"}],"source_content_type":"text/x-python","patch_set":15,"id":"5574ce95_7cc0f720","line":1023,"updated":"2026-10-06 11:50:56.000000000","message":"I have a few concerns about this being a helper function:\n\n1. The name of the function says nothing about extra_labels\n\n2. The name of the function says nothing about it being a *conditional* set\n\n3. To my mind ``client_object_type`` implies this is something the client is aware of, which it is not: the client doesn\u0027t know that the response is for an mpu (hmmm, or does it? I\u0027m pretty sure it does not: I  don\u0027t think s3api returns an upload-id header with a GET response).\n\nI suspect that with other work in progress on labels, we may end up with a separate module for labels helpers, or even a label class that encapsulate base_labels and extra_labels. I think we should avoid releasing a helper function in this *utils* module for the time being (with only one use case), and refactor later when we have more than one use case.","commit_id":"7c5438ffe83d0d5b482ab1076efd1fbd400f1cbf"},{"author":{"_account_id":36606,"name":"Yan Xiao","display_name":"Yan","email":"yanxiao@nvidia.com","username":"yanxiao"},"change_message_id":"3f04812bad82fb1f29af3d73f88f20ef6a4fd7d0","unresolved":false,"context_lines":[{"line_number":1020,"context_line":"    return \u0027,\u0027.join(environ.get(\u0027swift.log_info\u0027, []))"},{"line_number":1021,"context_line":""},{"line_number":1022,"context_line":""},{"line_number":1023,"context_line":"def set_client_object_type(req, object_type):"},{"line_number":1024,"context_line":"    \"\"\"Set the object type for a client object GET or HEAD.\"\"\""},{"line_number":1025,"context_line":"    base_labels \u003d req.environ.get(\u0027swift.base_labels\u0027) or {}"},{"line_number":1026,"context_line":"    extra_labels \u003d req.environ.get(\u0027swift.extra_labels\u0027)"}],"source_content_type":"text/x-python","patch_set":15,"id":"9f0f430c_292cfe92","line":1023,"in_reply_to":"5574ce95_7cc0f720","updated":"2026-10-16 19:31:56.000000000","message":"Acknowledged","commit_id":"7c5438ffe83d0d5b482ab1076efd1fbd400f1cbf"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"6ccc2b10809c2a1ca46be38a49d7821d003d7837","unresolved":true,"context_lines":[{"line_number":1026,"context_line":"    extra_labels \u003d req.environ.get(\u0027swift.extra_labels\u0027)"},{"line_number":1027,"context_line":"    if extra_labels is not None and base_labels.get(\u0027resource\u0027) \u003d\u003d \u0027object\u0027 \\"},{"line_number":1028,"context_line":"            and base_labels.get(\u0027method\u0027) in (\u0027GET\u0027, \u0027HEAD\u0027):"},{"line_number":1029,"context_line":"        extra_labels[\u0027object_type\u0027] \u003d object_type"},{"line_number":1030,"context_line":""},{"line_number":1031,"context_line":""},{"line_number":1032,"context_line":"def get_heartbeat_response_body(data_format, data_dict, error_list, root_tag):"}],"source_content_type":"text/x-python","patch_set":15,"id":"c3b61951_920a02c3","line":1029,"updated":"2026-10-06 11:50:56.000000000","message":"I wonder if this conditional logic better belongs in proxy_logging:\n\ns3api declares that to the best of its knowledge this is an mpu, proxy_logging applies conditional checks as to whether it want to include that extra label.","commit_id":"7c5438ffe83d0d5b482ab1076efd1fbd400f1cbf"},{"author":{"_account_id":36606,"name":"Yan Xiao","display_name":"Yan","email":"yanxiao@nvidia.com","username":"yanxiao"},"change_message_id":"3f04812bad82fb1f29af3d73f88f20ef6a4fd7d0","unresolved":false,"context_lines":[{"line_number":1026,"context_line":"    extra_labels \u003d req.environ.get(\u0027swift.extra_labels\u0027)"},{"line_number":1027,"context_line":"    if extra_labels is not None and base_labels.get(\u0027resource\u0027) \u003d\u003d \u0027object\u0027 \\"},{"line_number":1028,"context_line":"            and base_labels.get(\u0027method\u0027) in (\u0027GET\u0027, \u0027HEAD\u0027):"},{"line_number":1029,"context_line":"        extra_labels[\u0027object_type\u0027] \u003d object_type"},{"line_number":1030,"context_line":""},{"line_number":1031,"context_line":""},{"line_number":1032,"context_line":"def get_heartbeat_response_body(data_format, data_dict, error_list, root_tag):"}],"source_content_type":"text/x-python","patch_set":15,"id":"fd89e4e3_cd93e625","line":1029,"in_reply_to":"c3b61951_920a02c3","updated":"2026-10-16 19:31:56.000000000","message":"Acknowledged","commit_id":"7c5438ffe83d0d5b482ab1076efd1fbd400f1cbf"}],"swift/common/wsgi.py":[{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"6ccc2b10809c2a1ca46be38a49d7821d003d7837","unresolved":true,"context_lines":[{"line_number":1358,"context_line":"                 \u0027swift.trans_id\u0027, \u0027swift.authorize_override\u0027,"},{"line_number":1359,"context_line":"                 \u0027swift.authorize\u0027, \u0027HTTP_X_USER_ID\u0027, \u0027HTTP_X_PROJECT_ID\u0027,"},{"line_number":1360,"context_line":"                 \u0027HTTP_REFERER\u0027, \u0027swift.infocache\u0027,"},{"line_number":1361,"context_line":"                 \u0027swift.base_labels\u0027, \u0027swift.extra_labels\u0027,"},{"line_number":1362,"context_line":"                 \u0027swift.shard_listing_history\u0027):"},{"line_number":1363,"context_line":"        if name in env:"},{"line_number":1364,"context_line":"            newenv[name] \u003d env[name]"}],"source_content_type":"text/x-python","patch_set":12,"id":"52bd3bb2_5eb8e896","line":1361,"updated":"2026-10-06 11:50:56.000000000","message":"oh, have we decided that extra_labels is NOT shared with subrequest environs?","commit_id":"ffea3ca8c0a55f10218638a06934c600370b2da9"},{"author":{"_account_id":36606,"name":"Yan Xiao","display_name":"Yan","email":"yanxiao@nvidia.com","username":"yanxiao"},"change_message_id":"3f04812bad82fb1f29af3d73f88f20ef6a4fd7d0","unresolved":false,"context_lines":[{"line_number":1358,"context_line":"                 \u0027swift.trans_id\u0027, \u0027swift.authorize_override\u0027,"},{"line_number":1359,"context_line":"                 \u0027swift.authorize\u0027, \u0027HTTP_X_USER_ID\u0027, \u0027HTTP_X_PROJECT_ID\u0027,"},{"line_number":1360,"context_line":"                 \u0027HTTP_REFERER\u0027, \u0027swift.infocache\u0027,"},{"line_number":1361,"context_line":"                 \u0027swift.base_labels\u0027, \u0027swift.extra_labels\u0027,"},{"line_number":1362,"context_line":"                 \u0027swift.shard_listing_history\u0027):"},{"line_number":1363,"context_line":"        if name in env:"},{"line_number":1364,"context_line":"            newenv[name] \u003d env[name]"}],"source_content_type":"text/x-python","patch_set":12,"id":"20333fef_118f58f4","line":1361,"in_reply_to":"0a2cec7a_2c127ad1","updated":"2026-10-16 19:31:56.000000000","message":"Acknowledged","commit_id":"ffea3ca8c0a55f10218638a06934c600370b2da9"},{"author":{"_account_id":34930,"name":"Jianjian Huo","email":"jhuo@nvidia.com","username":"jhuo"},"change_message_id":"99883364907a29f5df2f5ecb5426c81c83cd3712","unresolved":true,"context_lines":[{"line_number":1358,"context_line":"                 \u0027swift.trans_id\u0027, \u0027swift.authorize_override\u0027,"},{"line_number":1359,"context_line":"                 \u0027swift.authorize\u0027, \u0027HTTP_X_USER_ID\u0027, \u0027HTTP_X_PROJECT_ID\u0027,"},{"line_number":1360,"context_line":"                 \u0027HTTP_REFERER\u0027, \u0027swift.infocache\u0027,"},{"line_number":1361,"context_line":"                 \u0027swift.base_labels\u0027, \u0027swift.extra_labels\u0027,"},{"line_number":1362,"context_line":"                 \u0027swift.shard_listing_history\u0027):"},{"line_number":1363,"context_line":"        if name in env:"},{"line_number":1364,"context_line":"            newenv[name] \u003d env[name]"}],"source_content_type":"text/x-python","patch_set":12,"id":"0a2cec7a_2c127ad1","line":1361,"in_reply_to":"52bd3bb2_5eb8e896","updated":"2026-10-06 15:49:01.000000000","message":"I don\u0027t feel why subrequest environs need it, since this patch aims to enable mpu label for the leftmost TTFB and other proxy-logging. maybe another follow-up patch if we later find subrequest environs need it too.","commit_id":"ffea3ca8c0a55f10218638a06934c600370b2da9"}],"test/unit/common/middleware/s3api/test_obj.py":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"e6187fbcfc8867f6f26923f2219c58f1d8d5726c","unresolved":false,"context_lines":[{"line_number":226,"context_line":"        status \u003d self._do_test_object_GETorHEAD_conditional("},{"line_number":227,"context_line":"            \u0027HEAD\u0027, {\u0027If-Match\u0027: \u0027\"%s\"\u0027 % legacy_etag}, resp_headers)"},{"line_number":228,"context_line":"        self.assertEqual(\u0027412\u0027, status)"},{"line_number":229,"context_line":"    def test_object_type_for_slo(self):"},{"line_number":230,"context_line":"        object_path \u003d \u0027/v1/AUTH_test/bucket/object\u0027"},{"line_number":231,"context_line":"        s3_etag_header \u003d sysmeta_header(\u0027object\u0027, \u0027etag\u0027)"},{"line_number":232,"context_line":"        cases \u003d ("}],"source_content_type":"text/x-python","patch_set":3,"id":"8633eacd_4a183add","line":229,"updated":"2026-08-31 20:25:52.000000000","message":"pep8: E301 expected 1 blank line, found 0","commit_id":"c7e20fe98442bffe3db96a43d90001aa2a66b206"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"e6187fbcfc8867f6f26923f2219c58f1d8d5726c","unresolved":false,"context_lines":[{"line_number":267,"context_line":""},{"line_number":268,"context_line":"        self.assertEqual(\u0027200 OK\u0027, status)"},{"line_number":269,"context_line":"        self.assertNotIn(\u0027swift.base_labels\u0027, req.environ)"},{"line_number":270,"context_line":"    def test_object_HEAD_error(self):"},{"line_number":271,"context_line":"        # HEAD does not return the body even an error response in the"},{"line_number":272,"context_line":"        # specifications of the REST API."},{"line_number":273,"context_line":"        # So, check the response code for error test of HEAD."}],"source_content_type":"text/x-python","patch_set":3,"id":"9d29e3f1_ff45cd39","line":270,"updated":"2026-08-31 20:25:52.000000000","message":"pep8: E301 expected 1 blank line, found 0","commit_id":"c7e20fe98442bffe3db96a43d90001aa2a66b206"},{"author":{"_account_id":34930,"name":"Jianjian Huo","email":"jhuo@nvidia.com","username":"jhuo"},"change_message_id":"1de7ce2101f5553e327ccfeb6871d0266aa8abc7","unresolved":true,"context_lines":[{"line_number":36,"context_line":"from swift.common.middleware.s3api.subresource import ACL, User, encode_acl, \\"},{"line_number":37,"context_line":"    Owner, Grant"},{"line_number":38,"context_line":"from swift.common.middleware.s3api.etree import fromstring"},{"line_number":39,"context_line":"from swift.common.middleware.s3api.utils import S3Timestamp, sysmeta_header"},{"line_number":40,"context_line":"from swift.common.middleware.versioned_writes.object_versioning import \\"},{"line_number":41,"context_line":"    DELETE_MARKER_CONTENT_TYPE"},{"line_number":42,"context_line":"from swift.common.utils import md5"}],"source_content_type":"text/x-python","patch_set":8,"id":"efed739e_fbdd0be2","line":39,"updated":"2026-09-23 00:30:48.000000000","message":"``sysmeta_header`` is giving zuul this error\n________________________________________________________________________________________ ERROR collecting test/unit/common/middleware/s3api/test_obj.py ________________________________________________________________________________________\nImportError while importing test module \u0027/home/zuul/src/opendev.org/openstack/swift/test/unit/common/middleware/s3api/test_obj.py\u0027.\nHint: make sure your test modules/packages have valid Python names.\nTraceback:\n/usr/local/lib/python3.7/importlib/__init__.py:127: in import_module\n    return _bootstrap._gcd_import(name[level:], package, level)\ntest/unit/common/middleware/s3api/test_obj.py:39: in \u003cmodule\u003e\n    from swift.common.middleware.s3api.utils import S3Timestamp, sysmeta_header\nE   ImportError: cannot import name \u0027sysmeta_header\u0027 from \u0027swift.common.middleware.s3api.utils\u0027 (/home/zuul/src/opendev.org/openstack/swift/swift/common/middleware/s3api/utils.py)\n```suggestion\nfrom swift.common.middleware.s3api.utils import S3Timestamp, sysmeta_header\n```","commit_id":"1fb1de1f25b6ecf27af31cb6c878aac6ce60e1ee"},{"author":{"_account_id":36606,"name":"Yan Xiao","display_name":"Yan","email":"yanxiao@nvidia.com","username":"yanxiao"},"change_message_id":"8a23a3c3020dde1ae96b51a4c41ad7757ee35f1f","unresolved":false,"context_lines":[{"line_number":36,"context_line":"from swift.common.middleware.s3api.subresource import ACL, User, encode_acl, \\"},{"line_number":37,"context_line":"    Owner, Grant"},{"line_number":38,"context_line":"from swift.common.middleware.s3api.etree import fromstring"},{"line_number":39,"context_line":"from swift.common.middleware.s3api.utils import S3Timestamp, sysmeta_header"},{"line_number":40,"context_line":"from swift.common.middleware.versioned_writes.object_versioning import \\"},{"line_number":41,"context_line":"    DELETE_MARKER_CONTENT_TYPE"},{"line_number":42,"context_line":"from swift.common.utils import md5"}],"source_content_type":"text/x-python","patch_set":8,"id":"a13b4274_66d4317f","line":39,"in_reply_to":"6b7381b1_72341049","updated":"2026-10-02 19:35:12.000000000","message":"Acknowledged","commit_id":"1fb1de1f25b6ecf27af31cb6c878aac6ce60e1ee"},{"author":{"_account_id":34930,"name":"Jianjian Huo","email":"jhuo@nvidia.com","username":"jhuo"},"change_message_id":"85d7fc70ec6a205df83bd2bcf420420449ef5312","unresolved":true,"context_lines":[{"line_number":36,"context_line":"from swift.common.middleware.s3api.subresource import ACL, User, encode_acl, \\"},{"line_number":37,"context_line":"    Owner, Grant"},{"line_number":38,"context_line":"from swift.common.middleware.s3api.etree import fromstring"},{"line_number":39,"context_line":"from swift.common.middleware.s3api.utils import S3Timestamp, sysmeta_header"},{"line_number":40,"context_line":"from swift.common.middleware.versioned_writes.object_versioning import \\"},{"line_number":41,"context_line":"    DELETE_MARKER_CONTENT_TYPE"},{"line_number":42,"context_line":"from swift.common.utils import md5"}],"source_content_type":"text/x-python","patch_set":8,"id":"6b7381b1_72341049","line":39,"in_reply_to":"efed739e_fbdd0be2","updated":"2026-10-02 01:59:32.000000000","message":"I have this fixed at: 1008368: sq? keep object response labels on client reads | https://review.opendev.org/c/openstack/swift/+/1008368","commit_id":"1fb1de1f25b6ecf27af31cb6c878aac6ce60e1ee"}],"test/unit/common/middleware/test_proxy_logging.py":[{"author":{"_account_id":34930,"name":"Jianjian Huo","email":"jhuo@nvidia.com","username":"jhuo"},"change_message_id":"d0fbf138a0e5791420afd3ee35199960202e0944","unresolved":true,"context_lines":[{"line_number":2459,"context_line":"    def test_object_type_response_metrics_end_to_end(self):"},{"line_number":2460,"context_line":"        # Check GET and HEAD metrics for normal objects, SLOs, and MPUs."},{"line_number":2461,"context_line":"        # Run requests through S3API, SLO, and both proxy_logging instances."},{"line_number":2462,"context_line":"        # Only the leftmost MPU response metrics have object_type\u003dmpu."},{"line_number":2463,"context_line":"        segment_body \u003d b\u0027segment body\u0027"},{"line_number":2464,"context_line":"        segment_etag \u003d md5("},{"line_number":2465,"context_line":"            segment_body, usedforsecurity\u003dFalse).hexdigest()"}],"source_content_type":"text/x-python","patch_set":16,"id":"b8712ef8_f88ac3da","line":2462,"updated":"2026-10-30 21:35:07.000000000","message":"s/\"object_type\u003dmpu\"/\"object_type\u003dslo_mpu\"","commit_id":"fdb271d27f118c89c995be7a6cde2079e158e6ea"}]}
