)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"7c141abe00370dd581cac4066b7a594e534c382a","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"WIP decrypter: only log missing key once per listing"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"TODO: not sure whether to work harder to truly de-dup, and/or add the"},{"line_number":10,"context_line":"path to the message."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"The decrypter claims to only list unknown key errors once per listing,"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"bfd28478_37dedb20","line":9,"range":{"start_line":9,"start_character":26,"end_line":9,"end_character":53},"updated":"2026-07-14 21:25:56.000000000","message":"I wonder if we could just drop the logging at https://github.com/openstack/swift/blob/2.38.0/swift/common/middleware/crypto/crypto_utils.py#L168 -- if we\u0027re going to catch then re-raise, why log? Why not let the code that\u0027s *actually* going to handle the exception decide to log or not?","commit_id":"ca00a11bbf2feed7692f694b0702fe542b6201e5"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"d6751a07ca0a2c9f6288e92849e7022523013345","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"a75e5823_de0b1bf8","updated":"2026-07-15 15:15:39.000000000","message":"I\u0027m happy with this direction i.e. reduce logging\n\nI\u0027ll try to get back to the patch soon to tidy up/review","commit_id":"3744cfd6763aee7b93835ef55bed278618f8c249"}],"swift/common/middleware/crypto/crypto_utils.py":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"08495691e835fb8daa70d768a32931d47a8cb267","unresolved":false,"context_lines":[{"line_number":164,"context_line":"        err \u003d None"},{"line_number":165,"context_line":"        try:"},{"line_number":166,"context_line":"            keys \u003d fetch_crypto_keys(key_id\u003dkey_id)"},{"line_number":167,"context_line":"        except UnknownSecretIdError as err:"},{"line_number":168,"context_line":"            # Caller is responsible for handling"},{"line_number":169,"context_line":"            raise"},{"line_number":170,"context_line":"        except Exception as err:  # noqa"}],"source_content_type":"text/x-python","patch_set":3,"id":"615ef765_83cdabc0","line":167,"updated":"2026-07-14 22:44:44.000000000","message":"pep8: F841 local variable \u0027err\u0027 is assigned to but never used","commit_id":"3744cfd6763aee7b93835ef55bed278618f8c249"}]}