)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":6968,"name":"Christian Schwede","email":"cschwede@nvidia.com","username":"cschwede"},"change_message_id":"46cb693227f91e8a92e43805f4b05968d4a3c966","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"0fc9c3fd_45bff2bd","updated":"2026-07-27 15:14:40.000000000","message":"LGTM, existing tests pass without modifications, nice refactoring.","commit_id":"2cf9946880ff9f827bbf6089d83a2f1b80d86767"}],"swift/common/statsd_client.py":[{"author":{"_account_id":36606,"name":"Yan Xiao","display_name":"Yan","email":"yanxiao@nvidia.com","username":"yanxiao"},"change_message_id":"f939ec794b3a8dee172bbfbae048fa2a5061ad24","unresolved":true,"context_lines":[{"line_number":699,"context_line":"    \"\"\""},{"line_number":700,"context_line":""},{"line_number":701,"context_line":""},{"line_number":702,"context_line":"class ChainLabelsMap(WeakDefaultMixin, collections.ChainMap):"},{"line_number":703,"context_line":"    \"\"\""},{"line_number":704,"context_line":"    Implements a custom ChainMap with the following behaviors:"},{"line_number":705,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"d2433d1b_3429b087","line":702,"updated":"2026-07-29 15:19:42.000000000","message":"nit: would it be better to raise exception that all self.maps are instance of WeakDefaultMixin?","commit_id":"9667885551910a8067a45b2c2a75cd88b32d4b3e"}],"test/unit/common/test_statsd_client.py":[{"author":{"_account_id":6968,"name":"Christian Schwede","email":"cschwede@nvidia.com","username":"cschwede"},"change_message_id":"46cb693227f91e8a92e43805f4b05968d4a3c966","unresolved":true,"context_lines":[{"line_number":1320,"context_line":"        child \u003d LabelsMap(a\u003d\u0027new\u0027)"},{"line_number":1321,"context_line":"        cm \u003d ChainLabelsMap(child, parent)"},{"line_number":1322,"context_line":"        self.assertEqual(\u0027new\u0027, cm[\u0027a\u0027])"},{"line_number":1323,"context_line":"        self.assertEqual(\u0027new\u0027, cm.get(\u0027a\u0027))"},{"line_number":1324,"context_line":""},{"line_number":1325,"context_line":"        parent \u003d LabelsMap(a\u003d\u0027old\u0027)"},{"line_number":1326,"context_line":"        child \u003d LabelsMap(a\u003d\u0027new\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"2dedc7a0_d7ceb5b2","line":1323,"updated":"2026-07-27 15:14:40.000000000","message":"`.get` delegates to `__getitem__` - this looks not needed? Or is there something in a followup patch that relies on this? Same for the next three blocks?","commit_id":"2cf9946880ff9f827bbf6089d83a2f1b80d86767"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"49cf0787070d790d77b2e6099f37a1061a4146c3","unresolved":true,"context_lines":[{"line_number":1320,"context_line":"        child \u003d LabelsMap(a\u003d\u0027new\u0027)"},{"line_number":1321,"context_line":"        cm \u003d ChainLabelsMap(child, parent)"},{"line_number":1322,"context_line":"        self.assertEqual(\u0027new\u0027, cm[\u0027a\u0027])"},{"line_number":1323,"context_line":"        self.assertEqual(\u0027new\u0027, cm.get(\u0027a\u0027))"},{"line_number":1324,"context_line":""},{"line_number":1325,"context_line":"        parent \u003d LabelsMap(a\u003d\u0027old\u0027)"},{"line_number":1326,"context_line":"        child \u003d LabelsMap(a\u003d\u0027new\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"10327ed7_8af5aeea","line":1323,"in_reply_to":"2dedc7a0_d7ceb5b2","updated":"2026-07-28 12:23:50.000000000","message":"agree the superclass does delegate to ``__get__item__``; I think I was just wanting to ensure that remains the case by testing","commit_id":"2cf9946880ff9f827bbf6089d83a2f1b80d86767"},{"author":{"_account_id":6968,"name":"Christian Schwede","email":"cschwede@nvidia.com","username":"cschwede"},"change_message_id":"46cb693227f91e8a92e43805f4b05968d4a3c966","unresolved":true,"context_lines":[{"line_number":1346,"context_line":"        cm \u003d ChainLabelsMap(child, parent)"},{"line_number":1347,"context_line":"        with self.assertRaises(KeyError):"},{"line_number":1348,"context_line":"            _ \u003d cm[\u0027b\u0027]"},{"line_number":1349,"context_line":"        self.assertEqual(\u0027new\u0027, cm.get(\u0027b\u0027, \u0027new\u0027))"},{"line_number":1350,"context_line":""},{"line_number":1351,"context_line":"    def test_set(self):"},{"line_number":1352,"context_line":"        child \u003d LabelsMap(a\u003dNone)"}],"source_content_type":"text/x-python","patch_set":1,"id":"c3ad7395_dc2ab90b","line":1349,"updated":"2026-07-27 15:14:40.000000000","message":"Hmm, this looks a bit suspicious to me. Maybe use some other value than `new`, which is already used by `child`? Like:\n\nself.assertEqual(\u0027default\u0027, cm.get(\u0027b\u0027, \u0027default\u0027)","commit_id":"2cf9946880ff9f827bbf6089d83a2f1b80d86767"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"49cf0787070d790d77b2e6099f37a1061a4146c3","unresolved":true,"context_lines":[{"line_number":1346,"context_line":"        cm \u003d ChainLabelsMap(child, parent)"},{"line_number":1347,"context_line":"        with self.assertRaises(KeyError):"},{"line_number":1348,"context_line":"            _ \u003d cm[\u0027b\u0027]"},{"line_number":1349,"context_line":"        self.assertEqual(\u0027new\u0027, cm.get(\u0027b\u0027, \u0027new\u0027))"},{"line_number":1350,"context_line":""},{"line_number":1351,"context_line":"    def test_set(self):"},{"line_number":1352,"context_line":"        child \u003d LabelsMap(a\u003dNone)"}],"source_content_type":"text/x-python","patch_set":1,"id":"8efc1db5_7f22cd85","line":1349,"in_reply_to":"c3ad7395_dc2ab90b","updated":"2026-07-28 12:23:50.000000000","message":"good call","commit_id":"2cf9946880ff9f827bbf6089d83a2f1b80d86767"}]}