)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":6968,"name":"Christian Schwede","email":"cschwede@nvidia.com","username":"cschwede"},"change_message_id":"aeec5801899d576448455cf597415fd3031439c0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"f71e7565_700ef6aa","updated":"2026-08-18 13:07:41.000000000","message":"LGTM","commit_id":"462222829c158ca9ca09bc17a14fe9d183c8a695"},{"author":{"_account_id":38767,"name":"Wael Halbawi","display_name":"Wael Halbawi","email":"whalbawi@nvidia.com","username":"whalbawi"},"change_message_id":"fad302ac922d21f7e05520305880540a5027d3b6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"912664c5_bd934991","updated":"2026-07-31 21:28:44.000000000","message":"LGTM!","commit_id":"462222829c158ca9ca09bc17a14fe9d183c8a695"},{"author":{"_account_id":38496,"name":"Andressa Cabistani","display_name":"Andressa","email":"acabistani@gmail.com","username":"andressadotpy","status":"I\u0027m a Software Engineer at Red Hat and I love Open Source and connect with people! Feel free to DM through IRC, I\u0027ll be delighted to chat"},"change_message_id":"56b7545b4c918a5666ff05bb64bcdf304afba567","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"a2c0a1fe_8f0ca05d","updated":"2026-08-18 14:57:16.000000000","message":"Looks good to me, I just added two small preferences of mine as comment but you don\u0027t need to address it.","commit_id":"462222829c158ca9ca09bc17a14fe9d183c8a695"},{"author":{"_account_id":38767,"name":"Wael Halbawi","display_name":"Wael Halbawi","email":"whalbawi@nvidia.com","username":"whalbawi"},"change_message_id":"60763d698f19b3b4bec9a1132195c8c91130ba9f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"99b73793_75f6d2a2","updated":"2026-07-31 21:27:27.000000000","message":"recheck","commit_id":"462222829c158ca9ca09bc17a14fe9d183c8a695"}],"test/unit/obj/test_diskfile.py":[{"author":{"_account_id":38496,"name":"Andressa Cabistani","display_name":"Andressa","email":"acabistani@gmail.com","username":"andressadotpy","status":"I\u0027m a Software Engineer at Red Hat and I love Open Source and connect with people! Feel free to DM through IRC, I\u0027ll be delighted to chat"},"change_message_id":"56b7545b4c918a5666ff05bb64bcdf304afba567","unresolved":true,"context_lines":[{"line_number":5138,"context_line":"                    raise OSError(eno, \u0027nope\u0027)"},{"line_number":5139,"context_line":"                return orig_listdir(path)"},{"line_number":5140,"context_line":""},{"line_number":5141,"context_line":"            def mock_quarantine_dir_renamer(device_path, from_dir):"},{"line_number":5142,"context_line":"                if from_dir \u003d\u003d hashdir:"},{"line_number":5143,"context_line":"                    raise OSError()"},{"line_number":5144,"context_line":"                return orig_quarantine_dir_renamer(device_path, from_dir)"}],"source_content_type":"text/x-python","patch_set":1,"id":"c0ee5f20_6336ad8a","line":5141,"updated":"2026-08-18 14:57:16.000000000","message":"Preference: add a short comment above e.g \"# fail only for hashdir to force suffix-quarantine fallback\"","commit_id":"462222829c158ca9ca09bc17a14fe9d183c8a695"},{"author":{"_account_id":38496,"name":"Andressa Cabistani","display_name":"Andressa","email":"acabistani@gmail.com","username":"andressadotpy","status":"I\u0027m a Software Engineer at Red Hat and I love Open Source and connect with people! Feel free to DM through IRC, I\u0027ll be delighted to chat"},"change_message_id":"56b7545b4c918a5666ff05bb64bcdf304afba567","unresolved":true,"context_lines":[{"line_number":5140,"context_line":""},{"line_number":5141,"context_line":"            def mock_quarantine_dir_renamer(device_path, from_dir):"},{"line_number":5142,"context_line":"                if from_dir \u003d\u003d hashdir:"},{"line_number":5143,"context_line":"                    raise OSError()"},{"line_number":5144,"context_line":"                return orig_quarantine_dir_renamer(device_path, from_dir)"},{"line_number":5145,"context_line":""},{"line_number":5146,"context_line":"            df \u003d self.df_mgr.get_diskfile("}],"source_content_type":"text/x-python","patch_set":1,"id":"6a33802e_9b7386a1","line":5143,"updated":"2026-08-18 14:57:16.000000000","message":"Preference: raise OSError() has no errno or message. The production code catches (OSError, IOError) regardless, so this is functional, but something like OSError(errno.EIO, \u0027nope\u0027) would make the simulated bad-sector failure more concrete.","commit_id":"462222829c158ca9ca09bc17a14fe9d183c8a695"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"8abba4fffa88db0148c7586d7d2d05527cc1d3ce","unresolved":true,"context_lines":[{"line_number":5145,"context_line":""},{"line_number":5146,"context_line":"            df \u003d self.df_mgr.get_diskfile("},{"line_number":5147,"context_line":"                self.existing_device, \u00270\u0027, \u0027abc\u0027, \u0027123\u0027, \u0027xyz-%s\u0027 % eno,"},{"line_number":5148,"context_line":"                policy\u003dPOLICIES.legacy)"},{"line_number":5149,"context_line":"            with mock.patch(\u0027os.listdir\u0027, side_effect\u003dmock_listdir), \\"},{"line_number":5150,"context_line":"                    mock.patch(\u0027swift.obj.diskfile.BaseDiskFileManager.\u0027"},{"line_number":5151,"context_line":"                               \u0027quarantine_dir_renamer\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"4627a7cc_c00618b3","line":5148,"range":{"start_line":5148,"start_character":32,"end_line":5148,"end_character":38},"updated":"2026-08-14 17:01:19.000000000","message":"Not `POLICIES.default`? Looks like that\u0027s what `_simple_get_diskfile` will use if not specified -- alternatively, should we specify the policy when we call `_create_test_file`?","commit_id":"462222829c158ca9ca09bc17a14fe9d183c8a695"},{"author":{"_account_id":6968,"name":"Christian Schwede","email":"cschwede@nvidia.com","username":"cschwede"},"change_message_id":"aeec5801899d576448455cf597415fd3031439c0","unresolved":true,"context_lines":[{"line_number":5145,"context_line":""},{"line_number":5146,"context_line":"            df \u003d self.df_mgr.get_diskfile("},{"line_number":5147,"context_line":"                self.existing_device, \u00270\u0027, \u0027abc\u0027, \u0027123\u0027, \u0027xyz-%s\u0027 % eno,"},{"line_number":5148,"context_line":"                policy\u003dPOLICIES.legacy)"},{"line_number":5149,"context_line":"            with mock.patch(\u0027os.listdir\u0027, side_effect\u003dmock_listdir), \\"},{"line_number":5150,"context_line":"                    mock.patch(\u0027swift.obj.diskfile.BaseDiskFileManager.\u0027"},{"line_number":5151,"context_line":"                               \u0027quarantine_dir_renamer\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"376aef03_c88036e0","line":5148,"range":{"start_line":5148,"start_character":32,"end_line":5148,"end_character":38},"in_reply_to":"4627a7cc_c00618b3","updated":"2026-08-18 13:07:41.000000000","message":"Good catch - and there are two more places where this could be fixed. No blocker to me, this is a low risk patch IMHO - let\u0027s merge it and fix these separately.\n\n1001336: tests: Use POLICIES.default in quarantine hashdir tests | https://review.opendev.org/c/openstack/swift/+/1001336","commit_id":"462222829c158ca9ca09bc17a14fe9d183c8a695"}]}