)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":39146,"name":"Nathaniel Martes","display_name":"Nate Martes","email":"nmartes@NVIDIA.com","username":"nmartes"},"change_message_id":"d0b931c6238f318a89bab304aeb370b020ce0240","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"331b5f6f_5c72441b","updated":"2026-08-06 22:30:53.000000000","message":"Squashed! https://review.opendev.org/c/openstack/swift/+/991516/62","commit_id":"78b47ea62821f82b7db6941f5768d104a27f3e5c"}],"swift/common/middleware/s3api/s3api.py":[{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"c8699ca57be645fdc633c1a773d01cedd7624796","unresolved":true,"context_lines":[{"line_number":484,"context_line":"    def handle_request(self, req):"},{"line_number":485,"context_line":"        controller \u003d req.controller(self.app, self.conf, self.logger)"},{"line_number":486,"context_line":"        req.set_acl_handler(req.controller.acl_handler(req, self.logger))"},{"line_number":487,"context_line":""},{"line_number":488,"context_line":"        if hasattr(controller, req.method):"},{"line_number":489,"context_line":"            handler \u003d getattr(controller, req.method)"},{"line_number":490,"context_line":"            if not getattr(handler, \u0027publicly_accessible\u0027, False):"}],"source_content_type":"text/x-python","patch_set":1,"id":"ab14fb56_169e3870","side":"PARENT","line":487,"updated":"2026-08-06 15:50:35.000000000","message":"oops, unintended","commit_id":"d08b5c3c3c8b5d837bcf07eb01fe5eecdfb13058"}],"swift/common/middleware/s3api/s3request.py":[{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"c8699ca57be645fdc633c1a773d01cedd7624796","unresolved":true,"context_lines":[{"line_number":266,"context_line":"        self._matching_checksum \u003d None"},{"line_number":267,"context_line":""},{"line_number":268,"context_line":"    @property"},{"line_number":269,"context_line":"    def matching_checksum(self):"},{"line_number":270,"context_line":"        return self._matching_checksum"},{"line_number":271,"context_line":""},{"line_number":272,"context_line":"    def chunk_update(self, chunk, eof, *args, **kwargs):"}],"source_content_type":"text/x-python","patch_set":1,"id":"8ea931f4_6ddcb2bb","line":269,"updated":"2026-08-06 15:50:35.000000000","message":"docstring would be good - this is the calculated value, if it matches","commit_id":"78b47ea62821f82b7db6941f5768d104a27f3e5c"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"c8699ca57be645fdc633c1a773d01cedd7624796","unresolved":true,"context_lines":[{"line_number":1666,"context_line":"        \"\"\""},{"line_number":1667,"context_line":"        return CHECKSUM_TYPE_FULL_OBJECT"},{"line_number":1668,"context_line":""},{"line_number":1669,"context_line":"    def _checksum_sysmeta_headers(self, checksumming_input):"},{"line_number":1670,"context_line":"        return {"},{"line_number":1671,"context_line":"            sysmeta_header(\u0027object\u0027, \u0027checksum-header\u0027):"},{"line_number":1672,"context_line":"                checksumming_input.checksum_key,"}],"source_content_type":"text/x-python","patch_set":1,"id":"11b24122_f736e283","line":1669,"range":{"start_line":1669,"start_character":40,"end_line":1669,"end_character":58},"updated":"2026-08-06 15:50:35.000000000","message":"note how we can just keep on passing checksumming_input around - simpler and less for a human to track through the call chain","commit_id":"78b47ea62821f82b7db6941f5768d104a27f3e5c"},{"author":{"_account_id":39146,"name":"Nathaniel Martes","display_name":"Nate Martes","email":"nmartes@NVIDIA.com","username":"nmartes"},"change_message_id":"672467165cb1a88d7eb071aa934ef1087c73dccf","unresolved":false,"context_lines":[{"line_number":1666,"context_line":"        \"\"\""},{"line_number":1667,"context_line":"        return CHECKSUM_TYPE_FULL_OBJECT"},{"line_number":1668,"context_line":""},{"line_number":1669,"context_line":"    def _checksum_sysmeta_headers(self, checksumming_input):"},{"line_number":1670,"context_line":"        return {"},{"line_number":1671,"context_line":"            sysmeta_header(\u0027object\u0027, \u0027checksum-header\u0027):"},{"line_number":1672,"context_line":"                checksumming_input.checksum_key,"}],"source_content_type":"text/x-python","patch_set":1,"id":"a45fa12a_10105023","line":1669,"range":{"start_line":1669,"start_character":40,"end_line":1669,"end_character":58},"in_reply_to":"11b24122_f736e283","updated":"2026-08-06 22:04:46.000000000","message":"This is much cleaner I agree!","commit_id":"78b47ea62821f82b7db6941f5768d104a27f3e5c"}]}