)]}'
{"test-requirements.txt":[{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"b036e2a4737a25366c0e20d280df141f87a782fb","unresolved":true,"context_lines":[{"line_number":13,"context_line":"nodeenv\u003e\u003d0.9.4 # BSD"},{"line_number":14,"context_line":"# This also needs xvfb library installed on your OS"},{"line_number":15,"context_line":"xvfbwrapper\u003e\u003d0.1.3 #license: MIT"},{"line_number":16,"context_line":"# Horizon integration tests requirements"},{"line_number":17,"context_line":"testtools\u003e\u003d2.2.0 # MIT"},{"line_number":18,"context_line":"selenium\u003e\u003d2.50.1 # Apache-2.0"}],"source_content_type":"text/plain","patch_set":23,"id":"4dcdd040_e74ab8d7","line":18,"range":{"start_line":16,"start_character":0,"end_line":18,"end_character":29},"updated":"2021-08-19 17:21:01.000000000","message":"Is it alphabetical order as commented above? or remote the comment itself if it\u0027s nonsence.","commit_id":"45d0eb1d8baad247425f193ad481cff6cb93f2fc"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"0b0f5a30e5abbf47123882bbe144e1a27f014aa5","unresolved":false,"context_lines":[{"line_number":13,"context_line":"nodeenv\u003e\u003d0.9.4 # BSD"},{"line_number":14,"context_line":"# This also needs xvfb library installed on your OS"},{"line_number":15,"context_line":"xvfbwrapper\u003e\u003d0.1.3 #license: MIT"},{"line_number":16,"context_line":"# Horizon integration tests requirements"},{"line_number":17,"context_line":"testtools\u003e\u003d2.2.0 # MIT"},{"line_number":18,"context_line":"selenium\u003e\u003d2.50.1 # Apache-2.0"}],"source_content_type":"text/plain","patch_set":23,"id":"ecb3b407_ccc6a4b1","line":18,"range":{"start_line":16,"start_character":0,"end_line":18,"end_character":29},"in_reply_to":"4dcdd040_e74ab8d7","updated":"2021-08-20 08:56:43.000000000","message":"Done","commit_id":"45d0eb1d8baad247425f193ad481cff6cb93f2fc"}],"tools/find_executables.sh":[{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"b036e2a4737a25366c0e20d280df141f87a782fb","unresolved":true,"context_lines":[{"line_number":1,"context_line":"OUTPUT\u003d`find . \\( -name .tox -o -name .git \\) -prune -o -type f -perm /a\u003dx -print \\"},{"line_number":2,"context_line":"        | grep -v -F -f ./tools/executable_files.txt`"},{"line_number":3,"context_line":"if [ -n \"$OUTPUT\" ]; then"},{"line_number":4,"context_line":"    echo \"Unexpected executable files are found:\""}],"source_content_type":"text/x-sh","patch_set":23,"id":"7389e802_779efef2","line":1,"updated":"2021-08-19 17:21:01.000000000","message":"- Could you add a comment about what is done by this script shortly for helping maintainers before this line?\n\n- It\u0027s better to add shebang at the top of this file.","commit_id":"45d0eb1d8baad247425f193ad481cff6cb93f2fc"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"0b0f5a30e5abbf47123882bbe144e1a27f014aa5","unresolved":false,"context_lines":[{"line_number":1,"context_line":"OUTPUT\u003d`find . \\( -name .tox -o -name .git \\) -prune -o -type f -perm /a\u003dx -print \\"},{"line_number":2,"context_line":"        | grep -v -F -f ./tools/executable_files.txt`"},{"line_number":3,"context_line":"if [ -n \"$OUTPUT\" ]; then"},{"line_number":4,"context_line":"    echo \"Unexpected executable files are found:\""}],"source_content_type":"text/x-sh","patch_set":23,"id":"615afa51_8fb88d0c","line":1,"in_reply_to":"7389e802_779efef2","updated":"2021-08-20 08:56:43.000000000","message":"Done","commit_id":"45d0eb1d8baad247425f193ad481cff6cb93f2fc"}],"tox.ini":[{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"b036e2a4737a25366c0e20d280df141f87a782fb","unresolved":true,"context_lines":[{"line_number":31,"context_line":"basepython \u003d python3"},{"line_number":32,"context_line":"commands \u003d {envpython} {toxinidir}/manage.py test tacker_horizon --settings\u003dtacker_horizon.test.settings --tag integration {posargs}"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"[testenv:py36]"},{"line_number":35,"context_line":"basepython \u003d python3.6"},{"line_number":36,"context_line":"commands \u003d"},{"line_number":37,"context_line":"  {envpython} {toxinidir}/manage.py test tacker_horizon --settings\u003dtacker_horizon.test.settings --exclude-tag integration {posargs}"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"[testenv:pep8]"},{"line_number":40,"context_line":"basepython \u003d python3"},{"line_number":41,"context_line":"commands \u003d flake8"}],"source_content_type":"text/x-properties","patch_set":23,"id":"7c87dbc8_6d04c8de","line":38,"range":{"start_line":34,"start_character":0,"end_line":38,"end_character":0},"updated":"2021-08-19 17:21:01.000000000","message":"What do you think to add other than py36 as tacker?","commit_id":"45d0eb1d8baad247425f193ad481cff6cb93f2fc"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"f4783ed9162b919006f3b53729f41653dc99b670","unresolved":true,"context_lines":[{"line_number":31,"context_line":"basepython \u003d python3"},{"line_number":32,"context_line":"commands \u003d {envpython} {toxinidir}/manage.py test tacker_horizon --settings\u003dtacker_horizon.test.settings --tag integration {posargs}"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"[testenv:py36]"},{"line_number":35,"context_line":"basepython \u003d python3.6"},{"line_number":36,"context_line":"commands \u003d"},{"line_number":37,"context_line":"  {envpython} {toxinidir}/manage.py test tacker_horizon --settings\u003dtacker_horizon.test.settings --exclude-tag integration {posargs}"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"[testenv:pep8]"},{"line_number":40,"context_line":"basepython \u003d python3"},{"line_number":41,"context_line":"commands \u003d flake8"}],"source_content_type":"text/x-properties","patch_set":23,"id":"23967fea_1183e277","line":38,"range":{"start_line":34,"start_character":0,"end_line":38,"end_character":0},"in_reply_to":"20b3a161_fa993774","updated":"2021-08-23 02:34:12.000000000","message":"It\u0027s recommended to test with py36, 38 and 39 currently. So, we\u0027d better to add `testenv:py39` below, and `py36` and `py39` to `envlist` at L.2.","commit_id":"45d0eb1d8baad247425f193ad481cff6cb93f2fc"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"143907a7760760106e41f9c8f5ab65e8f4ab9caf","unresolved":false,"context_lines":[{"line_number":31,"context_line":"basepython \u003d python3"},{"line_number":32,"context_line":"commands \u003d {envpython} {toxinidir}/manage.py test tacker_horizon --settings\u003dtacker_horizon.test.settings --tag integration {posargs}"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"[testenv:py36]"},{"line_number":35,"context_line":"basepython \u003d python3.6"},{"line_number":36,"context_line":"commands \u003d"},{"line_number":37,"context_line":"  {envpython} {toxinidir}/manage.py test tacker_horizon --settings\u003dtacker_horizon.test.settings --exclude-tag integration {posargs}"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"[testenv:pep8]"},{"line_number":40,"context_line":"basepython \u003d python3"},{"line_number":41,"context_line":"commands \u003d flake8"}],"source_content_type":"text/x-properties","patch_set":23,"id":"ed62c98b_8e38c02b","line":38,"range":{"start_line":34,"start_character":0,"end_line":38,"end_character":0},"in_reply_to":"23967fea_1183e277","updated":"2021-08-23 05:35:51.000000000","message":"Thanks for clarification. Done!","commit_id":"45d0eb1d8baad247425f193ad481cff6cb93f2fc"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"0b0f5a30e5abbf47123882bbe144e1a27f014aa5","unresolved":true,"context_lines":[{"line_number":31,"context_line":"basepython \u003d python3"},{"line_number":32,"context_line":"commands \u003d {envpython} {toxinidir}/manage.py test tacker_horizon --settings\u003dtacker_horizon.test.settings --tag integration {posargs}"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"[testenv:py36]"},{"line_number":35,"context_line":"basepython \u003d python3.6"},{"line_number":36,"context_line":"commands \u003d"},{"line_number":37,"context_line":"  {envpython} {toxinidir}/manage.py test tacker_horizon --settings\u003dtacker_horizon.test.settings --exclude-tag integration {posargs}"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"[testenv:pep8]"},{"line_number":40,"context_line":"basepython \u003d python3"},{"line_number":41,"context_line":"commands \u003d flake8"}],"source_content_type":"text/x-properties","patch_set":23,"id":"20b3a161_fa993774","line":38,"range":{"start_line":34,"start_character":0,"end_line":38,"end_character":0},"in_reply_to":"7c87dbc8_6d04c8de","updated":"2021-08-20 08:56:43.000000000","message":"Could you please elaborate the query.","commit_id":"45d0eb1d8baad247425f193ad481cff6cb93f2fc"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"8f960eb76d95ee4630b12ee132c174e5812d82a3","unresolved":true,"context_lines":[{"line_number":1,"context_line":"[tox]"},{"line_number":2,"context_line":"envlist \u003d py38,pep8,docs"},{"line_number":3,"context_line":"minversion \u003d 3.18.0"},{"line_number":4,"context_line":"skipsdist \u003d True"},{"line_number":5,"context_line":"ignore_basepython_conflict \u003d True"}],"source_content_type":"text/x-properties","patch_set":25,"id":"7b85cde7_4c780dcb","line":2,"updated":"2021-08-23 06:58:54.000000000","message":"Plese change this line as below to run tox with py36 and py39 in addition to py38.\n\n```\nenvlist \u003d py36,py38,py39,pep8,docs\n```","commit_id":"401ef874fa9771b746d120526018bac5aefe46fe"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"66308d917d84e9f5eef62559871a3b6094fe4787","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[tox]"},{"line_number":2,"context_line":"envlist \u003d py38,pep8,docs"},{"line_number":3,"context_line":"minversion \u003d 3.18.0"},{"line_number":4,"context_line":"skipsdist \u003d True"},{"line_number":5,"context_line":"ignore_basepython_conflict \u003d True"}],"source_content_type":"text/x-properties","patch_set":25,"id":"5cb7dc4d_095f54b9","line":2,"in_reply_to":"7b85cde7_4c780dcb","updated":"2021-08-23 08:52:33.000000000","message":"Done.\nSorry I overlooked to the comment, please find the same in PatchSet 26.","commit_id":"401ef874fa9771b746d120526018bac5aefe46fe"}]}