)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"b683bad5220d5a7b56ef9979226041be08831db2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"eeb59c3d_59fb90b0","updated":"2024-03-11 18:02:35.000000000","message":"Please find my comments. Thanks.","commit_id":"b3813f31d09287e83299d9bd8bb43e958e656800"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"99e93c1df345c7fa1d1d4ebfa5b1f9377f5c92c8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"45495efe_553a2cd3","updated":"2024-03-11 13:15:19.000000000","message":"Thanks for your patch, LGTM.","commit_id":"b3813f31d09287e83299d9bd8bb43e958e656800"},{"author":{"_account_id":36798,"name":"Haejin choe","display_name":"Haejin Choe","email":"fj7021hk@fujitsu.com","username":"fjt-choe"},"change_message_id":"5223d9bf6656918f1bf2d245f0a391d87264b3a5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"4d793db2_98103cbb","updated":"2024-03-13 14:50:07.000000000","message":"thanks for your review.","commit_id":"b3813f31d09287e83299d9bd8bb43e958e656800"}],"tacker_horizon/openstack_dashboard/dashboards/nfv/lccnsubscription/panel.py":[{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"b683bad5220d5a7b56ef9979226041be08831db2","unresolved":true,"context_lines":[{"line_number":21,"context_line":"from tacker_horizon.openstack_dashboard.dashboards.nfv import dashboard"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"class Lccnsubscription(horizon.Panel):"},{"line_number":25,"context_line":"    name \u003d _(\"LCCN Subscription\")"},{"line_number":26,"context_line":"    slug \u003d \"lccnsubscription\""},{"line_number":27,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"97123df2_16f54df8","line":24,"range":{"start_line":24,"start_character":10,"end_line":24,"end_character":11},"updated":"2024-03-11 18:02:35.000000000","message":"Capital \"S\" is preferable for considering the name convention, or any reason to do so.","commit_id":"b3813f31d09287e83299d9bd8bb43e958e656800"},{"author":{"_account_id":36798,"name":"Haejin choe","display_name":"Haejin Choe","email":"fj7021hk@fujitsu.com","username":"fjt-choe"},"change_message_id":"5223d9bf6656918f1bf2d245f0a391d87264b3a5","unresolved":true,"context_lines":[{"line_number":21,"context_line":"from tacker_horizon.openstack_dashboard.dashboards.nfv import dashboard"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"class Lccnsubscription(horizon.Panel):"},{"line_number":25,"context_line":"    name \u003d _(\"LCCN Subscription\")"},{"line_number":26,"context_line":"    slug \u003d \"lccnsubscription\""},{"line_number":27,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"85ca5f64_25691b7e","line":24,"range":{"start_line":24,"start_character":10,"end_line":24,"end_character":11},"in_reply_to":"97123df2_16f54df8","updated":"2024-03-13 14:50:07.000000000","message":"I fixed in PatchSet 6 it as you pointed out.","commit_id":"b3813f31d09287e83299d9bd8bb43e958e656800"}],"tacker_horizon/openstack_dashboard/dashboards/nfv/vnffmalarm/forms.py":[{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"b683bad5220d5a7b56ef9979226041be08831db2","unresolved":true,"context_lines":[{"line_number":22,"context_line":"from tacker_horizon.openstack_dashboard import api"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"class UpdateVNFFMAlarm(forms.SelfHandlingForm):"},{"line_number":26,"context_line":"    ack_state \u003d forms.ChoiceField("},{"line_number":27,"context_line":"        label\u003d_(\u0027ACK State\u0027),"},{"line_number":28,"context_line":"        choices\u003d[(\u0027ACKNOWLEDGED\u0027, _(\u0027ACKNOWLEDGED\u0027)),"}],"source_content_type":"text/x-python","patch_set":5,"id":"e1ec462b_50032970","line":25,"range":{"start_line":25,"start_character":12,"end_line":25,"end_character":22},"updated":"2024-03-11 18:02:35.000000000","message":"Why don\u0027t you define the same name for the term \"vnffmalarm\" because there are different names, such as VNFFMAlarm or Vnffmalarm, around under the directory and it\u0027s tricky for maintenance. Or, any reason to do so?","commit_id":"b3813f31d09287e83299d9bd8bb43e958e656800"},{"author":{"_account_id":36798,"name":"Haejin choe","display_name":"Haejin Choe","email":"fj7021hk@fujitsu.com","username":"fjt-choe"},"change_message_id":"5223d9bf6656918f1bf2d245f0a391d87264b3a5","unresolved":true,"context_lines":[{"line_number":22,"context_line":"from tacker_horizon.openstack_dashboard import api"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"class UpdateVNFFMAlarm(forms.SelfHandlingForm):"},{"line_number":26,"context_line":"    ack_state \u003d forms.ChoiceField("},{"line_number":27,"context_line":"        label\u003d_(\u0027ACK State\u0027),"},{"line_number":28,"context_line":"        choices\u003d[(\u0027ACKNOWLEDGED\u0027, _(\u0027ACKNOWLEDGED\u0027)),"}],"source_content_type":"text/x-python","patch_set":5,"id":"4e3d802b_be3db623","line":25,"range":{"start_line":25,"start_character":12,"end_line":25,"end_character":22},"in_reply_to":"e1ec462b_50032970","updated":"2024-03-13 14:50:07.000000000","message":"I revised class name in PatchSet 6.\nAlso the other Class names have been modified as well.","commit_id":"b3813f31d09287e83299d9bd8bb43e958e656800"}],"tacker_horizon/openstack_dashboard/dashboards/nfv/vnffmalarm/panel.py":[{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"b683bad5220d5a7b56ef9979226041be08831db2","unresolved":true,"context_lines":[{"line_number":21,"context_line":"from tacker_horizon.openstack_dashboard.dashboards.nfv import dashboard"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"class VnffmAlarm(horizon.Panel):"},{"line_number":25,"context_line":"    name \u003d _(\"Alarm\")"},{"line_number":26,"context_line":"    slug \u003d \"vnffmalarm\""},{"line_number":27,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"e44f67f3_93ba6f1a","line":24,"range":{"start_line":24,"start_character":6,"end_line":24,"end_character":16},"updated":"2024-03-11 18:02:35.000000000","message":"It\u0027s the same as in the comment in tacker_horizon/openstack_dashboard/dashboards/nfv/vnffmalarm/forms.py:25.","commit_id":"b3813f31d09287e83299d9bd8bb43e958e656800"},{"author":{"_account_id":36798,"name":"Haejin choe","display_name":"Haejin Choe","email":"fj7021hk@fujitsu.com","username":"fjt-choe"},"change_message_id":"5223d9bf6656918f1bf2d245f0a391d87264b3a5","unresolved":true,"context_lines":[{"line_number":21,"context_line":"from tacker_horizon.openstack_dashboard.dashboards.nfv import dashboard"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"class VnffmAlarm(horizon.Panel):"},{"line_number":25,"context_line":"    name \u003d _(\"Alarm\")"},{"line_number":26,"context_line":"    slug \u003d \"vnffmalarm\""},{"line_number":27,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"89356135_78ea9143","line":24,"range":{"start_line":24,"start_character":6,"end_line":24,"end_character":16},"in_reply_to":"e44f67f3_93ba6f1a","updated":"2024-03-13 14:50:07.000000000","message":"I revised class name in PatchSet 6.\nAlso the other Class names have been modified as well.","commit_id":"b3813f31d09287e83299d9bd8bb43e958e656800"}],"tacker_horizon/openstack_dashboard/dashboards/nfv/vnffmalarm/tables.py":[{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"b683bad5220d5a7b56ef9979226041be08831db2","unresolved":true,"context_lines":[{"line_number":19,"context_line":"from horizon import tables"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"class MyFilterAction(tables.FilterAction):"},{"line_number":23,"context_line":"    name \u003d \"myfilter\""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"1ed7dac4_5604d465","line":22,"range":{"start_line":22,"start_character":6,"end_line":22,"end_character":20},"updated":"2024-03-11 18:02:35.000000000","message":"I\u0027m not sure the name of the class is appropriate. What do you mean by myfilter actually?","commit_id":"b3813f31d09287e83299d9bd8bb43e958e656800"},{"author":{"_account_id":36798,"name":"Haejin choe","display_name":"Haejin Choe","email":"fj7021hk@fujitsu.com","username":"fjt-choe"},"change_message_id":"5223d9bf6656918f1bf2d245f0a391d87264b3a5","unresolved":true,"context_lines":[{"line_number":19,"context_line":"from horizon import tables"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"class MyFilterAction(tables.FilterAction):"},{"line_number":23,"context_line":"    name \u003d \"myfilter\""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"4fe8b5c1_b7f4679f","line":22,"range":{"start_line":22,"start_character":6,"end_line":22,"end_character":20},"in_reply_to":"1ed7dac4_5604d465","updated":"2024-03-13 14:50:07.000000000","message":"The `MyFilterAction` class was implemented in the legacy tables of other tacker-horizon and I used it as a reference..\nHowever, since it didn\u0027t need to define `MyFilterAction`, so I deleted it and change to set `tables.FilterAction` directly to table_actions in PatchSet 6.","commit_id":"b3813f31d09287e83299d9bd8bb43e958e656800"}],"tacker_horizon/openstack_dashboard/dashboards/nfv/vnfpmthreshold/templates/vnfpmthreshold/pmthreshold_detail.html":[{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"b683bad5220d5a7b56ef9979226041be08831db2","unresolved":true,"context_lines":[{"line_number":5,"context_line":"    \u003cdt\u003e{% trans \"ID\" %}\u003c/dt\u003e"},{"line_number":6,"context_line":"    \u003cdd\u003e{{ pmthreshold.id }}\u003c/dd\u003e"},{"line_number":7,"context_line":"    \u003cdt\u003e{% trans \"Links\" %}\u003c/dt\u003e"},{"line_number":8,"context_line":"    \u003cdd\u003e{{ pmthreshold.links }}\u003c/dd\u003e "},{"line_number":9,"context_line":"    \u003cdt\u003e{% trans \"Callback Uri\" %}\u003c/dt\u003e"},{"line_number":10,"context_line":"    \u003cdd\u003e{{ pmthreshold.callback_uri }}\u003c/dd\u003e"},{"line_number":11,"context_line":"    \u003cdt\u003e{% trans \"Criteria\" %}\u003c/dt\u003e"}],"source_content_type":"text/html","patch_set":5,"id":"5b803270_bd9013ee","line":8,"range":{"start_line":8,"start_character":36,"end_line":8,"end_character":37},"updated":"2024-03-11 18:02:35.000000000","message":"Useless tailing whitespaces here and after.","commit_id":"b3813f31d09287e83299d9bd8bb43e958e656800"},{"author":{"_account_id":36798,"name":"Haejin choe","display_name":"Haejin Choe","email":"fj7021hk@fujitsu.com","username":"fjt-choe"},"change_message_id":"5223d9bf6656918f1bf2d245f0a391d87264b3a5","unresolved":true,"context_lines":[{"line_number":5,"context_line":"    \u003cdt\u003e{% trans \"ID\" %}\u003c/dt\u003e"},{"line_number":6,"context_line":"    \u003cdd\u003e{{ pmthreshold.id }}\u003c/dd\u003e"},{"line_number":7,"context_line":"    \u003cdt\u003e{% trans \"Links\" %}\u003c/dt\u003e"},{"line_number":8,"context_line":"    \u003cdd\u003e{{ pmthreshold.links }}\u003c/dd\u003e "},{"line_number":9,"context_line":"    \u003cdt\u003e{% trans \"Callback Uri\" %}\u003c/dt\u003e"},{"line_number":10,"context_line":"    \u003cdd\u003e{{ pmthreshold.callback_uri }}\u003c/dd\u003e"},{"line_number":11,"context_line":"    \u003cdt\u003e{% trans \"Criteria\" %}\u003c/dt\u003e"}],"source_content_type":"text/html","patch_set":5,"id":"f900c6b9_c0f01392","line":8,"range":{"start_line":8,"start_character":36,"end_line":8,"end_character":37},"in_reply_to":"5b803270_bd9013ee","updated":"2024-03-13 14:50:07.000000000","message":"I have fixed it, and same fixing is done in other html file in PatchSet 6.","commit_id":"b3813f31d09287e83299d9bd8bb43e958e656800"}]}
