)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"85fd0aec3d126a24b7c60739f6d0583242c1a74d","unresolved":true,"context_lines":[{"line_number":17,"context_line":"Management interface, MgmtDriver helps those process as"},{"line_number":18,"context_line":"preamble/postamble of VNF LCM interface."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Change-Id: Ieaef65650b7026aca1672af15e8550f04a2a8623"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"f989bda9_8b8348f1","line":20,"range":{"start_line":20,"start_character":0,"end_line":20,"end_character":11},"updated":"2021-06-22 04:54:41.000000000","message":"Could you please add blueprint information in commit message.","commit_id":"69ade82ff2e6688b072a9d82648c700fc23fd23d"}],"specs/xena/helmchart-k8s-vim.rst":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"030c85374106cf5bd732c4db3af7ac7161146740","unresolved":true,"context_lines":[{"line_number":540,"context_line":""},{"line_number":541,"context_line":"      .. code-block::"},{"line_number":542,"context_line":""},{"line_number":543,"context_line":"         scp /\u003chelmchartfile_path\u003e \u003cmasternode username\u003e@\u003cmasternode_ip\u003e:/usr/home/\u003cvnf_instance_id\u003e"},{"line_number":544,"context_line":""},{"line_number":545,"context_line":"      .. note::"},{"line_number":546,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"9deba6ea_b3a82067","line":543,"range":{"start_line":543,"start_character":73,"end_line":543,"end_character":83},"updated":"2021-06-11 13:28:12.000000000","message":"The folder named “/usr/home” is not a good place to store helm charts.\nI think for example \"/opt/tacker/helm\" is better.","commit_id":"e18332507485504912e87c8b1c5b87a39e470ebe"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"9df0352377179f117de7b34848e4156f26133e64","unresolved":true,"context_lines":[{"line_number":540,"context_line":""},{"line_number":541,"context_line":"      .. code-block::"},{"line_number":542,"context_line":""},{"line_number":543,"context_line":"         scp /\u003chelmchartfile_path\u003e \u003cmasternode username\u003e@\u003cmasternode_ip\u003e:/usr/home/\u003cvnf_instance_id\u003e"},{"line_number":544,"context_line":""},{"line_number":545,"context_line":"      .. note::"},{"line_number":546,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"8faa245e_305bc07c","line":543,"range":{"start_line":543,"start_character":73,"end_line":543,"end_character":83},"in_reply_to":"9deba6ea_b3a82067","updated":"2021-06-22 02:26:23.000000000","message":"I\u0027ve confirmed with Patchset 2.","commit_id":"e18332507485504912e87c8b1c5b87a39e470ebe"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"030c85374106cf5bd732c4db3af7ac7161146740","unresolved":true,"context_lines":[{"line_number":556,"context_line":""},{"line_number":557,"context_line":"      .. code-block::"},{"line_number":558,"context_line":""},{"line_number":559,"context_line":"         helm package /usr/home/\u003cvnf_instance_id\u003e"},{"line_number":560,"context_line":""},{"line_number":561,"context_line":"      Register Helm package to repository."},{"line_number":562,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"6bf081ba_45146b7e","line":559,"range":{"start_line":559,"start_character":22,"end_line":559,"end_character":32},"updated":"2021-06-11 13:28:12.000000000","message":"ditto","commit_id":"e18332507485504912e87c8b1c5b87a39e470ebe"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"9df0352377179f117de7b34848e4156f26133e64","unresolved":true,"context_lines":[{"line_number":556,"context_line":""},{"line_number":557,"context_line":"      .. code-block::"},{"line_number":558,"context_line":""},{"line_number":559,"context_line":"         helm package /usr/home/\u003cvnf_instance_id\u003e"},{"line_number":560,"context_line":""},{"line_number":561,"context_line":"      Register Helm package to repository."},{"line_number":562,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"71413b12_0699b094","line":559,"range":{"start_line":559,"start_character":22,"end_line":559,"end_character":32},"in_reply_to":"6bf081ba_45146b7e","updated":"2021-06-22 02:26:23.000000000","message":"I\u0027ve confirmed with Patchset 2.","commit_id":"e18332507485504912e87c8b1c5b87a39e470ebe"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"030c85374106cf5bd732c4db3af7ac7161146740","unresolved":true,"context_lines":[{"line_number":569,"context_line":""},{"line_number":570,"context_line":"         + \u003cfile_name\u003e: This parameter is generated to be"},{"line_number":571,"context_line":"           \u003cvnf_instance_id\u003e + \u003cversion of package\u003e."},{"line_number":572,"context_line":"         + \u003chelmrepositoryname\u003e: Directory name specifid as the name of"},{"line_number":573,"context_line":"           repository. This may be a static value provided by Tacker."},{"line_number":574,"context_line":""},{"line_number":575,"context_line":"   #. Get target Helm chart from repository."},{"line_number":576,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"d54b12df_f9779b03","line":573,"range":{"start_line":572,"start_character":11,"end_line":573,"end_character":69},"updated":"2021-06-11 13:28:12.000000000","message":"Is it correct that `helmrepositoryname` is static value?\nI think helmrepositoryname should be one of input parameter and is used in `helm repo add`.","commit_id":"e18332507485504912e87c8b1c5b87a39e470ebe"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"9df0352377179f117de7b34848e4156f26133e64","unresolved":true,"context_lines":[{"line_number":569,"context_line":""},{"line_number":570,"context_line":"         + \u003cfile_name\u003e: This parameter is generated to be"},{"line_number":571,"context_line":"           \u003cvnf_instance_id\u003e + \u003cversion of package\u003e."},{"line_number":572,"context_line":"         + \u003chelmrepositoryname\u003e: Directory name specifid as the name of"},{"line_number":573,"context_line":"           repository. This may be a static value provided by Tacker."},{"line_number":574,"context_line":""},{"line_number":575,"context_line":"   #. Get target Helm chart from repository."},{"line_number":576,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"b5115b87_da80e610","line":573,"range":{"start_line":572,"start_character":11,"end_line":573,"end_character":69},"in_reply_to":"d54b12df_f9779b03","updated":"2021-06-22 02:26:23.000000000","message":"I\u0027ve confirmed with Patchset 2.","commit_id":"e18332507485504912e87c8b1c5b87a39e470ebe"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"030c85374106cf5bd732c4db3af7ac7161146740","unresolved":true,"context_lines":[{"line_number":576,"context_line":""},{"line_number":577,"context_line":"      .. code-block::"},{"line_number":578,"context_line":""},{"line_number":579,"context_line":"         helm repo add \u003chelmrepositoryname\u003e/\u003chelmchartname\u003e \u003crepositoryURL\u003e"},{"line_number":580,"context_line":""},{"line_number":581,"context_line":"      .. note::"},{"line_number":582,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"09d4bd48_01f1702e","line":579,"range":{"start_line":579,"start_character":23,"end_line":579,"end_character":59},"updated":"2021-06-11 13:28:12.000000000","message":"I think `helm repo add` command\u0027s first parameter must be only `\u003chelmrepositoryname\u003e`, `/\u003chelmchartname\u003e` is not necessary.","commit_id":"e18332507485504912e87c8b1c5b87a39e470ebe"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"9df0352377179f117de7b34848e4156f26133e64","unresolved":true,"context_lines":[{"line_number":576,"context_line":""},{"line_number":577,"context_line":"      .. code-block::"},{"line_number":578,"context_line":""},{"line_number":579,"context_line":"         helm repo add \u003chelmrepositoryname\u003e/\u003chelmchartname\u003e \u003crepositoryURL\u003e"},{"line_number":580,"context_line":""},{"line_number":581,"context_line":"      .. note::"},{"line_number":582,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"5747725e_20fd34a7","line":579,"range":{"start_line":579,"start_character":23,"end_line":579,"end_character":59},"in_reply_to":"09d4bd48_01f1702e","updated":"2021-06-22 02:26:23.000000000","message":"I\u0027ve confirmed with Patchset 2.","commit_id":"e18332507485504912e87c8b1c5b87a39e470ebe"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"6046ace0476284fe3bb0c1ffc5013449cdd33f15","unresolved":true,"context_lines":[{"line_number":662,"context_line":"|\u003e helmchartname             | String    | Helm chart name.                                          |"},{"line_number":663,"context_line":"|                            |           | Shall be present if \"exthelmchart\" is \"true\".             |"},{"line_number":664,"context_line":"+----------------------------+-----------+-----------------------------------------------------------+"},{"line_number":665,"context_line":"|\u003e exthelmchart_url          | String    | URL of external Helm repository.                          |"},{"line_number":666,"context_line":"|                            |           | Shall be present if \"exthelmchart\" is \"true\".             |"},{"line_number":667,"context_line":"+----------------------------+-----------+-----------------------------------------------------------+"},{"line_number":668,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"322b1b4e_fcf2e833","line":665,"range":{"start_line":665,"start_character":3,"end_line":665,"end_character":19},"updated":"2021-06-16 04:16:42.000000000","message":"This parameter is helm repository URL, so I think this parameter name should be `exthelmrepo_url` or `exthelmrepository_url`.\nCould you correct the part where this parameter is used in this specification.","commit_id":"e18332507485504912e87c8b1c5b87a39e470ebe"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"9df0352377179f117de7b34848e4156f26133e64","unresolved":true,"context_lines":[{"line_number":662,"context_line":"|\u003e helmchartname             | String    | Helm chart name.                                          |"},{"line_number":663,"context_line":"|                            |           | Shall be present if \"exthelmchart\" is \"true\".             |"},{"line_number":664,"context_line":"+----------------------------+-----------+-----------------------------------------------------------+"},{"line_number":665,"context_line":"|\u003e exthelmchart_url          | String    | URL of external Helm repository.                          |"},{"line_number":666,"context_line":"|                            |           | Shall be present if \"exthelmchart\" is \"true\".             |"},{"line_number":667,"context_line":"+----------------------------+-----------+-----------------------------------------------------------+"},{"line_number":668,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"74389d48_1559c782","line":665,"range":{"start_line":665,"start_character":3,"end_line":665,"end_character":19},"in_reply_to":"322b1b4e_fcf2e833","updated":"2021-06-22 02:26:23.000000000","message":"I\u0027ve confirmed with Patchset 2.","commit_id":"e18332507485504912e87c8b1c5b87a39e470ebe"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"6046ace0476284fe3bb0c1ffc5013449cdd33f15","unresolved":true,"context_lines":[{"line_number":681,"context_line":"            \"key1\u003dvalue1\","},{"line_number":682,"context_line":"            \"key2\u003dvalue2\""},{"line_number":683,"context_line":"            ],"},{"line_number":684,"context_line":"          \"exthelmchart_url\": \"http:///home/hylom/helm_test/mychart/example-0.1.0.tgz\""},{"line_number":685,"context_line":"        }"},{"line_number":686,"context_line":"      ]"},{"line_number":687,"context_line":"    }"}],"source_content_type":"text/x-rst","patch_set":1,"id":"c9200fc3_43319c99","line":684,"range":{"start_line":684,"start_character":10,"end_line":684,"end_character":86},"updated":"2021-06-16 04:16:42.000000000","message":"This parameter should be change　according to above comment, and example value must be helm repository URL not include file name.","commit_id":"e18332507485504912e87c8b1c5b87a39e470ebe"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"9df0352377179f117de7b34848e4156f26133e64","unresolved":true,"context_lines":[{"line_number":681,"context_line":"            \"key1\u003dvalue1\","},{"line_number":682,"context_line":"            \"key2\u003dvalue2\""},{"line_number":683,"context_line":"            ],"},{"line_number":684,"context_line":"          \"exthelmchart_url\": \"http:///home/hylom/helm_test/mychart/example-0.1.0.tgz\""},{"line_number":685,"context_line":"        }"},{"line_number":686,"context_line":"      ]"},{"line_number":687,"context_line":"    }"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1b5a8f9a_7aaf4498","line":684,"range":{"start_line":684,"start_character":10,"end_line":684,"end_character":86},"in_reply_to":"c9200fc3_43319c99","updated":"2021-06-22 02:26:23.000000000","message":"I\u0027ve confirmed with Patchset 3.","commit_id":"e18332507485504912e87c8b1c5b87a39e470ebe"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"030c85374106cf5bd732c4db3af7ac7161146740","unresolved":true,"context_lines":[{"line_number":675,"context_line":"      \"namespace\": \"namespaceA\","},{"line_number":676,"context_line":"      \"use_helm\": \"true\","},{"line_number":677,"context_line":"      \"using_helm_install_param\": ["},{"line_number":678,"context_line":"        {"},{"line_number":679,"context_line":"          \"exthelmchart\": \"true\","},{"line_number":680,"context_line":"          \"helmparameter\": ["},{"line_number":681,"context_line":"            \"key1\u003dvalue1\","},{"line_number":682,"context_line":"            \"key2\u003dvalue2\""},{"line_number":683,"context_line":"            ],"},{"line_number":684,"context_line":"          \"exthelmchart_url\": \"http:///home/hylom/helm_test/mychart/example-0.1.0.tgz\""},{"line_number":685,"context_line":"        }"},{"line_number":686,"context_line":"      ]"},{"line_number":687,"context_line":"    }"},{"line_number":688,"context_line":"  }"}],"source_content_type":"text/x-rst","patch_set":1,"id":"c194bc97_d9365622","line":685,"range":{"start_line":678,"start_character":0,"end_line":685,"end_character":9},"updated":"2021-06-11 13:28:12.000000000","message":"I think the following parameters are missing from the example.\n* helmreleasename\n* helmchartname\n* helmrepositoryname (if it is need to add to input parameter as above comment)\n\nAnd why don\u0027t you add example parameter the case of exthelmchart is \"false\"?","commit_id":"e18332507485504912e87c8b1c5b87a39e470ebe"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"9df0352377179f117de7b34848e4156f26133e64","unresolved":true,"context_lines":[{"line_number":675,"context_line":"      \"namespace\": \"namespaceA\","},{"line_number":676,"context_line":"      \"use_helm\": \"true\","},{"line_number":677,"context_line":"      \"using_helm_install_param\": ["},{"line_number":678,"context_line":"        {"},{"line_number":679,"context_line":"          \"exthelmchart\": \"true\","},{"line_number":680,"context_line":"          \"helmparameter\": ["},{"line_number":681,"context_line":"            \"key1\u003dvalue1\","},{"line_number":682,"context_line":"            \"key2\u003dvalue2\""},{"line_number":683,"context_line":"            ],"},{"line_number":684,"context_line":"          \"exthelmchart_url\": \"http:///home/hylom/helm_test/mychart/example-0.1.0.tgz\""},{"line_number":685,"context_line":"        }"},{"line_number":686,"context_line":"      ]"},{"line_number":687,"context_line":"    }"},{"line_number":688,"context_line":"  }"}],"source_content_type":"text/x-rst","patch_set":1,"id":"f3112dfb_ac9637bf","line":685,"range":{"start_line":678,"start_character":0,"end_line":685,"end_character":9},"in_reply_to":"c194bc97_d9365622","updated":"2021-06-22 02:26:23.000000000","message":"I\u0027ve confirmed with Patchset 2.","commit_id":"e18332507485504912e87c8b1c5b87a39e470ebe"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"030c85374106cf5bd732c4db3af7ac7161146740","unresolved":true,"context_lines":[{"line_number":718,"context_line":""},{"line_number":719,"context_line":"   .. code-block::"},{"line_number":720,"context_line":""},{"line_number":721,"context_line":"      helm repo remove \u003cexthelmchart_url\u003e"},{"line_number":722,"context_line":""},{"line_number":723,"context_line":"   .. note::"},{"line_number":724,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"c8f6d5b3_a265b25c","line":721,"range":{"start_line":721,"start_character":23,"end_line":721,"end_character":41},"updated":"2021-06-11 13:28:12.000000000","message":"The parameter of `helm repo remove` should be `helmrepositoryname`, not `exthelmchart_url`.","commit_id":"e18332507485504912e87c8b1c5b87a39e470ebe"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"9df0352377179f117de7b34848e4156f26133e64","unresolved":true,"context_lines":[{"line_number":718,"context_line":""},{"line_number":719,"context_line":"   .. code-block::"},{"line_number":720,"context_line":""},{"line_number":721,"context_line":"      helm repo remove \u003cexthelmchart_url\u003e"},{"line_number":722,"context_line":""},{"line_number":723,"context_line":"   .. note::"},{"line_number":724,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"a2e637be_f414ea49","line":721,"range":{"start_line":721,"start_character":23,"end_line":721,"end_character":41},"in_reply_to":"c8f6d5b3_a265b25c","updated":"2021-06-22 02:26:23.000000000","message":"I\u0027ve confirmed with Patchset 2.","commit_id":"e18332507485504912e87c8b1c5b87a39e470ebe"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"030c85374106cf5bd732c4db3af7ac7161146740","unresolved":true,"context_lines":[{"line_number":734,"context_line":""},{"line_number":735,"context_line":"   .. code-block::"},{"line_number":736,"context_line":""},{"line_number":737,"context_line":"      rm -f /usr/home/\u003cvnf_instance_id\u003e"},{"line_number":738,"context_line":""},{"line_number":739,"context_line":""},{"line_number":740,"context_line":"Data model impact"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9505bc23_f31ad9fd","line":737,"range":{"start_line":737,"start_character":12,"end_line":737,"end_character":21},"updated":"2021-06-11 13:28:12.000000000","message":"Same as first comment.\n\u003e The folder named “/usr/home” is not a good place to store helm charts.\n\u003e I think for example \"/opt/tacker/helm\" is better.","commit_id":"e18332507485504912e87c8b1c5b87a39e470ebe"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"9df0352377179f117de7b34848e4156f26133e64","unresolved":true,"context_lines":[{"line_number":734,"context_line":""},{"line_number":735,"context_line":"   .. code-block::"},{"line_number":736,"context_line":""},{"line_number":737,"context_line":"      rm -f /usr/home/\u003cvnf_instance_id\u003e"},{"line_number":738,"context_line":""},{"line_number":739,"context_line":""},{"line_number":740,"context_line":"Data model impact"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5e8a5687_0fcf4518","line":737,"range":{"start_line":737,"start_character":12,"end_line":737,"end_character":21},"in_reply_to":"9505bc23_f31ad9fd","updated":"2021-06-22 02:26:23.000000000","message":"I\u0027ve confirmed with Patchset 2.","commit_id":"e18332507485504912e87c8b1c5b87a39e470ebe"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"85fd0aec3d126a24b7c60739f6d0583242c1a74d","unresolved":true,"context_lines":[{"line_number":14,"context_line":"due to the trend of cloud-native application development."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"This specification proposes new interface for Kubernetes VIM with Helm chart."},{"line_number":17,"context_line":"It enable Users to include Helm chart files in their VNF Packages and"},{"line_number":18,"context_line":"to instantiate, scale-out/in, heal CNF with them."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Proposed Change"},{"line_number":22,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":23,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"20b4f8ec_9232f5a8","line":20,"range":{"start_line":17,"start_character":0,"end_line":20,"end_character":0},"updated":"2021-06-22 04:54:41.000000000","message":"Could you please rephrase statement, for e.g. \"It enables users to include Helm chart files in their VNF Packages and instantiate, scale-out/in, and heal CNF.\"","commit_id":"69ade82ff2e6688b072a9d82648c700fc23fd23d"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"85fd0aec3d126a24b7c60739f6d0583242c1a74d","unresolved":true,"context_lines":[{"line_number":22,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"When Users manage Kubernetes cluster as VNF instance with ETSI NFV-SOL003 VNF"},{"line_number":25,"context_line":"Lifecycle Management, it is also required to update MgmtDriver to support"},{"line_number":26,"context_line":"Helm chart."},{"line_number":27,"context_line":"Otherwise, Users need to install and configure Helm chart environment in"},{"line_number":28,"context_line":"their Kubernetes cluster."}],"source_content_type":"text/x-rst","patch_set":3,"id":"2a3e1a71_06c5a13e","line":25,"range":{"start_line":25,"start_character":25,"end_line":25,"end_character":44},"updated":"2021-06-22 04:54:41.000000000","message":"We could rephrase to \"must also\".","commit_id":"69ade82ff2e6688b072a9d82648c700fc23fd23d"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"85fd0aec3d126a24b7c60739f6d0583242c1a74d","unresolved":true,"context_lines":[{"line_number":45,"context_line":""},{"line_number":46,"context_line":"     HA Master nodes described in the spec \"Support HA Kubernetes Master"},{"line_number":47,"context_line":"     deployment with MgmtDriver\" [#SPEC-HA-K8S]_ may not be supported due to"},{"line_number":48,"context_line":"     the challenge how to manage plural connection info."},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"#. Heal Master node in Kubernetes Cluster VNF"},{"line_number":51,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"ccfbce06_fbbe9569","line":48,"range":{"start_line":48,"start_character":18,"end_line":48,"end_character":23},"updated":"2021-06-22 04:54:41.000000000","message":"Please change \"how\" to \"of how\".","commit_id":"69ade82ff2e6688b072a9d82648c700fc23fd23d"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"85fd0aec3d126a24b7c60739f6d0583242c1a74d","unresolved":true,"context_lines":[{"line_number":84,"context_line":"     The Scale operation may need to use Kubernetes PythonClient other than"},{"line_number":85,"context_line":"     Helm chart client."},{"line_number":86,"context_line":"     The number of replicas may not be exposed in `values.yaml` in Helm chart."},{"line_number":87,"context_line":"     In this case, Tacker needs to store exactly the same Database with"},{"line_number":88,"context_line":"     the case of Kubernetes Python Client in Instantiate operation."},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"#. CNF Heal"}],"source_content_type":"text/x-rst","patch_set":3,"id":"43cc4575_f0a3587b","line":87,"range":{"start_line":87,"start_character":41,"end_line":87,"end_character":48},"updated":"2021-06-22 04:54:41.000000000","message":"Please remove redundant word.","commit_id":"69ade82ff2e6688b072a9d82648c700fc23fd23d"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"85fd0aec3d126a24b7c60739f6d0583242c1a74d","unresolved":true,"context_lines":[{"line_number":84,"context_line":"     The Scale operation may need to use Kubernetes PythonClient other than"},{"line_number":85,"context_line":"     Helm chart client."},{"line_number":86,"context_line":"     The number of replicas may not be exposed in `values.yaml` in Helm chart."},{"line_number":87,"context_line":"     In this case, Tacker needs to store exactly the same Database with"},{"line_number":88,"context_line":"     the case of Kubernetes Python Client in Instantiate operation."},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"#. CNF Heal"}],"source_content_type":"text/x-rst","patch_set":3,"id":"097c65e4_5b817c05","line":87,"range":{"start_line":87,"start_character":67,"end_line":87,"end_character":71},"updated":"2021-06-22 04:54:41.000000000","message":"Please replace \"with\" to an another preposition \"as\".","commit_id":"69ade82ff2e6688b072a9d82648c700fc23fd23d"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"85fd0aec3d126a24b7c60739f6d0583242c1a74d","unresolved":true,"context_lines":[{"line_number":363,"context_line":"Required change is limited in ``heal_end`` method of MgmtDriver."},{"line_number":364,"context_line":"Tacker supports VNFC Heal operation with SOL002 and VNF Heal operation"},{"line_number":365,"context_line":"with SOL003."},{"line_number":366,"context_line":"In both cases, the similar process in Instantiate operation is added."},{"line_number":367,"context_line":""},{"line_number":368,"context_line":"Heal Master node with SOL002"},{"line_number":369,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1c0bfdc4_5e2e1819","line":366,"range":{"start_line":366,"start_character":15,"end_line":366,"end_character":18},"updated":"2021-06-22 04:54:41.000000000","message":"Please change article to \"a\".","commit_id":"69ade82ff2e6688b072a9d82648c700fc23fd23d"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"85fd0aec3d126a24b7c60739f6d0583242c1a74d","unresolved":true,"context_lines":[{"line_number":384,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":385,"context_line":""},{"line_number":386,"context_line":"This case follows the same logic in Terminate and Instantiate operations."},{"line_number":387,"context_line":"It is worth to note that ``VIM`` and ``VnfInstance.vimConnectionInfo``"},{"line_number":388,"context_line":"table should be updated with new Kubernetes Cluster information."},{"line_number":389,"context_line":""},{"line_number":390,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"be3dd12f_cb75e206","line":387,"range":{"start_line":387,"start_character":12,"end_line":387,"end_character":20},"updated":"2021-06-22 04:54:41.000000000","message":"Please change to \"noting\".","commit_id":"69ade82ff2e6688b072a9d82648c700fc23fd23d"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"85fd0aec3d126a24b7c60739f6d0583242c1a74d","unresolved":true,"context_lines":[{"line_number":610,"context_line":""},{"line_number":611,"context_line":"      .. note::"},{"line_number":612,"context_line":""},{"line_number":613,"context_line":"         The data table should be generated in exactly the same manner"},{"line_number":614,"context_line":"          with Python client."},{"line_number":615,"context_line":""},{"line_number":616,"context_line":"   #. Get and update the status of deployed resources."}],"source_content_type":"text/x-rst","patch_set":3,"id":"30e057fc_b8ee8faa","line":613,"range":{"start_line":613,"start_character":47,"end_line":613,"end_character":54},"updated":"2021-06-22 04:54:41.000000000","message":"Please remove redundant word \"exactly\". Second, please check note indentation.","commit_id":"69ade82ff2e6688b072a9d82648c700fc23fd23d"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"85fd0aec3d126a24b7c60739f6d0583242c1a74d","unresolved":true,"context_lines":[{"line_number":647,"context_line":"|\u003e helmparameter             | Array     | Parameters of KeyValuePairs,                              |"},{"line_number":648,"context_line":"|                            |           | which is specified during Helm installation.              |"},{"line_number":649,"context_line":"+----------------------------+-----------+-----------------------------------------------------------+"},{"line_number":650,"context_line":"|\u003e helmrepostitoryname       | String    | Helm repostiory name.                                     |"},{"line_number":651,"context_line":"|                            |           | Shall be present if \"exthelmchart\" is \"true\".             |"},{"line_number":652,"context_line":"+----------------------------+-----------+-----------------------------------------------------------+"},{"line_number":653,"context_line":"|\u003e helmchartname             | String    | Helm chart name.                                          |"}],"source_content_type":"text/x-rst","patch_set":3,"id":"680a8f9a_de2cc477","line":650,"range":{"start_line":650,"start_character":48,"end_line":650,"end_character":59},"updated":"2021-06-22 04:54:41.000000000","message":"Misspell word, \"repository\".","commit_id":"69ade82ff2e6688b072a9d82648c700fc23fd23d"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"85fd0aec3d126a24b7c60739f6d0583242c1a74d","unresolved":true,"context_lines":[{"line_number":725,"context_line":"      + \u003chelmreleasename\u003e: This parameter is obtained from the"},{"line_number":726,"context_line":"        \"Additional Params\" table in TackerDB."},{"line_number":727,"context_line":""},{"line_number":728,"context_line":"      **Discussion:** It might be better to uses other tables because"},{"line_number":729,"context_line":"      ``additionalParams`` should not be in Tacker DB"},{"line_number":730,"context_line":"      according to ETSI NFV-SOL003 ``VnfInstance.instantiatedVnfInfo``."},{"line_number":731,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"67cdc0b9_f11b1986","line":728,"range":{"start_line":728,"start_character":44,"end_line":728,"end_character":48},"updated":"2021-06-22 04:54:41.000000000","message":"Please replace \"uses\" to \"use\".","commit_id":"69ade82ff2e6688b072a9d82648c700fc23fd23d"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"85fd0aec3d126a24b7c60739f6d0583242c1a74d","unresolved":true,"context_lines":[{"line_number":738,"context_line":""},{"line_number":739,"context_line":"   .. note::"},{"line_number":740,"context_line":""},{"line_number":741,"context_line":"      **Discussion:** It might be better to uses other tables because"},{"line_number":742,"context_line":"      ``additionalParams`` should not be in Tacker DB"},{"line_number":743,"context_line":"      according to ETSI NFV-SOL003 ``VnfInstance.instantiatedVnfInfo``."},{"line_number":744,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"095d1f1c_d5ff7193","line":741,"range":{"start_line":741,"start_character":44,"end_line":741,"end_character":48},"updated":"2021-06-22 04:54:41.000000000","message":"Please replace \"uses\" to \"use\".","commit_id":"69ade82ff2e6688b072a9d82648c700fc23fd23d"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"85fd0aec3d126a24b7c60739f6d0583242c1a74d","unresolved":true,"context_lines":[{"line_number":758,"context_line":".. note::"},{"line_number":759,"context_line":""},{"line_number":760,"context_line":"   ``VnfInstance.vimConnectionInfo`` is defined as JSON."},{"line_number":761,"context_line":"   The ``extra`` field for Helm chart support doesn\u0027t make any impacts."},{"line_number":762,"context_line":""},{"line_number":763,"context_line":"REST API impact"},{"line_number":764,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"422f619a_c96db3a9","line":761,"range":{"start_line":761,"start_character":63,"end_line":761,"end_character":70},"updated":"2021-06-22 04:54:41.000000000","message":"Please change this to \"impact\".","commit_id":"69ade82ff2e6688b072a9d82648c700fc23fd23d"},{"author":{"_account_id":17255,"name":"Toshiaki Takahashi","email":"ts-takahashi@nec.com","username":"takahashi_ts"},"change_message_id":"2cf2b2846e01c640d3e5e4a326af5038e473ac58","unresolved":true,"context_lines":[{"line_number":126,"context_line":"                                                 |  +-------+-----------+        |"},{"line_number":127,"context_line":"                                                 |          |                    |"},{"line_number":128,"context_line":"                                                 |          v                    |"},{"line_number":129,"context_line":"             1. Kubernetes Cluster               |  +----------------------+     |"},{"line_number":130,"context_line":"                \u0026 Helm Installation              |  |    +-------------+   |     |"},{"line_number":131,"context_line":"          +-------------+------------------------+--+----| MgmtDriver  |   |     |"},{"line_number":132,"context_line":"          |             |                        |  |    +-------------+   |     |"}],"source_content_type":"text/x-rst","patch_set":4,"id":"7c0a0507_8e604e78","line":129,"range":{"start_line":129,"start_character":13,"end_line":129,"end_character":16},"updated":"2021-06-29 02:03:36.000000000","message":"Is this \"2.\"?","commit_id":"9062ed4a48c1824d6555f6d1258b92fb20673ade"},{"author":{"_account_id":33292,"name":"Masaki UENO","email":"masaki.ueno.up@hco.ntt.co.jp","username":"masaki-ueno"},"change_message_id":"2456ac3751208181919263dd6624b81e33882dc8","unresolved":true,"context_lines":[{"line_number":126,"context_line":"                                                 |  +-------+-----------+        |"},{"line_number":127,"context_line":"                                                 |          |                    |"},{"line_number":128,"context_line":"                                                 |          v                    |"},{"line_number":129,"context_line":"             1. Kubernetes Cluster               |  +----------------------+     |"},{"line_number":130,"context_line":"                \u0026 Helm Installation              |  |    +-------------+   |     |"},{"line_number":131,"context_line":"          +-------------+------------------------+--+----| MgmtDriver  |   |     |"},{"line_number":132,"context_line":"          |             |                        |  |    +-------------+   |     |"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3f21eb29_8d848dd9","line":129,"range":{"start_line":129,"start_character":13,"end_line":129,"end_character":16},"in_reply_to":"7c0a0507_8e604e78","updated":"2021-07-21 00:41:09.000000000","message":"Yes, this should be \"2.\" in this diagram.","commit_id":"9062ed4a48c1824d6555f6d1258b92fb20673ade"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"228f908018f10db55313d43d48d28f1d5d77b88f","unresolved":true,"context_lines":[{"line_number":347,"context_line":"    },"},{"line_number":348,"context_line":"    \"interface_info\": {"},{"line_number":349,"context_line":"    },"},{"line_number":350,"context_line":"    \"extra\": {"},{"line_number":351,"context_line":"      \"helm_info\": {"},{"line_number":352,"context_line":"          \"masternode_ip\": \"192.168.100.100\","},{"line_number":353,"context_line":"          \"masternode_username\": \"user1\","},{"line_number":354,"context_line":"          \"masternode_password\": \"password\","},{"line_number":355,"context_line":"      }"},{"line_number":356,"context_line":"    }"},{"line_number":357,"context_line":"  }"},{"line_number":358,"context_line":""},{"line_number":359,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"59f2c18a_bd61613c","line":356,"range":{"start_line":350,"start_character":0,"end_line":356,"end_character":5},"updated":"2021-08-03 02:41:02.000000000","message":"The current Tacker implementation creates a VimConnectionInfo from the Vims and VimAuth DBs with the VimId specified in Request as the key when running the VNF instantiate.\nrefs:\n* https://opendev.org/openstack/tacker/src/branch/master/tacker/vnflcm/vnflcm_driver.py#L509-L513\n* https://opendev.org/openstack/tacker/src/branch/master/tacker/vnflcm/utils.py#L38-L63\n\n\nSo, I think you need to add extra field to Vims\u0027 DB in order to extract extra field during CNF instantiate with helm chart.\nhttps://opendev.org/openstack/tacker/src/branch/master/tacker/db/nfvo/nfvo_db.py#L27-L48\n\nThis needs to be added to \"Datamodel impact\" because DB changes are required.","commit_id":"9062ed4a48c1824d6555f6d1258b92fb20673ade"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"e92f544f7010c78997fdfcfd72b0618073d6a95d","unresolved":false,"context_lines":[{"line_number":347,"context_line":"    },"},{"line_number":348,"context_line":"    \"interface_info\": {"},{"line_number":349,"context_line":"    },"},{"line_number":350,"context_line":"    \"extra\": {"},{"line_number":351,"context_line":"      \"helm_info\": {"},{"line_number":352,"context_line":"          \"masternode_ip\": \"192.168.100.100\","},{"line_number":353,"context_line":"          \"masternode_username\": \"user1\","},{"line_number":354,"context_line":"          \"masternode_password\": \"password\","},{"line_number":355,"context_line":"      }"},{"line_number":356,"context_line":"    }"},{"line_number":357,"context_line":"  }"},{"line_number":358,"context_line":""},{"line_number":359,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"c4ec6fb7_d2180d7f","line":356,"range":{"start_line":350,"start_character":0,"end_line":356,"end_character":5},"in_reply_to":"59f2c18a_bd61613c","updated":"2021-08-06 09:19:42.000000000","message":"Done","commit_id":"9062ed4a48c1824d6555f6d1258b92fb20673ade"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"228f908018f10db55313d43d48d28f1d5d77b88f","unresolved":true,"context_lines":[{"line_number":757,"context_line":""},{"line_number":758,"context_line":".. note::"},{"line_number":759,"context_line":""},{"line_number":760,"context_line":"   ``VnfInstance.vimConnectionInfo`` is defined as JSON."},{"line_number":761,"context_line":"   The ``extra`` field for Helm chart support doesn\u0027t make any impact."},{"line_number":762,"context_line":""},{"line_number":763,"context_line":"REST API impact"},{"line_number":764,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"965bb4ef_b9bd924a","line":761,"range":{"start_line":760,"start_character":0,"end_line":761,"end_character":70},"updated":"2021-08-03 02:41:02.000000000","message":"As you wrote, ‘VnfInstance.vimConnectionInfo` does not need to be changed.\nBut as I commented above, you need to add extra to Vims table to extract extra field during CNF instantiate.","commit_id":"9062ed4a48c1824d6555f6d1258b92fb20673ade"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"e92f544f7010c78997fdfcfd72b0618073d6a95d","unresolved":false,"context_lines":[{"line_number":757,"context_line":""},{"line_number":758,"context_line":".. note::"},{"line_number":759,"context_line":""},{"line_number":760,"context_line":"   ``VnfInstance.vimConnectionInfo`` is defined as JSON."},{"line_number":761,"context_line":"   The ``extra`` field for Helm chart support doesn\u0027t make any impact."},{"line_number":762,"context_line":""},{"line_number":763,"context_line":"REST API impact"},{"line_number":764,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"e7bfec7a_df7c4ffe","line":761,"range":{"start_line":760,"start_character":0,"end_line":761,"end_character":70},"in_reply_to":"965bb4ef_b9bd924a","updated":"2021-08-06 09:19:42.000000000","message":"Done","commit_id":"9062ed4a48c1824d6555f6d1258b92fb20673ade"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"1764b489b14d3bbc5ba132a2ab0ba184070ba10f","unresolved":true,"context_lines":[{"line_number":753,"context_line":"Data model impact"},{"line_number":754,"context_line":"-----------------"},{"line_number":755,"context_line":""},{"line_number":756,"context_line":"``VnfInstance.vimConnectionInfo`` is defined as JSON."},{"line_number":757,"context_line":"Helm chart support described in this spec adds ``extra`` column"},{"line_number":758,"context_line":"into ``Vims`` table as type ``json``."},{"line_number":759,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"7988e1b9_84b26e5b","line":756,"range":{"start_line":756,"start_character":0,"end_line":756,"end_character":53},"updated":"2021-08-06 04:20:23.000000000","message":"Can you leave this sentence as it is? I think it is necessary if you want to clearly state that there is no impact to `VnfInstance.vimConnectionInfo`.\n\nCould you delete the description or make it clear that there is no impact to `VnfInstance.vimConnectionInfo`?","commit_id":"c32e54ab5866f6ef7c39bedfcad26218416909e5"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"e92f544f7010c78997fdfcfd72b0618073d6a95d","unresolved":false,"context_lines":[{"line_number":753,"context_line":"Data model impact"},{"line_number":754,"context_line":"-----------------"},{"line_number":755,"context_line":""},{"line_number":756,"context_line":"``VnfInstance.vimConnectionInfo`` is defined as JSON."},{"line_number":757,"context_line":"Helm chart support described in this spec adds ``extra`` column"},{"line_number":758,"context_line":"into ``Vims`` table as type ``json``."},{"line_number":759,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"c06f3955_07ffea28","line":756,"range":{"start_line":756,"start_character":0,"end_line":756,"end_character":53},"in_reply_to":"7988e1b9_84b26e5b","updated":"2021-08-06 09:19:42.000000000","message":"Thanks for updating, I\u0027ve confirmed,","commit_id":"c32e54ab5866f6ef7c39bedfcad26218416909e5"}]}